Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL - rebased

Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/include/odp/api/plat/packet_types.h line 6 @@ -67,101 +67,89 @@ typedef enum { #endif -/** @internal Packet field accessor */ +/** @cond _ODP_HIDE_FROM_DOXYGEN_ */ + Comment: OK > Bill

Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL - rebased

Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/odp_packet.c line 51 @@ -1259,7 +1260,15 @@ int odp_packet_input_index(odp_packet_t pkt) void odp_packet_user_ptr_set(odp_packet_t pkt, const void *ptr) { - packet_hdr(pkt)->buf_hdr.user_ptr = ptr;

Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL - rebased

Petri Savolainen(psavol) replied on github web page: platform/linux-generic/include/odp/api/plat/packet_types.h line 6 @@ -67,101 +67,89 @@ typedef enum { #endif -/** @internal Packet field accessor */ +/** @cond _ODP_HIDE_FROM_DOXYGEN_ */ + Comment: This a section label for doxygen. We'll

Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL - rebased

Petri Savolainen(psavol) replied on github web page: platform/linux-generic/odp_packet.c line 51 @@ -1259,7 +1260,15 @@ int odp_packet_input_index(odp_packet_t pkt) void odp_packet_user_ptr_set(odp_packet_t pkt, const void *ptr) { - packet_hdr(pkt)->buf_hdr.user_ptr = ptr; +

Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL - rebased

Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/include/odp/api/plat/packet_types.h line 6 @@ -67,101 +67,89 @@ typedef enum { #endif -/** @internal Packet field accessor */ +/** @cond _ODP_HIDE_FROM_DOXYGEN_ */ + Comment: I like using this feature,

Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL - rebased

Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/odp_packet.c line 51 @@ -1259,7 +1260,15 @@ int odp_packet_input_index(odp_packet_t pkt) void odp_packet_user_ptr_set(odp_packet_t pkt, const void *ptr) { - packet_hdr(pkt)->buf_hdr.user_ptr = ptr;