Re: [lng-odp] [RFCv4] dpdk: enable hardware checksum support

> On 24 May 2017, at 11:32, Bogdan Pricope wrote: > > Hi Matias, > > Using ptypes reported by dpdk in parser was intended for another patch > (next work after csum). > Good, so we are on the same page. When implementing packet parsing you have to move/reimplement

Re: [lng-odp] [RFCv4] dpdk: enable hardware checksum support

Hi Matias, Using ptypes reported by dpdk in parser was intended for another patch (next work after csum). I guess your test is a degradation test (due to new ifs) and you did not enabled csum offloads/ set flags on packets. What will be interesting to see: - in a generation or termination test

Re: [lng-odp] [RFCv4] dpdk: enable hardware checksum support

Hi Bogdan, I ran a quick test run with the patch and the overhead seems to be surprisingly small at least on a Xeon cpu (E5-2697v3). However, I would still suggest making some changes to the code. More below. -Matias > > @@ -605,9 +663,11 @@ static inline int mbuf_to_pkt(pktio_entry_t