This patch has the same problem, however the core-CPU change seems to have
affected this one non-trivially. Not sure what the correct resync is since
the patch window is narrow here.
On Thu, Jan 8, 2015 at 10:07 AM, Stuart Haslam stuart.has...@arm.com
wrote:
Also fix an incorrect assumption
As noted, parts 3, 5, and 6 of this patch need to be rebased to account for
the prior application of Ola's core-CPU rename patch. After correcting
these issues locally the patches apply and compile fine for me.
I'm unable to test this with my setup, however with the above caveat:
Reviewed-by:
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
The timer API is updated according to
https://docs.google.com/a/linaro.org/document/d/1bfY_J8ecLJPsFTmYftb0NVmGnB9qkEc_NpcJ87yfaD8
A major change is that timers are allocated and freed separately from
The timer API is updated according to
https://docs.google.com/a/linaro.org/document/d/1bfY_J8ecLJPsFTmYftb0NVmGnB9qkEc_NpcJ87yfaD8
A major change is that timers are allocated and freed separately from
timeouts being set and cancelled. The life-length of a timer normally
corresponds to the
Cunit test program test/validation/odp_timer.c for the updated
timer API.
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Updated due to minor API changes.
test/validation/.gitignore |
Fix for Bug 1031 to enable linux-generic compiles on 32-bit systems.
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
platform/linux-generic/include/odp_buffer_internal.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/platform/linux-generic/include/odp_buffer_internal.h
https://bugs.linaro.org/show_bug.cgi?id=1031
--- Comment #6 from Bill Fischofer bill.fischo...@linaro.org ---
Fixed by https://patches.linaro.org/42895/
This patch can be applied independent of Ola's timer patch. The complete fix
requires this plus Ola's patch.
--
You are receiving this mail
For this series:
Reviewed-and-tested-by: Bill Fischofer bill.fischo...@linaro.org
On Thu, Jan 8, 2015 at 3:35 PM, Ola Liljedahl ola.liljed...@linaro.org
wrote:
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
The timer API is updated according
This patch does not apply to the current ODP tip:
error: patch failed: example/packet/odp_pktio.c:65
Hunk #2 succeeded at 77 (offset 1 line).
Hunk #3 succeeded at 100 (offset 1 line).
Hunk #4 succeeded at 142 (offset 1 line).
Hunk #5 succeeded at 219 (offset 1 line).
Hunk #6 succeeded at 226
Looks like the issue is that the name change from core_count to cpu_count
went in ahead of this patch.
On Thu, Jan 8, 2015 at 4:55 PM, Bill Fischofer bill.fischo...@linaro.org
wrote:
This patch does not apply to the current ODP tip:
error: patch failed: example/packet/odp_pktio.c:65
Hunk #2
Merged!
On Wed, Jan 7, 2015 at 8:52 PM, Zoltan Kiss zoltan.k...@linaro.org wrote:
Acked-by: Zoltan Kiss zoltan.k...@linaro.org
On 07/01/15 14:40, Ciprian Barbu wrote:
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
INSTALL.ODP.md | 8 +++-
1 file changed, 3
On Wed, Jan 7, 2015 at 9:41 PM, Mike Holmes mike.hol...@linaro.org wrote:
I am unsure if I need to pay attention to this for 0.7.0
Still abit unclear after the discussion we had with Petri, but I think
we need to keep the behavior as it is, meaning applications need to
take care of the
First set of synchronizer tests. This patch includes
tests for locks, barriers and atomics.
Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com
---
(This code contribution is provided under the terms of agreement LES-LTM-21309)
Changes from previous version:
Addressed
That certainly seems to be the upshot for now from yesterday's
discussions. Whether this is something that will persist longer-term
remains to be seen.
The net is that if you want to pause there a certain amount of choreography
that the application needs to do to perform such role-switching in a
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Monday, January 05, 2015 8:24 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [PATCHv3 2/3] api: odp_timer.h: updated API, lock-less
There is likely a bug in the odph checksumming functions as well. Due
to the casts to void ptr and function inlining, the compiler can
reorder memory accesses (e.g. move stored to the headers after the
checksumming has been performed). The compiler does not know that
these pointers alias each
On 8 January 2015 at 13:55, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Monday, January 05, 2015 8:24 PM
To:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
configure.ac | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index f0ce7e0..440cc63 100644
--- a/configure.ac
+++ b/configure.ac
@@ -44,16 +44,16 @@ AC_TYPE_UINT64_T
# Determine
Allow the test/performance directory to be optionally included when make
check is run
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
configure.ac | 37 -
test/performance/.gitignore | 2 ++
test/performance/Makefile.am | 5 +
+/**
+ * Create a timer pool
+ *
+ * @param name Name of the timer pool. The string will be
copied.
+ * @param buf_pool Buffer pool for allocating timeouts
Maybe a comment also here for the purpose of this pool. Or just remove it, if
there's no clear usage for it. It can be
https://bugs.linaro.org/show_bug.cgi?id=787
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Assignee|lng-odp@lists.linaro.org|mike.hol...@linaro.org
---
https://bugs.linaro.org/show_bug.cgi?id=706
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Assignee|bill.fischo...@linaro.org |robk...@cisco.com
---
https://bugs.linaro.org/show_bug.cgi?id=619
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Assignee|mike.hol...@linaro.org |lng-odp@lists.linaro.org
https://bugs.linaro.org/show_bug.cgi?id=619
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
https://bugs.linaro.org/show_bug.cgi?id=805
--- Comment #4 from Zoltan Kiss zoltan.k...@linaro.org ---
Before Christmas I managed to start up OVS-ODP on D01 (all the previous
problems were caused by the kernel driver which was probed for the GE ports as
well), but it seems packets are not
https://bugs.linaro.org/show_bug.cgi?id=638
--- Comment #6 from Mike Holmes mike.hol...@linaro.org ---
Ciprian - any updates to this issue
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing list
https://bugs.linaro.org/show_bug.cgi?id=301
--- Comment #5 from Mike Holmes mike.hol...@linaro.org ---
Maxim and updates to this issue ?
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing list
https://bugs.linaro.org/show_bug.cgi?id=300
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Version|unspecified |0.6
--- Comment #4 from
https://bugs.linaro.org/show_bug.cgi?id=299
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Version|unspecified |0.6
--- Comment #6 from
https://bugs.linaro.org/show_bug.cgi?id=1031
--- Comment #4 from Bill Fischofer bill.fischo...@linaro.org ---
Fixed by https://patches.linaro.org/42816/
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing
The main change in this series is to the way odp_pktio_open() works, it
now ensures a one-to-one relationship between a pktio device and a
pktio handle.
All of the (in-repo) examples have been updated and I've tested that
they all still work. Note that no changes were required in the
odp_ipsec
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
test/validation/odp_pktio.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c
index 45545f5..d1eb0d5 100644
--- a/test/validation/odp_pktio.c
+++
Create a new linux-generic pktio type ODP_PKTIO_TYPE_LOOPBACK which
will be used when the loop device is opened. A queue is used to
connect the pktio output queue to the input queue. Packets sent to the
loopback device are classified before making it to the input queue.
A random MAC address is
Also fix an incorrect assumption that the value of a pktio handle is
an integer starting at 0 and incrementing by 1 for each _open call,
which was previously true for linux-generic but has no guarantee on
other platforms.
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
https://bugs.linaro.org/show_bug.cgi?id=1004
--- Comment #2 from Mike Holmes mike.hol...@linaro.org ---
https://git.linaro.org/lng/odp.git/commit/006e196b9c717ffe73a629f7432e1abf0cc8f909
--
You are receiving this mail because:
You are on the CC list for the
https://bugs.linaro.org/show_bug.cgi?id=975
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.linaro.org/show_bug.cgi?id=1004
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Status|IN_PROGRESS |RESOLVED
https://bugs.linaro.org/show_bug.cgi?id=805
--- Comment #3 from Mike Holmes mike.hol...@linaro.org ---
Zoltan - where are we with this ?
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing list
https://bugs.linaro.org/show_bug.cgi?id=1031
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Ever confirmed|0 |1
This patch changes odp_pktio_open() to ensure a one-to-one relationship
between a pktio device an a pktio handle. Attempts to open a device
which is already open will fail, setting errno to -EEXIST to indicate
the reason for the failure. A new API odp_pktio_lookup() is added which
can be used to
No functional change, just fixing up some style issues.
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
example/l2fwd/odp_l2fwd.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/example/l2fwd/odp_l2fwd.c b/example/l2fwd/odp_l2fwd.c
https://bugs.linaro.org/show_bug.cgi?id=1035
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Assignee|bill.fischo...@linaro.org |bala.manoha...@linaro.org
open each pktio interface once, rather than once per thread.
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
example/generator/odp_generator.c | 79 ---
1 file changed, 49 insertions(+), 30 deletions(-)
diff --git a/example/generator/odp_generator.c
Replace all instances of perror() with ODP_ERR() so that output may be
redirected to odp_override_log().
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
platform/linux-generic/odp_packet_socket.c | 39 +++---
1 file changed, 19 insertions(+), 20 deletions(-)
diff
On 8 January 2015 at 15:39, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
+/**
+ * Create a timer pool
+ *
+ * @param name Name of the timer pool. The string will be
copied.
+ * @param buf_pool Buffer pool for allocating timeouts
Maybe a comment also here
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
platform/linux-generic/odp_crypto.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index 13c5556..345c22a 100644
---
Alex/Robbie: Can you please review this so it can be included in 0.7.0?
Thanks.
On Thu, Jan 8, 2015 at 10:24 AM, Bill Fischofer bill.fischo...@linaro.org
wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
platform/linux-generic/odp_crypto.c | 3 ++-
1 file changed, 2
https://bugs.linaro.org/show_bug.cgi?id=1001
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Assignee|mike.hol...@linaro.org |ciprian.ba...@linaro.org
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/odp_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index 13c5556..2f95cbe 100644
---
Geoffrey: Any updates on this? I'm surprised you were able to expose ABA
issues with local caching since the vast majority of allocs/frees will be
going to the local caches and thus immune to this exposure no matter what
load you're generating. As Mike noted, the test case that exposes this is
Note that Robbie is currently working on a crypto patch that may or may not
intersect with this. May need to coordinate the sequencing.
On Thu, Jan 8, 2015 at 2:50 PM, Mike Holmes mike.hol...@linaro.org wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
Reviewed-by: Bill Fischofer
On 8 January 2015 at 06:48, Mario Torrecillas Rodriguez
mario.torrecillasrodrig...@arm.com wrote:
First set of synchronizer tests. This patch includes
tests for locks, barriers and atomics.
Signed-off-by: Mario Torrecillas Rodriguez
mario.torrecillasrodrig...@arm.com
Reviewed-by: Mike
52 matches
Mail list logo
