Re: [lng-odp] [PATCHv2] doc: userguide: add thread type description to odp_init_local() discussion

does the diagram need an update too ? http://docs.opendataplane.org/master/linux-generic/output/users-guide.html#_initialization It shows calling these apis. On 24 February 2016 at 19:11, Bill Fischofer wrote: > This addresses Bug

Re: [lng-odp] [API-NEXT PATCH 1/3] linux-generic: pktio: add link_status handler for loop interfaces

Parts 2 and 3 need to be reversed since the required build will fail without the fixes. v2 submitted to correct this. (I also added back Mike's signed-off-by to Part 3 since he found that omission first). apply-and-build runs clean for me with that change. On Tue, Mar 1, 2016 at 1:08 PM, Mike

[lng-odp] [API-NEXT PATCHv2 2/3] validation: tm: miscellaneous cleanup and fixes for tm cunit tests

Add missing odp_pktin/out_queue_config() calls for interfaces and streamline link status processing to enable the TM Cunit test to run properly with the latest PktIO changes. Signed-off-by: Bill Fischofer --- test/validation/traffic_mngr/traffic_mngr.c | 59

Re: [lng-odp] [PATCHv2] doc: userguide: add thread type description to odp_init_local() discussion

I don't think so. What would you change there? It's an overview and doesn't show parameters to any ODP API calls. On Tue, Mar 1, 2016 at 1:55 PM, Mike Holmes wrote: > does the diagram need an update too ? > > >

Re: [lng-odp] [API-NEXT PATCH 1/3] linux-generic: pktio: add link_status handler for loop interfaces

I am seeing a problem now, I ran twice, not sure what is different, I did a git clean -xdf before this run PATCH_DIR=~/incoming/bill ./apply-and-build.sh make check-TESTS make[4]: Entering directory

Re: [lng-odp] [PATCHv2] doc: userguide: add thread type description to odp_init_local() discussion

On 1 March 2016 at 15:00, Bill Fischofer wrote: > I don't think so. What would you change there? It's an overview and > doesn't show parameters to any ODP API calls. > Ok > > On Tue, Mar 1, 2016 at 1:55 PM, Mike Holmes > wrote: > >> does

[lng-odp] [API-NEXT PATCHv2 1/3] linux-generic: pktio: add link_status handler for loop interfaces

ODP loopback interfaces should always be considered up, so add a handler for odp_pktio_link_status() for this device type that always returns 1 to indicate the link is up. Signed-off-by: Bill Fischofer --- platform/linux-generic/pktio/loop.c | 7 +++ 1 file

[lng-odp] [API-NEXT PATCHv2 3/3] linux-generic: test: add tm unit test to list of tests to run

Signed-off-by: Mike Holmes Signed-off-by: Bill Fischofer --- platform/linux-generic/test/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/linux-generic/test/Makefile.am b/platform/linux-generic/test/Makefile.am index

[lng-odp] Crash on odp_cpuinfo_parser

Hi Experts, I met an ODP crash in linux generic. It crashes at requiring the CPU frequency. pos = strchr(sysinfo->model_str[id], '@'); *(pos - 1) = '\0'; My testbed is an ubuntu running on KVM, and the CPU model is: "model name : QEMU Virtual CPU version 2.0.0" There is no “@" in this string

[lng-odp] [PATCH 2/3] example: ipsec: Add IPSEC ESP protocol offload

From: Adrian Lutan This patch adds the IPSEC ESP protocol offload support in odp_ipsec application. The protocol offloading enablement and configuration are specified in the IPSec policy configuration line as follows: -p

[lng-odp] [PATCH 3/3] linux-generic: crypto: add implementation of IPSec ESP offloading

From: Adrian Lutan The implementation supports insertion and removal of ESP header, trailer and ICV, and optionally use of ESN (Extended Sequence Number) feature. Note: use of ESP ciphering without authentication is not supported as it represents a security issue and is not

[lng-odp] [PATCH 1/3] [API-NEXT] api: crypto: add crypto IPSec extension

From: Adrian Lutan This patch adds IPSec protocol processing capabilities to crypto sesssions. Implementations which have these capabilities in hardware crypto engines can use the extension to offload the application from IPSec protocol processing. Signed-off-by: Alexandru

Re: [lng-odp] Try operation for rwlock and recursive_rwlock

This would seem to be a very reasonable and straightforward add, however trylock variants should be added to the non-recursive rwlock calls as well. Based on internal discussions, we will finalize this at BKK and it will probably be part of Monarch RC2. On Thu, Feb 25, 2016 at 7:28 AM, Sorin

Re: [lng-odp] [API-NEXT PATCH 1/3] doc: images: add gv file for pktio state machine

Hi Bill, I am probably missing something obvious, but that Makefile does not exist for me... Does this require some previous patch that have made their way to the repo yet? erachmi@erachmi-ericsson:~/linaro/ODP/odp$ git am

Re: [lng-odp] [API-NEXT PATCH 1/3] linux-generic: pktio: add link_status handler for loop interfaces

On 29 February 2016 at 15:53, Bill Fischofer wrote: > ODP loopback interfaces should always be considered up, so add a > handler for odp_pktio_link_status() for this device type that always > returns 1 to indicate the link is up. > > Signed-off-by: Bill Fischofer

Re: [lng-odp] [API-NEXT PATCH 1/3] linux-generic: pktio: add link_status handler for loop interfaces

If it's not defined it's better to return -1. However the question is shouldn't a loop interface have its own definition for this function? I know link_status was added after the original restructure so perhaps this was just an omission? On Tue, Mar 1, 2016 at 8:53 AM, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCHv1] linux-generic:pktio:add an interface to support multi pool

Hi, The above described use-case is implementable with the existing ODP classification framework. Few points to take note for implementing this use-case * Each CoS has an associated pool from which packets arriving at this CoS is allocated. * There is an existing PMR rule ODP_PMR_LEN which

[lng-odp] [PATCH 2/2] linux-generic: test: ODP_SHM_PROP test

Adding a platform side test to test sharing memory between ODP and linux. Also tests that the shared memory device name (under /dev/shm/) is scoped. Signed-off-by: Christophe Milard --- platform/linux-generic/m4/configure.m4 | 1 +

Re: [lng-odp] [API-NEXT PATCH 1/3] linux-generic: pktio: add link_status handler for loop interfaces

On 03/01/16 17:56, Bill Fischofer wrote: If it's not defined it's better to return -1. However the question is shouldn't a loop interface have its own definition for this function? I know link_status was added after the original restructure so perhaps this was just an omission? Really,

[lng-odp] [PATCH 0/2] linux test for shared memory

(Note: requires: linux-generic: shmem: odp scope in /dev/shmem) Adding a platform side test to test sharing memory between ODP and linux. This test is more interresting for its side effects: *first complete test on the platform side building ODP and platform programs (other platform tests so far

Re: [lng-odp] [API-NEXT PATCH] api: pktio: added drv_name to pktio info structure

Merged, Maxim. On 03/01/16 16:19, Juha-Matti Tilli wrote: Add drv_name to pktio info structure. This allows applications to see which pktio driver is used. For example, an application might want to print a message with netmap or DPDK installation instructions if it seems that sockets are used.

Re: [lng-odp] [API-NEXT PATCH 1/3] linux-generic: pktio: add link_status handler for loop interfaces

Bill, Idea if ops is not defined that some common value has to be used. Instead of fixing loop it's needed to fix common code to return 1 if link_status is not implemented. int odp_pktio_link_status(odp_pktio_t id) { pktio_entry_t *entry; int ret = -1; <--- has to be 1 . if

[lng-odp] [PATCH 1/2] linux-generic: test: adding odp includes

A new Makefile.inc is created, defining common includes that linux specific tests will need if they need to build with ODP. Tests just acting as wrappers around platform agnostic tests will not need these defines, whereas tests building ODP executable will. Signed-off-by: Christophe Milard

Re: [lng-odp] [PATCH] linux-generic: fix usage of function strncpy

Merged, Maxim. On 02/29/16 19:23, Mike Holmes wrote: On 23 February 2016 at 04:25, > wrote: From: Hongbo Zhang > Reviewed-by: Mike Holmes

Re: [lng-odp] [PATCH] validation: scheduler: increase delay tolerance

Merged, Maxim. On 03/01/16 04:25, Bill Fischofer wrote: OK, thanks for the explanation. With that: Reviewed-by: Bill Fischofer > On Mon, Feb 29, 2016 at 4:22 PM, Ivan Khoronzhuk

[lng-odp] [API-NEXT PATCH] api: pktio: added drv_name to pktio info structure

Add drv_name to pktio info structure. This allows applications to see which pktio driver is used. For example, an application might want to print a message with netmap or DPDK installation instructions if it seems that sockets are used. The pktio driver information is also useful information to be

Re: [lng-odp] [PATCHv2 0/2] cleanly destroy resources

ping. Please review. (Should be simple run and see that there is no ODP_ERR() on ending term_global() ) Maxim. On 02/25/16 15:35, Maxim Uvarov wrote: v2: apply on master, not api-next and correst stop instead of close. Maxim Uvarov (2): performance: scheduling: cleanly destroy resources