Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, > What will be the total number of SA in the system? Will it be around 100K? Yes, the API should work with that many SAs. > If that is the case IMO it might be better to add a "context_packet" > which could be copied to the output packet instead of having 100K > different queues? I think

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, > > +typedef struct odp_ipsec_lifetime_t { > > + /** Soft expiry limits for the session */ > > + struct { > > + /** Limit in seconds */ > > + uint64_t sec; > > Does expiry time mean the ADD_TIME -Time calculated when the policy is > added to database

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, > > + /** IPv6 Differentiated Services Code Point */ > > + uint8_t dscp; > > > > IPv6 does not use a DSCP. The field is called Traffic Class in IPv6 so this > should be uint8_t traffic_class; RFC 2474 renames IPv4 ToS and IPv6 traffic class

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Bala Manoharan
Some quick comments... Regards, Bala On 15 November 2016 at 14:17, Petri Savolainen wrote: > Added definitions for a look-a-side IPSEC offload API. In addition to > IPSEC packet transformations, it also supports: > * inbound SA look up > * outbound IP fragmentation

[lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Petri Savolainen
Added definitions for a look-a-side IPSEC offload API. In addition to IPSEC packet transformations, it also supports: * inbound SA look up * outbound IP fragmentation Signed-off-by: Petri Savolainen --- include/odp/api/spec/event.h | 2 +-

[lng-odp] Testing

2016-11-15 Thread Bill Fischofer
Testing the list manager. Please ignore.

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Bala Manoharan
Regards, Bala On 15 November 2016 at 14:17, Petri Savolainen wrote: > Added definitions for a look-a-side IPSEC offload API. In addition to > IPSEC packet transformations, it also supports: > * inbound SA look up > * outbound IP fragmentation > > Signed-off-by: Petri

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bala Manoharan [mailto:bala.manoha...@linaro.org] > Sent: Tuesday, November 15, 2016 3:06 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com> > Cc: lng-odp-forward > Subject: Re: [lng-odp]

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Bill Fischofer
On Tue, Nov 15, 2016 at 2:47 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Added definitions for a look-a-side IPSEC offload API. In addition to > IPSEC packet transformations, it also supports: > * inbound SA look up > * outbound IP fragmentation > > Signed-off-by: Petri Savolainen