Re: [lng-odp] [PATCH v2] linux-generic: pool: don't allocate buffers from invalid pool

[Bill Fischofer]

On Fri, Mar 10, 2017 at 11:14 AM, Dmitry Eremin-Solenikov <
dmitry.ereminsoleni...@linaro.org> wrote:

> Add ODP_ASSERT checking that passed pool is not ODP_POOL_INVALID before
> tring to allocate buffers from that pool.
>
> Signed-off-by: Dmitry Eremin-Solenikov 
>

Reviewed-by: Bill Fischofer 


> ---
>  platform/linux-generic/odp_pool.c | 4 
>  1 file changed, 4 insertions(+)
>
> diff --git a/platform/linux-generic/odp_pool.c
> b/platform/linux-generic/odp_pool.c
> index cf7c2c41..2c1ba914 100644
> --- a/platform/linux-generic/odp_pool.c
> +++ b/platform/linux-generic/odp_pool.c
> @@ -768,6 +768,8 @@ odp_buffer_t odp_buffer_alloc(odp_pool_t pool_hdl)
> pool_t *pool;
> int ret;
>
> +   ODP_ASSERT(ODP_POOL_INVALID != pool_hdl);
> +
> pool = pool_entry_from_hdl(pool_hdl);
> ret = buffer_alloc_multi(pool, , NULL, 1);
>
> @@ -781,6 +783,8 @@ int odp_buffer_alloc_multi(odp_pool_t pool_hdl,
> odp_buffer_t buf[], int num)
>  {
> pool_t *pool;
>
> +   ODP_ASSERT(ODP_POOL_INVALID != pool_hdl);
> +
> pool = pool_entry_from_hdl(pool_hdl);
>
> return buffer_alloc_multi(pool, buf, NULL, num);
> --
> 2.11.0
>
>

[lng-odp] [PATCH v2] linux-generic: pool: don't allocate buffers from invalid pool

[Dmitry Eremin-Solenikov]

Add ODP_ASSERT checking that passed pool is not ODP_POOL_INVALID before
tring to allocate buffers from that pool.

Signed-off-by: Dmitry Eremin-Solenikov 
---
 platform/linux-generic/odp_pool.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/platform/linux-generic/odp_pool.c 
b/platform/linux-generic/odp_pool.c
index cf7c2c41..2c1ba914 100644
--- a/platform/linux-generic/odp_pool.c
+++ b/platform/linux-generic/odp_pool.c
@@ -768,6 +768,8 @@ odp_buffer_t odp_buffer_alloc(odp_pool_t pool_hdl)
pool_t *pool;
int ret;
 
+   ODP_ASSERT(ODP_POOL_INVALID != pool_hdl);
+
pool = pool_entry_from_hdl(pool_hdl);
ret = buffer_alloc_multi(pool, , NULL, 1);
 
@@ -781,6 +783,8 @@ int odp_buffer_alloc_multi(odp_pool_t pool_hdl, 
odp_buffer_t buf[], int num)
 {
pool_t *pool;
 
+   ODP_ASSERT(ODP_POOL_INVALID != pool_hdl);
+
pool = pool_entry_from_hdl(pool_hdl);
 
return buffer_alloc_multi(pool, buf, NULL, num);
-- 
2.11.0

Re: [lng-odp] [PATCH] linux-gen: abi: fix include/odp/api/abi symlink creation

[Maxim Uvarov]

I merged this patch.

Thanks,
Maxim.

On 03/08/2017 05:24 PM, Dmitry Eremin-Solenikov wrote:

On 08.03.2017 17:13, Peltonen, Janne (Nokia - FI/Espoo) wrote:

Are you saying that in your shell this works (echoes foobar):
if false ; then : else echo foobar ; fi

Does not work here (bash 4.4.11(1)-release).

[lng-odp] [Linaro/odp] ec8a54: linux-gen: abi: fix include/odp/api/abi symlink cr...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/Linaro/odp
  Commit: ec8a54c9236925ea97ee154eb70093d6effb1311
  
https://github.com/Linaro/odp/commit/ec8a54c9236925ea97ee154eb70093d6effb1311
  Author: Janne Peltonen 
  Date:   2017-03-10 (Fri, 10 Mar 2017)

  Changed paths:
M platform/linux-generic/Makefile.am

  Log Message:
  ---
  linux-gen: abi: fix include/odp/api/abi symlink creation

Fix the ABI symlink creation that went broken in 3d6cbd2.

Signed-off-by: Janne Peltonen 
Signed-off-by: Maxim Uvarov