Don't dereference pointer after successful check for NULL as this makes Coverity
complain. (Coverity CID 85397, https://bugs.linaro.org/show_bug.cgi?id=1056)
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
Replace usage of perror and abort with CU_FAIL_FATAL in order for fatal
errors not to disturb the overall validation flow.
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Use CU_ASSERT_FATAL instead of plain assert so to work better with the cunit
test framework.
Use LOG_DBG instead of printf. Remove some unnecessary printouts.
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
Ensure we run at least one worker thread.
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
test/validation/odp_timer.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
Don't report late timeouts using CU_FAIL as this interferes with the cunit
test framework. Just count and report the number of late timeouts.
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Changes since version 4:
Moved change of printf to LOG_DBG from patch #1 to patch #4.
Changes since version 3:
Split out patch #6 from patch #4.
Miscellaneous cleanup of test/validation/odp_timer.c.
Patch #1:
Don't report late timeouts using CU_FAIL as this interferes with the cunit
test
Use nanosleep instead of the deprecated usleep. Define POSIX version to be able
to use rand_r. (https://bugs.linaro.org/show_bug.cgi?id=1048)
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Reviewed-by: Petri Savolainen petri.savolai...@linaro.org
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Thursday, February 05, 2015 6:20 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp]
Reviewed-by: Petri Savolainen petri.savolai...@linaro.org
-Original Message-
From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org]
Sent: Thursday, February 05, 2015 7:37 PM
To: lng-odp@lists.linaro.org
Cc: Savolainen, Petri (NSN - FI/Espoo); Taras Kondratiuk
Subject:
On 02/05/2015 03:48 PM, Savolainen, Petri (NSN - FI/Espoo) wrote:
In summary, patch set is OK to merge after these updates:
- patch 3/9: api: odp_buffer.h: undefined behavior description
* leave out the patch all together
- patch 6/9: api: odp_shared_memory.h: updated return descriptions
*
*/
int odp_pktio_send(odp_pktio_t id, odp_packet_t pkt_table[], unsigned
len);
Same here: int/int vs. int/unsigned
Those changes are in another patch (the last one I think).
Found it. That's OK for me.
-Petri
___
lng-odp mailing list
Also corrected return description of odp_shm_reserve(), it returns
ODP_SHM_INVALID (not NULL) on failure.
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
include/odp/api/shared_memory.h |
Reviewed-by: Petri Savolainen petri.savolai...@linaro.org
-Petri
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Thursday, February 05, 2015 3:41 PM
To: lng-odp@lists.linaro.org
Subject:
That patch needs to go to release because it fixes version output.
Anders said that it will be good to split it on 2, but I have not idea
what are the logical pieces
should be there.
Maxim.
On 02/04/2015 06:22 PM, Maxim Uvarov wrote:
Remove odp_impl.c and version_types.h, represent
This change was proposed as part of 0.5 and was removed as Petri preferred
it the way it is. Historically we couldn't move these routines with the
rest of the buffer routines because of typedef dependencies, but now that
they are factored out it really doesn't matter from a technical standpoint.
On Tue, Feb 3, 2015 at 10:03 PM, Mike Holmes mike.hol...@linaro.org wrote:
On 3 February 2015 at 14:18, Zoltan Kiss zoltan.k...@linaro.org wrote:
Acked and merged: Zoltan Kiss zoltan.k...@linaro.org
On 22/01/15 16:11, Ciprian Barbu wrote:
This patch series contains some fixes and
Improved thread id documentation and added odp_thread_count(),
which returns number of active threads.
Signed-off-by: Petri Savolainen petri.savolai...@linaro.org
---
include/odp/api/thread.h| 17 +
platform/linux-generic/odp_thread.c | 4
2 files changed, 21
This returns system specific cpu id.
Signed-off-by: Petri Savolainen petri.savolai...@linaro.org
---
example/timer/odp_timer_test.c | 2 +-
include/odp/api/thread.h| 8
platform/linux-generic/odp_thread.c | 3 ++-
test/performance/odp_scheduling.c | 2 +-
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/odp_debug_internal.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/platform/linux-generic/include/odp_debug_internal.h
b/platform/linux-generic/include/odp_debug_internal.h
Thanks, merged!
Maxim.
On 02/05/2015 12:39 PM, Mario Torrecillas Rodriguez wrote:
Added odp_errno.c and errno.h
Changed odp_packet_io and odp_timer to use it.
Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com
---
(This code contribution is provided under the terms
Ping!?!
On 2 February 2015 at 19:52, Ola Liljedahl ola.liljed...@linaro.org wrote:
Move the platform specific definitions for timer pool, timer and timeout to
the platform's include/odp/plat/timer_types.h file.
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code
Merged,
Maxim.
On 02/05/2015 06:10 PM, Bill Fischofer wrote:
On Thu, Feb 5, 2015 at 9:07 AM, Ola Liljedahl
ola.liljed...@linaro.org mailto:ola.liljed...@linaro.org wrote:
Ping!?!
On 2 February 2015 at 19:52, Ola Liljedahl
ola.liljed...@linaro.org
On Thu, Feb 5, 2015 at 9:07 AM, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Ping!?!
On 2 February 2015 at 19:52, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Move the platform specific definitions for timer pool, timer and timeout
to
the platform's include/odp/plat/timer_types.h file.
Hi,
This call has still int vs. unsigned int mismatch.
*
* @return Number of events outputed (0 ... num)
*/
int odp_schedule_multi(odp_queue_t *from, uint64_t wait, odp_event_t events[],
unsigned int num);
int num would be according to our new policy. Negative return
This move is OK. Just remove also this:
#include odp/buffer.h
since there's not dependency anymore.
-petri
-Original Message-
From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org]
Sent: Thursday, February 05, 2015 4:19 PM
To: lng-odp@lists.linaro.org
Cc: Savolainen,
On 5 February 2015 at 22:12, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
On 02/03/2015 11:04 PM, Ola Liljedahl wrote:
My alternative approach that should achieve that same goals as Petri
but give more freedom to implementations. You don't have to approve of
it, I just want to show that
HW is free to organize whatever underlying facilities it has at its
disposal to match ODP API semantics. That's the whole point of having ODP
APIs specify only what's actually needed at the application level and
giving the implementation freedom in how to provide the needed semantics.
For
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/buffer.h | 19 +++
include/odp/api/pool.h| 20
platform/linux-generic/include/odp/pool.h | 1 +
3 files changed, 20 insertions(+), 20
On Thu, Feb 5, 2015 at 11:36 AM, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
include/odp/api/buffer.h | 19 +++
Start header guards with ODP_API_ prefix to avoid confusion with other
files with the same name.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/align.h | 4 ++--
include/odp/api/atomic.h | 4 ++--
include/odp/api/barrier.h| 4 ++--
On Thu, Feb 5, 2015 at 10:20 AM, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Use (signed) int for parameter that should match return type of function.
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
(This document/code
On 5 February 2015 at 13:17, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Wednesday, February 04, 2015 11:07 PM
To:
This file contains cpu related API calls. The calls are
renames from odp_thread_cpu() and odp_sys_cpu_count().
Signed-off-by: Petri Savolainen petri.savolai...@linaro.org
---
include/odp.h| 1 +
include/odp/api/cpu.h| 54
This returns number of cpus available to ODP.
Signed-off-by: Petri Savolainen petri.savolai...@linaro.org
---
example/generator/odp_generator.c| 2 +-
example/ipsec/odp_ipsec.c| 2 +-
example/l2fwd/odp_l2fwd.c| 2 +-
example/packet/odp_pktio.c
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
example/Makefile.inc | 1 +
test/Makefile.inc| 1 +
2 files changed, 2 insertions(+)
diff --git a/example/Makefile.inc b/example/Makefile.inc
index 91f8f49..b3a9706 100644
--- a/example/Makefile.inc
+++ b/example/Makefile.inc
@@
As discussed before, I think this function can crash on bad handles as any
other buffer API call. So, let's leave out this patch.
More documentation on sanity checking can be added with another patch.
-Petri
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
include/odp/api/hints.h | 12
platform/linux-generic/include/odp_debug_internal.h | 19 ---
2 files changed, 12 insertions(+), 19 deletions(-)
diff --git
On 5 February 2015 at 13:23, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Wednesday, February 04, 2015 11:07 PM
To:
Added odp_errno.c and errno.h
Changed odp_packet_io and odp_timer to use it.
Signed-off-by: Mario Torrecillas Rodriguez mario.torrecillasrodrig...@arm.com
---
(This code contribution is provided under the terms of agreement LES-LTM-21309)
Changes from previous version:
* Fixed pktio test issue
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Wednesday, February 04, 2015 11:07 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [PATCHv6 5/9] api: odp_packet_io.h: updated return
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Wednesday, February 04, 2015 11:07 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [PATCHv6 6/9] api: odp_shared_memory.h: updated return
odp_global_data should be defined once in a C file.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/odp_internal.h | 6 --
platform/linux-generic/odp_init.c | 1 +
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git
On 02/05/2015 07:40 PM, Bill Fischofer wrote:
This looks like a reasonable precaution.
Changes to ticketlock.h were not saved in editor, so it is missed.
I'll post v2.
___
lng-odp mailing list
lng-odp@lists.linaro.org
On Thursday, February 5, 2015, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
Start header guards with ODP_API_ prefix to avoid confusion with other
files with the same name.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
javascript:;
Reviewed-by: Bill Fischofer
44 matches
Mail list logo
