Re: [lng-odp] [PATCHv2] validation: timer: added cancel test

2015-03-16 Thread Bill Fischofer
For the additions: Reviewed-by: Bill Fischofer bill.fischo...@linaro.org On Mon, Mar 16, 2015 at 8:55 AM, Ola Liljedahl ola.liljed...@linaro.org wrote: On 12 March 2015 at 17:03, Ola Liljedahl ola.liljed...@linaro.org wrote: Add basic timer cancel test that checks that everything is OK when

Re: [lng-odp] [PATCH 3/3] linux-generic: schedule: make sure SCHED queues get freed by the scheduler

2015-03-16 Thread Bill Fischofer
Code should not have #if 0 or #if 1 in them. Leftover from debugging? On Mon, Mar 16, 2015 at 10:16 AM, Maxim Uvarov maxim.uva...@linaro.org wrote: On 03/16/15 17:51, Ciprian Barbu wrote: ODP_QUEUE_TYPE_SCHED queues only get marked as destroyed, they need to be removed from the pri_queues

Re: [lng-odp] [PATCH 1/3] validation: pktio: add support for VPATH builds

2015-03-16 Thread Mike Holmes
On 16 March 2015 at 07:48, Stuart Haslam stuart.has...@linaro.org wrote: Running make check in a VPATH build fails as the odp_pktio_run script incorrectly assumes that the odp_pktio binary is in the same directory. Resolve this by passing the path to the test binary to the script via the

Re: [lng-odp] [PATCH] linux-generic: queue: fix potential queue leak

2015-03-16 Thread Bill Fischofer
On Mon, Mar 16, 2015 at 8:58 AM, Stuart Haslam stuart.has...@linaro.org wrote: If schedule buffer allocation fails during odp_queue_create(), a scheduled or pktin queue may be incorrectly left in an allocated state. Signed-off-by: Stuart Haslam stuart.has...@linaro.org Reviewed-by: Bill

Re: [lng-odp] Query: Compilation of ODP with optimising flags

2015-03-16 Thread Ola Liljedahl
On 15 March 2015 at 13:45, Mike Holmes mike.hol...@linaro.org wrote: On 14 March 2015 at 03:47, Sunil Kumar Kori sunil.k...@freescale.com wrote: Hello All, I have to compile ODP with optimization flags ‘O’zero. Can someone help me out to do the same ? Sunil You don't provide much

Re: [lng-odp] C++ compilation question

2015-03-16 Thread Maxim Uvarov
did you apply Bills patch? Maxim. On 03/16/15 16:41, Ola Liljedahl wrote: I am trying to include ODP header files from a C++ source file. $ make all --- Compiling nat.cc g++ -fno-exceptions -g -ggdb -Wall -O2 -Wno-extern-c-compat -c -MMD -MP -I../../odp/include

[lng-odp] [PATCH] linux-generic: queue: fix potential queue leak

2015-03-16 Thread Stuart Haslam
If schedule buffer allocation fails during odp_queue_create(), a scheduled or pktin queue may be incorrectly left in an allocated state. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- platform/linux-generic/odp_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [lng-odp] C++ compilation question

2015-03-16 Thread Ola Liljedahl
No but the problem is not with the C++ null struct problem which I think Bill's patch fixes (this one http://patches.opendataplane.org/patch/1092/). -- Ola On 16 March 2015 at 14:50, Maxim Uvarov maxim.uva...@linaro.org wrote: did you apply Bills patch? Maxim. On 03/16/15 16:41, Ola

Re: [lng-odp] C++ compilation question

2015-03-16 Thread Mike Holmes
I think you are seeing this https://bugs.linaro.org/show_bug.cgi?id=1259 On 16 March 2015 at 09:41, Ola Liljedahl ola.liljed...@linaro.org wrote: I am trying to include ODP header files from a C++ source file. $ make all --- Compiling nat.cc g++ -fno-exceptions -g -ggdb -Wall -O2

[lng-odp] C++ compilation question

2015-03-16 Thread Ola Liljedahl
I am trying to include ODP header files from a C++ source file. $ make all --- Compiling nat.cc g++ -fno-exceptions -g -ggdb -Wall -O2 -Wno-extern-c-compat -c -MMD -MP -I../../odp/include -I../../odp/platform/linux-generic/include -o obj/nat.o nat.cc In file included from

Re: [lng-odp] [PATCHv2 2/2] tests: performance add l2fwd to run script

2015-03-16 Thread Stuart Haslam
On Fri, Mar 13, 2015 at 06:03:47PM +0300, Maxim Uvarov wrote: Move common pktio linux-generic functions to setup virtual net to linux-generic folder and add running l2fwd test for make check. Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- platform/linux-generic/test/pktio_env |

Re: [lng-odp] [PATCHv2] validation: added odp_cpumask test

2015-03-16 Thread Bill Fischofer
On Mon, Mar 16, 2015 at 5:05 AM, Christophe Milard christophe.mil...@linaro.org wrote: Half sunny days tests for odp cpumask: At this point, odp_cpu_count() is used to get the number of cpus a odp_cpumask_t may contain. This returns probably a too conservative (small) number Signed-off-by:

Re: [lng-odp] [PATCH 3/3] performance: scheduling: add support for VPATH builds

2015-03-16 Thread Stuart Haslam
On Mon, Mar 16, 2015 at 02:54:29PM +0300, Maxim Uvarov wrote: I would merge patches 2 and 3 if they modify the same lines. Maxim. But they are doing different things, if I were to merge the patches the description would need to explain both sets of changes and the log would be less clear.

[lng-odp] [PATCHv2] validation: pktio: prevent race when using veth pair

2015-03-16 Thread Stuart Haslam
There's a potential race condition whereby the test case could start running before the virtual ethernet interfaces are fully brought up. So replace the the arbitrary delay with a check for the interface's operational state before kicking off the test. Signed-off-by: Stuart Haslam

Re: [lng-odp] [PATCH] example: odp_ipsec: remove USE_MAC_ADDR_HACK

2015-03-16 Thread Maxim Uvarov
Patch looks like clear and correct, I'm going to merge it. Maxim. On 03/11/15 16:13, Ciprian Barbu wrote: Remove the old hack and switch to using the provided API This also fixes https://bugs.linaro.org/show_bug.cgi?id=1330 Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org ---

[lng-odp] [PATCH 2/3] performance: scheduling: catch exit codes

2015-03-16 Thread Stuart Haslam
odp_scheduling_run always exits with code 0 so make check will never report failures. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- test/performance/odp_scheduling_run | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/performance/odp_scheduling_run

[lng-odp] [PATCH 1/3] validation: pktio: add support for VPATH builds

2015-03-16 Thread Stuart Haslam
Running make check in a VPATH build fails as the odp_pktio_run script incorrectly assumes that the odp_pktio binary is in the same directory. Resolve this by passing the path to the test binary to the script via the TESTS_ENVIRONMENT variable. Signed-off-by: Stuart Haslam stuart.has...@linaro.org

[lng-odp] [PATCH 3/3] performance: scheduling: add support for VPATH builds

2015-03-16 Thread Stuart Haslam
Pass the test executable path to the test script to avoid the assumption that they're both in the same directory. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- test/performance/Makefile.am| 2 ++ test/performance/odp_scheduling_run | 3 ++- 2 files changed, 4 insertions(+), 1

Re: [lng-odp] query regarding queue ODP_QUEUE_TYPE_SCHED

2015-03-16 Thread Maxim Uvarov
Hello Nikhil, ipsec example can work with polling queues and with scheduler: #ifdef IPSEC_POLL_QUEUES #define QUEUE_CREATE(n, t, p) polled_odp_queue_create(n, t, p) #define SCHEDULE(q, w)polled_odp_schedule(q, w) #else #define QUEUE_CREATE(n, t, p) odp_queue_create(n, t, p) #define

Re: [lng-odp] [PATCH 3/3] performance: scheduling: add support for VPATH builds

2015-03-16 Thread Maxim Uvarov
I would merge patches 2 and 3 if they modify the same lines. Maxim. On 03/16/15 14:48, Stuart Haslam wrote: Pass the test executable path to the test script to avoid the assumption that they're both in the same directory. Signed-off-by: Stuart Haslam stuart.has...@linaro.org ---

Re: [lng-odp] [PATCH] validation: pktio: prevent race when using veth pair

2015-03-16 Thread Maxim Uvarov
On 03/16/15 14:54, Stuart Haslam wrote: On Thu, Mar 12, 2015 at 10:54:49AM +, Stuart Haslam wrote: On Wed, Mar 11, 2015 at 04:47:59PM -0400, Mike Holmes wrote: I simultaneously ran two independent instances of odp with make check and neither had an issue, one had this patch the other did

[lng-odp] [PATCHv2] validation: added odp_cpumask test

2015-03-16 Thread Christophe Milard
Half sunny days tests for odp cpumask: At this point, odp_cpu_count() is used to get the number of cpus a odp_cpumask_t may contain. This returns probably a too conservative (small) number Signed-off-by: Christophe Milard christophe.mil...@linaro.org --- Second try fir this matvh, with updates

Re: [lng-odp] [PATCHv2 1/2] example: l2fwd print packets per second

2015-03-16 Thread Ciprian Barbu
So are we still going with this change, before moving l2fwd to performance tests? On Mon, Mar 16, 2015 at 10:26 AM, Savolainen, Petri (Nokia - FI/Espoo) petri.savolai...@nokia.com wrote: -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-

Re: [lng-odp] [PATCH] validation: pktio: prevent race when using veth pair

2015-03-16 Thread Stuart Haslam
On Mon, Mar 16, 2015 at 03:04:42PM +0300, Maxim Uvarov wrote: On 03/16/15 14:54, Stuart Haslam wrote: On Thu, Mar 12, 2015 at 10:54:49AM +, Stuart Haslam wrote: On Wed, Mar 11, 2015 at 04:47:59PM -0400, Mike Holmes wrote: I simultaneously ran two independent instances of odp with make

Re: [lng-odp] [PATCH] validation: pktio: prevent race when using veth pair

2015-03-16 Thread Stuart Haslam
On Thu, Mar 12, 2015 at 10:54:49AM +, Stuart Haslam wrote: On Wed, Mar 11, 2015 at 04:47:59PM -0400, Mike Holmes wrote: I simultaneously ran two independent instances of odp with make check and neither had an issue, one had this patch the other did not. At the same time I used the

[lng-odp] [PATCH 2/3] linux-generic: queue: add queue_is_destroyed internal call

2015-03-16 Thread Ciprian Barbu
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org --- platform/linux-generic/include/odp_queue_internal.h | 9 + 1 file changed, 9 insertions(+) diff --git a/platform/linux-generic/include/odp_queue_internal.h b/platform/linux-generic/include/odp_queue_internal.h index

Re: [lng-odp] [PATCHv2 1/2] example: l2fwd print packets per second

2015-03-16 Thread Maxim Uvarov
On 03/16/15 13:22, Ciprian Barbu wrote: So are we still going with this change, before moving l2fwd to performance tests? I think yes, why not? Even if after then it will be not hard to ally that patch. On Mon, Mar 16, 2015 at 10:26 AM, Savolainen, Petri (Nokia - FI/Espoo)

Re: [lng-odp] [PATCH 3/3] linux-generic: schedule: make sure SCHED queues get freed by the scheduler

2015-03-16 Thread Maxim Uvarov
On 03/16/15 17:51, Ciprian Barbu wrote: ODP_QUEUE_TYPE_SCHED queues only get marked as destroyed, they need to be removed from the pri_queues of the linux-generic scheduler Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org --- platform/linux-generic/odp_schedule.c | 25

[lng-odp] [PATCH 1/3] validation: schedule: free queues and pool

2015-03-16 Thread Ciprian Barbu
With the implementation of termination APIs it is now necessarry to cleanup all allocated resources, queues and pool in this case. Fixes https://bugs.linaro.org/show_bug.cgi?id=1284 Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org --- test/validation/odp_schedule.c | 56

[lng-odp] [PATCH 0/3] Fixes for https://bugs.linaro.org/show_bug.cgi?id=1284

2015-03-16 Thread Ciprian Barbu
Like in the previous RFC, the first patch is the fix. The second and third patch represent a proposed fix for freeing the ODP_QUEUE_TYPE_SCHED queues that were not removed from the internal priority queues because the scheduler did not know they were empty. Ciprian Barbu (3): validation:

Re: [lng-odp] C++ compilation question

2015-03-16 Thread Ola Liljedahl
On 16 March 2015 at 15:09, Mike Holmes mike.hol...@linaro.org wrote: I think you are seeing this https://bugs.linaro.org/show_bug.cgi?id=1259 Yes that looks like it. Your comment https://bugs.linaro.org/show_bug.cgi?id=1259#c2 How would I do this? I am compiling using g++ and not specifying

Re: [lng-odp] [PATCHv2 2/2] tests: performance add l2fwd to run script

2015-03-16 Thread Maxim Uvarov
On 03/16/15 14:09, Stuart Haslam wrote: On Fri, Mar 13, 2015 at 06:03:47PM +0300, Maxim Uvarov wrote: Move common pktio linux-generic functions to setup virtual net to linux-generic folder and add running l2fwd test for make check. Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org ---

Re: [lng-odp] [PATCHv2] validation: pktio: prevent race when using veth pair

2015-03-16 Thread Maxim Uvarov
For me that version works good. Thanks, Maxim. On 03/16/15 15:27, Stuart Haslam wrote: There's a potential race condition whereby the test case could start running before the virtual ethernet interfaces are fully brought up. So replace the the arbitrary delay with a check for the interface's

Re: [lng-odp] [PATCHv2 1/2] example: l2fwd print packets per second

2015-03-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
-Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- boun...@lists.linaro.org] On Behalf Of ext Maxim Uvarov Sent: Friday, March 13, 2015 5:04 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCHv2 1/2] example: l2fwd print packets per second Current

Re: [lng-odp] [PATCH ARCH] remove api_guide_lines

2015-03-16 Thread Anders Roxell
On 2015-03-11 14:30, Mike Holmes wrote: This docuemtnation has been moved to the API document Signed-off-by: Mike Holmes mike.hol...@linaro.org Applied. Cheers, Anders --- api_guide_lines.dox | 178 1 file changed, 178 deletions(-)