SCN produced some buggy scanning here which leads to broken rules set
from command line and
example did not work as expected. Originally there was SCN and it was
reverted with:
(api-next branch).
commit 3824a72a48da0954ec3f28d5fb6ff51cec891363
Author: Balasubramanian Manoharan
Applied.
Maxim.
On 01/12/2016 15:24, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Ping.
*From:*EXT Bill Fischofer [mailto:bill.fischo...@linaro.org]
*Sent:* Monday, January 04, 2016 6:43 PM
*To:* Savolainen, Petri (Nokia - FI/Espoo)
*Cc:* LNG ODP Mailman List
*Subject:* Re: [lng-odp]
On Tue, Jan 12, 2016 at 05:36:35PM -0500, Mike Holmes wrote:
> The script did not check that the odp_generator was present and worse it
> failed silently if it was not present.
>
> Signed-off-by: Mike Holmes
> ---
> test/performance/odp_l2fwd_run | 10 ++
> 1
On Tue, Jan 05, 2016 at 04:10:36PM +0100, Nicolas Morey-Chaisemartin wrote:
> Signed-off-by: Nicolas Morey-Chaisemartin
Reviewed-by: Stuart Haslam
> ---
> example/classifier/odp_classifier.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Confused: Are we talking about aliasing all functions XXX to api_XXX()
and/or drv_XXX(), i.e. some sort of facading, or are we still talking about
having the driver interface using drv_XXX() and api_YYY()?
1) Facading:
Facading make sense: it is clearly defined. But is comes with extra
Patch sequence is not build-able if I on that patch (i.e. only 4 patches
applied):
../../platform/linux-generic/include/odp/cpu.h:20:26: fatal error:
odp/cpu_arch.h: No such file or directory
#include
Maxim.
On 01/05/2016 17:42, Petri Savolainen wrote:
Deleted odph_pause() and replaced
ODP API (odp.h and everything you can see through that) does not change at all
due to the introduction of driver interface. You may need to add some
parameters or functions, but it should be very minimal since driver interface
is part of the internal structure of an implementation (and may
On Wed, Jan 13, 2016 at 02:15:28PM +0300, Maxim Uvarov wrote:
> SCN produced some buggy scanning here which leads to broken rules
> set from command line and
> example did not work as expected. Originally there was SCN and it
> was reverted with:
That was because it was previously using SCNx32,
On 01/12/2016 21:57, Zoltan Kiss wrote:
Hi,
We have a couple of places where the entire source file couldn't be
copied from linux-generic, but some of the functions are. E.g. the
loopback implementation from linux-generic's pktio code is something
like that. It would be nice to somehow get
Merged,
Maxim.
On 01/11/2016 22:01, Mike Holmes wrote:
On 11 January 2016 at 04:47, Christophe Milard
>
wrote:
Limiting the usage of the C library to the functions defined in its
C99 version.
Signed-off-by:
Linux-generic solves this problems with watermarks. As the shared pool
depletes and hits its low watermark free() calls always return elements
back to the shared pool rather than the local cache until the shared pool
reaches its high watermark. This ensures that elements cannot get "lost" in
the
What arch you tried? What it was building (examples, validation,
implementation, ...) ?
I cannot see any problems with ARCH=x86 (4 or all patches applied). It rebased
OK on top of latest api-next. Builds OK with 'make'. Builds OK after 'make
install'.
-Petri
> -Original Message-
>
Merged,
Maxim.
On 01/06/2016 17:10, Stuart Haslam wrote:
Modify the tests that currently transmit packets in batches to also
receive packets in batches. This adds coverage of odp_queue_deq_multi()
and odp_schedule_multi() specifically against a packet input queue,
as this doesn't get tested
> -Original Message-
> From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org]
> Sent: Wednesday, January 13, 2016 2:34 PM
> To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [API-NEXT PATCH 4/5] helper: deleted odph_pause
>
> On 01/13/2016
On Wed, Jan 13, 2016 at 03:30:03PM +0300, Maxim Uvarov wrote:
> Please resend this patch with Review. Original patch is missing for
> unknown reason.
>
> Maxim.
Mails from Nicolas get flagged as spam by google, looks to be due to a
DKIM failure.
"It has a from address in kalray.eu but has
On Wed, Jan 13, 2016 at 3:49 AM, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
> Hi,
>
> What object types you'd allocate from the pool? Packets, buffers, timeouts
> or some other application specific object?
>
> If it's application specific objects, we'd actually need
These arch depedent files are not limited to cpu_cycle
calls implementation only.
Signed-off-by: Petri Savolainen
---
platform/linux-generic/Makefile.am | 8 ++--
platform/linux-generic/arch/linux/odp_cpu_arch.c | 48 ++
The script did not check that the odp_generator was present.
Updates to ensure the clean up is always called at EXIT
Signed-off-by: Mike Holmes
---
v2:
Use stuarts suggetion to clean up the interfaces on EXIT
test/performance/odp_l2fwd_run | 13 +
1 file
Please resend this patch with Review. Original patch is missing for
unknown reason.
Maxim.
On 01/06/2016 20:53, Bala Manoharan wrote:
Reviewed-by: Balasubramanian Manoharan
Regards,
Bala
On 6 January 2016 at 23:04, Nicolas Morey-Chaisemartin
Implemented pause as an inline function in a cpu arch dependent
header file.
Signed-off-by: Petri Savolainen
---
helper/Makefile.am| 2 ++
platform/linux-generic/Makefile.am| 4 +++-
Deleted odph_pause() and replaced usage with odp_cpu_pause()
calls.
Signed-off-by: Petri Savolainen
---
helper/Makefile.am | 1 -
helper/odph_pause.h | 54
helper/ring.c| 10 +++--
.
On 01/05/2016 18:21, Nicolas Morey-Chaisemartin wrote:
Copy the expected digest at the end of the plaintext
to validate Auth decode functions
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/crypto/odp_crypto_test_inp.c | 5 +
1 file changed, 5
.
On 01/05/2016 18:20, Nicolas Morey-Chaisemartin wrote:
This adds tests for the auth/hash check function in crypto
v2:
Rebased on master branch (was API-NEXT due to required AES-GCM patch series)
Nicolas Morey-Chaisemartin (3):
validation: crypto: support auth decoding
validation:
Can you please resend original patch? You can include Stuarts review.
I do not see it in my email and in
http://patches.opendataplane.org/project/lng-odp/list/
Thanks,
Maxim.
On 01/13/2016 14:20, Stuart Haslam wrote:
On Wed, Jan 13, 2016 at 02:15:28PM +0300, Maxim Uvarov wrote:
SCN
On 13 January 2016 at 11:31, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
>
>
> ODP API (odp.h and everything you can see through that) does not change at
> all due to the introduction of driver interface. You may need to add some
> parameters or functions, but it
Removed odp_spin() and replaced usage with odp_cpu_pause().
Signed-off-by: Petri Savolainen
---
platform/linux-generic/Makefile.am | 1 -
platform/linux-generic/include/odp_spin_internal.h | 58 --
On 13 January 2016 at 03:49, Maxim Uvarov wrote:
> On 01/12/2016 21:57, Zoltan Kiss wrote:
>
>> Hi,
>>
>> We have a couple of places where the entire source file couldn't be
>> copied from linux-generic, but some of the functions are. E.g. the loopback
>> implementation
.
On 01/05/2016 18:21, Nicolas Morey-Chaisemartin wrote:
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/crypto/odp_crypto_test_inp.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/test/validation/crypto/odp_crypto_test_inp.c
.
On 01/05/2016 18:21, Nicolas Morey-Chaisemartin wrote:
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/crypto/odp_crypto_test_inp.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/test/validation/crypto/odp_crypto_test_inp.c
.
On 01/05/2016 18:21, Nicolas Morey-Chaisemartin wrote:
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/crypto/odp_crypto_test_inp.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/test/validation/crypto/odp_crypto_test_inp.c
On 01/13/2016 14:20, Stuart Haslam wrote:
On Wed, Jan 13, 2016 at 02:15:28PM +0300, Maxim Uvarov wrote:
SCN produced some buggy scanning here which leads to broken rules
set from command line and
example did not work as expected. Originally there was SCN and it
was reverted with:
That was
On 01/13/2016 15:42, Stuart Haslam wrote:
On Wed, Jan 13, 2016 at 03:30:03PM +0300, Maxim Uvarov wrote:
Please resend this patch with Review. Original patch is missing for
unknown reason.
Maxim.
Mails from Nicolas get flagged as spam by google, looks to be due to a
DKIM failure.
"It has a
Pause is used in tight loops to reduce stress to the system.
Signed-off-by: Petri Savolainen
---
include/odp/api/cpu.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/odp/api/cpu.h b/include/odp/api/cpu.h
index 8a804d4..4cbaf58 100644
---
On 13 January 2016 at 15:33, Bill Fischofer
wrote:
> If we can eliminate a dependency that seems like another reason to use the
> .svgs directly. I really don't see the need for PDF support since few are
> going to be printing manuals these days.
>
Agree, I am hoping
Adds cpumasks for control and worker cores to the ODP global init data
which is passed as an argument to odp_init_global.
The intent is to allow an external entity to pass in lists of the
CPU resources available to the current ODP application.
It is assumed that these masks would by default be
In order to enable externally supplied CPU resource management policies to be
passed into ODP instances / applications, a minor change is needed to the
existing ODP API. By adding cpumasks for available control and worker CPUs
to the data structure specified as a parameter to odp_init_global(),
I did now :0
v2 submitted to correct that oversight. Thanks.
On Wed, Jan 13, 2016 at 3:08 PM, Mike Holmes wrote:
> Did you test with doxygen ?
>
> On 13 January 2016 at 16:07, Bill Fischofer
> wrote:
>
>> Simplify ODP documentation builds by
Probably we need to add convert (imagemagic package?) check to ./configure.
Maxim.
On 01/13/2016 19:01, Mike Holmes wrote:
Have you installed the DEPENDENCIES for building the docs ?
Did you just make or "make distcheck"
On 13 January 2016 at 10:58, Bala Manoharan
Simplify ODP documentation builds by using .svg files directly for all
images. This eliminates the need to create .png and .eps files via the
imagemagic package. Note that this removes easy PDF output for ODP user
documents, however there is no real demand for such capability.
Signed-off-by: Bill
On 13 January 2016 at 14:31, Maxim Uvarov wrote:
> Probably we need to add convert (imagemagic package?) check to ./configure.
>
It is there, what has changed is that it apparently gets required even if
you dont build docs.
As we move to direct use of .svg I can delete
If we can eliminate a dependency that seems like another reason to use the
.svgs directly. I really don't see the need for PDF support since few are
going to be printing manuals these days.
On Wed, Jan 13, 2016 at 2:11 PM, Mike Holmes wrote:
>
>
> On 13 January 2016 at
Did you test with doxygen ?
On 13 January 2016 at 16:07, Bill Fischofer
wrote:
> Simplify ODP documentation builds by using .svg files directly for all
> images. This eliminates the need to create .png and .eps files via the
> imagemagic package. Note that this
On Wed, Jan 13, 2016 at 2:35 PM, Mike Holmes wrote:
>
>
> On 13 January 2016 at 15:33, Bill Fischofer
> wrote:
>
>> If we can eliminate a dependency that seems like another reason to use
>> the .svgs directly. I really don't see the need for
The idea behind this suite is to have a mechanism to test the
behaviour of the system after applying all the different PMR, default
CoS, error CoS and L2 and L3 CoS values. your suggested changes tests
each and every configuration individually which defeats the idea of
the suite.
There is a
Suggested-by: Anders Roxell
Signed-off-by: Mike Holmes
---
doc/users-guide/users-guide-tm.adoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/users-guide/users-guide-tm.adoc
b/doc/users-guide/users-guide-tm.adoc
This patch series complements and depends on the addition of new cpumasks to
the initialization data structure defined as a parameter to odp_init_global().
The code changes included here use the new cpumasks to ensure that the
linux-generic reference platform implementation allocates CPU resources
Signed-off-by: Bill Fischofer
---
CONTRIBUTING | 5 ++---
DEPENDENCIES | 7 ++-
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/CONTRIBUTING b/CONTRIBUTING
index 4ad964e..f6e3fc6 100644
--- a/CONTRIBUTING
+++ b/CONTRIBUTING
@@ -126,9 +126,8 @@ Code
This patch does not apply maybe you need to rebase to HEAD.
Regards,
Bala
Regards,
Bala
On 12 January 2016 at 23:41, Ivan Khoronzhuk wrote:
> There is no need to create default input queue for pktio if
> default CoS is assigned.
>
> Signed-off-by: Ivan Khoronzhuk
Hi Ivan,
It would be better if you can send this patch on API-NEXT branch as I
said before I am working on API proposal to modify odp_pmr_create()
function syntax and it would be easy if we could modify your changes
to API-NEXT and then we can move it to master branch.
The patch 3 in your series
On 14.01.16 07:55, Bala Manoharan wrote:
The idea behind this suite is to have a mechanism to test the
behaviour of the system after applying all the different PMR, default
CoS, error CoS and L2 and L3 CoS values. your suggested changes tests
each and every configuration individually which
The idea of having to create pktio in each and every test case is to
create robustness in test cases and have them as independent from each
other as possible. In classification when you remove a CoS rule it is
not expected to see the changes immediately some systems will have
latency and the
On 14.01.16 07:52, Bala Manoharan wrote:
This patch does not apply maybe you need to rebase to HEAD.
Regards,
Bala
Regards,
Bala
I will re-base, but this patch still has questions.
Like, do we need to assign default input queue if it's not supposed to be used
and completely replaced by
On 14.01.16 07:59, Bala Manoharan wrote:
The idea of having to create pktio in each and every test case is to
create robustness in test cases and have them as independent from each
other as possible. In classification when you remove a CoS rule it is
not expected to see the changes immediately
Mike,
I am running OFP cunit test: ofp_test_init. It happens 1 out of 3 runs.
gdb ./test/cunit/ofp_test_init
Bogdan
From: Mike Holmes [mailto:mike.hol...@linaro.org]
Sent: Tuesday, January 12, 2016 5:57 PM
To: Bogdan Pricope
Cc: lng-odp@lists.linaro.org
Subject: Re:
v3 submitted to add updates for these two files as well. Thanks.
On Wed, Jan 13, 2016 at 4:41 PM, Mike Holmes wrote:
> DEPENDENCIES and CONTRIBUTING need to be updated since we no longer need
> to talk about .png or .eps
>
> On 13 January 2016 at 16:15, Bill Fischofer
Signed-off-by: Mike Holmes
---
doc/users-guide/users-guide-tm.adoc | 83 +
1 file changed, 83 insertions(+)
diff --git a/doc/users-guide/users-guide-tm.adoc
b/doc/users-guide/users-guide-tm.adoc
index dc0d003..e68157f 100644
---
DEPENDENCIES and CONTRIBUTING need to be updated since we no longer need to
talk about .png or .eps
On 13 January 2016 at 16:15, Bill Fischofer
wrote:
> Simplify ODP documentation builds by using .svg files directly for all
> images. This eliminates the need to create
These code changes depend on the addition of control and worker cpumasks
to the ODP initialization parameter data structure, and implement the
change in behavior suggested with that patch. They serve as the 'glue'
between the input of the new ODP API initial cpuset masks and the use of
those new
For this series:
Reviewed-by: Bill Fischofer
On Wed, Jan 13, 2016 at 4:07 PM, Mike Holmes wrote:
> Signed-off-by: Mike Holmes
> ---
> doc/users-guide/users-guide-tm.adoc | 83
> +
>
Hi,
Firstly, I don't want to bring any new type of pool into ODP.
I just want to give user more chance to use more areas of memory. For example,
referring to your example of various HW offload engines, if there two or more
types of engines
which have different request on memory attributions
Signed-off-by: Christophe Milard
---
doc/implementers-guide/implementers-guide.adoc | 21 +
1 file changed, 21 insertions(+)
diff --git a/doc/implementers-guide/implementers-guide.adoc
b/doc/implementers-guide/implementers-guide.adoc
index
Merged!
Maxim.
Looks like my system was compiled with netmap support but no actual
drivers. That was the reason
for no packets in l2fwd.
Maxim.
On 01/13/2016 14:50, Maxim Uvarov wrote:
In my testing it breaks l2fwd test if I run 'make check' under root.
Maxim.
On 01/08/2016 00:55, Bill
Have you installed the DEPENDENCIES for building the docs ?
Did you just make or "make distcheck"
On 13 January 2016 at 10:58, Bala Manoharan
wrote:
> Hi,
>
> The api-next branch is broken after merge from master.
> convert atomic_queue.svg atomic_queue.png
>
When marking a test which has a precondition as temporarly inactive,
it feels better to be able to keep the precondition function:
ODP_TEST_INFO_CONDITIONAL(send_failure, check_send_failure)
will be marked as inactive by:
ODP_TEST_INFO_INACTIVE(send_failure, check_send_failure)
rather than:
On 01/13/2016 01:42 PM, Stuart Haslam wrote:
> On Wed, Jan 13, 2016 at 03:30:03PM +0300, Maxim Uvarov wrote:
>> Please resend this patch with Review. Original patch is missing for
>> unknown reason.
>>
>> Maxim.
> Mails from Nicolas get flagged as spam by google, looks to be due to a
> DKIM
On Wed, Jan 13, 2016 at 08:52:07AM -0500, Mike Holmes wrote:
> The script did not check that the odp_generator was present.
> Updates to ensure the clean up is always called at EXIT
>
> Signed-off-by: Mike Holmes
Reviewed-by: Stuart Haslam
>
Hi,
The api-next branch is broken after merge from master.
convert atomic_queue.svg atomic_queue.png
/bin/bash: convert: command not found
make[2]: *** [atomic_queue.png] Error 127
Regards,
Bala
___
lng-odp mailing list
lng-odp@lists.linaro.org
Documentation on conditional test is added here, as it seemed to be missing
Signed-off-by: Christophe Milard
---
doc/implementers-guide/implementers-guide.adoc | 29 ++
1 file changed, 29 insertions(+)
diff --git
On 01/13/2016 00:15, Nicolas Morey-Chaisemartin wrote:
Hi,
I have the same issue with our implementation.
I usually either work from the git diff of linux generic before and post update
and backport changed or to a diff of the diff of linux-generic vs mppa platform
before and after the merge.
resend to list (google marked it as spam).
Maxim.
On 01/12/2016 20:40, Nicolas Morey-Chaisemartin wrote:
Old version of OpenSSL require SET_TAG to be called before
decrypting the data. New versions are compatible either way
Signed-off-by: Nicolas Morey-Chaisemartin
---
It can be used to restore headroom later. Does it possible a headroom
to be > sizeof(int32)/2?
Signed-off-by: Ivan Khoronzhuk
---
include/odp/api/packet_io.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/odp/api/packet_io.h
Now odp_time_wait_ns() can be used.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/pktio/pktio.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
index 45c11c5..29ad4ea
The odp_pktio_stop() called is supposed to return error.
Signed-off-by: Ivan Khoronzhuk
---
test/validation/pktio/pktio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c
index
73 matches
Mail list logo