Re: [lng-odp] [PATCH] example: classifier: use SCN macro to scan uint32_t

2016-01-13 Thread Maxim Uvarov
SCN produced some buggy scanning here which leads to broken rules set from command line and example did not work as expected. Originally there was SCN and it was reverted with: (api-next branch). commit 3824a72a48da0954ec3f28d5fb6ff51cec891363 Author: Balasubramanian Manoharan

Re: [lng-odp] [API-NEXT PATCH 1/2] api: cpumask: documented string format

2016-01-13 Thread Maxim Uvarov
Applied. Maxim. On 01/12/2016 15:24, Savolainen, Petri (Nokia - FI/Espoo) wrote: Ping. *From:*EXT Bill Fischofer [mailto:bill.fischo...@linaro.org] *Sent:* Monday, January 04, 2016 6:43 PM *To:* Savolainen, Petri (Nokia - FI/Espoo) *Cc:* LNG ODP Mailman List *Subject:* Re: [lng-odp]

Re: [lng-odp] [PATCH] test: perf: l2fwd detect missing odp_generator

2016-01-13 Thread Stuart Haslam
On Tue, Jan 12, 2016 at 05:36:35PM -0500, Mike Holmes wrote: > The script did not check that the odp_generator was present and worse it > failed silently if it was not present. > > Signed-off-by: Mike Holmes > --- > test/performance/odp_l2fwd_run | 10 ++ > 1

Re: [lng-odp] [PATCH] example: classifier: use SCN macro to scan uint32_t

2016-01-13 Thread Stuart Haslam
On Tue, Jan 05, 2016 at 04:10:36PM +0100, Nicolas Morey-Chaisemartin wrote: > Signed-off-by: Nicolas Morey-Chaisemartin Reviewed-by: Stuart Haslam > --- > example/classifier/odp_classifier.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [lng-odp] [API-NEXT RFC 02/31] api: introducing the driver api definition file

2016-01-13 Thread Christophe Milard
Confused: Are we talking about aliasing all functions XXX to api_XXX() and/or drv_XXX(), i.e. some sort of facading, or are we still talking about having the driver interface using drv_XXX() and api_YYY()? 1) Facading: Facading make sense: it is clearly defined. But is comes with extra

Re: [lng-odp] [API-NEXT PATCH 4/5] helper: deleted odph_pause

2016-01-13 Thread Maxim Uvarov
Patch sequence is not build-able if I on that patch (i.e. only 4 patches applied): ../../platform/linux-generic/include/odp/cpu.h:20:26: fatal error: odp/cpu_arch.h: No such file or directory #include Maxim. On 01/05/2016 17:42, Petri Savolainen wrote: Deleted odph_pause() and replaced

Re: [lng-odp] [API-NEXT RFC 02/31] api: introducing the driver api definition file

2016-01-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
ODP API (odp.h and everything you can see through that) does not change at all due to the introduction of driver interface. You may need to add some parameters or functions, but it should be very minimal since driver interface is part of the internal structure of an implementation (and may

Re: [lng-odp] [PATCH] example: classifier: use SCN macro to scan uint32_t

2016-01-13 Thread Stuart Haslam
On Wed, Jan 13, 2016 at 02:15:28PM +0300, Maxim Uvarov wrote: > SCN produced some buggy scanning here which leads to broken rules > set from command line and > example did not work as expected. Originally there was SCN and it > was reverted with: That was because it was previously using SCNx32,

Re: [lng-odp] Maintain code copy-pasted from linux-generic in ODP-DPDK

2016-01-13 Thread Maxim Uvarov
On 01/12/2016 21:57, Zoltan Kiss wrote: Hi, We have a couple of places where the entire source file couldn't be copied from linux-generic, but some of the functions are. E.g. the loopback implementation from linux-generic's pktio code is something like that. It would be nice to somehow get

Re: [lng-odp] [PATCH] doc: implementers-guide: libC version

2016-01-13 Thread Maxim Uvarov
Merged, Maxim. On 01/11/2016 22:01, Mike Holmes wrote: On 11 January 2016 at 04:47, Christophe Milard > wrote: Limiting the usage of the C library to the functions defined in its C99 version. Signed-off-by:

Re: [lng-odp] odp_pool_param_t::num versus per-thread object caches

2016-01-13 Thread Bill Fischofer
Linux-generic solves this problems with watermarks. As the shared pool depletes and hits its low watermark free() calls always return elements back to the shared pool rather than the local cache until the shared pool reaches its high watermark. This ensures that elements cannot get "lost" in the

Re: [lng-odp] [API-NEXT PATCH 4/5] helper: deleted odph_pause

2016-01-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
What arch you tried? What it was building (examples, validation, implementation, ...) ? I cannot see any problems with ARCH=x86 (4 or all patches applied). It rebased OK on top of latest api-next. Builds OK with 'make'. Builds OK after 'make install'. -Petri > -Original Message- >

Re: [lng-odp] [PATCHv4] validation: pktio: test batch receive

2016-01-13 Thread Maxim Uvarov
Merged, Maxim. On 01/06/2016 17:10, Stuart Haslam wrote: Modify the tests that currently transmit packets in batches to also receive packets in batches. This adds coverage of odp_queue_deq_multi() and odp_schedule_multi() specifically against a packet input queue, as this doesn't get tested

Re: [lng-odp] [API-NEXT PATCH 4/5] helper: deleted odph_pause

2016-01-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Wednesday, January 13, 2016 2:34 PM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 4/5] helper: deleted odph_pause > > On 01/13/2016

Re: [lng-odp] [PATCH] validation: classification: remove double frees

2016-01-13 Thread Stuart Haslam
On Wed, Jan 13, 2016 at 03:30:03PM +0300, Maxim Uvarov wrote: > Please resend this patch with Review. Original patch is missing for > unknown reason. > > Maxim. Mails from Nicolas get flagged as spam by google, looks to be due to a DKIM failure. "It has a from address in kalray.eu but has

Re: [lng-odp] [PATCH] pool:support to create pool on user's own memory

2016-01-13 Thread Bill Fischofer
On Wed, Jan 13, 2016 at 3:49 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Hi, > > What object types you'd allocate from the pool? Packets, buffers, timeouts > or some other application specific object? > > If it's application specific objects, we'd actually need

[lng-odp] [API-NEXT PATCH v2 1/5] linux-generic: arch: renamed cpu arch files

2016-01-13 Thread Petri Savolainen
These arch depedent files are not limited to cpu_cycle calls implementation only. Signed-off-by: Petri Savolainen --- platform/linux-generic/Makefile.am | 8 ++-- platform/linux-generic/arch/linux/odp_cpu_arch.c | 48 ++

[lng-odp] [PATCH v2] test: perf: l2fwd detect missing odp_generator

2016-01-13 Thread Mike Holmes
The script did not check that the odp_generator was present. Updates to ensure the clean up is always called at EXIT Signed-off-by: Mike Holmes --- v2: Use stuarts suggetion to clean up the interfaces on EXIT test/performance/odp_l2fwd_run | 13 + 1 file

Re: [lng-odp] [PATCH] validation: classification: remove double frees

2016-01-13 Thread Maxim Uvarov
Please resend this patch with Review. Original patch is missing for unknown reason. Maxim. On 01/06/2016 20:53, Bala Manoharan wrote: Reviewed-by: Balasubramanian Manoharan Regards, Bala On 6 January 2016 at 23:04, Nicolas Morey-Chaisemartin

[lng-odp] [API-NEXT PATCH v2 3/5] linux-generic: cpu: implemented pause

2016-01-13 Thread Petri Savolainen
Implemented pause as an inline function in a cpu arch dependent header file. Signed-off-by: Petri Savolainen --- helper/Makefile.am| 2 ++ platform/linux-generic/Makefile.am| 4 +++-

[lng-odp] [API-NEXT PATCH v2 4/5] helper: deleted odph_pause

2016-01-13 Thread Petri Savolainen
Deleted odph_pause() and replaced usage with odp_cpu_pause() calls. Signed-off-by: Petri Savolainen --- helper/Makefile.am | 1 - helper/odph_pause.h | 54 helper/ring.c| 10 +++--

Re: [lng-odp] [PATCH v2 1/3] validation: crypto: support auth decoding

2016-01-13 Thread Maxim Uvarov
. On 01/05/2016 18:21, Nicolas Morey-Chaisemartin wrote: Copy the expected digest at the end of the plaintext to validate Auth decode functions Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/crypto/odp_crypto_test_inp.c | 5 + 1 file changed, 5

Re: [lng-odp] [PATCH v2 0/3] Add validation for crypto auth decoding

2016-01-13 Thread Maxim Uvarov
. On 01/05/2016 18:20, Nicolas Morey-Chaisemartin wrote: This adds tests for the auth/hash check function in crypto v2: Rebased on master branch (was API-NEXT due to required AES-GCM patch series) Nicolas Morey-Chaisemartin (3): validation: crypto: support auth decoding validation:

Re: [lng-odp] [PATCH] example: classifier: use SCN macro to scan uint32_t

2016-01-13 Thread Maxim Uvarov
Can you please resend original patch? You can include Stuarts review. I do not see it in my email and in http://patches.opendataplane.org/project/lng-odp/list/ Thanks, Maxim. On 01/13/2016 14:20, Stuart Haslam wrote: On Wed, Jan 13, 2016 at 02:15:28PM +0300, Maxim Uvarov wrote: SCN

Re: [lng-odp] [API-NEXT RFC 02/31] api: introducing the driver api definition file

2016-01-13 Thread Christophe Milard
On 13 January 2016 at 11:31, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > ODP API (odp.h and everything you can see through that) does not change at > all due to the introduction of driver interface. You may need to add some > parameters or functions, but it

[lng-odp] [API-NEXT PATCH v2 5/5] linux-generic: removed spin_internal

2016-01-13 Thread Petri Savolainen
Removed odp_spin() and replaced usage with odp_cpu_pause(). Signed-off-by: Petri Savolainen --- platform/linux-generic/Makefile.am | 1 - platform/linux-generic/include/odp_spin_internal.h | 58 --

Re: [lng-odp] Maintain code copy-pasted from linux-generic in ODP-DPDK

2016-01-13 Thread Mike Holmes
On 13 January 2016 at 03:49, Maxim Uvarov wrote: > On 01/12/2016 21:57, Zoltan Kiss wrote: > >> Hi, >> >> We have a couple of places where the entire source file couldn't be >> copied from linux-generic, but some of the functions are. E.g. the loopback >> implementation

Re: [lng-odp] [PATCH v2 3/3] validation: crypto: validate sha256_check function

2016-01-13 Thread Maxim Uvarov
. On 01/05/2016 18:21, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/crypto/odp_crypto_test_inp.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/test/validation/crypto/odp_crypto_test_inp.c

Re: [lng-odp] [PATCH v2 2/3] validation: crypto: validate md5_check

2016-01-13 Thread Maxim Uvarov
. On 01/05/2016 18:21, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/crypto/odp_crypto_test_inp.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/test/validation/crypto/odp_crypto_test_inp.c

Re: [lng-odp] [PATCH v2 3/3] validation: crypto: validate sha256_check function

2016-01-13 Thread Maxim Uvarov
. On 01/05/2016 18:21, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin --- test/validation/crypto/odp_crypto_test_inp.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/test/validation/crypto/odp_crypto_test_inp.c

Re: [lng-odp] [PATCH] example: classifier: use SCN macro to scan uint32_t

2016-01-13 Thread Maxim Uvarov
On 01/13/2016 14:20, Stuart Haslam wrote: On Wed, Jan 13, 2016 at 02:15:28PM +0300, Maxim Uvarov wrote: SCN produced some buggy scanning here which leads to broken rules set from command line and example did not work as expected. Originally there was SCN and it was reverted with: That was

Re: [lng-odp] [PATCH] validation: classification: remove double frees

2016-01-13 Thread Maxim Uvarov
On 01/13/2016 15:42, Stuart Haslam wrote: On Wed, Jan 13, 2016 at 03:30:03PM +0300, Maxim Uvarov wrote: Please resend this patch with Review. Original patch is missing for unknown reason. Maxim. Mails from Nicolas get flagged as spam by google, looks to be due to a DKIM failure. "It has a

[lng-odp] [API-NEXT PATCH v2 2/5] api: cpu: added pause call

2016-01-13 Thread Petri Savolainen
Pause is used in tight loops to reduce stress to the system. Signed-off-by: Petri Savolainen --- include/odp/api/cpu.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/odp/api/cpu.h b/include/odp/api/cpu.h index 8a804d4..4cbaf58 100644 ---

Re: [lng-odp] API-NEXT branch is broken

2016-01-13 Thread Mike Holmes
On 13 January 2016 at 15:33, Bill Fischofer wrote: > If we can eliminate a dependency that seems like another reason to use the > .svgs directly. I really don't see the need for PDF support since few are > going to be printing manuals these days. > Agree, I am hoping

[lng-odp] [API_NEXT RFC 01/01] ODP API: add control/worker cpumasks to init data

2016-01-13 Thread Gary S. Robertson
Adds cpumasks for control and worker cores to the ODP global init data which is passed as an argument to odp_init_global. The intent is to allow an external entity to pass in lists of the CPU resources available to the current ODP application. It is assumed that these masks would by default be

[lng-odp] [API_NEXT RFC 00/01] ODP API: add control/worker cpumasks to init data

2016-01-13 Thread Gary S. Robertson
In order to enable externally supplied CPU resource management policies to be passed into ODP instances / applications, a minor change is needed to the existing ODP API. By adding cpumasks for available control and worker CPUs to the data structure specified as a parameter to odp_init_global(),

Re: [lng-odp] [API-NEXT PATCH] doc: remove imagemagic dependency and use svg diagrams in all asciidocs

2016-01-13 Thread Bill Fischofer
I did now :0 v2 submitted to correct that oversight. Thanks. On Wed, Jan 13, 2016 at 3:08 PM, Mike Holmes wrote: > Did you test with doxygen ? > > On 13 January 2016 at 16:07, Bill Fischofer > wrote: > >> Simplify ODP documentation builds by

Re: [lng-odp] API-NEXT branch is broken

2016-01-13 Thread Maxim Uvarov
Probably we need to add convert (imagemagic package?) check to ./configure. Maxim. On 01/13/2016 19:01, Mike Holmes wrote: Have you installed the DEPENDENCIES for building the docs ? Did you just make or "make distcheck" On 13 January 2016 at 10:58, Bala Manoharan

[lng-odp] [API-NEXT PATCHv2] doc: remove imagemagic dependency and use svg diagrams in all asciidocs

2016-01-13 Thread Bill Fischofer
Simplify ODP documentation builds by using .svg files directly for all images. This eliminates the need to create .png and .eps files via the imagemagic package. Note that this removes easy PDF output for ODP user documents, however there is no real demand for such capability. Signed-off-by: Bill

Re: [lng-odp] API-NEXT branch is broken

2016-01-13 Thread Mike Holmes
On 13 January 2016 at 14:31, Maxim Uvarov wrote: > Probably we need to add convert (imagemagic package?) check to ./configure. > It is there, what has changed is that it apparently gets required even if you dont build docs. As we move to direct use of .svg I can delete

Re: [lng-odp] API-NEXT branch is broken

2016-01-13 Thread Bill Fischofer
If we can eliminate a dependency that seems like another reason to use the .svgs directly. I really don't see the need for PDF support since few are going to be printing manuals these days. On Wed, Jan 13, 2016 at 2:11 PM, Mike Holmes wrote: > > > On 13 January 2016 at

Re: [lng-odp] [API-NEXT PATCH] doc: remove imagemagic dependency and use svg diagrams in all asciidocs

2016-01-13 Thread Mike Holmes
Did you test with doxygen ? On 13 January 2016 at 16:07, Bill Fischofer wrote: > Simplify ODP documentation builds by using .svg files directly for all > images. This eliminates the need to create .png and .eps files via the > imagemagic package. Note that this

Re: [lng-odp] API-NEXT branch is broken

2016-01-13 Thread Bill Fischofer
On Wed, Jan 13, 2016 at 2:35 PM, Mike Holmes wrote: > > > On 13 January 2016 at 15:33, Bill Fischofer > wrote: > >> If we can eliminate a dependency that seems like another reason to use >> the .svgs directly. I really don't see the need for

Re: [lng-odp] [PATCH 5/5] validation: cls: split pmr chain test

2016-01-13 Thread Bala Manoharan
The idea behind this suite is to have a mechanism to test the behaviour of the system after applying all the different PMR, default CoS, error CoS and L2 and L3 CoS values. your suggested changes tests each and every configuration individually which defeats the idea of the suite. There is a

[lng-odp] [API-NEXT PATCH 2/2] doc: users: fix TM typos

2016-01-13 Thread Mike Holmes
Suggested-by: Anders Roxell Signed-off-by: Mike Holmes --- doc/users-guide/users-guide-tm.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/users-guide/users-guide-tm.adoc b/doc/users-guide/users-guide-tm.adoc

[lng-odp] [API_NEXT RFC 00/01] linux-generic: add support for initial cpumasks

2016-01-13 Thread Gary S. Robertson
This patch series complements and depends on the addition of new cpumasks to the initialization data structure defined as a parameter to odp_init_global(). The code changes included here use the new cpumasks to ensure that the linux-generic reference platform implementation allocates CPU resources

[lng-odp] [API-NEXT PATCHv3 2/2] doc: update CONTRIBUTING and DEPENDENCIES files for images

2016-01-13 Thread Bill Fischofer
Signed-off-by: Bill Fischofer --- CONTRIBUTING | 5 ++--- DEPENDENCIES | 7 ++- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTING b/CONTRIBUTING index 4ad964e..f6e3fc6 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -126,9 +126,8 @@ Code

Re: [lng-odp] [PATCH 3/5] validation: cls: test_pmr: don't create default input queue

2016-01-13 Thread Bala Manoharan
This patch does not apply maybe you need to rebase to HEAD. Regards, Bala Regards, Bala On 12 January 2016 at 23:41, Ivan Khoronzhuk wrote: > There is no need to create default input queue for pktio if > default CoS is assigned. > > Signed-off-by: Ivan Khoronzhuk

Re: [lng-odp] [PATCH 0/5] validation: cls: correct tests a little

2016-01-13 Thread Bala Manoharan
Hi Ivan, It would be better if you can send this patch on API-NEXT branch as I said before I am working on API proposal to modify odp_pmr_create() function syntax and it would be easy if we could modify your changes to API-NEXT and then we can move it to master branch. The patch 3 in your series

Re: [lng-odp] [PATCH 5/5] validation: cls: split pmr chain test

2016-01-13 Thread Ivan Khoronzhuk
On 14.01.16 07:55, Bala Manoharan wrote: The idea behind this suite is to have a mechanism to test the behaviour of the system after applying all the different PMR, default CoS, error CoS and L2 and L3 CoS values. your suggested changes tests each and every configuration individually which

Re: [lng-odp] [PATCH 4/5] validation: cls: use correct MAC addresses

2016-01-13 Thread Bala Manoharan
The idea of having to create pktio in each and every test case is to create robustness in test cases and have them as independent from each other as possible. In classification when you remove a CoS rule it is not expected to see the changes immediately some systems will have latency and the

Re: [lng-odp] [PATCH 3/5] validation: cls: test_pmr: don't create default input queue

2016-01-13 Thread Ivan Khoronzhuk
On 14.01.16 07:52, Bala Manoharan wrote: This patch does not apply maybe you need to rebase to HEAD. Regards, Bala Regards, Bala I will re-base, but this patch still has questions. Like, do we need to assign default input queue if it's not supposed to be used and completely replaced by

Re: [lng-odp] [PATCH 4/5] validation: cls: use correct MAC addresses

2016-01-13 Thread Ivan Khoronzhuk
On 14.01.16 07:59, Bala Manoharan wrote: The idea of having to create pktio in each and every test case is to create robustness in test cases and have them as independent from each other as possible. In classification when you remove a CoS rule it is not expected to see the changes immediately

Re: [lng-odp] ODP 1.5 - Crash while cleanup ODP/ODP timer pool

2016-01-13 Thread Bogdan Pricope
Mike, I am running OFP cunit test: ofp_test_init. It happens 1 out of 3 runs. gdb ./test/cunit/ofp_test_init Bogdan From: Mike Holmes [mailto:mike.hol...@linaro.org] Sent: Tuesday, January 12, 2016 5:57 PM To: Bogdan Pricope Cc: lng-odp@lists.linaro.org Subject: Re:

Re: [lng-odp] [API-NEXT PATCHv2] doc: remove imagemagic dependency and use svg diagrams in all asciidocs

2016-01-13 Thread Bill Fischofer
v3 submitted to add updates for these two files as well. Thanks. On Wed, Jan 13, 2016 at 4:41 PM, Mike Holmes wrote: > DEPENDENCIES and CONTRIBUTING need to be updated since we no longer need > to talk about .png or .eps > > On 13 January 2016 at 16:15, Bill Fischofer

[lng-odp] [API-NEXT PATCH 1/2] doc: users: add TM example

2016-01-13 Thread Mike Holmes
Signed-off-by: Mike Holmes --- doc/users-guide/users-guide-tm.adoc | 83 + 1 file changed, 83 insertions(+) diff --git a/doc/users-guide/users-guide-tm.adoc b/doc/users-guide/users-guide-tm.adoc index dc0d003..e68157f 100644 ---

Re: [lng-odp] [API-NEXT PATCHv2] doc: remove imagemagic dependency and use svg diagrams in all asciidocs

2016-01-13 Thread Mike Holmes
DEPENDENCIES and CONTRIBUTING need to be updated since we no longer need to talk about .png or .eps On 13 January 2016 at 16:15, Bill Fischofer wrote: > Simplify ODP documentation builds by using .svg files directly for all > images. This eliminates the need to create

[lng-odp] [API_NEXT RFC 01/01] linux-generic: add support for initial cpumasks

2016-01-13 Thread Gary S. Robertson
These code changes depend on the addition of control and worker cpumasks to the ODP initialization parameter data structure, and implement the change in behavior suggested with that patch. They serve as the 'glue' between the input of the new ODP API initial cpuset masks and the use of those new

Re: [lng-odp] [API-NEXT PATCH 1/2] doc: users: add TM example

2016-01-13 Thread Bill Fischofer
For this series: Reviewed-by: Bill Fischofer On Wed, Jan 13, 2016 at 4:07 PM, Mike Holmes wrote: > Signed-off-by: Mike Holmes > --- > doc/users-guide/users-guide-tm.adoc | 83 > + >

[lng-odp] 答复: [PATCH] pool:support to create pool on user's own memory

2016-01-13 Thread Xu Zaibo
Hi, Firstly, I don't want to bring any new type of pool into ODP. I just want to give user more chance to use more areas of memory. For example, referring to your example of various HW offload engines, if there two or more types of engines which have different request on memory attributions

[lng-odp] [PATCHv2 3/3] doc: implementers-guide: inactive precond tests

2016-01-13 Thread Christophe Milard
Signed-off-by: Christophe Milard --- doc/implementers-guide/implementers-guide.adoc | 21 + 1 file changed, 21 insertions(+) diff --git a/doc/implementers-guide/implementers-guide.adoc b/doc/implementers-guide/implementers-guide.adoc index

Re: [lng-odp] [API-NEXT PATCH 1/2] linux-generic: classification: implement verify_pmr_dmac

2016-01-13 Thread Maxim Uvarov
Merged! Maxim. Looks like my system was compiled with netmap support but no actual drivers. That was the reason for no packets in l2fwd. Maxim. On 01/13/2016 14:50, Maxim Uvarov wrote: In my testing it breaks l2fwd test if I run 'make check' under root. Maxim. On 01/08/2016 00:55, Bill

Re: [lng-odp] API-NEXT branch is broken

2016-01-13 Thread Mike Holmes
Have you installed the DEPENDENCIES for building the docs ? Did you just make or "make distcheck" On 13 January 2016 at 10:58, Bala Manoharan wrote: > Hi, > > The api-next branch is broken after merge from master. > convert atomic_queue.svg atomic_queue.png >

[lng-odp] [PATCHv2 2/3] validation: possibility to inactive preconded test

2016-01-13 Thread Christophe Milard
When marking a test which has a precondition as temporarly inactive, it feels better to be able to keep the precondition function: ODP_TEST_INFO_CONDITIONAL(send_failure, check_send_failure) will be marked as inactive by: ODP_TEST_INFO_INACTIVE(send_failure, check_send_failure) rather than:

Re: [lng-odp] [PATCH] validation: classification: remove double frees

2016-01-13 Thread Nicolas Morey-Chaisemartin
On 01/13/2016 01:42 PM, Stuart Haslam wrote: > On Wed, Jan 13, 2016 at 03:30:03PM +0300, Maxim Uvarov wrote: >> Please resend this patch with Review. Original patch is missing for >> unknown reason. >> >> Maxim. > Mails from Nicolas get flagged as spam by google, looks to be due to a > DKIM

Re: [lng-odp] [PATCH v2] test: perf: l2fwd detect missing odp_generator

2016-01-13 Thread Stuart Haslam
On Wed, Jan 13, 2016 at 08:52:07AM -0500, Mike Holmes wrote: > The script did not check that the odp_generator was present. > Updates to ensure the clean up is always called at EXIT > > Signed-off-by: Mike Holmes Reviewed-by: Stuart Haslam >

[lng-odp] API-NEXT branch is broken

2016-01-13 Thread Bala Manoharan
Hi, The api-next branch is broken after merge from master. convert atomic_queue.svg atomic_queue.png /bin/bash: convert: command not found make[2]: *** [atomic_queue.png] Error 127 Regards, Bala ___ lng-odp mailing list lng-odp@lists.linaro.org

[lng-odp] [PATCHv2 1/3] doc: implementers-guide: conditional tests

2016-01-13 Thread Christophe Milard
Documentation on conditional test is added here, as it seemed to be missing Signed-off-by: Christophe Milard --- doc/implementers-guide/implementers-guide.adoc | 29 ++ 1 file changed, 29 insertions(+) diff --git

Re: [lng-odp] Maintain code copy-pasted from linux-generic in ODP-DPDK

2016-01-13 Thread Maxim Uvarov
On 01/13/2016 00:15, Nicolas Morey-Chaisemartin wrote: Hi, I have the same issue with our implementation. I usually either work from the git diff of linux generic before and post update and backport changed or to a diff of the diff of linux-generic vs mppa platform before and after the merge.

Re: [lng-odp] [PATCH] linux-generic: crypto: fix AES-GCM compatibility with old version of OpenSSL

2016-01-13 Thread Maxim Uvarov
resend to list (google marked it as spam). Maxim. On 01/12/2016 20:40, Nicolas Morey-Chaisemartin wrote: Old version of OpenSSL require SET_TAG to be called before decrypting the data. New versions are compatible either way Signed-off-by: Nicolas Morey-Chaisemartin ---

[lng-odp] [RFC PATCH] api: packet_io: return headroom when set new one

2016-01-13 Thread Ivan Khoronzhuk
It can be used to restore headroom later. Does it possible a headroom to be > sizeof(int32)/2? Signed-off-by: Ivan Khoronzhuk --- include/odp/api/packet_io.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/odp/api/packet_io.h

[lng-odp] [PATCH] validation: pktio: use odp_time_ns() instead own function

2016-01-13 Thread Ivan Khoronzhuk
Now odp_time_wait_ns() can be used. Signed-off-by: Ivan Khoronzhuk --- test/validation/pktio/pktio.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 45c11c5..29ad4ea

[lng-odp] [PATCH] validation: pktio: fix check of pktio_stop() called twice

2016-01-13 Thread Ivan Khoronzhuk
The odp_pktio_stop() called is supposed to return error. Signed-off-by: Ivan Khoronzhuk --- test/validation/pktio/pktio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index