Re: [lng-odp] [PATCH API-NEXT v1] IPsec TFC packets/padding support

2017-12-11 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: include/odp/api/spec/ipsec.h line 33 @@ -1293,6 +1297,10 @@ int odp_ipsec_in(const odp_packet_t pkt_in[], int num_in, * with IPSEC, etc headers constructed according to the standards. The amount * and content of packet data

Re: [lng-odp] IPsec and crypto performance and OpenSSL

2017-12-11 Thread Bill Fischofer
I think we've pretty much abandoned the notion that linux-generic will support threads as separate processes as there seems to be little justification for it. The current plan is to continue this assumption in the "2.0" code base as well. So having OpenSSL rely on threads sharing the same address

Re: [lng-odp] IPsec and crypto performance and OpenSSL

2017-12-11 Thread Dmitry Eremin-Solenikov
On 11 December 2017 at 19:14, Maxim Uvarov wrote: > odp_init_global() allocates shm, then odp_init_local() / odp_term_local() > allocates/destroys per thread contexts in array in that shm. I think that > has to work. The problem lies in OpenSSL 1.1 "opaque structures"

Re: [lng-odp] [PATCH API-NEXT v1] api: ipsec: require IPv4 or IPv6 flag to be set

2017-12-11 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: include/odp/api/spec/ipsec.h line 4 @@ -1207,6 +1207,7 @@ typedef struct odp_ipsec_status_t { * * Each input packet must have a valid value for these metadata (other metadata * is ignored): + * - IPv4 or IPv6 flag: Set packet flag

Re: [lng-odp] [PATCH API-NEXT v1] api: ipsec: require IPv4 or IPv6 flag to be set

2017-12-11 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: include/odp/api/spec/ipsec.h line 4 @@ -1277,6 +1279,7 @@ int odp_ipsec_in(const odp_packet_t pkt_in[], int num_in, * * Each input packet must have a valid value for these metadata (other metadata * is ignored): + * - IPv4 or IPv6

[lng-odp] [PATCH API-NEXT v8 2/2] api: ipsec: reuse checksum checking flags from packet API

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Reuse odp_packet_parse_chksum_t from packet API to ease passing checksum flags to packet parsing functions. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 314

[lng-odp] [PATCH API-NEXT v8 1/2] api: packet: separate checksum check flags

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Separate union controlling different checksum checks. It will be used by IPsec API. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 314 (lumag:ipsec-chksum) **

Re: [lng-odp] [PATCH v9] one more try to add nice stats for Shippable

2017-12-11 Thread Github ODP bot
Tom Trahan(ttrahan) replied on github web page: scripts/Dockerfile @@ -22,6 +22,7 @@ RUN sudo apt-get update && sudo apt-get install -yy \ RUN wget "https://github.com/Shippable/support/raw/master/bin/reports; && \ chmod +x reports && \ rm -f /home/shippable/cexec/bin/reports && \ +

[lng-odp] [PATCH v9 6/6] test: Shippable: create directory for binary

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch: https://github.com/Linaro/odp/pull/309.patch ** Base sha:

[lng-odp] [PATCH v9 5/6] test: add Shippable report parser binary for ARM in Shippable build image

2017-12-11 Thread Github ODP bot
From: Tom Trahan Signed-off-by: Tom Trahan Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch:

[lng-odp] [PATCH v9 4/6] shipabble: use xml statistics

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch: https://github.com/Linaro/odp/pull/309.patch ** Base sha:

[lng-odp] [PATCH v9 1/6] test: build: enable cunit output to xml

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch: https://github.com/Linaro/odp/pull/309.patch ** Base sha:

[lng-odp] [PATCH v9 3/6] test: cunit common fix header paths

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch: https://github.com/Linaro/odp/pull/309.patch ** Base sha:

[lng-odp] [PATCH v9 2/6] linux-gen:test: shmem pass args to cunit

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Pass args to cunit to make code commong with other tests. Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch:

[lng-odp] [PATCH v9 0/6] one more try to add nice stats for Shippable

2017-12-11 Thread Github ODP bot
github /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch: https://github.com/Linaro/odp/pull/309.patch ** Base sha: 6881620135a179911a5839d4be97423a8d80e5ab ** Merge commit sha:

[lng-odp] [PATCH v3 3/3] linux-generic: pool: avoid direct use of printf() in odp_pool_print()

2017-12-11 Thread Github ODP bot
From: Bill Fischofer Use ODP_PRINT() rather than printf() to send output through the log function. Signed-off-by: Bill Fischofer --- /** Email created from pull request 325 (Bill-Fischofer-Linaro:bug3465) **

[lng-odp] [PATCH v3 2/3] linux-generic: pool: avoid direct use of printf() in check_params

2017-12-11 Thread Github ODP bot
From: Bill Fischofer Use ODP_DBG() for diagnostic error prints rather than direct use of printf(). This allows errors to be output conditionally and via the log function. Signed-off-by: Bill Fischofer --- /** Email created from pull request

[lng-odp] [PATCH v3 1/3] linux-generic: pool: validate params before creating pool

2017-12-11 Thread Github ODP bot
From: Bill Fischofer Enhance the check_params() routine to verify that params != NULL prior to dereferencing it. This fixes Bug https://bugs.linaro.org/show_bug.cgi?id=3465 Signed-off-by: Bill Fischofer --- /** Email created from pull

[lng-odp] [PATCH v3 0/3] linux-generic: pool: validate params before creating pool

2017-12-11 Thread Github ODP bot
Enhance the check_params() routine to verify that params != NULL prior to dereferencing it. This fixes Bug https://bugs.linaro.org/show_bug.cgi?id=3465 Signed-off-by: Bill Fischofer bill.fischo...@linaro.org github /** Email created from pull request 325

[lng-odp] [PATCH v8 4/5] shipabble: use xml statistics

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch: https://github.com/Linaro/odp/pull/309.patch ** Base sha:

[lng-odp] [PATCH v8 1/5] test: build: enable cunit output to xml

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch: https://github.com/Linaro/odp/pull/309.patch ** Base sha:

[lng-odp] [PATCH v8 2/5] linux-gen:test: shmem pass args to cunit

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Pass args to cunit to make code commong with other tests. Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch:

[lng-odp] [PATCH v8 3/5] test: cunit common fix header paths

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Signed-off-by: Maxim Uvarov --- /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch: https://github.com/Linaro/odp/pull/309.patch ** Base sha:

[lng-odp] [PATCH v8 0/5] one more try to add nice stats for Shippable

2017-12-11 Thread Github ODP bot
github /** Email created from pull request 309 (muvarov:devel/master_shippable2) ** https://github.com/Linaro/odp/pull/309 ** Patch: https://github.com/Linaro/odp/pull/309.patch ** Base sha: 6881620135a179911a5839d4be97423a8d80e5ab ** Merge commit sha:

[lng-odp] [PATCH v2 0/3] linux-generic: pool: validate params before creating pool

2017-12-11 Thread Github ODP bot
Enhance the check_params() routine to verify that params != NULL prior to dereferencing it. This fixes Bug https://bugs.linaro.org/show_bug.cgi?id=3465 Signed-off-by: Bill Fischofer bill.fischo...@linaro.org github /** Email created from pull request 325

[lng-odp] [PATCH v2 3/3] linux-generic: pool: avoid direct use of printf() in odp_pool_print()

2017-12-11 Thread Github ODP bot
From: Bill Fischofer Use ODP_PRINT() rather than printf() to send output through the log function. Signed-off-by: Bill Fischofer --- /** Email created from pull request 325 (Bill-Fischofer-Linaro:bug3465) **

[lng-odp] [PATCH v2 1/3] linux-generic: pool: validate params before creating pool

2017-12-11 Thread Github ODP bot
From: Bill Fischofer Enhance the check_params() routine to verify that params != NULL prior to dereferencing it. This fixes Bug https://bugs.linaro.org/show_bug.cgi?id=3465 Signed-off-by: Bill Fischofer --- /** Email created from pull

Re: [lng-odp] IPsec and crypto performance and OpenSSL

2017-12-11 Thread Maxim Uvarov
odp_init_global() allocates shm, then odp_init_local() / odp_term_local() allocates/destroys per thread contexts in array in that shm. I think that has to work. Maxim. On 11 December 2017 at 17:02, Francois Ozog wrote: > I favor finishing ODP (ex 2.0) integration

[lng-odp] [PATCH API-NEXT v1 14/14] example: generator: replace atomic counter with per worker counters

2017-12-11 Thread Github ODP bot
From: Bogdan Pricope Use of atomic counters reduces total packet throughput. Signed-off-by: Bogdan Pricope Reviewed-by: Ilias Apalodimas Signed-off-by: Maxim Uvarov --- /** Email

[lng-odp] [PATCH API-NEXT v1 13/14] example: generator: add configuration option for csum support

2017-12-11 Thread Github ODP bot
From: Bogdan Pricope Add configuration option to enable platform checksum support (if available) for calculation and validation. By default, checksum calculation is performed in software and validation is disabled. Signed-off-by: Bogdan Pricope

[lng-odp] [PATCH API-NEXT v1 12/14] example: generator: increase maximum TX burst size to 512

2017-12-11 Thread Github ODP bot
From: Bogdan Pricope Bigger TX bursts may increase packet throughput. Signed-off-by: Bogdan Pricope Reviewed-by: Ilias Apalodimas Signed-off-by: Maxim Uvarov --- /** Email created from

[lng-odp] [PATCH API-NEXT v1 11/14] example: generator: remove 1 ms sleep on send loop

2017-12-11 Thread Github ODP bot
From: Bogdan Pricope The 1 ms sleep is reducing total packet throughput. Signed-off-by: Bogdan Pricope Reviewed-by: Ilias Apalodimas Signed-off-by: Maxim Uvarov --- /** Email created

[lng-odp] [PATCH API-NEXT v1 9/14] linux-gen: dpdk: cast addresses to uintptr_t rather than uint64_t

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov This is to remove the following error: pktio/dpdk.c: In function ‘mbuf_data_off’: pktio/dpdk.c:126:9: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] return

[lng-odp] [PATCH API-NEXT v1 7/14] linux-gen: add support for using system-wide DPDK

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Support using distro-installed DPDK for Pkt I/O. Distributions (like Ubuntu, Debian, etc) start providing DPDK packages. It is wise to enable users to use distro-provided DPDK version rather than requiring to always compile it from

[lng-odp] [PATCH API-NEXT v1 8/14] linux-gen: pktio: support using DPDK lt 17.08

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Debian unstable ships with DPDK 16.11. Add support for building with this version. Signed-off-by: Dmitry Eremin-Solenikov Reviewed-and-tested-by: Matias Elo --- /** Email

[lng-odp] [PATCH API-NEXT v1 10/14] travis: also use DPDK when doing cross-compile tests

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Compile and use DPDK when doing cross-compilation tests. This enables us to test that pktio/dpdk.c works on non-x86 targets. Signed-off-by: Dmitry Eremin-Solenikov Reviewed-and-tested-by: Matias

[lng-odp] [PATCH API-NEXT v1 1/14] travis: add enable-deprecated test configuration

2017-12-11 Thread Github ODP bot
From: Matias Elo Test ODP build with 'enable-deprecated' flag set. Signed-off-by: Matias Elo Reviewed-by: Bill Fischofer Signed-off-by: Maxim Uvarov --- /** Email created from pull request 335

[lng-odp] [PATCH API-NEXT v1 6/14] linux-gen: apply -msse4.2 only in x86 case

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Flag -msse4.2 should be used only for i?86/x86_64 targets, it does not make sense for any other target. Signed-off-by: Dmitry Eremin-Solenikov Reviewed-and-tested-by: Matias Elo

[lng-odp] [PATCH API-NEXT v1 5/14] configure: separate common DPDK check to odp_dpdk.m4

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Separate DPDK macros to top-level file so that they can be reused by other implementations (like ODP-DPDK). Signed-off-by: Dmitry Eremin-Solenikov Reviewed-and-tested-by: Matias Elo

[lng-odp] [PATCH API-NEXT v1 2/14] travis: disable ccache for codecov

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Log says: odp_pktio_perf.gcno:cannot open notes file Reason is codecov does not see any generated files which were not complied due to ccache. Disabling ccache makes it work. Signed-off-by: Maxim Uvarov Reviewed-by: Bill

[lng-odp] [PATCH API-NEXT v1 3/14] gitignore add gcov files

2017-12-11 Thread Github ODP bot
From: Maxim Uvarov Signed-off-by: Maxim Uvarov Reviewed-by: Bill Fischofer --- /** Email created from pull request 335 (muvarov:devel/api-next_master_merge) ** https://github.com/Linaro/odp/pull/335 ** Patch:

[lng-odp] [PATCH API-NEXT v1 0/14] merge master to api-next

2017-12-11 Thread Github ODP bot
github /** Email created from pull request 335 (muvarov:devel/api-next_master_merge) ** https://github.com/Linaro/odp/pull/335 ** Patch: https://github.com/Linaro/odp/pull/335.patch ** Base sha: 630d8422564ebf4991b468cb38a29e9483fc2ec2 ** Merge commit

[lng-odp] [Linaro/odp] 6e09ad: example: generator: remove 1 ms sleep on send loop

2017-12-11 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 6e09adf147ad3ccb4df1cc988d20d31c3246d2aa https://github.com/Linaro/odp/commit/6e09adf147ad3ccb4df1cc988d20d31c3246d2aa Author: Bogdan Pricope Date: 2017-12-11 (Mon, 11 Dec 2017)

[lng-odp] [Linaro/odp] 5096ae: virtio: move to own directory

2017-12-11 Thread GitHub
Branch: refs/heads/devel/native-drivers Home: https://github.com/Linaro/odp Commit: 5096aebd6cc4f84eda65683f799f6a1c269433c1 https://github.com/Linaro/odp/commit/5096aebd6cc4f84eda65683f799f6a1c269433c1 Author: Josep Puigdemont Date: 2017-11-27

Re: [lng-odp] [PATCH API-NEXT v7] IPsec checksumming API

2017-12-11 Thread Github ODP bot
Petri Savolainen(psavol) replied on github web page: include/odp/api/spec/ipsec.h line 30 @@ -159,32 +159,7 @@ typedef struct odp_ipsec_inbound_config_t { * level. Checksum checking status can be queried for each packet with * odp_packet_l3_chksum_status() and

Re: [lng-odp] IPsec and crypto performance and OpenSSL

2017-12-11 Thread Francois Ozog
I favor finishing ODP (ex 2.0) integration rather than optimizing linux-generic at this stage. On 11 December 2017 at 14:39, Peltonen, Janne (Nokia - FI/Espoo) < janne.pelto...@nokia.com> wrote: > Hi, > > When playing with IPsec I noticed that the Linux generic > ODP implementation creates a

[lng-odp] [PATCH API-NEXT v1 0/1] api: crypto: typo correction

2017-12-11 Thread Github ODP bot
Subtype PACKET_CRYPTO in capital letters. Signed-off-by: Petri Savolainen petri.savolai...@linaro.org github /** Email created from pull request 334 (psavol:next-crypto-typo) ** https://github.com/Linaro/odp/pull/334 ** Patch:

[lng-odp] IPsec and crypto performance and OpenSSL

2017-12-11 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, When playing with IPsec I noticed that the Linux generic ODP implementation creates a separate OpenSSL crypto context for each crypto-operation as opposed to doing it at ODP crypto session creation. With IPsec this adds a lot of overhead for every packet processed and significantly reduces

Re: [lng-odp] [PATCH API-NEXT v7] IPsec checksumming API

2017-12-11 Thread Github ODP bot
Petri Savolainen(psavol) replied on github web page: include/odp/api/spec/packet.h @@ -1178,6 +1178,31 @@ int odp_packet_move_data(odp_packet_t pkt, uint32_t dst_offset, * */ +/** + * Flags to control packet data checksum checking + */ +typedef union odp_packet_parse_chksum_t { + /**

Re: [lng-odp] [PATCH API-NEXT v1] optimize pktio performance

2017-12-11 Thread Github ODP bot
Matias Elo(matiaselo) replied on github web page: platform/linux-generic/odp_event.c line 18 @@ -24,17 +25,24 @@ odp_event_type_t odp_event_type(odp_event_t event) odp_event_subtype_t odp_event_subtype(odp_event_t event) { - return

Re: [lng-odp] [PATCH API-NEXT v3] doc: userguide: ipsec state machine changes

2017-12-11 Thread Github ODP bot
JannePeltonen replied on github web page: doc/images/ipsec_sa_states.msc line 35 @@ -0,0 +1,76 @@ +msc { + +a [label = "Application"], +o [label = "ODP"], +p [label = "Platform"]; + +--- [label = "IPsec configuration, done once"]; +a->o [label = "odp_ipsec_config()"]; +

Re: [lng-odp] [PATCH API-NEXT v2] api: refine parser metadata specifications

2017-12-11 Thread Github ODP bot
Petri Savolainen(psavol) replied on github web page: include/odp/api/spec/packet_flags.h line 64 @@ -23,87 +23,114 @@ extern "C" { #include /** @addtogroup odp_packet - * Boolean operations on a packet. + * Operations on packet metadata flags. * @{ */ /** - * Check for packet

Re: [lng-odp] [PATCH API-NEXT v2] api: refine parser metadata specifications

2017-12-11 Thread Github ODP bot
Petri Savolainen(psavol) replied on github web page: include/odp/api/spec/packet_flags.h line 44 @@ -23,87 +23,114 @@ extern "C" { #include /** @addtogroup odp_packet - * Boolean operations on a packet. + * Operations on packet metadata flags. * @{ */ /** - * Check for packet

Re: [lng-odp] [PATCH API-NEXT v2] api: refine parser metadata specifications

2017-12-11 Thread Github ODP bot
Petri Savolainen(psavol) replied on github web page: include/odp/api/spec/packet_flags.h @@ -23,87 +23,114 @@ extern "C" { #include /** @addtogroup odp_packet - * Boolean operations on a packet. + * Operations on packet metadata flags. * @{ */ /** - * Check for packet errors + *

Re: [lng-odp] [PATCH API-NEXT v2] api: refine parser metadata specifications

2017-12-11 Thread Github ODP bot
Petri Savolainen(psavol) replied on github web page: include/odp/api/spec/packet_flags.h @@ -23,87 +23,114 @@ extern "C" { #include /** @addtogroup odp_packet - * Boolean operations on a packet. + * Operations on packet metadata flags. * @{ */ /** - * Check for packet errors + *

Re: [lng-odp] [PATCH API-NEXT v2] api: refine parser metadata specifications

2017-12-11 Thread Github ODP bot
Petri Savolainen(psavol) replied on github web page: include/odp/api/spec/packet_flags.h @@ -23,87 +23,114 @@ extern "C" { #include /** @addtogroup odp_packet - * Boolean operations on a packet. + * Operations on packet metadata flags. * @{ */ /** - * Check for packet errors + *

Re: [lng-odp] [PATCH API-NEXT v2] api: refine parser metadata specifications

2017-12-11 Thread Github ODP bot
Petri Savolainen(psavol) replied on github web page: include/odp/api/spec/packet_flags.h @@ -23,87 +23,114 @@ extern "C" { #include /** @addtogroup odp_packet - * Boolean operations on a packet. + * Operations on packet metadata flags. * @{ */ /** - * Check for packet errors + *

[lng-odp] [PATCH API-NEXT v1 1/2] api: shm: name is optional

2017-12-11 Thread Github ODP bot
From: Petri Savolainen Align shared memory name parameter specification with other APIs. Name is optional and does not need to be unique, except when it's used for lookups. Signed-off-by: Petri Savolainen --- /** Email created from pull

[lng-odp] [PATCH API-NEXT v1 0/2] api: shm name is optional

2017-12-11 Thread Github ODP bot
Align shared memory name parameter specification with other APIs. Name is optional and does not need to be unique, except when it's used for lookups. github /** Email created from pull request 333 (psavol:next-shm-name) **

[lng-odp] [PATCH API-NEXT v1 2/2] validation: shm: add name tests

2017-12-11 Thread Github ODP bot
From: Petri Savolainen Test shm blocks with NULL and maximum length names. Signed-off-by: Petri Savolainen --- /** Email created from pull request 333 (psavol:next-shm-name) ** https://github.com/Linaro/odp/pull/333 ** Patch:

[lng-odp] [PATCH API-NEXT v2 5/5] linux-gen: packet: set next layer offsets allways

2017-12-11 Thread Github ODP bot
From: Petri Savolainen Update implementation to follow API change of layer offsets. Set L3 offset always after successful L2 parse. Set L4 offset always after successful L3 parse. Signed-off-by: Petri Savolainen --- /** Email created

[lng-odp] [PATCH API-NEXT v2 3/5] api: packet_flags: adjust white spaces

2017-12-11 Thread Github ODP bot
From: Petri Savolainen Improve header file readability by aligning param and retval documentation with spaces. Signed-off-by: Petri Savolainen --- /** Email created from pull request 332 (psavol:next-l4-offset) **

[lng-odp] [PATCH API-NEXT v2 4/5] api: parse: set next layer offset

2017-12-11 Thread Github ODP bot
From: Petri Savolainen Explicitly require that implementation sets the next layer offset after user defined last parse layer. Next layer offset can be set without checking the layer itself. For example: l4_offset = l3_offset + l3_hdr_len Also renamed

[lng-odp] [PATCH API-NEXT v2 1/5] api: packet: refine layer offset specification

2017-12-11 Thread Github ODP bot
From: Petri Savolainen Offset functions just point to the start of an layer. Offsets may be set also when a layer does not have a known header or a known header has an error. For example, L4 offset may be set always after a successful parse of L3 (IP) layer. There

[lng-odp] [PATCH API-NEXT v2 2/5] api: packet_flags: refine error and layer flags

2017-12-11 Thread Github ODP bot
From: Petri Savolainen Error flag functions (packet_has_error, packet_has_l4_error) indicate if an error was found. Layer flag functions (packet_has_l4) tell if parser did found and checked a protocol (header) of a layer. Both are controlled by parser configuration.

[lng-odp] [PATCH API-NEXT v2 0/5] api: refine parser metadata specifications

2017-12-11 Thread Github ODP bot
Offset functions just point to the start of an layer. Offsets may be set also when a layer does not have a known header or a known header has an error. For example, L4 offset may be set always after a successful parse of L3 (IP) layer. There are other API calls to check if L4 is a known protocol

Re: [lng-odp] odp_shm_reserve() with same block name

2017-12-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
The same name for N queues/pools/shms/etc may be still valuable for debugging. E.g. application may label “packet” vs. “timeout” pools/queues. When the application fails with a queue (named “timeout”), debugging can be started from timer code path (vs the packet code path). The code paths

Re: [lng-odp] [PATCH API-NEXT v1] api: refine parser metadata specifications

2017-12-11 Thread Github ODP bot
Petri Savolainen(psavol) replied on github web page: include/odp/api/spec/packet.h line 66 @@ -1347,15 +1347,16 @@ uint32_t odp_packet_user_area_size(odp_packet_t pkt); /** * Layer 2 start pointer * - * Returns pointer to the start of the layer 2 header. Optionally, outputs - * number of

[lng-odp] [PATCH API-NEXT v7 2/2] api: ipsec: reuse checksum checking flags from packet API

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Reuse odp_packet_parse_chksum_t from packet API to ease passing checksum flags to packet parsing functions. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 314

[lng-odp] [PATCH API-NEXT v7 1/2] api: packet: separate checksum check flags

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Separate union controlling different checksum checks. It will be used by IPsec API. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 314 (lumag:ipsec-chksum) **

[lng-odp] [PATCH API-NEXT v7 0/2] IPsec checksumming API

2017-12-11 Thread Github ODP bot
Separate checksumming flags into separate type to be used by both packet parse and IPsec functions. github /** Email created from pull request 314 (lumag:ipsec-chksum) ** https://github.com/Linaro/odp/pull/314 ** Patch:

Re: [lng-odp] odp_shm_reserve() with same block name

2017-12-11 Thread Stanisław Kardach
Thank you for the explanation. So if application should use unique names only for objects it wants to lookup AND it is possible to have NULL names (same as having same name multiple times), wouldn't it be a bit cleaner to state for each module API: 1. If no name is given then object cannot be

[lng-odp] [PATCH API-NEXT v6 2/2] api: ipsec: reuse checksum checking flags from packet API

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Reuse odp_packet_parse_chksum_t from packet API to ease passing checksum flags to packet parsing functions. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 314

[lng-odp] [PATCH API-NEXT v6 1/2] api: packet: separate checksum check flags

2017-12-11 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Separate union controlling different checksum checks. It will be used by IPsec API. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 314 (lumag:ipsec-chksum) **

[lng-odp] [PATCH API-NEXT v6 0/2] IPsec checksumming API

2017-12-11 Thread Github ODP bot
Separate checksumming flags into separate type to be used by both packet parse and IPsec functions. github /** Email created from pull request 314 (lumag:ipsec-chksum) ** https://github.com/Linaro/odp/pull/314 ** Patch:

Re: [lng-odp] New API to convert user area ptr to odp_packet_t

2017-12-11 Thread Francois Ozog
yes, configurable headroom purpose is very different from user_area and from user_pointer. ODP provide all. Headroom can be used for many reasons but the primary one is to prepend an additional protocol header such as IPsec. The user_area is a design pattern found in many frameworks (it is very

Re: [lng-odp] odp_shm_reserve() with same block name

2017-12-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Stanislaw Kardach > Sent: Friday, December 08, 2017 6:03 PM > To: LNG ODP Mailman List > Subject: [lng-odp] odp_shm_reserve() with same block name > > Hi all, > >