Hi Ola,
Maybe I'm wrong, but let me try to explain change in question.
The main reason in this change is the lack of possibility to convert
buf_hdr to
buf_handle. The function odp_timeout_to_event requires this conversion.
By and
large it's not required the tmo_handle to be the tmo_header for
On 24.06.15 20:09, Bill Fischofer wrote:
Answers inline
On Wed, Jun 24, 2015 at 11:13 AM, Ivan Khoronzhuk
ivan.khoronz...@linaro.org mailto:ivan.khoronz...@linaro.org wrote:
Guys, sorry I didn't ask the following questions during the ODP meeting.
I had an issue with my microphone
Hi Bill,
On 25.06.15 16:52, Bill Fischofer wrote:
This RFC adds routines that permit classification rules to be manipulated
in a stateful manner. The odp_pktio_pmr_cos() routine is intended to be
deprecated and in its place the new odp_pktio_cls_context_swap() routine
is to be used instead.
and provides for that implementation flexibility. In this
case for linux-generic it's implementated as a memset, but that detail
is now hidden from the user as other platforms are free to implement the
init functions in a manner that work best for them.
On Thu, Jun 25, 2015 at 12:06 PM, Ivan Khoronzhuk
+ lng-odp. Unintentionally removed
On 25.06.15 20:06, Ivan Khoronzhuk wrote:
Hi Bill,
On 25.06.15 15:09, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
include/odp/api/pool.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/odp/api
. It's not correct, the code shouldn't
have such kind dependency from macro definition, and it prevents to
re-use this code for another platforms with different
ODP_QUEUE_INVALID. So, fix it.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
platform/linux-generic/odp_timer.c | 1 +
1
. It's not correct, the code shouldn't
have such kind dependency from macro definition, and it prevents to
re-use this code for another platforms with different
ODP_QUEUE_INVALID. So, fix it.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
platform/linux-generic/odp_timer.c | 1 +
1
Guys, sorry I didn't ask the following questions during the ODP meeting.
I had an issue with my microphone and it seems the call was ended quickly.
But I need to ask. Maybe it's better, it requires some illustration.
For now, I need the answer on the following questions:
- Are we going to use
generates error.
It's not correct, the code shouldn't have such kind dependency from
macro definition, and it prevents to re-use this code for another
platforms with different ODP_QUEUE_INVALID. So, fix it.
Reviewed-by: Ola Liljedahl ola.liljed...@linaro.org
Signed-off-by: Ivan Khoronzhuk
On 24.06.15 19:57, Bala Manoharan wrote:
Hi Ivan,
Pls see my comments inline.
On 24 June 2015 at 09:13, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
Guys, sorry I didn't ask the following questions during the ODP meeting.
I had an issue with my
Hi, Bill
On 01.07.15 05:12, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
include/odp/api/classification.h | 106 +++
1 file changed, 106 insertions(+)
diff --git a/include/odp/api/classification.h
Ola,
I need this change.
Could you please comment on this if you have some objections.
or maybe send your version.
On 30.06.15 13:16, Ivan Khoronzhuk wrote:
It's more generic implementation simplify reusing timer API
for other platforms.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz
In case if for some reason one of the TMOs was lost, the test will
be polling forever in order to take it and delete. It can be used to
indicate that event was lost. Just abort the test if it cannot receive
one of the last TMOs for some period.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz
This series fixes some races in the timer test termination path and
adds some new abilities. The races and drawbacks where found while
testing linux-generic timer API on Keystone implementation, so it's
tested.
Since v1:
- only comments were fixed
Ivan Khoronzhuk (2):
example: timer
can
receive two last events for example.
According to above, added several improvements:
- don't send more timeouts that supposed to receive
- free timer and tmo for a last received tmos = num of threads.
- leave the main loop only if a last tmo/timer is free.
Signed-off-by: Ivan Khoronzhuk
Maxim,
mutex and spinlock is not the same ...
On 03.07.15 16:54, Maxim Uvarov wrote:
Petri, looks like you invented mutex (mtx_recursive) :
https://www-01.ibm.com/support/knowledgecenter/ssw_aix_71/com.ibm.aix.basetrf1/mtx_destroy.htm
Thanks,
Maxim.
On 07/03/15 16:25, Petri Savolainen
For my opinion, using lock in lock its bad design. It shouldn't be
masked. So it can be useful only for legacy applications and should be
avoided in new apps or even disabled somehow.
On 03.07.15 17:00, Ivan Khoronzhuk wrote:
Maxim,
mutex and spinlock is not the same ...
On 03.07.15 16:54
is free.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
example/timer/odp_timer_test.c | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/example/timer/odp_timer_test.c b/example/timer/odp_timer_test.c
index 5e4306e..e832e35
On 03.07.15 12:56, Ivan Khoronzhuk wrote:
Current implementation has at least two races that lead to several issues:
- gbls-remain can overflow. One thread can decrement remain counter to 0.
While another can decrement it once again and it will be 0 once again. After
what the thread
is free.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
example/timer/odp_timer_test.c | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/example/timer/odp_timer_test.c b/example/timer/odp_timer_test.c
index 5e4306e..584a581 100644
This series fixes some races in the timer test and adds some
new abilities. The races and drawbacks where found while testing
linux-generic timer API on keystone implementation, so it tested.
Ivan Khoronzhuk (2):
example: timer: delete races while termination
example: timer: use ability
In case if for some reason one of the TMOs was lost, the test will
be polling forever in order to take it and delete. It can be used to
indicate that event was lost. Just abort the test if it cannot receive
one of the last TMOs for some period.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz
Just decided to add the ability to indicate that some TMO was lost.
At least it already helped me to figure out the issue in odp_schedule of
keystone implementation.
So see this patch inside new series:
[lng-odp] [Patch 0/2] example: timer: fix/improve test
On 03.07.15 12:56, Ivan Khoronzhuk
It's more generic implementation simplify reusing timer API
for other platforms.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
I've checked this patch with Keystone implementation.
.../linux-generic/include/odp_timer_internal.h | 9 ---
platform/linux-generic
As a proposition, we had talk some time ago about,
You moved packet creation to common classification file.
Maybe it's time to assign correct src/dst MAC address, taken from pktio?
In separate patch.
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
data.seq;
+ }
+
+ return TEST_SEQ_INVALID;
+}
+
...
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
One moment.
I need to checkout, I deep enough in some other stuff.
On 18.08.15 14:53, Maxim Uvarov wrote:
Ivan, did you test that patches? Do you want to add your review-by?
Maxim.
On 08/17/15 19:08, Bala Manoharan wrote:
Ping.
On 14 August 2015 at 22:00, Ivan Khoronzhuk ivan.khoronz
, odp_queue_type_t qtype);
void configure_pktio_default_cos(void);
void test_pktio_default_cos(void);
void configure_pktio_error_cos(void);
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman
ticks
*/
-uint64_t odp_time_ns_to_cycles(uint64_t ns);
+uint64_t odp_time_ns_to_tick(uint64_t ns);
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
+
On 19.08.15 17:49, Ivan Khoronzhuk wrote:
On 19.08.15 17:12, Savolainen, Petri (Nokia - FI/Espoo) wrote:
Hi,
As I mentioned in the call, I'd like to avoid confusion between time and timer (timer
tick). In minimum, the API documentation should not refer to timer. Also
could term 'tick
On 19.08.15 12:49, Stuart Haslam wrote:
On Sat, Aug 08, 2015 at 01:28:08AM +0300, Ivan Khoronzhuk wrote:
The word cycle is left from old API time names. The cycle is
ambiguous word, especially when it can be used for other purposes.
So better to use tick word or just t symbol.
Signed-off
Hi, Stuart
On 19.08.15 12:50, Stuart Haslam wrote:
On Sat, Aug 08, 2015 at 01:28:09AM +0300, Ivan Khoronzhuk wrote:
The time API were changed from *_cycles* to *_tick*, so use
appropriate names.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
platform/linux-generic/arch/linux
/pipermail/lng-odp/2015-August/014435.html
As an example it uses odp_time_tick_to_ns(1) to get resolution.
I think no need in this API.
-Original Message-
From: ext Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org]
Sent: Wednesday, August 19, 2015 5:53 PM
To: Savolainen, Petri (Nokia - FI
I think it should be in 1.3
Stuart, could you please review it.
On 08.08.15 01:28, Ivan Khoronzhuk wrote:
This seres is intended to change time API names from *_cycles*
to *_tick*. Also remove usage of word cycle from appropriate
places as it's no more valid.
Based on api-next
Ivan Khoronzhuk
as is. Only comment should be shorter.
Like for IP header:
#define ODPH_IPV4HDR_LEN 20 /** Min length of IP header (no options) */
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman
TEST_SEQ_INVALID;
+}
+
+static inline
+int parse_ipv4_string(const char *ipaddress, uint32_t *addr, uint32_t *mask)
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
Hi Bala,
just several comments I forgot to mention.
On 19.08.15 08:45, Bala Manoharan wrote:
Ivan,
On 18 August 2015 at 22:39, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
post test review.
I've tested. It works for me. (except UDP/TCP src
Bala,
On 18.08.15 18:54, Bala Manoharan wrote:
Ivan,
On 18 August 2015 at 21:15, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
Bala,
On 18.08.15 18:16, Bala Manoharan wrote:
Hi Ivan,
On 18 August 2015 at 19:22, Ivan Khoronzhuk
Bala,
On 18.08.15 18:16, Bala Manoharan wrote:
Hi Ivan,
On 18 August 2015 at 19:22, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
Hi, Bala
Note: Your patch is based on API-NEXT and it obliged me to do some
modifications
On 20.08.15 17:17, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-Original Message-
From: ext Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org]
Sent: Thursday, August 20, 2015 4:49 PM
To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org;
Stuart Haslam; Maxim Uvarov
https://lists.linaro.org/mailman/listinfo/lng-odp
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
___
lng-odp
without
regard to its relative order with respect to other items originating
from the same ordered queue. In effect, after a release_ordered() call
the event behaves as if it came from a parallel queue rather than an
ordered one.
On Wed, Jul 29, 2015 at 10:36 AM, Ivan Khoronzhuk
ivan.khoronz
/ver_abt_log_dbg/odp_ver_abt_log_dbg.c
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp
It's needed as pktio is not set in promisc mode.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
test/performance/odp_pktio_perf.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/performance/odp_pktio_perf.c
b/test/performance/odp_pktio_perf.c
index
shure
On 04.08.15 15:19, Mike Holmes wrote:
In the platform call just now the discussion came to this patch.
Ivan can you propose an API to get the timer resolution for the
platform, then the test suite can call that and run the test appropriately.
On 29 July 2015 at 08:39, Ivan Khoronzhuk
Current test supposes that timer counter resolution is very close
to 1ns. But that's not always true. The resoulution can be 8ns for
instance, it's not always close to CPU frequency.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
test/validation/time/time.c | 2 +-
1 file changed
it's freq, so it make sense.
On 07/28/15 18:23, Ivan Khoronzhuk wrote:
Current test supposes that timer counter resolution is very close
to 1ns. But that's not always true. The resoulution can be 8ns for
instance, it's not always close to CPU frequency.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz
On 29.07.15 14:42, Ivan Khoronzhuk wrote:
On 29.07.15 14:34, Maxim Uvarov wrote:
Should we have
#define CONFIG_TIMER_RESOLUTION
in config.h?
And relay on it's value.
Maxim.
Maybe.
In case of CPU freq this is inversely proportional to odp_sys_cpu_hz(),
and can be determined. But in case
On 29.07.15 14:47, Bill Fischofer wrote:
Agreed. An ODP implementation should be for a platform, not for a
specific model within a platform family. Another reason why config.h
needs to be converted from #defines to APIs.
There is a little more sense under it. Each CPU, theoretically, (no
conversion to get real ns.
On 29 July 2015 at 08:39, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
Mike,
On 29.07.15 15:27, Mike Holmes wrote:
On 29 July 2015 at 08:17, Ivan Khoronzhuk
ivan.khoronz...@linaro.org mailto:ivan.khoronz
The API names even can be leaved as is.
Only description change (remove CPU cycles)
On 05.08.15 15:01, Ivan Khoronzhuk wrote:
On 04.08.15 15:19, Mike Holmes wrote:
In the platform call just now the discussion came to this patch.
Ivan can you propose an API to get the timer resolution
This seres is intedent to change time API names from *_cycles*
to *_counts*. Also remove usage of word cycle from appropriate
places as it's no more valid.
Based on api-next.
Ivan Khoronzhuk (4):
api: time: unbind CPU cycles from time API
test/example: avoid cycle word usage
linux-generic
cycles to measure
time, the better hi-resolution timer the better measurements.
So, unbind CPU cycle counter from time API by eliminating word
cycle as it's believed to use with CPU.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
example/ipsec/odp_ipsec.c | 6
The word cycle is left from old API time names. The cycle is
ambiguous word, especially when it can be used with software cycles.
So better to use time word or just t symbol, as no matter in
which units time is measured, in sec, hours, cycles or counts.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz
The time API were changed from *_cycles* to *_counts*, so use
appropriate names.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
platform/linux-generic/arch/linux/odp_time.c | 2 +-
platform/linux-generic/arch/mips64/odp_time.c | 2 +-
platform/linux-generic/arch/x86/odp_time.c
The word cycle is left from old API time names. The cycle is
ambiguous word, especially when it can be used with software cycles.
So better to use time word or just t symbol, as no matter in
which units time is measured, in sec, hours, cycles or counts.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz
On 03.08.15 19:24, Bala Manoharan wrote:
On 3 August 2015 at 21:44, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
One more issue
On 30.07.15 18:20, Balasubramanian Manoharan wrote:
Additional test suite is added to classification
;
+ }
+
+ return TEST_SEQ_INVALID;
+}
+
...
--
Regards,
Ivan Khoronzhuk
Regards,
Bala
--
Regards,
Ivan Khoronzhuk
--
Regards,
Ivan Khoronzhuk
in this
case PMRset primitive should be used.
PS:
You patches are based on api-next, and I cannot check it w/o
modifications connected with odp_pktio_params_t.
I merged v1.2 tag and based on it.
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng
Mike,
On 29.07.15 15:27, Mike Holmes wrote:
On 29 July 2015 at 08:17, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
On 29.07.15 14:47, Bill Fischofer wrote:
Agreed. An ODP implementation should be for a platform, not for a
specific
On 06.08.15 13:08, Stuart Haslam wrote:
On Tue, Aug 04, 2015 at 03:05:21PM +0300, Ivan Khoronzhuk wrote:
It's needed as pktio is not set in promisc mode.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
test/performance/odp_pktio_perf.c | 6 +++---
1 file changed, 3
It's needed as pktio is not set in promisc mode.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
Since v1:
- initialize mac address at init, while packet creation only copy
test/performance/odp_pktio_perf.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions
Hi, Stuart
I've combined here v1 and v2.
On 07.08.15 12:33, Stuart Haslam wrote:
On Thu, Aug 06, 2015 at 08:18:36PM +0300, Ivan Khoronzhuk wrote:
On 06.08.15 20:03, Stuart Haslam wrote:
On Thu, Aug 06, 2015 at 05:30:30PM +0300, Ivan Khoronzhuk wrote:
The direct comparing of cur_cycles
Hi, Stuart
On 06.08.15 19:44, Stuart Haslam wrote:
On Thu, Aug 06, 2015 at 05:07:17PM +0300, Ivan Khoronzhuk wrote:
The direct comparing of cur_cycles and end_cycles is not valid,
as end_cycles can be overflowed and comparison will give wrong
result. So use odp_time_diff_cycles
On 06.08.15 20:03, Stuart Haslam wrote:
On Thu, Aug 06, 2015 at 05:30:30PM +0300, Ivan Khoronzhuk wrote:
The direct comparing of cur_cycles and end_cycles is not valid,
as end_cycles can be overflowed and comparison will give wrong
result. So use odp_time_diff_cycles() for that, as it takes
On 14.08.15 19:29, Bala Manoharan wrote:
Hi Ivan,
I am planning to add MAC support in a separate patch.
I believe MAC should be easier to get-in since it has been agreed.
Ok.
___
lng-odp mailing list
lng-odp@lists.linaro.org
01f5c738c6e73bd3ad75984d293c506f952a1eff
...
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
The TOLERANCE hardcodes a timer resolution, so replace it on
real timer resolution that can be got by odp_time_tick_to_ns(1).
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
Based on
api: time: change API to use ticks instead of cycles
https://lists.linaro.org/pipermail/lng-odp
;
/** Packet pool*/
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
This series is intended to fix ticks overflows while sending packets.
Based on master
Ivan Khoronzhuk (2):
performance: odp_pktio_perf: fix potential overflow for send_duration
performance: odp_pktio_perf: fix potential overflow for burst_gap
test/performance/odp_pktio_perf.c | 12
The direct comparing of cur_cycles and end_cycles is not valid,
as end_cycles can be overflowed and comparison will give wrong
result. So use odp_time_diff_cycles() for that, as it takes in
account cycles overflow.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
test/performance
The direct comparing of cur_cycles and next_tx_cycles is not
valid, as next_tx_cycles can be overflowed and comparison will
give wrong result. So use odp_time_diff_cycles() for that, as it
takes in account ticks overflow.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
test
The direct comparing of cur_cycles and next_tx_cycles is not
valid, as next_tx_cycles can be overflowed and comparison will
give wrong result. So use odp_time_diff_cycles() for that, as it
takes in account ticks overflow.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
test
This series is intended to fix ticks overflows while sending packets.
Based on master
Since v1:
- replaced on =
Ivan Khoronzhuk (2):
performance: odp_pktio_perf: fix potential overflow for send_duration
performance: odp_pktio_perf: fix potential overflow for burst_gap
test
On 24.07.15 19:03, Ivan Khoronzhuk wrote:
Mike,
On 24.07.15 17:42, Mike Holmes wrote:
I had hoped this might fix the clang thread sanitizer warnings - see
https://bugs.linaro.org/show_bug.cgi?id=1457
But when applied it does not fix them, however this does not mean these
are bad patches
that event was lost Ivan Khoronzhuk
* 8922a00 :2015-07-24 - example: timer: delete races while termination
Ivan Khoronzhuk
* 8cb1a23 :2015-07-22 - (origin/master, origin/HEAD, master)
linux-generic: pktio: remove _pkt suffix for open, close, recv and
* 3e443e2 :2015-07-24 - gitignore: add ar-lib Maxim
-example-timer-delete-races-while-termination.patch has style
problems, please review.
On 3 July 2015 at 08:38, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
Current implementation has at least two races that lead to several
issues:
- gbls-remain can
were fixed
Ivan Khoronzhuk (2):
example: timer: delete races while termination
example: timer: use ability to indicate that event was lost
example/timer/odp_timer_test.c | 45 ++
1 file changed, 28 insertions(+), 17 deletions(-)
--
1.9.1
In case if for some reason one of the TMOs was lost, the test will
be polling forever in order to take it and delete. It can be used to
indicate that event was lost. Just abort the test if it cannot receive
one of the last TMOs for some period.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz
can
receive two last events for example.
According to above, added several improvements:
- don't send more timeouts that supposed to receive
- free timer and tmo for a last received tmos = num of threads.
- leave the main loop only if a last tmo/timer is free.
Signed-off-by: Ivan Khoronzhuk
value for an odp_cos_t
*
* @param hdl odp_cos_t handle to be printed
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
I suppose, the intention was to check only ODP_PMR_IPPROTO capability.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
test/validation/classification/odp_classification_tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/classification
only one.
It's not formated patch and is only for demonstration.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
.../classification/odp_classification_tests.c | 42 ++
1 file changed, 42 insertions(+)
diff --git a/test/validation/classification
it will be one PMR, but emulated by two. And implementation
cannot know a priori in what circumstances this entry will be used.
So, question is openBut, at least, this change allows to return
more accurate number.
Signed-off-by: Ivan Khoronzhuk ivan.khoronz...@linaro.org
---
include/odp/api
Bala,
On 15.07.15 11:31, Bala Manoharan wrote:
Hi Ivan,
Comments Inline...
On 15 July 2015 at 02:48, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
It's simple improvement is intended to open eyes on possible
hidden issues when a packet can
On 15.07.15 19:43, Ivan Khoronzhuk wrote:
Hi, Nicolas
Maybe I'm wrong, but it's supposed that headroom is used to extend the
packet data, when it's required. And if you need some meta-data you
probably should add it in packet header or else, but under headroom.
I meant your actual headroom
the list server.
It's good when the letter is seen by everyone with the same subject.
Envoyé depuis un mobile Samsung.
Message d'origine
De : Ivan Khoronzhuk
Date :15/07/2015 18:34 (GMT+01:00)
À : Bill Fischofer , Genis Riera
Cc : ODP mailing list
Objet : Re: [lng-odp] [PATCH
What about to pick up this patch?
I still need it. I'm not sure, but seems this issue was before this
patch.
On 01.07.15 19:03, Ola Liljedahl wrote:
On 30 June 2015 at 12:16, Ivan Khoronzhuk ivan.khoronz...@linaro.org
mailto:ivan.khoronz...@linaro.org wrote:
It's more generic
Hi, Genis
On 15.07.15 18:47, Genis Riera wrote:
A new headroom parameter is added to odp_pool_param_t when the pool is
type of ODP_POOL_PACKET, so that headroom size could be configured at
pool initialization time (ODP application runtime).
Signed-off-by: Genis Riera Perez
at StarFlow Networks
Edifici K2M, S103 c/ Jordi Girona 31
08034 Barcelona
E-mail: gri...@starflownetworks.com mailto:gri...@starflownetworks.com
On Wed, Jul 15, 2015 at 5:54 PM, Ivan Khoronzhuk
ivan.khoronz...@linaro.org mailto:ivan.khoronz...@linaro.org wrote:
Hi, Genis
On 15.07.15 18:47
for that, and in case if it cannot implement l2-l2-l3 it
has to return error, but not 2.
On 15.07.15 17:35, Bala wrote:
On 15-Jul-2015, at 7:58 pm, Ivan Khoronzhuk ivan.khoronz...@linaro.org wrote:
Bala,
.
On 15.07.15 12:25, Bala Manoharan wrote:
.
It's only a proposition
Genis,
On 15.07.15 19:11, Genis Riera wrote:
Ivan,
If you have this compilation issues I can send again the patch without
this check, assuming always positive values. Is it right for you?
Yes, but wait a while, maybe someone else have some propositions.
Hi, Nicolas
Maybe I'm wrong, but it's supposed that headroom is used to extend the
packet data, when it's required. And if you need some meta-data you
probably should add it in packet header or else, but under headroom.
On 15.07.15 19:28, Nicolas Morey-Chaisemartin wrote:
As this is a change
be checked in another way.
On 21 October 2015 at 18:15, Ivan Khoronzhuk <ivan.khoronz...@linaro.org> wrote:
On 21.10.15 15:14, Bala Manoharan wrote:
I skipped this coz this as I just realised that since this was an
error packet and it might not be required for platforms to parse an
error
ro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
--
Regards,
Ivan Khoronzhuk
___
lng-odp mailing list
lng-odp@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/lng-odp
On 23.10.15 14:18, Savolainen, Petri (Nokia - FI/Espoo) wrote:
-Original Message-
From: EXT Ivan Khoronzhuk [mailto:ivan.khoronz...@linaro.org]
Sent: Friday, October 23, 2015 2:12 PM
To: Savolainen, Petri (Nokia - FI/Espoo); EXT Maxim Uvarov; lng-
o...@lists.linaro.org
Subject: Re
There cannot be used direct comparison of timestamps of counter
that can overflow, better to compare ranges.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org>
---
test/performance/odp_pktio_perf.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git
lign linux-generic implementation with
new time API.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronz...@linaro.org>
---
platform/linux-generic/Makefile.am | 1 +
.../linux-generic/include/odp/plat/time_types.h| 36 +
platform/linux-generic/include/odp/time
The word "cycle" is left from old API time names. The "cycle" is
ambiguous word, especially when it can be used for other purposes.
So better to use "tick" or "time" word or just "t" symbol.
Signed-off-by: Ivan Khoronzhuk <ivan.khoronz.
ed instead of odp_time_from_ns(0) for
comparison and initialization.
This patch changes only used time API, it doesn't change used var
names for simplicity.
This time API can be implemented with local timer counter, so
shouldn't be used between threads.
Signed-off-by: Ivan Khoronzhuk <
1 - 100 of 612 matches
Mail list logo
