Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-20 Thread Bogdan Pricope
Hi Petri, We need some changes to API in order to accommodate OFP IPsec patch: 1. On inbound direction, OFP needs on output of IPsec operation: a. Next Layer Protocol - L3: IPv4 / IPv6 for tunnel mode ; L4: UDP/TCP/etc. for transport mode (this is encrypted in original packet) b. Next

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
I-NEXT DRAFT] api: ipsec: added IPSEC API > > Few comments. > > Regards > Nikhil > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri > Savolainen > Sent: Tuesday, November 15, 2016 2:18 PM > To: lng-odp@lists.li

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-16 Thread Nikhil Agarwal
Few comments. Regards Nikhil -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri Savolainen Sent: Tuesday, November 15, 2016 2:18 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API Added definitions

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
> >> > >> Packet context ptr will not work in the case in which the packet is > >> directly received from the interface by the offload engine. > >> Is the above case valid or all the packet comes only through the > application? > > > > In this API draft the packets come only through the

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-16 Thread Bala Manoharan
ent: Wednesday, November 16, 2016 11:16 AM >> To: Savolainen, Petri (Nokia - FI/Espoo) >> <petri.savolai...@nokia-bell-labs.com> >> Cc: lng-odp-forward <lng-odp@lists.linaro.org> >> Subject: Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API >> >&

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-16 Thread Peltonen, Janne (Nokia - FI/Espoo)
c: lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API > > Regards, > Bala > > > On 15 November 2016 at 20:17, Savolainen, Petri (Nokia - FI/Espoo) > <petri.savolai...@nokia-bell-labs.com> wrote: &g

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-16 Thread Bala Manoharan
gt;> To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- >> labs.com> >> Cc: lng-odp-forward <lng-odp@lists.linaro.org> >> Subject: Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API >> >> Some quick comments...

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-16 Thread Bala Manoharan
gt;> To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolainen@nokia-bell- >> labs.com> >> Cc: lng-odp-forward <lng-odp@lists.linaro.org> >> Subject: Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API >> >> Regards, >> Bala >>

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Wednesday, November 16, 2016 4:52 AM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia-bell-labs.com> Cc: lng-odp-forward <lng-odp@lists.linaro.org> Subject: Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: add

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Peltonen, Janne (Nokia - FI/Espoo)
ia-bell-labs.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API > > On Tue, Nov 15, 2016 at 2:47 AM, Petri Savolainen < > petri.savolai...@nokia.com> wrote: > > > Added definitio

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Bill Fischofer
On Tue, Nov 15, 2016 at 2:47 AM, Petri Savolainen < petri.savolai...@nokia.com> wrote: > Added definitions for a look-a-side IPSEC offload API. In addition to > IPSEC packet transformations, it also supports: > * inbound SA look up > * outbound IP fragmentation > > Signed-off-by: Petri Savolainen

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, > What will be the total number of SA in the system? Will it be around 100K? Yes, the API should work with that many SAs. > If that is the case IMO it might be better to add a "context_packet" > which could be copied to the output packet instead of having 100K > different queues? I think

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Peltonen, Janne (Nokia - FI/Espoo)
Hi, > > +typedef struct odp_ipsec_lifetime_t { > > + /** Soft expiry limits for the session */ > > + struct { > > + /** Limit in seconds */ > > + uint64_t sec; > > Does expiry time mean the ADD_TIME -Time calculated when the policy is > added to database

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> Subject: Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API > > Some quick comments... > > Regards, > Bala > > > On 15 November 2016 at 14:17, Petri Savolainen > <petri.savolai...@nokia.com> wrote: > > Added definitions for a look-a-side IPS

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Bala Manoharan
Regards, Bala On 15 November 2016 at 14:17, Petri Savolainen wrote: > Added definitions for a look-a-side IPSEC offload API. In addition to > IPSEC packet transformations, it also supports: > * inbound SA look up > * outbound IP fragmentation > > Signed-off-by: Petri

Re: [lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Bala Manoharan
Some quick comments... Regards, Bala On 15 November 2016 at 14:17, Petri Savolainen wrote: > Added definitions for a look-a-side IPSEC offload API. In addition to > IPSEC packet transformations, it also supports: > * inbound SA look up > * outbound IP fragmentation

[lng-odp] [API-NEXT DRAFT] api: ipsec: added IPSEC API

2016-11-15 Thread Petri Savolainen
Added definitions for a look-a-side IPSEC offload API. In addition to IPSEC packet transformations, it also supports: * inbound SA look up * outbound IP fragmentation Signed-off-by: Petri Savolainen --- include/odp/api/spec/event.h | 2 +-