Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-14 Thread Alexandru Badicioiu
gt; figuring out what to do with those events). Different types of events >>>>>>>> may >>>>>>>> be received from the same queue and require different action. >>>>>>>>

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-14 Thread Ola Liljedahl
on events and timeout events. The timer patch I did on Taras' >>>>>>> request based timeouts on buffers with the timeout-specific data stored >>>>>>> in >>>>>>> the buffer data so no need for a timeout-specific header. This design

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-14 Thread Alexandru Badicioiu
buffer data so no need for a timeout-specific header. This design >>>>>> simplifies reuse on other platforms where the event (HW buffer) >>>>>> definition >>>>>> is fixed and there might be no room for additional event-type specific >>>

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-12 Thread Ola Liljedahl
) definition >>>>> is fixed and there might be no room for additional event-type specific >>>>> headers. >>>>> >>>> Just to clearify. An implementation doing the above would still have >>>> specific p

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-12 Thread Bill Fischofer
header. This design >>>>> simplifies reuse on other platforms where the event (HW buffer) definition >>>>> is fixed and there might be no room for additional event-type specific >>>>> headers. >>>>> >>>> Just to clearify. An implementation doing the above

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-12 Thread Alexandru Badicioiu
events. No need to >>> dynamically change the type of an event. >>> >>> >>>> >>>> On 10 June 2015 at 10:11, Savolainen, Petri (Nokia - FI/Espoo) < >>>> petri.savolai...@nokia.com> wrote: >>>>

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-12 Thread Ola Liljedahl
;>> petri.savolai...@nokia.com> wrote: >>> >>>> >>>> >>>> >>>> >>>> *From:* lng-odp [mailto:lng-odp-boun...@lists.linaro.org] *On Behalf >>>> Of *ext Christophe Milard >>>> *Sent:* Wednesday, June 10

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-10 Thread Bill Fischofer
oun...@lists.linaro.org] *On Behalf Of >>> *ext Christophe Milard >>> *Sent:* Wednesday, June 10, 2015 10:18 AM >>> *To:* Bill Fischofer >>> *Cc:* LNG ODP Mailman List >>> *Subject:* Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate >>> buffe

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-10 Thread Ola Liljedahl
; wrote: > >> >> >> >> >> *From:* lng-odp [mailto:lng-odp-boun...@lists.linaro.org] *On Behalf Of *ext >> Christophe Milard >> *Sent:* Wednesday, June 10, 2015 10:18 AM >> *To:* Bill Fischofer >> *Cc:* LNG ODP Mailman List >> *Subject:*

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-10 Thread Alexandru Badicioiu
> *Sent:* Wednesday, June 10, 2015 10:18 AM >> *To:* Bill Fischofer >> *Cc:* LNG ODP Mailman List >> *Subject:* Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer >> type hack for completions >> >> >> >> >> >> >> >> On

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-10 Thread Ola Liljedahl
m> wrote: > > > > > *From:* lng-odp [mailto:lng-odp-boun...@lists.linaro.org] *On Behalf Of *ext > Christophe Milard > *Sent:* Wednesday, June 10, 2015 10:18 AM > *To:* Bill Fischofer > *Cc:* LNG ODP Mailman List > *Subject:* Re: [lng-odp] [PATCH] linux-generic: crypto: eli

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-10 Thread Bill Fischofer
8 AM > *To:* Bill Fischofer > *Cc:* LNG ODP Mailman List > *Subject:* Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer > type hack for completions > > > > > > > > On 10 June 2015 at 04:50, Bill Fischofer > wrote: > > odp_crypto_operation()

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Christophe Milard Sent: Wednesday, June 10, 2015 10:18 AM To: Bill Fischofer Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions On 10 June 2015 at

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-10 Thread Christophe Milard
On 10 June 2015 at 04:50, Bill Fischofer wrote: > odp_crypto_operation() should not change underlying buffer types for > completions as these are purely internal and not needed, and doing > so is confusing and error-prome. > > Yes, Bill, I would prefer your approach: my patch felt like a hack to

[lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

2015-06-09 Thread Bill Fischofer
odp_crypto_operation() should not change underlying buffer types for completions as these are purely internal and not needed, and doing so is confusing and error-prome. Signed-off-by: Bill Fischofer --- platform/linux-generic/include/odp_buffer_internal.h | 9 - platform/linux-generic/od