Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

My comments, inline. On 03/01/2017 08:59 AM, Yi He wrote: > Comments on 1/5 and 2/5, other patches in this series look OK to me. > > On 13 February 2017 at 20:49, Bogdan Pricope > wrote: > > Signed-off-by: Bogdan Pricope >

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

Comments on 1/5 and 2/5, other patches in this series look OK to me. On 13 February 2017 at 20:49, Bogdan Pricope wrote: > Signed-off-by: Bogdan Pricope > --- > example/generator/odp_generator.c | 131 ++ > +++- > 1 file changed, 114 insertions(+), 17 deletions(

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

Hi, >From my point of view, at the end of review process this series (+ the patch related to stats logging message) should be added at least in odp-dpdk. Bogdan On 15 February 2017 at 18:55, Mike Holmes wrote: > So this is a request to add this to Monarch LTS then ? > > On 15 February 2017 at 0

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

So this is a request to add this to Monarch LTS then ? On 15 February 2017 at 03:58, Bogdan Pricope wrote: > Hi, > > There were multiple small “fixes” required to make the packet valid. > They should go in together and in all branches. > > Br, > Bogdan > > On 14 February 2017 at 16:38, Nicolas M

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

Hi, There were multiple small “fixes” required to make the packet valid. They should go in together and in all branches. Br, Bogdan On 14 February 2017 at 16:38, Nicolas Morey-Chaisemartin wrote: > > > Le 02/13/2017 à 01:49 PM, Bogdan Pricope a écrit : >> Signed-off-by: Bogdan Pricope >> --- >

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

Le 02/13/2017 à 01:49 PM, Bogdan Pricope a écrit : > Signed-off-by: Bogdan Pricope > --- > example/generator/odp_generator.c | 131 > +- > 1 file changed, 114 insertions(+), 17 deletions(-) > > diff --git a/example/generator/odp_generator.c > b/example/gene

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

Hi, Any mechanism that will prevent from copying data is a good thing. This change can be done after the new API is merged in master branch. Br, Bogdan On 13 February 2017 at 21:04, Bill Fischofer wrote: > On Mon, Feb 13, 2017 at 6:49 AM, Bogdan Pricope > wrote: >> Signed-off-by: Bogdan Prico

Re: [lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

On Mon, Feb 13, 2017 at 6:49 AM, Bogdan Pricope wrote: > Signed-off-by: Bogdan Pricope > --- > example/generator/odp_generator.c | 131 > +- > 1 file changed, 114 insertions(+), 17 deletions(-) > > diff --git a/example/generator/odp_generator.c > b/example/g

[lng-odp] [PATCH 1/5] test: generator: compose sending packets from reference packet plus differences

Signed-off-by: Bogdan Pricope --- example/generator/odp_generator.c | 131 +- 1 file changed, 114 insertions(+), 17 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index 8062d87..d1e3ecc 100644 --- a/example/gen