Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-10 Thread Elo, Matias (Nokia - FI/Espoo)
> >> >> On 2 June 2016 at 13:15, Matias Elo wrote: > >> >> > Don't allocate new packets inside of the internal > >> >> > classifier helpers _odp_packet_cls_enq() and > >> >> > _odp_packet_classifier(). Instead, save destination queue to > >> >> > the parsed packet header

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-09 Thread Bala Manoharan
On 9 June 2016 at 14:56, Elo, Matias (Nokia - FI/Espoo) wrote: >> >> On 2 June 2016 at 13:15, Matias Elo wrote: >> >> > Don't allocate new packets inside of the internal >> >> > classifier helpers _odp_packet_cls_enq() and >> >> >

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-09 Thread Elo, Matias (Nokia - FI/Espoo)
> >> On 2 June 2016 at 13:15, Matias Elo wrote: > >> > Don't allocate new packets inside of the internal > >> > classifier helpers _odp_packet_cls_enq() and > >> > _odp_packet_classifier(). Instead, save destination queue to > >> > the parsed packet header and return correct

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-08 Thread Elo, Matias (Nokia - FI/Espoo)
<mailto:bala.manoha...@linaro.org>> Cc: Elo, Matias (Nokia - FI/Espoo) <matias@nokia.com<mailto:matias@nokia.com>>; LNG ODP Mailman List <lng-odp@lists.linaro.org<mailto:lng-odp@lists.linaro.org>> Subject: Re: [lng-odp] [PATCH v2 4/4] linux-gen:

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-08 Thread Bala Manoharan
Regards, Bala On 8 June 2016 at 12:24, Elo, Matias (Nokia - FI/Espoo) wrote: > > >> On 2 June 2016 at 13:15, Matias Elo wrote: >> > Don't allocate new packets inside of the internal >> > classifier helpers _odp_packet_cls_enq() and >> >

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-08 Thread Elo, Matias (Nokia - FI/Espoo)
st <lng-odp@lists.linaro.org> Subject: Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier Hello all, Sorry for joining the convesation late too. At Starflow we detected a regression at this exact commit. We use the RAW socket interface (socket_mmap PKTIO) and now t

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-07 Thread Bill Fischofer
I've added this topic to the agenda for the Wednesday ARCH call. On Tue, Jun 7, 2016 at 8:14 AM, Oriol Arcas wrote: > Hello all, > > Sorry for joining the convesation late too. At Starflow we detected a > regression at this exact commit. We use the RAW socket

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-07 Thread Oriol Arcas
Hello all, Sorry for joining the convesation late too. At Starflow we detected a regression at this exact commit. We use the RAW socket interface (socket_mmap PKTIO) and now the performance has dropped to kB/s. There is connectivity, but the behavior is erratic and the performance very low.

Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-07 Thread Bala Manoharan
Hi, Just realised that I haven't sent these comment. Sorry for the late feedback. Comments inline... Regards, Bala On 2 June 2016 at 13:15, Matias Elo wrote: > Don't allocate new packets inside of the internal > classifier helpers _odp_packet_cls_enq() and >

[lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new packets in classifier

2016-06-02 Thread Matias Elo
Don't allocate new packets inside of the internal classifier helpers _odp_packet_cls_enq() and _odp_packet_classifier(). Instead, save destination queue to the parsed packet header and return correct packet pool. This enables zero-copy packet classification. Added new internal pktio helper