[lng-odp] Compression API: hashing

2018-12-10 Thread Dmitry Eremin-Solenikov
Hello, I have been reworking compression API implementation to properly allocate/deallocate memory. Right now I've stumbled upon digest part of compression API. Currently on both compression and decompression digest should be written after co/decompressed output data. However both our hardware

Re: [lng-odp] Compression API: hashing

2018-12-10 Thread Bill Fischofer
I assume that's an API change? Can you put together a draft PR of what what would look like that we can discuss? On Mon, Dec 10, 2018 at 1:00 PM Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > Hello, > > I have been reworking compression API implementation to properly >

Re: [lng-odp] Compression API: hashing

2018-12-10 Thread Dmitry Eremin-Solenikov
On 10/12/2018 22:11, Bill Fischofer wrote: > I assume that's an API change? Can you put together a draft PR of what > what would look like that we can discuss? I can sketch a draft PR, however I'd like to hear an opinion first. Basically my suggestion is to move digest from packet data to

Re: [lng-odp] Compression API: hashing

2018-12-10 Thread Bill Fischofer
I'd like to hear from Janne as to what OFP would prefer. I'll also add this to the discussion agenda for tomorrow's public call. Thanks. On Mon, Dec 10, 2018 at 2:28 PM Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > On 10/12/2018 22:11, Bill Fischofer wrote: > > I assume

[lng-odp] [Bug 4014] Separate IP ID allocation for transport and tunnel mode SAs may cause duplicate IDs.

2018-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=4014 --- Comment #3 from Janne Peltonen --- RFC 791 and RFC 6864 specify uniqueness criteria for the IP ID field. Those criteria have to be met also with IPsec even if IPsec RFCs do not say so explicitly. Now an IP host/router implementation that is using

[lng-odp] [Bug 4018] Unexpected IV causes IPsec API validation to fail.

2018-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=4018 --- Comment #3 from Janne Peltonen --- I am referring to all IPsec output tests. The test cases compare the output packet produced by the IPsec implementation against the expected output packet defined in the test vector. The packets match only if the

[lng-odp] [Bug 4018] Unexpected IV causes IPsec API validation to fail.

2018-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=4018 --- Comment #4 from Dmitry Eremin-Solenikov --- Janne, I've rechecked IPsec testsuite. Please correct me if I'm wrong. Output-with-compare tests fall into two major groups: - Null encryption + HMAC-SHA-somthing. These test vectors do not require IV

[lng-odp] [Bug 4131] New: Missing AES-CCM ipsec test cases

2018-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=4131 Bug ID: 4131 Summary: Missing AES-CCM ipsec test cases Product: OpenDataPlane - linux- generic reference Version: master Hardware: Other OS: Linux Status: UNCONFIRMED

[lng-odp] [Bug 4018] Unexpected IV causes IPsec API validation to fail.

2018-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=4018 --- Comment #5 from Janne Peltonen --- Sound right to me. Maybe the corrected test cases could still do the full packet comparison if they notice that the IV is the same as in the test vector. This way the current implementation would get some extra

[lng-odp] [Bug 4131] Missing AES-CCM ipsec test cases

2018-12-10 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=4131 Bill Fischofer changed: What|Removed |Added Assignee|maxim.uva...@linaro.org |dmitry.ereminsolenikov@lina