Reviewed-by: Petri Savolainen petri.savolai...@linaro.org
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Mike Holmes
Sent: Wednesday, December 10, 2014 9:12 PM
To: lng-odp@lists.linaro.org
Subject: [lng-odp]
Merged,
Maxim.
On 12/09/2014 10:19 PM, Stuart Haslam wrote:
caddr_t is undefined when building with -std=c99
When defined, caddr_t is normally a char *, but the third argument to
ioctl() is an untyped pointer so the cast isn't required.
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
Are these cunit tests for odp_atomic.h only?
Are there any cunit tests for plain spin locks, ticket locks, rwlocks etc?
-- Ola
On 10 December 2014 at 20:42, Mike Holmes mike.hol...@linaro.org wrote:
I think odp_syne would be better as odp_sync throughout the patch
Does Barrys patch cover
Merged,
Maxim.
On 12/10/2014 08:12 PM, Mike Holmes wrote:
This fixes https://bugs.linaro.org/show_bug.cgi?id=714
Signed-off-by: Alexandru Badicioiu alexandru.badici...@linaro.org
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
This extends a prvious patch from Alex to cover all the
On Wednesday 10 December 2014 08:42 PM, Robbie King wrote:
Signed-off-by: Robbie King robk...@cisco.com
---
example/ipsec/odp_ipsec.c | 68 ---
1 file changed, 46 insertions(+), 22 deletions(-)
diff --git a/example/ipsec/odp_ipsec.c
On Thursday 11 December 2014 05:30 AM, Taras Kondratiuk wrote:
On 12/10/2014 05:12 PM, Robbie King wrote:
Signed-off-by: Robbie Kingrobk...@cisco.com
---
platform/linux-generic/include/api/odp_crypto.h | 77 -
1 file changed, 63 insertions(+), 14 deletions(-)
diff
On Wednesday 10 December 2014 08:42 PM, Robbie King wrote:
Signed-off-by: Robbie King robk...@cisco.com
---
.../linux-generic/include/odp_crypto_internal.h| 2 +
platform/linux-generic/odp_crypto.c| 98 ++
2 files changed, 83 insertions(+), 17
Update odp version in one place (C code), and use it for doxygen also.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
configure.ac | 2 +-
doc/doxygen.cfg| 2 +-
m4/ax_prog_doxygen.m4 | 4 ++--
scripts/odp_version.sh | 7 +++
4 files changed, 11 insertions(+), 4
Add cunit tests for new pktio api:
- MAC address get;
- Promisc mode set / test;
- MTU value set / get;
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
removed odp_pktio binary from the patch. git show does not shows binary files,
interesting is there any way to see binaries in git log.
Wrongly added odp_pktio binary to git commit bellow.
Removing it.
commit ecc9ec203835552f0ad01fd3de0566033151580a
Author: Taras Kondratiuk taras.kondrat...@linaro.org
Date: Wed Dec 3 11:22:19 2014 +0200
validation: queue: reuse common main() function
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Mike Holmes
Sent: Thursday, December 11, 2014 12:01 AM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [PATCH] api: doxygen: test_odp_sys_cpu_model_str
Specify
Looks like no objections and it's ok to merge.
Maxim.
On 12/09/2014 05:44 PM, Maxim Uvarov wrote:
Remove duplicate and trailing white spaces in generated cflags,
ldflags and etc.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
configure.ac | 10 ++
1 file changed, 10
On Thu, Dec 11, 2014 at 05:00:44AM +, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v3 removes RFC, incorporates bug fixes from Stuart, and doxygen
usage recommendations fram Anders and Petri
example/generator/odp_generator.c | 82
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Stuart Haslam
Sent: Thursday, December 11, 2014 3:01 PM
To: Bill Fischofer
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCHv3] Implement v0.5 level
On 2014-12-09 16:38, Maxim Uvarov wrote:
if $AM_LDFLAGS is empty then libs output shifted with white-spaces
according to other prints. Also line up ld and clfags.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
configure.ac | 6 +++---
1 file changed, 3 insertions(+), 3
I agree on the name confusion. I hadn't noticed that before but will
change it.
Yes, the returned packet segment lengths are always limited to the actual
length of the frame. The latest code should be doing that. If it isn't,
that's a bug that I'll fix.
Bill
On Thu, Dec 11, 2014 at 7:10 AM,
On 12/11/2014 04:12 PM, Anders Roxell wrote:
On 2014-12-09 16:38, Maxim Uvarov wrote:
if $AM_LDFLAGS is empty then libs output shifted with white-spaces
according to other prints. Also line up ld and clfags.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
configure.ac | 6 +++---
1
Merged. With removing one empty line as discussed with Anders.
Maxim.
On 12/09/2014 05:44 PM, Maxim Uvarov wrote:
Remove duplicate and trailing white spaces in generated cflags,
ldflags and etc.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
configure.ac | 10 ++
1 file
On Wed, Dec 10, 2014 at 8:14 PM, Mike Holmes mike.hol...@linaro.org wrote:
Currently a test can fail tests_gloabl_init without indicating to the user.
This patch ensures that an indication is always given via stdout.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
Reviewed-by: Ciprian Barbu
See [rk] below.
-Original Message-
From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org]
Sent: Wednesday, December 10, 2014 7:12 PM
To: Robbie King (robking); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [RFC v2 3/3] Update IPsec example app to use new
completion event
On Thu, Dec 11, 2014 at 9:21 AM, Jerin Jacob
jerin.ja...@caviumnetworks.com wrote:
On Wed, Dec 10, 2014 at 07:12:43PM +0200, Ciprian Barbu wrote:
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
v3:
- changes after Mike's review
- removed duplicate check of end of test in
On 12/11/2014 04:25 PM, Robbie King (robking) wrote:
See [rk] below.
-Original Message-
From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org]
Sent: Wednesday, December 10, 2014 7:12 PM
To: Robbie King (robking); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [RFC v2 3/3]
Ahh, now I see what you mean. Good catch.
-Original Message-
From: Taras Kondratiuk [mailto:taras.kondrat...@linaro.org]
Sent: Thursday, December 11, 2014 9:39 AM
To: Robbie King (robking); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [RFC v2 3/3] Update IPsec example app to use new
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
v4:
- fixes after Jerin's comments
- removed tests_global_init and made it suite init function
v3:
- changes after Mike's review
- removed duplicate check of end of test in schedule_common_
v2:
- rebased against ODP tip
- fixed some
Changed CFLAGS to CPPFLAGS in relevant places to remove the warnings:
configure: WARNING: CUnit/Basic.h: accepted by the compiler, rejected
by the preprocessor!
configure: WARNING: CUnit/Basic.h: proceeding with the compiler's
result
Reported-by: Mike Holmes mike.hol...@linaro.org
Signed-off-by:
Make sure all of CFLAGS/CPPFLAGS/LDFLAGS are passed through to automake
fron configure.
Previously only CFLAGS was passed through.
Signed-off-by: Anders Roxell anders.rox...@linaro.org
---
configure.ac | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure.ac b/configure.ac
index
Remove warnings and and pass through user set flags
Anders Roxell (3):
configure.ac: remove cunit warning
configure.ac: pass through user set CPP/LD-FLAGS
configure.ac: print all flags at end of configure
configure.ac | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
Makes it more obvious to the user what flags are set and by which means
(AM_*/LIBS is set by configure's internals, the others by the user).
Signed-off-by: Anders Roxell anders.rox...@linaro.org
---
configure.ac | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configure.ac b/configure.ac
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
v4:
- fixes after Jerin's comments
- removed tests_global_init and made it suite init function
v3:
- changes after Mike's review
- removed duplicate check of end of test in schedule_common_
v2:
- rebased against ODP tip
- fixed some
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Bill Fischofer
Sent: Thursday, December 11, 2014 7:00 AM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [PATCHv4] Implement v0.5 buffer pool APIs
Signed-off-by:
https://bugs.linaro.org/show_bug.cgi?id=714
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
On 12/11/2014 04:29 PM, Robbie King (robking) wrote:
Instead of replying to all the other emails I'm just going to hit this on. :-)
I agree with Taras that we can do away with the two API calls by making ctx
a parameter value for the operation (making the completion event an output
only).
https://bugs.linaro.org/show_bug.cgi?id=975
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Assignee|mike.hol...@linaro.org |taras.kondrat...@linaro.org
On Wed, Dec 10, 2014 at 01:29:24PM +, Mike Holmes wrote:
On 10 December 2014 at 08:23, Stuart Haslam stuart.has...@arm.com wrote:
On Tue, Dec 09, 2014 at 08:05:27PM +, Mike Holmes wrote:
Works around https://bugs.linaro.org/show_bug.cgi?id=975
Signed-off-by: Mike Holmes
https://bugs.linaro.org/show_bug.cgi?id=832
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Assignee|lng-odp@lists.linaro.org|taras.kondrat...@linaro.org
https://bugs.linaro.org/show_bug.cgi?id=831
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Priority|--- |Normal
Ever
On Thu, Dec 11, 2014 at 01:13:06PM +, Bill Fischofer wrote:
I agree on the name confusion. I hadn't noticed that before but will change
it.
Yes, the returned packet segment lengths are always limited to the actual
length of the frame. The latest code should be doing that. If it
https://bugs.linaro.org/show_bug.cgi?id=787
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Summary|odp_shared_memory.c i snot |odp_shared_memory.c is not
https://bugs.linaro.org/show_bug.cgi?id=825
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Resolution|--- |WONTFIX
https://bugs.linaro.org/show_bug.cgi?id=856
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
Ever
https://bugs.linaro.org/show_bug.cgi?id=627
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.linaro.org/show_bug.cgi?id=509
--- Comment #2 from Mike Holmes mike.hol...@linaro.org ---
Need to retest with latest packet API
--
You are receiving this mail because:
You are on the CC list for the bug.___
lng-odp mailing list
On 11 December 2014 at 11:15, Stuart Haslam stuart.has...@arm.com wrote:
On Wed, Dec 10, 2014 at 01:29:24PM +, Mike Holmes wrote:
On 10 December 2014 at 08:23, Stuart Haslam stuart.has...@arm.com
wrote:
On Tue, Dec 09, 2014 at 08:05:27PM +, Mike Holmes wrote:
Works around
On Thu, Dec 11, 2014 at 9:52 AM, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Bill Fischofer
Sent: Thursday, December 11, 2014 7:00 AM
https://bugs.linaro.org/show_bug.cgi?id=787
Ola Liljedahl ola.liljed...@linaro.org changed:
What|Removed |Added
CC|
On 11 December 2014 at 10:43, Ciprian Barbu ciprian.ba...@linaro.org
wrote:
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
Reviewed-by: Mike Holmes mike.hol...@linaro.org
My issues are covered, we will need to implement the clean up to compliment
schd_suite_init, once those APIs are
On 11 December 2014 at 07:13, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Mike Holmes
Sent: Thursday, December 11, 2014 12:01 AM
To:
On 11 December 2014 at 04:36, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Are these cunit tests for odp_atomic.h only?
Are there any cunit tests for plain spin locks, ticket locks, rwlocks etc?
Yes, Mario has Barrys code as the basis.
-- Ola
On 10 December 2014 at 20:42, Mike Holmes
On 12/11/2014 07:00 AM, Bill Fischofer wrote:
+odp_buffer_pool_t odp_buffer_pool_create(const char *name,
+ odp_shm_t shm,
+ odp_buffer_pool_param_t *params)
{
- odp_buffer_chunk_hdr_t *chunk_hdr;
-
-
However, your comments as well as Taras' observations prompted a more
thorough review of the segment API implementations and I've corrected a
number of flaws that will be part of the v4 packet patch I'll post this
evening.
Thanks.
Bill
On Thu, Dec 11, 2014 at 10:24 AM, Stuart Haslam
Packet pools support segmentation, however not in v0.5 because
odp_packet_socket.c can't deal with segmented I/O so there is currently no
way to Rx or Tx a segmented packet. This needs to be addressed prior to
v1.0.
This is the reason why ODP_CONFIG_PACKET_BUF_LEN_MIN is set to 1664 in
v0.5, so
On 12/12/2014 12:10 AM, Bill Fischofer wrote:
Packet pools support segmentation, however not in v0.5 because
odp_packet_socket.c can't deal with segmented I/O so there is currently
no way to Rx or Tx a segmented packet. This needs to be addressed prior
to v1.0.
This is the reason why
That is correct. The API is what's in odp_packet.h. Linux-generic
supports all of these APIs, however we don't have the ability to do I/O on
segmented packets (yet) in linux-generic, hence the default segment size I
noted.
Bill
On Thu, Dec 11, 2014 at 4:45 PM, Taras Kondratiuk
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v4 Incorporates the following changes
- Doxygen cleanup to standardize @return/@retval usage
- Fix bugs in odp_packet_seg_len(), odp_packet_seg_data_len(),
- and other segment-oriented routines reported by Stuart and Taras
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v5 Incorporates documentation changes to standardize @return/@retval usage
and correct miscellaneous typos. No code changes in this revision.
v4 Removes RFC, incorporates doxygen change recommended by Anders and Petri
and incorporates
On Thursday 11 December 2014 09:41 PM, Taras Kondratiuk wrote:
On 12/11/2014 04:29 PM, Robbie King (robking) wrote:
Instead of replying to all the other emails I'm just going to hit this on. :-)
I agree with Taras that we can do away with the two API calls by making ctx
a parameter value for
Remove odp_atomic_test in test/api_test and add the odp_atomic_test
to test/validation as one part of odp syncronizers
Signed-off-by: Yan Songming yan.songm...@linaro.org
---
test/api_test/Makefile.am | 5 +-
test/api_test/odp_atomic_test.c| 299
57 matches
Mail list logo
