Re: [lng-odp] [PATCH v2] helper: convert to a library

2015-07-08 Thread Maxim Uvarov
On 07/07/15 21:20, Mike Holmes wrote: On 7 July 2015 at 06:34, Maxim Uvarov maxim.uva...@linaro.org mailto:maxim.uva...@linaro.org wrote: this path install helper headers to /usr/include that is not correct. Right place is /usr/include/odp/helper due to 2 reasons: 1. be

Re: [lng-odp] [PATCH 0/6] validation: module system created

2015-07-08 Thread Christophe Milard
sorry for the spelling errors. Have to check why this was not detected here. Fixed. Will send a Pull request with those. Christophe. On 8 July 2015 at 14:31, Stuart Haslam stuart.has...@linaro.org wrote: On Fri, Jul 03, 2015 at 01:49:33PM +0200, Christophe Milard wrote: To be applied on top

Re: [lng-odp] [PATCH 0/4] validation: new module errno

2015-07-08 Thread Stuart Haslam
On Thu, Jul 02, 2015 at 04:40:17PM +0200, Christophe Milard wrote: Errno, previously part of module ver_abt_log_dbg is now separated as its own module, and gets through the normal changes to conform to the new test structure (lib...) and naming convention. Christophe Milard (4):

Re: [lng-odp] [PATCH 0/4] validation: shmem tests moved to platform side

2015-07-08 Thread Stuart Haslam
On Fri, Jul 03, 2015 at 04:27:32PM +0200, Christophe Milard wrote: Shared memory tests are now converted as well, and eventually called from the platform side. to be applied on top of: validation: module system created Christophe Milard (4): validation: own main in odp_shared_memory.c

Re: [lng-odp] [PATCH 3/5] validation: cosmetic changes in odp_timer.c

2015-07-08 Thread Stuart Haslam
On Fri, Jul 03, 2015 at 05:45:38PM +0200, Christophe Milard wrote: As preparation before moving the file (next patch) where the whole file will be checked again by check-patch called via check-odp. Some warnings remains about missing blank lines, after variable declarations, but it would not

Re: [lng-odp] Generator

2015-07-08 Thread Steve McIntyre
[ adding cc to lng-odp ] On Mon, Jul 06, 2015 at 06:59:01PM +0100, Steve McIntyre wrote: In terms of automation... I've got the meat of a multi-node LAVA test setup ready in git now, and it's currently running odp_generator between 2 x86 machines. It's not very useful for several reasons. The

Re: [lng-odp] [PATCH 3/5] validation: cosmetic changes in odp_timer.c

2015-07-08 Thread Christophe Milard
It did warn me. This is the reason why I broke some of these lines when it looked reasonable. What do you wish me to do? Christophe. On 8 July 2015 at 14:31, Stuart Haslam stuart.has...@linaro.org wrote: On Fri, Jul 03, 2015 at 05:45:38PM +0200, Christophe Milard wrote: As preparation before

Re: [lng-odp] [PATCH 3/5] validation: cosmetic changes in odp_timer.c

2015-07-08 Thread Stuart Haslam
On Wed, Jul 08, 2015 at 02:37:01PM +0200, Christophe Milard wrote: It did warn me. This is the reason why I broke some of these lines when it looked reasonable. What do you wish me to do? Not wrap the line in the two places I highlighted. As a secondary thing we should also look into why

Re: [lng-odp] [PATCH] validation: renaming system to time

2015-07-08 Thread Stuart Haslam
On Thu, Jul 02, 2015 at 05:43:25PM +0200, Christophe Milard wrote: Module system (which just contained time tests) is now logicaly renamed time. The renaming includes files and function names, to match test conventions. Signed-off-by: Christophe Milard christophe.mil...@linaro.org

Re: [lng-odp] [PATCH 0/6] validation: module system created

2015-07-08 Thread Stuart Haslam
On Fri, Jul 03, 2015 at 01:49:33PM +0200, Christophe Milard wrote: To be applied on top of patch validation: new module errno Module system is now created from odp_ver_abt_log_dbg (which only contains system tests), then tests for system go through the same modification as pktio, and gets

Re: [lng-odp] Generator

2015-07-08 Thread Maxim Uvarov
On 8 July 2015 at 15:31, Steve McIntyre steve.mcint...@linaro.org wrote: [ adding cc to lng-odp ] On Mon, Jul 06, 2015 at 06:59:01PM +0100, Steve McIntyre wrote: In terms of automation... I've got the meat of a multi-node LAVA test setup ready in git now, and it's currently running

[lng-odp] [PATCHv2 2/3] linux-generic: pktio: handle segmented packet in socket mode

2015-07-08 Thread Nicolas Morey-Chaisemartin
Fixes bug #1670 Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- platform/linux-generic/odp_packet_socket.c | 74 +++--- 1 file changed, 58 insertions(+), 16 deletions(-) diff --git a/platform/linux-generic/odp_packet_socket.c

[lng-odp] [PATCHv2 1/3] linux-generic: pktio: remove basic socket implementation

2015-07-08 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- example/generator/odp_generator.c | 1 - example/packet/odp_pktio.c | 1 - .../linux-generic/include/odp_packet_io_internal.h | 3 +- platform/linux-generic/odp_packet_io.c |

[lng-odp] [PATCHv2 3/5] validation: cosmetic changes in odp_timer.c

2015-07-08 Thread Christophe Milard
As preparation before moving the file (next patch) where the whole file will be checked again by check-patch called via check-odp. Some warnings remains about missing blank lines, after variable declarations, but it would not add to readibility when the variables are declared in the function's

[lng-odp] [PATCHv2 4/5] validation: creating own dir and lib for timer

2015-07-08 Thread Christophe Milard
Signed-off-by: Christophe Milard christophe.mil...@linaro.org --- configure.ac | 1 + test/validation/.gitignore | 1 - test/validation/Makefile.am| 12 ++-- test/validation/timer/.gitignore | 2 ++

[lng-odp] [PATCHv2 3/3] test: pktio: add tests for segmented packets

2015-07-08 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- test/validation/pktio/pktio.c | 99 ++- 1 file changed, 89 insertions(+), 10 deletions(-) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 82ced5c..213d365

[lng-odp] [PATCHv2 2/5] validation: renaming in odp_timer.c

2015-07-08 Thread Christophe Milard
Renaming of things which may be, one day, exported in a lib. This renaming is important, as it creates consistency between test symbols, which is needed if things get eventually exported in the lib. Also, tests are often created from other tests: Fixing the first exemples will help geting future

[lng-odp] [PATCHv2 0/3] Remove basic pktio sock and support segmented packet

2015-07-08 Thread Nicolas Morey-Chaisemartin
Pretty much the same patch as before except for the test part. There are now 3 test suite in the pktio test: * Standard one * Segmented for regular packets (No Jumbo) * Segmented Jumbo packet (unsegmented regular) The pool have different name at each run so people who don't support pool_destroy

Re: [lng-odp] [API-NEXT PATCH 01/11] api: sched: removed SYNC_DEFAULT

2015-07-08 Thread Maxim Uvarov
Merged to api-next. Used updated v2 3/11 patch from BIll. Thanks, Maxim. On 07/02/15 15:45, Petri Savolainen wrote: User should pick a synchronisation method and use SYNC_NONE if does not need synchronization. Signed-off-by: Petri Savolainen petri.savolai...@nokia.com ---

[lng-odp] [PATCHv2 1/5] validation: own main in odp_timer.c

2015-07-08 Thread Christophe Milard
Signed-off-by: Christophe Milard christophe.mil...@linaro.org Reviewed-by: Stuart Haslam stuart.has...@linaro.org --- test/validation/Makefile.am | 2 ++ test/validation/odp_timer.c | 15 +-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/test/validation/Makefile.am

[lng-odp] [PATCHv2 0/5] tests for timer moved to plt side

2015-07-08 Thread Christophe Milard
since V1: -removed line split according to Stuart comment. -a bit of cleanup in Makefile.am to avoid bootstrap warnings. To be applied on top of patch for shmem (validation: shmem tests moved to platform side). Tests for timer now go through the same modification as pktio, and gets finally called

Re: [lng-odp] [PATCH v2] helper: convert to a library

2015-07-08 Thread Mike Holmes
On 8 July 2015 at 07:28, Maxim Uvarov maxim.uva...@linaro.org wrote: On 07/07/15 21:20, Mike Holmes wrote: On 7 July 2015 at 06:34, Maxim Uvarov maxim.uva...@linaro.org mailto: maxim.uva...@linaro.org wrote: this path install helper headers to /usr/include that is not correct.

Re: [lng-odp] [PATCH] linux-generic: packet: fix byte order in IPv6 header parsing

2015-07-08 Thread Maxim Uvarov
Merged, Thanks, Maxim. On 07/07/15 19:21, Bill Fischofer wrote: On Tue, Jul 7, 2015 at 10:05 AM, Michael Altizer xi...@verizon.net mailto:xi...@verizon.net wrote: Signed-off-by: Michael Altizer xi...@verizon.net mailto:xi...@verizon.net Reviewed-by: Bill Fischofer

Re: [lng-odp] [PATCHv2 0/5] tests for timer moved to plt side

2015-07-08 Thread Stuart Haslam
On Wed, Jul 08, 2015 at 04:11:36PM +0200, Christophe Milard wrote: since V1: -removed line split according to Stuart comment. -a bit of cleanup in Makefile.am to avoid bootstrap warnings. To be applied on top of patch for shmem (validation: shmem tests moved to platform side). Tests for

[lng-odp] [PATCHv2 5/5] validation: call to timer_main from platform

2015-07-08 Thread Christophe Milard
timer_main is now ran from the platform side. As timer tests do not have any platform dependency, the call to the platform agnostic tests is performed directly in the Makefele.am (TESTS). Signed-off-by: Christophe Milard christophe.mil...@linaro.org Reviewed-by: Stuart Haslam

[lng-odp] api: api-next - master merge: pktio clarification

2015-07-08 Thread Maxim Uvarov
Cherry-picked following patches to master: e4ccaec (HEAD, danger3/master, master) event: implement odp_event_free() 8088898 api: event: define odp_event_free() 561b327 packet_io: release unsent packets after odp_pktio_send() 089c4e1 packet_socket: do not release packets in odp_pktio_send

[lng-odp] Pull request: validation last modules from platform side

2015-07-08 Thread Christophe Milard
Hi Maxim, Hope this is what you need for a proper pull request. Let me know if anything is wrong/could be improved in this pull-req. All these patches have been reviewed by Stuart and do -hopefully- not contain any big surprises. just the continuation of the run from platform side for the last

Re: [lng-odp] [PATCH] doc: doxygen: Add Converter function guidelines

2015-07-08 Thread Bill Fischofer
On Wed, Jul 8, 2015 at 12:23 PM, Mike Holmes mike.hol...@linaro.org wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org Reviewed-by: Bill Fischofer bill.fischo...@linaro.org --- doc/api_guide_lines.dox | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [lng-odp] [API-NEXT PATCH RFC] api: packet: add optional persistent metadata

2015-07-08 Thread Zoltan Kiss
On 03/07/15 09:05, Savolainen, Petri (Nokia - FI/Espoo) wrote: Maybe it's better to add this into packet pool parameters. Usage of build time config macros should be minimized in the future. Sounds OK, but we'll need an accessor which tells this based on packet, so it could be easily

[lng-odp] [PATCH] doc: doxygen: Add Converter function guidelines

2015-07-08 Thread Mike Holmes
Signed-off-by: Mike Holmes mike.hol...@linaro.org --- doc/api_guide_lines.dox | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/api_guide_lines.dox b/doc/api_guide_lines.dox index f3f7799..c544afd 100644 --- a/doc/api_guide_lines.dox +++ b/doc/api_guide_lines.dox @@ -100,6

Re: [lng-odp] [API-NEXT PATCH 1/3] api: classification: add ODP_PMR_OFFSET_ABS

2015-07-08 Thread Bala Manoharan
On 7 July 2015 at 18:34, BenoƮt Ganne bga...@kalray.eu wrote: In this case of ABS_OFFSET_L2 failure during creation is better as the application can better handle the code for different implementations supporting different number of OFFSET term values rather than failing in the context in

[lng-odp] [API-NEXT PATCH v6] queue: handle return value of odp_queue_enq_multi()

2015-07-08 Thread Zoltan Kiss
Unsent packet has to be released. If the event type is obvious from the context, use directly the relevant release functions, otherwise odp_event(free). Wider error handling is attempted, but this patch can't fix all the flaws in the many calling functions of odp_queue_enq() Signed-off-by: Zoltan

[lng-odp] [PATCH] linux-generic: types: increase alignment of odp_handle_t to avoid lint issues

2015-07-08 Thread Bill Fischofer
ODP handles are abstract types however because compilers see their implementation they assume these have alignments that can result in false lint warnings. Increasing the apparent alignment to uint64_t removes these. It has no effect on ODP operation or performance. Signed-off-by: Bill Fischofer

[lng-odp] [API-NEXT PATCH 1/2] api: thread: thrmask use uint_32_t

2015-07-08 Thread Mike Holmes
The thrmask apis do not return an error, use unsigned Signed-off-by: Mike Holmes mike.hol...@linaro.org --- include/odp/api/thrmask.h | 4 ++-- platform/linux-generic/odp_thread.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/odp/api/thrmask.h

[lng-odp] [API-NEXT PATCH 2/2] validation: thread: test thrmask

2015-07-08 Thread Mike Holmes
Signed-off-by: Mike Holmes mike.hol...@linaro.org --- test/validation/thread/thread.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/test/validation/thread/thread.c b/test/validation/thread/thread.c index d0bd75e..d5609a2 100644 ---