On 07/09/15 16:43, Mike Holmes wrote:
Subject should localize to the specific example
example: generator: print correct appl_mode
On 9 July 2015 at 09:32, Balakrishna.Garapati
balakrishna.garap...@linaro.org
mailto:balakrishna.garap...@linaro.org wrote:
Signed-off-by:
From: Bill Fischofer bill.fischo...@linaro.org
This patch removes the 2nd parameter to odp_pool_create() because it has two
major issues:
1. Applications have no way to know how big a shm area is required for a given
pool since that information is implementation specific. So there's no portable
Merged, thanks,
Maxim.
On 07/09/15 16:56, Bill Fischofer wrote:
On Thu, Jul 9, 2015 at 3:56 AM, Nicolas Morey-Chaisemartin
nmo...@kalray.eu mailto:nmo...@kalray.eu wrote:
Signed-off-by: Benoît Ganne benoit.ga...@kalray.eu
mailto:benoit.ga...@kalray.eu
Reviewed-by: Nicolas
From: Petri Savolainen petri.savolai...@nokia.com
The call sets all possible CPUs in the mask. It's system specific which
CPUs are actually available to the application.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Reviewed-by: Christophe Milard christophe.mil...@linaro.org
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
---
since v1: changed the commit message
example/generator/odp_generator.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/example/generator/odp_generator.c
b/example/generator/odp_generator.c
index
Wrong version. Sent an other patch with correct version v2. Ignore this
patch.
/Krishna
On 9 July 2015 at 16:00, Balakrishna.Garapati
balakrishna.garap...@linaro.org wrote:
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
---
example/generator/odp_generator.c | 6 --
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
---
example/generator/odp_generator.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/example/generator/odp_generator.c
b/example/generator/odp_generator.c
index 0ff264c..15de035 100644
---
From: Petri Savolainen petri.savolai...@nokia.com
Added default cpumask functions for worker and control threads.
These will replace odph_linux_cpumask_default() helper. CPU masks
and IDs are system specific, API is generic.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Reviewed-by:
From: Petri Savolainen petri.savolai...@nokia.com
The linux specific helper was replaced by default cpumask
calls (odp_cpumask_def_worker()) in the cpumask API.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Reviewed-by: Christophe Milard christophe.mil...@linaro.org
Signed-off-by:
On Thu, Jul 9, 2015 at 3:56 AM, Nicolas Morey-Chaisemartin nmo...@kalray.eu
wrote:
Signed-off-by: Benoît Ganne benoit.ga...@kalray.eu
Reviewed-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
test/performance/odp_pktio_perf.c | 2
From: Petri Savolainen petri.savolai...@nokia.com
Thread IDs and masks are used to control thread access to various
resources. Linux generic implementation reuse cpumask implementation.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
From: Petri Savolainen petri.savolai...@nokia.com
Cleaned Doxygen documentation grouping. Corrected wrong
groupings and created new groups when needed.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
Signed-off-by: Maxim Uvarov
From: Petri Savolainen petri.savolai...@nokia.com
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Reviewed-and-tested-by: Bill Fischofer bill.fischo...@linaro.org
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_thread.c | 28
https://bugs.linaro.org/show_bug.cgi?id=1670
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Status|UNCONFIRMED |IN_PROGRESS
https://bugs.linaro.org/show_bug.cgi?id=1337
Bill Fischofer bill.fischo...@linaro.org changed:
What|Removed |Added
CC|
From: Petri Savolainen petri.savolai...@nokia.com
Linux generic thread mask handling uses thrmask API. Added
worker and control masks for easy implementation of functions
returning those masks.
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Reviewed-and-tested-by: Bill Fischofer
https://bugs.linaro.org/show_bug.cgi?id=1615
--- Comment #2 from Mike Holmes mike.hol...@linaro.org ---
Ivan posted patches http://patches.opendataplane.org/patch/2097/
--
You are receiving this mail because:
You are on the CC list for the bug.___
https://bugs.linaro.org/show_bug.cgi?id=1608
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.linaro.org/show_bug.cgi?id=1001
--- Comment #11 from Mike Holmes mike.hol...@linaro.org ---
Will close this next week if there is no update
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the
https://bugs.linaro.org/show_bug.cgi?id=1615
--- Comment #3 from Mike Holmes mike.hol...@linaro.org ---
Ivan posted patches http://patches.opendataplane.org/patch/2097/
--
You are receiving this mail because:
You are on the CC list for the bug.___
On Thu, Jul 09, 2015 at 11:25:30AM +0200, Christophe Milard wrote:
A few things that were needed when old-style modules (called directely
from the validation side) and new-style modules (lib and platform calls)
were both in use can now be cleaned up.
To be applied once all modules have been
https://bugs.linaro.org/show_bug.cgi?id=1548
--- Comment #2 from Bill Fischofer bill.fischo...@linaro.org ---
Bug fixed by commit f4b93abaa3e2ac6af6fe75209a4f6622f5d68e1e by Michael Altizer
--
You are receiving this mail because:
You are on the CC list for the
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/classification/classification.c| 2 +-
test/validation/classification/classification.h| 31 ++
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/pktio/pktio.c | 32
test/validation/pktio/pktio.h | 27 +++
2 files changed, 43 insertions(+), 16
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/thread/thread.c | 10 +-
test/validation/thread/thread.h | 14 ++
2 files changed, 19 insertions(+), 5 deletions(-)
diff --git
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/crypto/crypto.c | 6 +++---
test/validation/crypto/crypto.h | 24
test/validation/crypto/odp_crypto_test_inp.c |
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/init/init.c | 18 +-
test/validation/init/init.h | 18 ++
2 files changed, 27 insertions(+), 9 deletions(-)
diff --git
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/buffer/buffer.c | 14 +++---
test/validation/buffer/buffer.h | 18 ++
2 files changed, 25 insertions(+), 7 deletions(-)
diff --git
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/shmem/shmem.c | 6 +++---
test/validation/shmem/shmem.h | 12
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/time/time.c | 8
test/validation/time/time.h | 14 ++
2 files changed, 18 insertions(+), 4 deletions(-)
diff --git
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/timer/timer.c | 12 ++--
test/validation/timer/timer.h | 15 +++
2 files changed, 21 insertions(+), 6 deletions(-)
diff --git
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/queue/queue.c | 10 +-
test/validation/queue/queue.h | 16
2 files changed, 21 insertions(+), 5 deletions(-)
diff --git
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/packet/packet.c | 44 -
test/validation/packet/packet.h | 33 +++
2 files changed, 55
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/pool/pool.c | 14 +++---
test/validation/pool/pool.h | 16
2 files changed, 23 insertions(+), 7 deletions(-)
diff --git
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/cpumask/cpumask.c | 32
test/validation/cpumask/cpumask.h | 25 +
2 files changed, 41 insertions(+), 16
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/synchronizers/synchronizers.c | 44 +--
test/validation/synchronizers/synchronizers.h | 35 +
2 files changed, 57
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/system/system.c | 18 +-
test/validation/system/system.h | 18 ++
2 files changed, 27 insertions(+), 9 deletions(-)
diff --git
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/scheduler/scheduler.c | 68 +--
test/validation/scheduler/scheduler.h | 45 +++
2 files changed, 79
test symbols are now exported in the module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/random/random.c | 6 +++---
test/validation/random/random.h | 12
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git
This series of patch populate the module test libraries
with the related test symbols.
Christophe Milard (17):
validation: synchronizers: lib populated
validation: crypto: lib populated
validation: shmem: lib populated
validation: init: lib populated
validation: buffer: lib populated
Patch set merged!
Maxim.
On 07/09/15 12:43, Nicolas Morey-Chaisemartin wrote:
Few merge conflicts with our branch (none your fault) but all the tests are
still OK.
I'm good with this on the functional side anyway. I haven't taken the time to
check all the patches individually.
Nicolas
On
From: Hongbo Zhang hongbo.zh...@linaro.org
Previous patch makes varible model_str to array model_str[] to contain data
for each CPU on AMP platforms, and then this patch adds new API to get the
corresponding model string for each CPU indexed by CPU ID.
Signed-off-by: Hongbo Zhang
From: Hongbo Zhang hongbo.zh...@linaro.org
For AMP system such as ARM big.LITTLE, cores are heterogeneous, and cpu_hz
for each core may be different too, so this patch changes the cpu_hz to
data array cpu_hz[] to contain data for each different core, while for the
common SMP system, we can simply
From: Hongbo Zhang hongbo.zh...@linaro.org
Currently the API to get CPU frequency is vague, it needs to be clarified
whether max or current frequency is returned, and now most use cases want
to get max capacity of CPU in fact, so this patch makes it clear that the
cpu_hz stand for max CPU
From: Hongbo Zhang hongbo.zh...@linaro.org
Previous CPU frequency API is adapted to return max frequency, now new
APIs are added for getting the current CPU frequency.
odp_cpu_id_hz(int id) returns frequency of the CPU specified by parameter
id, while odp_cpu_hz() returns frequency of the CPU on
Merged,
thanks,
Maxim.
On 07/06/15 22:02, Mike Holmes wrote:
On 6 July 2015 at 14:04, Anders Roxell anders.rox...@linaro.org
mailto:anders.rox...@linaro.org wrote:
Signed-off-by: Anders Roxell anders.rox...@linaro.org
mailto:anders.rox...@linaro.org
Reviewed-by: Mike Holmes
From: Hongbo Zhang hongbo.zh...@linaro.org
v2 - v3 changes:
- move all CPU related API declaration into cpu.h
- refine tests for per-CPU APIs
- revise API for getting current frequency
v1 - v2 changes:
- separate original 1/3 patch to two
- add validation patch to test new APIs
- other minor
From: Hongbo Zhang hongbo.zh...@linaro.org
For AMP system such as ARM big.LITTLE, cores are heterogeneous, and the
model_str for each core may be different too, so this patch changes the
model_str to data array model_str[] to contain data for each different
core, while for the common SMP system,
From: Hongbo Zhang hongbo.zh...@linaro.org
Previous patch makes varible cpu_hz to array cpu_hz[] to contain data for
each CPU on AMP platforms, and then this patch adds new API to get the
corresponding max frequency for each CPU indexed by CPU ID.
Signed-off-by: Hongbo Zhang
From: Hongbo Zhang hongbo.zh...@linaro.org
This patch moves all CPU realted APIs to the cpu.h, they are:
odp_sys_cpu_hz() and odp_sys_cpu_model_str(), and accordingly rename
them to odp_cpu_hz() and odp_cpu_model_str(),
All the calling functions are updated too.
New APIs for AMP system will be
From: Hongbo Zhang hongbo.zh...@linaro.org
This patch adds test for the newly introduced per-CPU system APIs:
new per-CPU APIs: odp_cpu_id_hz_max(), odp_cpu_id_model_str()
abd new crurrent frequency APIs: odp_cpu_hz(), odp_cpu_id_hz()
Signed-off-by: Hongbo Zhang hongbo.zh...@linaro.org
add
---
The validation/Makefile.am is now simply calling the Makefile of
each module and many older things can be cleaned-up from it.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
since v1: rebased.
To be applied once all modules have been converted to be called from
the platform
On 8 July 2015 at 23:20, Mike Holmes mike.hol...@linaro.org wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/thread/thread.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/test/validation/thread/thread.c
Signed-off-by: Benoît Ganne benoit.ga...@kalray.eu
Reviewed-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu
---
test/performance/odp_pktio_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/performance/odp_pktio_perf.c
b/test/performance/odp_pktio_perf.c
index
Good point. Yes, the circular dependencies are problematic and there's
also the question of casting to different object types which might have
differing alignments. The simplest solution is the (void *) intermediate
cast in those specific cases.
So please ignore this patch. I'll post the other
Merged,
Thanks,
Maxim.
On 07/06/15 22:13, Mike Holmes wrote:
Remove the need to build helper source files into the linux-generic
library by converting helpers to be their own library.
This removes the need for all other platforms to also build in the
helpers which are optional just to run the
Removal of the weak definitions of global_test_init and global_test_term.
This removes the last shared symbols between tests and therefore gives
the possibility to create a test superlib containing all tests of
all modules, if so wished.
Also, it forces the definition of these functions into each
A few things that were needed when old-style modules (called directely
from the validation side) and new-style modules (lib and platform calls)
were both in use can now be cleaned up.
To be applied once all modules have been converted to be called from
the platform side, i.e. after pull request:
The obsolete symbol odp_testsuites is no longer used and therefore removed.
Suite arrays are now called Module_suites[_*], and are part of each
module lib.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/common/odp_cunit_common.h | 7 ---
1 file changed, 7
Now that all modules defines their own main(), the dual
library builds for cunit_common (one with main(), the other without)
is no longer needed. It is therefore removed.
Signed-off-by: Christophe Milard christophe.mil...@linaro.org
---
test/validation/common/Makefile.am| 8 ++--
Few merge conflicts with our branch (none your fault) but all the tests are
still OK.
I'm good with this on the functional side anyway. I haven't taken the time to
check all the patches individually.
Nicolas
On 07/08/2015 05:07 PM, Christophe Milard wrote:
Hi Maxim,
Hope this is what you
I'm not sure it's sufficient enough. What happens if you cast the type
into something which is not 8 byte aligned, but bigger? The example Mike
saw was in ODP-DPDK CI:
18:50:48 ./include/odp_pool_internal.h:92:9: error: cast from
'odp_buffer_t' (aka 'struct (anonymous at
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
---
example/generator/odp_generator.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/example/generator/odp_generator.c
b/example/generator/odp_generator.c
index 0ff264c..15de035 100644
---
Subject should localize to the specific example
example: generator: print correct appl_mode
On 9 July 2015 at 09:32, Balakrishna.Garapati
balakrishna.garap...@linaro.org wrote:
Signed-off-by: Balakrishna.Garapati balakrishna.garap...@linaro.org
With fixed subject message
Reviewed-by: Mike
Following patches are planned to be merged from api-next to
master to be included for next point release 1.2. The major
reason is to unblock dpdk with creating worker threads and
pool creation without providing shared memory to it.
If no objection in 24 hours I'm going to merge that patches.
From: Petri Savolainen petri.savolai...@nokia.com
Two thread types are defined: worker and control threads. API calls from
a worker thread should be throughput and latency optimized, while the
second one is not so sensitive to call overheads and latency.
Signed-off-by: Petri Savolainen
From: Petri Savolainen petri.savolai...@nokia.com
User needs to select the thread type (worker or control) of
the initialized thread. Implementation may reserve HW direct access
only to worker threads, while control threads share HW access, etc.
Signed-off-by: Petri Savolainen
Stuart: Can you review that obvious one as well? It belongs to the clean-up
stuff as well...
Thanks
/Christophe.
On 9 July 2015 at 09:30, Christophe Milard christophe.mil...@linaro.org
wrote:
The validation/Makefile.am is now simply calling the Makefile of
each module and many older things
https://bugs.linaro.org/show_bug.cgi?id=1337
--- Comment #5 from Christophe Milard christophe.mil...@linaro.org ---
The function cpumask_setall() (in api-next) now returns a mask with all bit set
in the mask and can therefore be used.
--
You are receiving this mail because:
You are the assignee
https://bugs.linaro.org/show_bug.cgi?id=1632
Mike Holmes mike.hol...@linaro.org changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
https://bugs.linaro.org/show_bug.cgi?id=1001
Bill Fischofer bill.fischo...@linaro.org changed:
What|Removed |Added
CC|
From: Petri Savolainen petri.savolai...@nokia.com
Signed-off-by: Petri Savolainen petri.savolai...@nokia.com
Reviewed-and-tested-by: Bill Fischofer bill.fischo...@linaro.org
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_thread.c | 5 +
1 file changed, 5
PRINT_APPL_MODE prints #mode (string) mode (0,1 or 2). if we pass
appl_args-mode, it prints this as a string instead of ex: APPL_MODE_PING.
On 9 July 2015 at 15:48, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 07/09/15 16:43, Mike Holmes wrote:
Subject should localize to the specific
73 matches
Mail list logo
