Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-13 Thread Maxim Uvarov
Merged, we also need this option to be tested in CI. Maxim. On 10/12/16 18:21, Bill Fischofer wrote: This version resolves the issue with running from an installed copy of ODP. On Thu, Sep 29, 2016 at 6:46 PM, Petri Savolainen < petri.savolai...@nokia.com> wrote: Building ABI compatible or

[lng-odp] [PATCHv2] test: skip pktio_perf tests on 1 and 2 cpus machines

2016-10-13 Thread Maxim Uvarov
Make check should skip the test instead of failing it. Test splits RX and TX cores for packet processing. Core 0 bind to control thread. So running machine should have at least 2 worker threads which is not enough on 1 and 2 cpus machine. CUnit uses special value 77 to mark test as SKIPPED and not

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-13 Thread Mike Holmes
On 13 October 2016 at 12:39, Maxim Uvarov wrote: > On 10/13/16 19:33, Mike Holmes wrote: > >> Anders comments have not been addressed on the list, are they resloved ? >> >> > In current patch set - no. Because it's subject for separate patch. But we > need resolve

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-13 Thread Maxim Uvarov
On 10/13/16 19:33, Mike Holmes wrote: Anders comments have not been addressed on the list, are they resloved ? In current patch set - no. Because it's subject for separate patch. But we need resolve version name before tagging. Maxim. On 13 October 2016 at 11:40, Maxim Uvarov

Re: [lng-odp] [PATCH v2] linux-gen: build: de-couple abi compatibility from shared lib

2016-10-13 Thread Mike Holmes
Anders comments have not been addressed on the list, are they resloved ? On 13 October 2016 at 11:40, Maxim Uvarov wrote: > Merged, > > we also need this option to be tested in CI. > > Maxim. > > > On 10/12/16 18:21, Bill Fischofer wrote: > >> This version resolves the

[lng-odp] [PATCH] timers: fix off by one tick in timer expiration processing

2016-10-13 Thread Brian Brooks
A timer pool's tick starts at t0 (zero). Once the first period has passed, the timer pool is scanned for any timers that have expired since t0 + 1. Current code does an atomic fetch increment on the tick, but uses the previous tick during timer expiration processing. What is needed is the

[lng-odp] [Bug 2552] New: Timer pools expire one tick later than they should

2016-10-13 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2552 Bug ID: 2552 Summary: Timer pools expire one tick later than they should Product: OpenDataPlane - linux- generic reference Version: v1.11.0.0 Hardware: All OS: Linux

Re: [lng-odp] [PATCH] timers: fix off by one tick in timer expiration processing

2016-10-13 Thread Bill Fischofer
Since this is a bug fix, please open a Bug for it so that this can be tracked as a defect closure. On Thu, Oct 13, 2016 at 4:18 PM, Brian Brooks wrote: > A timer pool's tick starts at t0 (zero). Once the first period has passed, > the timer pool is scanned for any

Re: [lng-odp] [PATCHv2] test: skip pktio_perf tests on 1 and 2 cpus machines

2016-10-13 Thread Mike Holmes
On 13 October 2016 at 12:37, Maxim Uvarov wrote: > Make check should skip the test instead of failing it. > Test splits RX and TX cores for packet processing. Core > 0 bind to control thread. So running machine should have > at least 2 worker threads which is not enough

Re: [lng-odp] [API-NEXT PATCHv6 0/5] Add Packet Splice/Reference APIs

2016-10-13 Thread Bill Fischofer
Ping. I'd like to get some review feedback on this patch series so we can make progress on this item. I believe this reflects the basics of what we discussed at LAS16. But if the APIs need to be adjusted then what sort of adjustment is needed? Thanks. On Mon, Oct 10, 2016 at 10:45 PM, Bill

Re: [lng-odp] [API-NEXT PATCHv2 1/2] api: dev: add device apis for numa support

2016-10-13 Thread Christophe Milard
On 13 October 2016 at 02:44, Bill Fischofer wrote: > Add the odp_dev_id() API used for NUMA support > I am a bit confused here: what is a device? a numa_id or other things as well? In this patch series everything that relates to numa is called "device". Shouldn't be

Re: [lng-odp] [API-NEXT PATCHv2 1/2] api: dev: add device apis for numa support

2016-10-13 Thread Bill Fischofer
On Thu, Oct 13, 2016 at 6:33 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > On 13 October 2016 at 13:20, Bill Fischofer > wrote: > > > > > > On Thu, Oct 13, 2016 at 2:03 AM, Christophe Milard > > wrote: > >> > >> On 13

Re: [lng-odp] [API-NEXT PATCHv2 1/2] api: dev: add device apis for numa support

2016-10-13 Thread Christophe Milard
On 13 October 2016 at 13:20, Bill Fischofer wrote: > > > On Thu, Oct 13, 2016 at 2:03 AM, Christophe Milard > wrote: >> >> On 13 October 2016 at 02:44, Bill Fischofer >> wrote: >> > Add the odp_dev_id() API used

Re: [lng-odp] [API-NEXT PATCHv2 1/2] api: dev: add device apis for numa support

2016-10-13 Thread Bill Fischofer
On Thu, Oct 13, 2016 at 2:03 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > On 13 October 2016 at 02:44, Bill Fischofer > wrote: > > Add the odp_dev_id() API used for NUMA support > > > > I am a bit confused here: what is a device? a numa_id or other

[lng-odp] clarification of pktout checksum offload feature

2016-10-13 Thread Maciej Czekaj
Guys, I was going to implement checksum offload for OFP project based on Monarch checksum offload capability and I found out that there is no example for using that API. Also, documentation seams to leave some room for various interpretations, so I would like to clarify that and post a

[lng-odp] linker --whole-archive, --start-group options and noinst_RELOCATABLES

2016-10-13 Thread Christophe Milard
Hi, I am working for ODP (OpenDataPlane: http://opendataplane.org) and we are using autotools (including libtool) We want to have connectable plug-ins to implements some functions (actually user-space NIC drivers). These plug-ins would be either linked dynamicaly (using dlopen()) or staticaly, at

Re: [lng-odp] [API-NEXT PATCHv2 1/2] api: dev: add device apis for numa support

2016-10-13 Thread Christophe Milard
On 13 October 2016 at 14:06, Bill Fischofer wrote: > > > On Thu, Oct 13, 2016 at 6:53 AM, Christophe Milard > wrote: >> >> On 13 October 2016 at 13:44, Bill Fischofer >> wrote: >> > >> > >> > On Thu, Oct 13,

Re: [lng-odp] [API-NEXT PATCHv2 1/2] api: dev: add device apis for numa support

2016-10-13 Thread Christophe Milard
On 13 October 2016 at 13:44, Bill Fischofer wrote: > > > On Thu, Oct 13, 2016 at 6:33 AM, Christophe Milard > wrote: >> >> On 13 October 2016 at 13:20, Bill Fischofer >> wrote: >> > >> > >> > On Thu, Oct 13,

Re: [lng-odp] [API-NEXT PATCHv2 1/2] api: dev: add device apis for numa support

2016-10-13 Thread Bill Fischofer
On Thu, Oct 13, 2016 at 6:53 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > On 13 October 2016 at 13:44, Bill Fischofer > wrote: > > > > > > On Thu, Oct 13, 2016 at 6:33 AM, Christophe Milard > > wrote: > >> > >> On 13