Re: [lng-odp] [PATCHv3] doc: helper: add missing doxygen for helper table functions

thanks, that is good now, merged. Maxim. On 02/09/17 22:35, Bill Fischofer wrote: > Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2865 by adding > missing doxygen documentation for helper table functions > > Signed-off-by: Bill Fischofer > --- > Changes for

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

here I need to take some break. Will continue to review later in separate email... > +/** > + * Add a single fragment to a shared fraglist > + * > + * @param fl Pointer to the shared fraglist to add "frag" to > + * @param frag Pointer to the fragment to add to "fl" > + * @param

Re: [lng-odp] [PATCH] travis: catch doxygen errors

Looks reasonable On Thu, Feb 9, 2017 at 1:31 PM, Maxim Uvarov wrote: > make doxygen-doc does not return negative code on > errors. Do it manually. > > Signed-off-by: Maxim Uvarov Reviewed-by: Bill Fischofer > --- >

[lng-odp] [PATCHv3] doc: helper: add missing doxygen for helper table functions

Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2865 by adding missing doxygen documentation for helper table functions Signed-off-by: Bill Fischofer --- Changes for v3: - Change @private to @internal for compatibility with older doxygen levels

[lng-odp] [Linaro/odp] 969d1c: test: l2fwd: add pktio driver print out

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 969d1c74ef21b77df01b120297d4156b87183894 https://github.com/Linaro/odp/commit/969d1c74ef21b77df01b120297d4156b87183894 Author: Petri Savolainen Date: 2017-02-09 (Thu, 09 Feb

[lng-odp] [PATCH] travis: catch doxygen errors

make doxygen-doc does not return negative code on errors. Do it manually. Signed-off-by: Maxim Uvarov --- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 9544ec8f..954174fa 100644 --- a/.travis.yml +++

[lng-odp] [PATCHv1 1/2] linux-generic: classification: implement vlan id packet matching rule

Add implementation for outer and inner vlan ID packet matching rule Signed-off-by: Balasubramanian Manoharan --- .../include/odp_classification_inlines.h | 41 +++--- 1 file changed, 36 insertions(+), 5 deletions(-) diff --git

Re: [lng-odp] [PATCH 3/5] test: generator: various improvements

Reviewed-and-tested-by: Bogdan Pricope On 8 February 2017 at 14:19, Petri Savolainen wrote: > User may select number of worker threads (-w) or cpumask (-c) > (but not both) to limit number of worker thread. > > Increased pool size since

[lng-odp] [PATCHv1 2/2] validation: classification: add test case for outer and inner vlan id

Adds test case for outer and inner vlan id packet matching rule Signed-off-by: Balasubramanian Manoharan --- .../validation/api/classification/classification.h | 2 + .../api/classification/odp_classification_common.c | 17 +-

Re: [lng-odp] Packet references API

On Thu, Feb 9, 2017 at 9:32 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Hi, > > I still think that packet ref API should be defined so that an implementation > may fall back to doing packet copy instead of reference to shared data (if it > simply

[lng-odp] [Bug 2812] helper/test/process fails on a single core system

https://bugs.linaro.org/show_bug.cgi?id=2812 --- Comment #1 from Bill Fischofer --- Unable to recreate issue on my uniprocessor VM from this description. Please provide more details on exact setup (e.g., OS level) and steps to recreate from a fresh clone. -- You are

Re: [lng-odp] [PATCHv1 1/2] linux-generic: classification: implement vlan id packet matching rule

For this series: Reviewed-and-tested-by: Bill Fischofer On Thu, Feb 9, 2017 at 3:02 AM, Balasubramanian Manoharan wrote: > Add implementation for outer and inner vlan ID packet matching rule > > Signed-off-by: Balasubramanian Manoharan

[lng-odp] [API-NEXT PATCHv3 1/5] linux-gen: inline: rename _STATIC to _ODP_INLINE

From: Petri Savolainen This define is visible to applications through API headers. Use _ODP prefix to avoid name space collision. Also "inline" describes better the purpose of the macro than "static". Signed-off-by: Petri Savolainen

[lng-odp] [API-NEXT PATCHv3 4/5] linux-gen: packet: inline functions

From: Petri Savolainen Added first inlined packet functions. Functions are allways used inlined within the implementation. Applications see inlined versions only when ABI compatibility is disabled. Signed-off-by: Petri Savolainen

Re: [lng-odp] Packet references API

On 9 February 2017 at 21:02, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Hi, > > I still think that packet ref API should be defined so that an implementation > may fall back to doing packet copy instead of reference to shared data (if it > simply cannot

Re: [lng-odp] [PATCHv2] travis: add code style checks

Merged, Maxim. On 02/09/17 16:36, Mike Holmes wrote: > > > On 8 February 2017 at 16:50, Maxim Uvarov > wrote: > > run checkpatch.pl to check code style for > applied patches. > Do not check spelling

[lng-odp] Packet references API

Hi, I still think that packet ref API should be defined so that an implementation may fall back to doing packet copy instead of reference to shared data (if it simply cannot handle packets by reference). Now after implementing packet ref API as copy (in about 90 lines), only issues are with

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 02/09/17 17:28, Joe Savage wrote: > Thanks, Maxim. A few comments on some of the feedback so far. > >>> +int main(void) >>> +{ >>> + odp_instance_t instance; >>> + odp_pool_t fragment_pool; >>> + odp_shm_t shm; >>> + odp_cpumask_t cpumask; >>> + odph_odpthread_t

Re: [lng-odp] [PATCH 0/5] Packet test fixes

Merged, this patch set decreases code coverage: https://github.com/Linaro/odp/pull/3 (tool works in test mode) Maxim. On 02/08/17 20:24, Bill Fischofer wrote: > For this series: > > Reviewed-and-tested-by: Bill Fischofer > > On Wed, Feb 8, 2017 at 6:19 AM, Petri

Re: [lng-odp] [PATCHv2] travis: add code style checks

On 8 February 2017 at 16:50, Maxim Uvarov wrote: > run checkpatch.pl to check code style for applied patches. > Do not check spelling now. Will check it only on merge requests. > > Signed-off-by: Maxim Uvarov > Reviewed-by: Mike Holmes

[lng-odp] [API-NEXT PATCHv3 3/5] linux-gen: packet: packet handle is hdr pointer

From: Petri Savolainen Changed packet handle (odp_packet_t) to store pointer to the packet header, instead a bit field structure of pool and index. Buffer and event handles are not changed. Pointer as handle improves packet accessor function performance and enable

[lng-odp] [API-NEXT PATCHv3 5/5] linux-gen: packet: inline flag functions

From: Petri Savolainen Added first inlined packet flag functions. Functions are allways used inlined within the implementation. Applications see inlined versions only when ABI compatibility is disabled. Signed-off-by: Petri Savolainen

[lng-odp] [API-NEXT PATCHv3 2/5] linux-gen: ticketlock: inline also in application

From: Petri Savolainen Enable ticketlock function inlining in applications when not building for ABI compatibility. Signed-off-by: Petri Savolainen Signed-off-by: Bill Fischofer ---

[lng-odp] [API-NEXT PATCHv3 0/5] Packet function inline

First set of packet and packet flag functions are inlined. Inline functions are used (can be used) internally always, but are exposed through API only when builing for non-ABI compatibility. Packet handle value is changed from index(es) to a packet header pointer. Packet/buffer header structure

[lng-odp] [Bug 2812] helper/test/process fails on a single core system

https://bugs.linaro.org/show_bug.cgi?id=2812 Mike Holmes changed: What|Removed |Added Assignee|maxim.uva...@linaro.org

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

Thanks, Maxim. A few comments on some of the feedback so far. > > +int main(void) > > +{ > > + odp_instance_t instance; > > + odp_pool_t fragment_pool; > > + odp_shm_t shm; > > + odp_cpumask_t cpumask; > > + odph_odpthread_t threads[MAX_WORKERS] = {}; > > + odp_packet_t

[lng-odp] [Bug 2872] odp_pktio_ordered_run.sh: line 34: [: : integer expression expected

https://bugs.linaro.org/show_bug.cgi?id=2872 Mike Holmes changed: What|Removed |Added CC||mike.hol...@linaro.org

[lng-odp] [Bug 2828] CID 174662: Bad sizeof() in odp_schedule_sp.c

https://bugs.linaro.org/show_bug.cgi?id=2828 Mike Holmes changed: What|Removed |Added CC||mike.hol...@linaro.org

[lng-odp] merge window for next tag (1.14 or 1.13.1) ends 20 Feb 2017

Hello, we will try to do next development release at the end of current month. That means that we need freeze code to 20 Feb 2017 and have one. Process is the same api-next ---> next ---> master. So if you think there are any candidates for patches which can be moved please let me know. You

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

On 02/09/17 19:22, Joe Savage wrote: > +int main(void) > +{ > + odp_instance_t instance; > + odp_pool_t fragment_pool; > + odp_shm_t shm; > + odp_cpumask_t cpumask; > + odph_odpthread_t threads[MAX_WORKERS] = {}; > + odp_packet_t

Re: [lng-odp] [PATCH v2] example: add IPv4 fragmentation/reassembly example

> >>> +int main(void) > >>> +{ > >>> + odp_instance_t instance; > >>> + odp_pool_t fragment_pool; > >>> + odp_shm_t shm; > >>> + odp_cpumask_t cpumask; > >>> + odph_odpthread_t threads[MAX_WORKERS] = {}; > >>> + odp_packet_t dequeued_pkts[NUM_PACKETS]; > >>> + int i; >

Re: [lng-odp] [API-NEXT PATCH 15/15] linux-gen: support older libconfig version

Could apply it on current API next, today. I am fine with this patch (15/15) On 1 February 2017 at 18:46, Christophe Milard wrote: > needs rebase, I think: > erachmi@erachmi-ericsson:~/linaro/ODP/odp$ git am > ~/incoming/lng-odp_API-NEXT_PATCH_* > Applying: merge

Re: [lng-odp] [API-NEXT PATCH 15/15] linux-gen: support older libconfig version

On 27 January 2017 at 15:29, Maxim Uvarov wrote: > Travis CI uses old libconfig8 amd64 1.3.2-2ubuntu2, > which does not have defines for errors. Move error print > under ifdef to fix compilation. > > Signed-off-by: Maxim Uvarov Reviewed-by:

Re: [lng-odp] [API-NEXT PATCH 15/15] linux-gen: support older libconfig version

Merged this patch Thanks! On 02/09/17 21:41, Christophe Milard wrote: > On 27 January 2017 at 15:29, Maxim Uvarov wrote: >> Travis CI uses old libconfig8 amd64 1.3.2-2ubuntu2, >> which does not have defines for errors. Move error print >> under ifdef to fix compilation.

[lng-odp] [Linaro/odp] 969d1c: test: l2fwd: add pktio driver print out

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 969d1c74ef21b77df01b120297d4156b87183894 https://github.com/Linaro/odp/commit/969d1c74ef21b77df01b120297d4156b87183894 Author: Petri Savolainen Date: 2017-02-09 (Thu, 09 Feb

[lng-odp] [Linaro/odp]

Branch: refs/heads/next Home: https://github.com/Linaro/odp

[lng-odp] [Linaro/odp] 332d48: travis: add code style checks

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 332d48c9c25504b3cbb9451e292a98c15df17ccb https://github.com/Linaro/odp/commit/332d48c9c25504b3cbb9451e292a98c15df17ccb Author: Maxim Uvarov Date: 2017-02-09 (Thu, 09 Feb 2017)

[lng-odp] [Linaro/odp] a1bcdb: linux-gen: support older libconfig version

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: a1bcdb71f9c5525e02a9609fb32b767f4f76b082 https://github.com/Linaro/odp/commit/a1bcdb71f9c5525e02a9609fb32b767f4f76b082 Author: Maxim Uvarov Date: 2017-02-09 (Thu, 09 Feb 2017)

[lng-odp] [Linaro/odp] f21b2d: linux-gen: sched: fix SP scheduler hang in process...

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: f21b2d23874d517e147a3e096e99aa272b99dbe4 https://github.com/Linaro/odp/commit/f21b2d23874d517e147a3e096e99aa272b99dbe4 Author: Yi He Date: 2017-02-09 (Thu, 09 Feb 2017) Changed paths: