[lng-odp] [Bug 2911] unchecked return value may result in out of bounds access

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2911 Bill Fischofer changed: What|Removed |Added Assignee|maxim.uva...@linaro.org

[lng-odp] [Bug 2910] odph_iplookup_table_put_value() uses overlapping pointer addresses

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2910 --- Comment #4 from Bill Fischofer --- Matias: I haven't heard anything back from He Peng, who was the original contributor for this. I suggest we go with your patch if it's working for you as I'm not sure who else is using

[lng-odp] [Bug 2873] code coverage odp_timer_wheel.c

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2873 Bill Fischofer changed: What|Removed |Added CC|

[lng-odp] [Bug 2857] Bus error on not enough hdd space (Ubuntu VM, aarch64)

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2857 Bill Fischofer changed: What|Removed |Added Assignee|christophe.mil...@linaro.or

[lng-odp] [PATCH v4 1/2] validation: packet: increase test pool size

2017-03-30 Thread Matias Elo
Previously packet_test_concatsplit() could fail on some pool implementations as the pool ran out of buffers. Increase default pools size and use capability to make sure the value is valid. Signed-off-by: Matias Elo --- V4: - Moved to master branch (Krishna)

[lng-odp] [PATCH v4 2/2] validation: packet: remove invalid check from packet_test_alloc_segmented()

2017-03-30 Thread Matias Elo
One can't assume that the packet should be segmented as this test is using a different pool with different parameters than the default test pool. Signed-off-by: Matias Elo --- test/common_plat/validation/api/packet/packet.c | 3 --- 1 file changed, 3 deletions(-) diff

[lng-odp] [Bug 2831] CID 168994: Unchecked return in mmap_unmap_sock()

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2831 Bill Fischofer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

Re: [lng-odp] [PATCH] test: bench_packet: fix headroom/tailroom test return values

2017-03-30 Thread Bill Fischofer
On Thu, Mar 30, 2017 at 2:41 AM, Matias Elo wrote: > Zero is a valid return value from the packet headroom/tailroom functions. > > Signed-off-by: Matias Elo Reviewed-by: Bill Fischofer > --- >

[lng-odp] [PATCH] linux-generic: decouple odp_errno define from odp-linux

2017-03-30 Thread Balakrishna Garapati
makes it easy to define odp_errno to dpdk rteerrno and fixes linking issues. Signed-off-by: Balakrishna Garapati --- platform/linux-generic/Makefile.am| 1 + platform/linux-generic/include/odp_errno_define.h | 27 +++

[lng-odp] [Bug 2797] scheduler_main runs for long time

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2797 --- Comment #8 from Mike Holmes --- Yi - Alex Bennée, the author of the code pinged me and is curious if it was locking fixes or the single threaded nature - possibly knowing that is of value to ODP ? I am not suggesting you

[lng-odp] [Bug 2895] odp_crypto_operation() does not work with multi-segment packets

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2895 Bill Fischofer changed: What|Removed |Added CC|

Re: [lng-odp] [PATCH] test: performance: lower the MAX_PKT_SIZE to 1518

2017-03-30 Thread Elo, Matias (Nokia - FI/Espoo)
Hi, The patch I just submitted "test: bench_packet: fix headroom/tailroom test" should fix this problem. -Matias > On 30 Mar 2017, at 10:13, Krishna Garapati > wrote: > > ping > > On 24 March 2017 at 14:40, Balakrishna Garapati < >

Re: [lng-odp] [PATCHv5 1/5] test: generator: compose sending packets from reference packet plus differences

2017-03-30 Thread Yi He
For this patch series: Reviewed-and-tested-by: Yi He On 28 March 2017 at 19:03, Bogdan Pricope wrote: > Signed-off-by: Bogdan Pricope > --- > example/generator/odp_generator.c | 130 ++ >

[lng-odp] [API-NEXT PATCH v4 2/3] api: ipsec: add inline IPSEC support

2017-03-30 Thread Petri Savolainen
Added support for inline IPSEC processing on packet input and output. Inline mode IPSEC and traffic manager cannot be enabled (currently) on the same pktio interface. Signed-off-by: Petri Savolainen --- include/odp/api/spec/ipsec.h | 355

[lng-odp] [PATCH] test: bench_packet: fix headroom/tailroom test return values

2017-03-30 Thread Matias Elo
Zero is a valid return value from the packet headroom/tailroom functions. Signed-off-by: Matias Elo --- test/common_plat/performance/odp_bench_packet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/common_plat/performance/odp_bench_packet.c

[lng-odp] [API-NEXT PATCH v4 1/3] api: ipsec: extend lookaside API

2017-03-30 Thread Petri Savolainen
Added configuration option for inbound SPI range (for lookups). Removed unique SPI requirement and added config option for overlap. Added default queue for lookup misses. Added SA disable function and status event for the response from it. The same event may be used for e.g. IPSEC statistics, etc

[lng-odp] [API-NEXT PATCH v4 3/3] linux-gen: ipsec: add stubs for new functions

2017-03-30 Thread Petri Savolainen
Enable application build with IPSEC. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_ipsec.c | 24 1 file changed, 24 insertions(+) diff --git a/platform/linux-generic/odp_ipsec.c b/platform/linux-generic/odp_ipsec.c index

[lng-odp] [Bug 2910] odph_iplookup_table_put_value() uses overlapping pointer addresses

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2910 --- Comment #5 from Matias Elo --- Sure, I'll send a patch tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.

[lng-odp] [API-NEXT PATCH v2 1/4] api: hints: remove ODP_DEPRECATED from API

2017-03-30 Thread Petri Savolainen
Remove ODP_DEPRECATED macro as it depends on (GCC) compiler type attribute, which may not be supported (the same way) by all compilers. Also the attribute works only for types, but not e.g. for fields of structure. A new configuration option will be added to control deprecated definitions.

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

2017-03-30 Thread Ola Liljedahl
No build, no run. We found several problems (memory ordering related so visible on ARM but not on x86) in the upstream code when running on ARM systems. Aren’t there any ARM systems to run on in the LNG lab? -- Ola Ola Liljedahl, Networking System Architect, ARM Phone: +46 706 866 373 Skype:

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

2017-03-30 Thread Brian Brooks
On 03/28 18:50:32, Bill Fischofer wrote: > > > > > > This part > generates numerous checkpatch warnings and errors. Please > run checkpatch and correct for v2. > > Also, this part introduces a

[lng-odp] [API-NEXT PATCH v2 3/4] test: crypto: remove references to deprecated crypto apis

2017-03-30 Thread Petri Savolainen
Remove last remaining references to deprecated API definitions. Signed-off-by: Petri Savolainen --- example/ipsec/odp_ipsec_misc.h| 4 ++-- example/ipsec/odp_ipsec_sa_db.c | 4 ++-- example/ipsec/odp_ipsec_stream.c | 6 +++---

[lng-odp] [Bug 2921] New: odp_init_global() and odp_pool_create() set errno = 12

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2921 Bug ID: 2921 Summary: odp_init_global() and odp_pool_create() set errno = 12 Product: OpenDataPlane - linux- generic reference Version: v1.11.0.0 Hardware: x86 OS: Linux

[lng-odp] [API-NEXT PATCH v2 2/4] api: deprecated: add configure option and macros

2017-03-30 Thread Petri Savolainen
Added configuration option --enable-deprecated to control if deprecated APIs are enabled or disabled. Added ODP_DEPRECATED_API macro into the API. Its value can be used to check if deprecated API definitions are enabled or disabled. Deprecated APIs are disabled by default. Deprecated APIs are

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

2017-03-30 Thread Bill Fischofer
On Thu, Mar 30, 2017 at 8:56 AM, Brian Brooks wrote: > On 03/28 18:50:32, Bill Fischofer wrote: >> >> >> >> >> >> This >> part generates numerous checkpatch warnings and

[lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-03-30 Thread Petri Savolainen
Replaced ODP_DEPRECATED macro (which was based on GCC __attribute__) with compiler independent mechanism to control if deprecated API definitions are visible to the application. ODP_DEPRECATED_API can be used both in application and implementation to check if deprecated APIs are enabled. By

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

2017-03-30 Thread Maxim Uvarov
I think for now we do not have build for arm v8 & clang. At least it did not capture build error. Maxim. On 30 March 2017 at 17:45, Bill Fischofer wrote: > On Thu, Mar 30, 2017 at 8:56 AM, Brian Brooks > wrote: > > On 03/28 18:50:32, Bill

[lng-odp] [API-NEXT PATCH v2 4/4] api: crypto: enforce deprecated API status

2017-03-30 Thread Petri Savolainen
Used ODP_DEPRECATE() to control if deprecated API definitions are visible in the API or not. Signed-off-by: Petri Savolainen --- include/odp/api/spec/crypto.h | 29 ++-- platform/linux-generic/odp_crypto.c | 45

[lng-odp] [Bug 2921] odp_init_global() and odp_pool_create() set errno = 12

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2921 --- Comment #1 from Oriol Arcas --- This behavior is not harmful, ODP continues working properly. It just may confuse the user app. -- You are receiving this mail because: You are on the CC list for the bug.

[lng-odp] [Bug 2704] Builds TAR have no .scmversion

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2704 Bill Fischofer changed: What|Removed |Added CC|

[lng-odp] [Linaro/odp] 07bf45: test: generator: compose sending packets from refe...

2017-03-30 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 07bf459919d968674741fe9be6120124221ee62e https://github.com/Linaro/odp/commit/07bf459919d968674741fe9be6120124221ee62e Author: Bogdan Pricope Date: 2017-03-30 (Thu, 30 Mar 2017)

[lng-odp] [Linaro/odp] 138a4a: test: bench_packet: fix headroom/tailroom test ret...

2017-03-30 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 138a4a92b0bbf5bcc713a62747644276ada8d05d https://github.com/Linaro/odp/commit/138a4a92b0bbf5bcc713a62747644276ada8d05d Author: Matias Elo Date: 2017-03-30 (Thu, 30 Mar 2017) Changed

[lng-odp] [PATCHv2] test: perf: fix bash syntax in odp_pktio_ordered_run.sh

2017-03-30 Thread Maxim Uvarov
bash -lt syntax expects 2 integer values, not strings. Also return code of piped command needs to be get in a little bit different way. https://bugs.linaro.org/show_bug.cgi?id=2872 Signed-off-by: Maxim Uvarov --- v2: after repairing test logic make distcheck failed due

Re: [lng-odp] [API-NEXT 2/4] linux-generic: ring.c: use required memory orderings

2017-03-30 Thread Bill Fischofer
Maxim: Per discussions today, this part needs to be separated from the rest of this series and merged on an expedited basis to resolve critical issues when running ODP on ARM systems. V2 of the scheduler patch will omit this part. On Tue, Mar 28, 2017 at 2:23 PM, Brian Brooks

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

2017-03-30 Thread Brian Brooks
On 03/29 11:20:37, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Couple of high level comments: > > 1) Too many #ifdefs >* Code is hard to read and maintain when every 10th line is #ifdef or #else >* Are all #ifdef combinations tested? Or meant to be supported? >* It seems that some

Re: [lng-odp] [PATCH] test: performance: lower the MAX_PKT_SIZE to 1518

2017-03-30 Thread Krishna Garapati
ping On 24 March 2017 at 14:40, Balakrishna Garapati < balakrishna.garap...@linaro.org> wrote: > "bench_packet_tailroom" test fails on odp-dpdk with the pkt size 2048 > leaving no space for tailroom. > > Signed-off-by: Balakrishna Garapati > --- >

[lng-odp] [Bug 2921] odp_init_global() and odp_pool_create() set errno = 12

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2921 Bill Fischofer changed: What|Removed |Added CC|

[lng-odp] [Bug 2921] odp_init_global() and odp_pool_create() set errno = 12

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2921 --- Comment #3 from Bill Fischofer --- Sorry, I noticed you reported this against ODP Monarch (v1.11.0.0). In this case neither odp_init.c nor odp_pool.c references errno, so again I don't see how this is the case. Are you

Re: [lng-odp] [PATCHv2] test: perf: fix bash syntax in odp_pktio_ordered_run.sh

2017-03-30 Thread Bill Fischofer
On Thu, Mar 30, 2017 at 11:20 AM, Maxim Uvarov wrote: > bash -lt syntax expects 2 integer values, not strings. > Also return code of piped command needs to be get in > a little bit different way. > https://bugs.linaro.org/show_bug.cgi?id=2872 > > Signed-off-by: Maxim

[lng-odp] [Bug 2797] scheduler_main runs for long time

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2797 Yi He changed: What|Removed |Added CC||yi...@linaro.org

[lng-odp] [Bug 2797] scheduler_main runs for long time

2017-03-30 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=2797 --- Comment #9 from Yi He --- Hi, Mike I did the tests, just like you and Alex analysed: "If it runs faster than it used to (but still slower than the MTTCG case) then it could be some of the ancillary changes to locking un-wedged