[lng-odp] [Linaro/odp] 4c2311: example: generator: add configuration option for R...

2018-01-14 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 4c23114ed39db175beaa317f63b782fad02b2c6f https://github.com/Linaro/odp/commit/4c23114ed39db175beaa317f63b782fad02b2c6f Author: Bogdan Pricope Date: 2018-01-14 (Sun, 14 Jan 2018)

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: test/validation/api/time/time.c line 19 @@ -423,11 +423,12 @@ static void time_test_accuracy(time_cb time_cur, time_from_ns_cb time_from_ns) { int i; odp_time_t t1, t2, wait, diff; - clock_t c1, c2; + struct

[lng-odp] [Linaro/odp] 250342: linux-generic: remove camelcase from icmp protocol

2018-01-14 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 2503425036ca2ee48003ef20fcb87003e5d1e956 https://github.com/Linaro/odp/commit/2503425036ca2ee48003ef20fcb87003e5d1e956 Author: Bill Fischofer Date: 2018-01-14 (Sun, 14 Jan 2018)

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: example/ipfragreass/Makefile.am line 3 @@ -1,5 +1,7 @@ include $(top_srcdir)/example/Makefile.inc +LDADD += $(ATOMIC_LIBS) Comment: This example is not generic enough. It uses atomic primitives directly. > muvarov wrote > This kind

[lng-odp] [Linaro/odp] 634b38: test: l2fwd: improve cache usage

2018-01-14 Thread GitHub
Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: 634b380b63de53c65b92c214d91aaf03785d69db https://github.com/Linaro/odp/commit/634b380b63de53c65b92c214d91aaf03785d69db Author: Matias Elo Date: 2018-01-14 (Sun, 14 Jan 2018) Changed

[lng-odp] [PATCH v12 0/14] Misc fixes

2018-01-14 Thread Github ODP bot
Several small fixes produced while working on updating ODP packaging. github /** Email created from pull request 377 (lumag:misc-fixes) ** https://github.com/Linaro/odp/pull/377 ** Patch: https://github.com/Linaro/odp/pull/377.patch ** Base sha:

[lng-odp] [PATCH v12 7/14] helper/tests: use common Makefile.inc for tests

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 377 (lumag:misc-fixes) ** https://github.com/Linaro/odp/pull/377 ** Patch:

[lng-odp] [PATCH v12 8/14] test, linux-gen: use common test/Makefile.inc

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Populate test/Makefile.inc with more variables, allowing us to drop platform test/Makefile.inc. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 377

[lng-odp] [PATCH API-NEXT v7 1/7] validation: crypto: stop declaring test functions as public

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov There is no use to declare test functions as public, they are defined and used in the same file. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 352

[lng-odp] [PATCH API-NEXT v7 0/7] Add separate auth IV

2018-01-14 Thread Github ODP bot
I was thinking again about GMAC auth case. Currently GMAC just reuses cipher IV data fields, which is not future proof and not quite obvious. So let's add separate set of IV-related fields for authentication algorithms. github /** Email created from pull

[lng-odp] [PATCH API-NEXT v7 5/7] api: crypto: add separate auth IV

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov GMAC auth algorithm requires IV to work. Instead of hacking the ODP_CIPHER_ALG_NULL iv to include value for ODP_AUTH_ALG_GMAC, provide separate iv (in auth capability, session params and operation params). Signed-off-by: Dmitry

[lng-odp] [PATCH API-NEXT v7 3/7] api: crypto: use cipher_iv instead of iv in session params

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov In preparation to add auth-specific IV, rename iv field to ciper_iv. Provide deprecated compatibility field iv. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 352

[lng-odp] [PATCH API-NEXT v7 4/7] api: crypto: use cipher_iv_ptr instead of override_iv_ptr

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov In preparation to add auth-specific IV, rename override_iv_ptr field to ciper_iv_ptr. Provide deprecated compatibility field override_iv_ptr. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email

[lng-odp] [PATCH API-NEXT v7 6/7] validation: crypto: use auth IV for GMAC test case

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Change GMAC testing code to use new auth IV fields. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 352 (lumag:crypto_gmac_iv) **

[lng-odp] [PATCH API-NEXT v7 2/7] linux-gen: crypto: move session type to odp_crypto module

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov There is no point in having odp_crypto_generic_session_t definition in global include file. Move it to odp_crypto module. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
muvarov replied on github web page: example/ipfragreass/Makefile.am line 3 @@ -1,5 +1,7 @@ include $(top_srcdir)/example/Makefile.inc +LDADD += $(ATOMIC_LIBS) Comment: This kind of thing which is better to avoid. If we are going to merge odp implementations platforms to common repo then it

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
muvarov replied on github web page: example/ipfragreass/Makefile.am line 3 @@ -1,5 +1,7 @@ include $(top_srcdir)/example/Makefile.inc +LDADD += $(ATOMIC_LIBS) Comment: Ok, Than. Agree. > muvarov wrote > also please add link to bugz if it's bug fix to git comment. >> muvarov wrote >>

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
muvarov replied on github web page: test/validation/api/time/time.c line 19 @@ -423,11 +423,12 @@ static void time_test_accuracy(time_cb time_cur, time_from_ns_cb time_from_ns) { int i; odp_time_t t1, t2, wait, diff; - clock_t c1, c2; + struct timeval tv1, tv2,

[lng-odp] [PATCH v12 5/14] linux-gen: don't pass DPKD_LIBS for dynamic linking with libodp-linux

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 377 (lumag:misc-fixes) ** https://github.com/Linaro/odp/pull/377 ** Patch:

[lng-odp] [PATCH v12 6/14] example: add missing libraries to LDADD variables

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 377 (lumag:misc-fixes) ** https://github.com/Linaro/odp/pull/377 ** Patch:

[lng-odp] [PATCH v12 4/14] performance: odp_crypto: correct typo

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Receieved -> Received. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 377 (lumag:misc-fixes) ** https://github.com/Linaro/odp/pull/377 ** Patch:

[lng-odp] [PATCH v12 14/14] example: ipsec_api: remove file conflict with ipsec example

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov ipsec_api example installs program with the same name, as ipsec example does. Remove file conflict between two examples. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull

[lng-odp] [PATCH v12 12/14] linux-gen: don't use SYSCONFDIR

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov sysconfig is not used in TigerMoth, so let's drop the variable in linux-gen's Makefile. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 377 (lumag:misc-fixes) **

[lng-odp] [PATCH v12 13/14] tests: don't use ODP_SYSCONFIG_FILE

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov libconfig is not used in TigerMoth, so let's drop the variable in test's Makefile.inc. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 377 (lumag:misc-fixes) **

[lng-odp] [PATCH API-NEXT v7 7/7] linux-gen: crypto, ipsec: use auth_iv.

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Separate handling of authentication IV data. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 352 (lumag:crypto_gmac_iv) ** https://github.com/Linaro/odp/pull/352

Re: [lng-odp] [PATCH v3][WIP] Validate checksums during packet parsing

2018-01-14 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/include/odp_chksum_internal.h line 1 @@ -0,0 +1,59 @@ +/* Copyright (c) 2013, Linaro Limited Comment: 2018 https://github.com/Linaro/odp/pull/389#discussion_r161402959 updated_at 2018-01-14 16:39:21

Re: [lng-odp] [PATCH v3][WIP] Validate checksums during packet parsing

2018-01-14 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/odp_packet.c line 182 @@ -2191,7 +2201,7 @@ int packet_parse_common_l3_l4(packet_parser_t *prs, const uint8_t *parseptr, switch (ethtype) { case _ODP_ETHTYPE_IPV4:

Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL

2018-01-14 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/include/odp/api/plat/packet_types.h @@ -67,101 +67,130 @@ typedef enum { #endif -/** @internal Packet field accessor */ +/** @cond _ODP_HIDE_FROM_DOXYGEN_ */ + +/* Packet field accessor */ #define

[lng-odp] [Bug 3572] New: time_main test fails if run under heavy load

2018-01-14 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=3572 Bug ID: 3572 Summary: time_main test fails if run under heavy load Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other OS: Linux Status:

[lng-odp] [PATCH v12 3/14] doc: add missing implementers-guide images to Makefile.am

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Omitting those images in Makefile.am made them disappear from distribution tarball resulting in an improperly-built documentation files. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email

[lng-odp] [PATCH v12 2/14] doc: add missing user-guide images to Makefile.am

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov Omitting those images in Makefile.am made them disappear from distribution tarball resulting in an improperly-built documentation files. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email

[lng-odp] [PATCH v12 1/14] helper: link against libpthread and libodp-linux

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov libodphelper.so uses symbols from libpthread and libodp-linux.so, link it aganst those libraries. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 377

[lng-odp] [PATCH v12 11/14] Revert "test: time: do not fail under gcov"

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov This reverts commit 7a7e3ff9d50d67b7c79058db98ba27ab5a806437. After fixing time test to use clock_gettime() instead of clock(), this test should not fail under Travis/coverage. Reenable the test. Signed-off-by: Dmitry

[lng-odp] [PATCH v12 10/14] validation: time: use clock_gettime() instead of clock()

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov ODP test for time API uses clock() to compare time against. However clock() returns processor time used by program, which can differ between runs. Use clock_gettime() as a time source to compare against. Signed-off-by: Dmitry

[lng-odp] [PATCH v12 9/14] validation: stop overriding LDADD variable

2018-01-14 Thread Github ODP bot
From: Dmitry Eremin-Solenikov LDADD variable can be used to pass other libraries (like DPDK). Stop overriding LDADD entirely. Instead use PRELDADD variable or appending to LDADD. Signed-off-by: Dmitry Eremin-Solenikov ---

Re: [lng-odp] [PATCH v12] Misc fixes

2018-01-14 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: test/validation/api/time/time.c @@ -423,11 +423,12 @@ static void time_test_accuracy(time_cb time_cur, time_from_ns_cb time_from_ns) { int i; odp_time_t t1, t2, wait, diff; - clock_t c1, c2; + struct timeval

Re: [lng-odp] [PATCH v12] Misc fixes

2018-01-14 Thread Github ODP bot
muvarov replied on github web page: test/validation/api/time/time.c @@ -423,11 +423,12 @@ static void time_test_accuracy(time_cb time_cur, time_from_ns_cb time_from_ns) { int i; odp_time_t t1, t2, wait, diff; - clock_t c1, c2; + struct timeval tv1, tv2, tvdiff;

Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL

2018-01-14 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/include/odp/api/plat/packet_types.h @@ -67,101 +67,130 @@ typedef enum { #endif -/** @internal Packet field accessor */ +/** @cond _ODP_HIDE_FROM_DOXYGEN_ */ + +/* Packet field accessor */ #define

Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL

2018-01-14 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/include/odp/api/plat/packet_types.h @@ -67,101 +67,130 @@ typedef enum { #endif -/** @internal Packet field accessor */ +/** @cond _ODP_HIDE_FROM_DOXYGEN_ */ + +/* Packet field accessor */ #define

Re: [lng-odp] [PATCH API-NEXT v1] api: pktio: clarify timeout and stop interaction

2018-01-14 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: include/odp/api/spec/packet_io.h line 25 @@ -884,14 +887,19 @@ int odp_pktin_recv(odp_pktin_queue_t queue, odp_packet_t packets[], int num); * @param numMaximum number of packets to receive * @param wait

Re: [lng-odp] [PATCH API-NEXT v1] User pointer init to NULL

2018-01-14 Thread Github ODP bot
Bill Fischofer(Bill-Fischofer-Linaro) replied on github web page: platform/linux-generic/include/odp/api/plat/packet_types.h line 155 @@ -156,7 +157,12 @@ typedef union { uint32_t all_flags; struct { - uint32_t reserved1: 12; + uint32_t reserved1:

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
muvarov replied on github web page: test/validation/api/time/time.c line 19 @@ -423,11 +423,12 @@ static void time_test_accuracy(time_cb time_cur, time_from_ns_cb time_from_ns) { int i; odp_time_t t1, t2, wait, diff; - clock_t c1, c2; + struct timeval tv1, tv2,