Hi,
I would rather keep the output print more consistent and include also pcap
pktio.
So something like:
> + pktio_dpdk: ${pktio_dpdk_support}
> + pktio_netmap: ${netmap_support}
> + pktio_pcap: ${have_pcap}
-Matias
> -Original Message-
> From: lng-odp [
Thanks, I'll fix this and the patch 1 right away.
-Matias
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Wednesday, May 11, 2016 7:12 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH v2 2/2] linux-gen
From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Thursday, May 12, 2016 10:34 PM
To: Elo, Matias (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [PATCH 4/4] linux-generic: packet: initialize only
selected odp_packet_hdr_t members
On Thu, May 12, 2016 at
: Elo, Matias (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [PATCH 2/4] linux-generic: packet: remove vlan_s_tag and
vlan_c_tag members from odp_packet_hdr_t
There is a use-case in classification, where the packet can be classified based
on outer/inner vlan tag and for that
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Thursday, May 12, 2016 6:51 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCH] validation: pktio: initialize pkt_seq
>
> recv_packets_tmo() has if for not init
Reviewed-and-tested-by: Matias Elo
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Friday, May 13, 2016 3:45 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCHv2] validation: pktio: initialize pkt_seq
>
> I
From: EXT Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Saturday, May 14, 2016 8:45 PM
To: Mike Holmes
Cc: Elo, Matias (Nokia - FI/Espoo) ; LNG ODP Mailman List
Subject: Re: [lng-odp] [PATCH 4/4] linux-generic: packet: initialize only
selected odp_packet_hdr_t members
I agree we
+1 for the mandatory plain text as well. At least for us replacing Outlook as
email client is not really an option and the cursed blue line makes inline
replies a pain.
-Matias
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Zoltan
> Ki
> Hi Matias,
>
> The odp_time_local and others functions are time sensitive functions,
> that's why it was decided to avoid copping as more as possible.
>
> The timespec is not simple "long type". Its type is arch dependent but is
> always
> 64bit.
> In case of 32 bit system it's defined as long
> The types are different, then better to make odp_time_t to be same size of
> timespec.
>
> Initially, it was smth like typedef timespec odp_time_t, but new versions of
> Ubuntu
> have some problem with leaking some library internals to ODP project with such
> definition
> (not sure what it was,
From: Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Tuesday, May 17, 2016 9:46 PM
To: Mike Holmes
Cc: Elo, Matias (Nokia - FI/Espoo) ; lng-odp
Subject: Re: [lng-odp] [PATCH v2 5/5] linux-generic: packet: initialize only
selected odp_packet_hdr_t members
On Tue, May 17, 2016 at
Hi Xuelin,
Some initial comments below. I didn't have yet time to look at the routing part.
-Matias
> +
> +struct {
> + odp_pktio_t if0, if1;
> + odp_pktin_queue_t if0in, if1in;
> + odp_pktout_queue_t if0out, if1out;
> + odph_ethaddr_t src, dst;
> +} global;
I would prefer the a
>
> > +struct {
> > + odp_pktio_t if0, if1;
> > + odp_pktin_queue_t if0in, if1in;
> > + odp_pktout_queue_t if0out, if1out;
> > + odph_ethaddr_t src, dst;
> > +} global;
>
> I would prefer the application to support more than two interfaces. This makes
> the application logic more complex
> I'm also wondering if I should send the final big patch or a patch set with
> enhancement history.
I would prefer you send it as a single patch as it is a whole new application.
There is no point in showing the "unfinished" versions in the git history.
-Matias
_
Hi Forrest,
Checkpatch throws one error from the patch:
ERROR: spaces required around that '==' (ctx:VxW)
#485: FILE: example/l3fwd/odp_l3fwd.c:427:
+ if (args->route_str[0]== NULL) {
You could add a test script for running the application during make check (for
e
One more thing, the output binary file should be added to .gitignore.
-Matias
>
> Checkpatch throws one error from the patch:
>
> ERROR: spaces required around that '==' (ctx:VxW)
> #485: FILE: example/l3fwd/odp_l3fwd.c:427:
> + if (args->route_str[0]== NULL) {
>
> You
> > diff --git a/platform/linux-generic/pktio/socket_mmap.c b/platform/linux-
> generic/pktio/socket_mmap.c
> > index ce05775..6d7ec59 100644
> > --- a/platform/linux-generic/pktio/socket_mmap.c
> > +++ b/platform/linux-generic/pktio/socket_mmap.c
> > @@ -166,6 +166,10 @@ static inline unsigned pkt
From: Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Friday, June 03, 2016 3:34 AM
To: Elo, Matias (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [PATCH] linux-gen: fix debug info print functions
The use of ODP_DBG() is intentional in all of these cases. These are
> + if (nb_txq == 0)
> + fwd_pktio->nb_txq = 1;
> + else if (nb_txq > (int)capa.max_output_queues)
> + fwd_pktio->nb_txq = capa.max_output_queues;
> +
> + in_queue_param.num_queues = fwd_pktio->nb_rxq;
> + out_queue_param.num_queues = fwd_pktio->nb_txq;
> +
>
> On 2 June 2016 at 13:15, Matias Elo wrote:
> > Don't allocate new packets inside of the internal
> > classifier helpers _odp_packet_cls_enq() and
> > _odp_packet_classifier(). Instead, save destination queue to
> > the parsed packet header and return correct packet pool.
> > This enables zero-
are only run with the
loopback interface type.
-Matias
From: Oriol Arcas [mailto:or...@starflownetworks.com]
Sent: Tuesday, June 07, 2016 4:15 PM
To: Bala Manoharan
Cc: Elo, Matias (Nokia - FI/Espoo) ; LNG ODP Mailman List
Subject: Re: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't all
gt;dst_queue);
ret = queue_enq(dst_queue,
buf_hdr, 0);
--
-Matias
From: Elo, Matias (Nokia - FI/Espoo)
Sent: Wednesday, June 08, 2016 10:12 AM
To: 'Oriol Arcas' ; Bala Manoharan
Cc: LNG ODP Mailman List
Subject: RE: [lng-odp] [PATCH v2 4/4] linux-gen: pktio: don't allocate new
> >> On 2 June 2016 at 13:15, Matias Elo wrote:
> >> > Don't allocate new packets inside of the internal
> >> > classifier helpers _odp_packet_cls_enq() and
> >> > _odp_packet_classifier(). Instead, save destination queue to
> >> > the parsed packet header and return correct packet pool.
> >> > Th
===
Upon review and based on prior discussions that ODP_PRINT() should be used for
ODP APIs that print output, I believe that these changes should be made for the
following modules/routines:
odp_pool.c => odp_pool_print() should use ODP_PRINT()
odp_traffic_mngr.c => odp_tm_stats_print() should u
Hi Forrest,
On my system the application crashes on start:
$ sudo ./example/l3fwd/odp_l3fwd -i eth0,eth1 -r 1.1.1.0/24:eth0 -r
2.2.2.0/24:eth1
ODP system info
---
ODP API version: 1.10.0
ODP impl name: odp-linux
CPU model: Intel(R) Xeon(R) CPU E5-2697 v3
CPU freq (hz): 2600
> >> >> On 2 June 2016 at 13:15, Matias Elo wrote:
> >> >> > Don't allocate new packets inside of the internal
> >> >> > classifier helpers _odp_packet_cls_enq() and
> >> >> > _odp_packet_classifier(). Instead, save destination queue to
> >> >> > the parsed packet header and return correct packe
From: Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Thursday, June 09, 2016 11:55 PM
To: Elo, Matias (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [PATCH v2 1/2] linux-gen: fix debug info print functions
On Thu, Jun 9, 2016 at 6:57 AM, Matias Elo
Message-
> From: forrest.shi [mailto:forrest@linaro.org]
> Sent: Sunday, June 12, 2016 11:46 AM
> To: Elo, Matias (Nokia - FI/Espoo)
> Cc: lng-odp@lists.linaro.org
> Subject: RE: [lng-odp][PATCH v3] example: introducing l3fwd
>
> Hi Matias,
>
> The dpdk_open fa
Comments below.
Regards,
Matias
>
> > diff --git a/example/l3fwd/jhash.h b/example/l3fwd/jhash.h new file
> > > mode 100644 index 000..d3dbd2a
> > > --- /dev/null
> > > +++ b/example/l3fwd/jhash.h
> > > @@ -0,0 +1,46 @@
> > > +/** jhash.h: Jenkins hash support.
> > > + *
> > > + * Copyright
Hi Maxim,
I wrote this application for an ODP programming tutorial in the OPNFV design
summit next week. For sure I'll add the validation test in a following
revision, but for now I would be thankful for any feedback regarding the
application code.
-Matias
> -Original Message-
> From:
Thanks for feedback!
-Matias
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim
> Uvarov
> Sent: Thursday, June 16, 2016 2:12 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH 1/2] example: echo: add new L2 echo example
> appl
> -Original Message-
> From: Maxim Uvarov [mailto:maxim.uva...@linaro.org]
> Sent: Thursday, June 16, 2016 2:28 PM
> To: Elo, Matias (Nokia - FI/Espoo) ; lng-
> o...@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH 1/2] example: echo: add new L2 echo example
> appl
Hi Forrest,
I was finally able to test the application.
I'm running the application with the same arguments than in the helper printout:
$ sudo ./example/l3fwd/odp_l3fwd -i eth0,eth1 -r 1.1.1.0/24:eth0
-2.2.2.0/24:eth1
...
pktio/dpdk.c:556:dpdk_open():Invalid dpdk netdev: eth0
Ping. Barry, what's your opinion on removing these tm print functions?
-Matias
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bill
> Fischofer
> Sent: Thursday, June 09, 2016 11:49 PM
> To: Maxim Uvarov
> Cc: Barry Spinney ; LNG ODP Mailman Li
Hi Forrest,
The destination MAC address doesn't seem to work (tried also with colons as
separators):
$ sudo ./example/l3fwd/odp_l3fwd -i 0,2 -r 1.1.1.0/24:0:02.01.03.04.05.01 -r
2.2.2.0/24:2:0:02.01.03.04.05.02 -t 2
...
Routing table
-
subnet next_hopdest_mac
Comments below.
-Matias
> > > +#define MAX_NB_RX_QUEUE (MAX_NB_WORKER)
> > > +#define MAX_NB_TX_QUEUE (MAX_NB_WORKER)
> > > +#define MAX_NB_QCONF_PER_CORE(MAX_NB_PKTIO)
> >
> > You could remove the MAX_NB_RX_QUEUE & MAX_NB_TX_QUEUE &
> > MAX_NB_QCONF_PER_CORE defines altogether and use the
nfiguration is the culprit here.
I'm
Using dpdk/netmap pktio, so I have enough HW queues for all the threads.
>
>
> If no route is found the packet should in my opinion be dropped.
> =
> This could be kept for one port sce
> Hello,
>
> Can somebody else confirm that ./scripts/build-pktio-dpdk script is broken?
> I.e. now I see that script compiles dpdk and odp but it does not compile
> dpdk pktio for odp for some reason.
> config.log says that there is no -ldpdk. But ./configure passes to the
> end and returns 0.
>
Hi Bill,
I'm working on this patch set now when Petri is on vacation.
-Matias
> The idea behind this patch looks good, however it really should be split
> into at least two patches since the changes to pktio to exploit the change
> are really independent of the base functional change.
I split
Hi Forrest,
I'm currently on vacation. I'll be back at the office on August 8th.
-Matias
> On 25 Jul 2016, at 10:06, forrest.shi wrote:
>
> Hi Matias,
>
> Do you have any further comment about this version?
>
> Thanks,
> Forrest
>
>> -Original Message-
>> From: forrest@linaro.o
, August 11, 2016 7:20 PM
To: forrest.shi
Cc: lng-odp ; Elo, Matias (Nokia - FI/Espoo)
; Savolainen, Petri (Nokia - FI/Espoo)
Subject: Re: [lng-odp] [PATCHv7 1/2] example: introducing l3fwd
I CC'ed Matias, I am not sure if we can get another Member to run this on their
HW ?
It does not have
: 141K of event 'cycles:pp', Event count (approx.): 90818460609
Overhead CommandShared Object Symbol
+ 99.47% odp_l3fwd odp_l3fwd [.] find_fwd_db_entry
-Matias
From: Elo, Matias (Nokia - FI/Espoo)
Sent: Friday, August 12, 2016 9:54 AM
To: 'Mike Holmes
/l3fwd/odp_l3fwd -i p2p1,p1p1 -r
1.1.1.0/24,p2p1 -r 2.2.2.0/24,p1p1 -t 1 -d 999
-Matias
From: forrest.shi [mailto:forrest@linaro.org]
Sent: Monday, August 15, 2016 8:17 AM
To: Elo, Matias (Nokia - FI/Espoo) ; Mike
Holmes
Cc: lng-odp
Subject: Re: [lng-odp] [PATCHv7 1/2] example: introducing
the patch
should fix the first 2 issues, at least on my side.
Thanks,
Forrest
在 8/12/2016 4:28 PM, Elo, Matias (Nokia - FI/Espoo) 写道:
I tested the application on our server and the forwarding rate doesn’t scale
when core
count is increased (added l2fwd and OFP results for reference). Based on so
, August 15, 2016 11:19 PM
To: Elo, Matias (Nokia - FI/Espoo)
Cc: forrest.shi ; lng-odp
Subject: Re: [lng-odp] [PATCHv7 1/2] example: introducing l3fwd
Do we want to discuss this during tomorrow's ODP public call? I'll add it to
the agenda.
On Mon, Aug 15, 2016 at 6:36 AM, Elo, Mat
> Would you please have a review on this version?
>
> It should fix the TX queue binding issue.
>
> Each thread has one tx queue for each port.
>
Hi Forrest,
Now the throughput scales as it should. The hash IP lookup performance is still
bad
(~3K packets per second) but in my opinion this ca
> was v8 send to mailing list?
Looks like it wasn't. I received the patch directly from Forrest.
-Matias
>
> I do not see it here:
> http://patches.opendataplane.org/project/lng-odp/list/
>
>
> On 08/23/16 19:09, Mike Holmes wrote:
> > On 23 August 2016 a
) sent by HW packet
generator for each port.
I'm trying to reproduce the issue.
Thanks.
Forrest
在 8/24/2016 12:09 AM, Mike Holmes 写道:
On 23 August 2016 at 09:28, Elo, Matias (Nokia - FI/Espoo)
mailto:matias@nokia-bell-labs.com>> wrote:
> Would you please have a review o
Just nitpicking here but there is an extra ' From: Xuelin Shi
' in all commit messages.
You should also include the version tag in all patches (e.g. [PATCHv9 3/3]).
This way one can apply all the patches with a single 'git am /*'
call in right order.
There's one typo in the commit message ac
OK, I’ll create a matching bug report.
-Matias
From: Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Tuesday, September 06, 2016 4:01 PM
To: Elo, Matias (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List ; Mattila, Juha (Nokia -
FI/Oulu)
Subject: Re: [lng-odp] [PATCH] linux-gen: tap: add
Reviewed-and-tested-by: Matias Elo
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Nicolas
> Morey-Chaisemartin
> Sent: Friday, October 09, 2015 4:23 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCH] configure: move all AM_CO
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Friday, October 16, 2015 7:00 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH 1/2] linux-generic: netmap: wait for the
> interface
> to become active
>
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Stuart
> Haslam
> Sent: Friday, October 16, 2015 8:43 PM
> To: Maxim Uvarov
> Cc: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH 1/2] linux-generic: netmap: wait for the
> interfac
> -Original Message-
> From: EXT Stuart Haslam [mailto:stuart.has...@linaro.org]
> Sent: Tuesday, October 20, 2015 3:29 PM
> To: Elo, Matias (Nokia - FI/Espoo)
> Cc: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH 2/2] linux-generic: netmap: use sep
stuart.has...@linaro.org]
> Sent: Tuesday, October 20, 2015 7:37 PM
> To: Elo, Matias (Nokia - FI/Espoo)
> Cc: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH 2/2] linux-generic: netmap: use separate rx and
> tx
> descriptors
>
> On Tue, Oct 20, 2015 at 0
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Wednesday, October 21, 2015 1:58 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [API-NEXT PATCH] api: pktio: add odp_pktio_print() API
>
> it has to be odp h
Ping.
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Elo,
> Matias (Nokia - FI/Espoo)
> Sent: Monday, October 19, 2015 1:32 PM
> To: EXT Stuart Haslam ; Maxim Uvarov
>
> Cc: lng-odp@lists.linaro.org
> Subject:
> -Original Message-
> From: EXT Stuart Haslam [mailto:stuart.has...@linaro.org]
> Sent: Wednesday, October 21, 2015 2:37 PM
> To: Elo, Matias (Nokia - FI/Espoo)
> Cc: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH 2/2] linux-generic: netmap: use sep
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Thursday, October 22, 2015 2:49 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH v2 1/2] linux-generic: netmap: wait for the
> interface to become active
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Friday, October 23, 2015 1:03 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH v5 3/6] test: l2fwd: fix crash when accuracy is
> set to
> 0
>
> On 10/23/
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Monday, October 26, 2015 11:36 AM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH v6 6/6] test: l2fwd: word copy ethernet
> addresses
>
> On 10/23/2015 1
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Monday, October 26, 2015 11:42 AM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH v2 1/2] linux-generic: netmap: wait for the
> interface to become active
>
Ping. V2 was already reviewed and tested by Stuart. The only change in v3 was
the added comment.
-Matias
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Elo,
> Matias (Nokia - FI/Espoo)
> Sent: Monday, October 26, 2015 12:31
I added the odp_pktio_print() function while thinking just this use case.
Comments below.
-Matias
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Zoltan
> Kiss
> Sent: Friday, October 30, 2015 8:38 PM
> To: lng-odp@lists.linaro.org
> Sub
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Monday, November 02, 2015 2:44 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [API-NEXT PATCH v2] validation: pktio: test
> odp_pktio_print()
>
> On 11/02/20
Hi Nicolas,
You could try to limit the amount of reserved hugepages per application e.g.:
$ ODP_PLATFORM_PARAMS="-n 4 -m 512" ./test/performance/odp_l2fwd -i 0,1 -c 2
P.S. You should send odp-dpdk related questions to
lng-odp-d...@lists.linaro.org mailing list.
-Matias
From: lng-odp [mailto:
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Friday, November 06, 2015 1:40 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [PATCH] linux-generic: netmap: replace nm_dispatch()
> helper
>
> On 11/06/2015 1
Sure, I'll check them.
-Matias
> -Original Message-
> From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org]
> Sent: Wednesday, November 11, 2015 1:53 PM
> To: lng-odp@lists.linaro.org; Elo, Matias (Nokia - FI/Espoo)
>
> Subject: Re: [lng-odp] [PATCH 1/2] linux-
The patch fixes socket mmap transmit bug. For both patches:
Reviewed-and-Tested-by: Matias Elo
While testing the patch set I noticed that the pktio_test_send_failure()
doesn't pass when using a directly attached cable between NIC ports. However,
this seems to be unrelated to the patch set.
$
Did you first apply Petri’s '[API-NEXT PATCH v3 0/7] Multi-queue packet io
APIs' patch set as noted in the cover letter?
-Matias
From: EXT Mike Holmes [mailto:mike.hol...@linaro.org]
Sent: Thursday, November 19, 2015 9:47 PM
To: Elo, Matias (Nokia - FI/Espoo)
Cc: lng-odp
Subject: Re
Can be discarded. Already fixed in Ilya Maximets' patch.
-Matias
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Matias
> Elo
> Sent: Tuesday, December 08, 2015 12:37 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCH] validati
ng.com]
> Sent: Tuesday, December 08, 2015 12:44 PM
> To: Elo, Matias (Nokia - FI/Espoo) ; lng-
> o...@lists.linaro.org
> Subject: Re: validation: pktio: fix start_stop and send_failure tests
>
> Matias,
> please check out my patch ( https://lists.linaro.org/pipermail/lng-odp/2
> -Original Message-
> From: EXT Stuart Haslam [mailto:stuart.has...@linaro.org]
> Sent: Friday, December 11, 2015 2:25 PM
> To: Elo, Matias (Nokia - FI/Espoo)
> Cc: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [API-NEXT PATCH v2 4/5] linux-generic: netmap: ad
> -Original Message-
> From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org]
> Sent: Wednesday, December 16, 2015 6:42 PM
> To: Savolainen, Petri (Nokia - FI/Espoo) ; lng-
> o...@lists.linaro.org; Elo, Matias (Nokia - FI/Espoo) ;
> Elo,
> Matias (Nokia - FI/Espoo)
&g
> -Original Message-
> From: EXT Zoltan Kiss [mailto:zoltan.k...@linaro.org]
> Sent: Thursday, December 17, 2015 7:53 PM
> To: Elo, Matias (Nokia - FI/Espoo) ; Savolainen, Petri
> (Nokia - FI/Espoo) ; lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [API-NEXT PATCH 05
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT
> Stuart
> Haslam
> Sent: Thursday, December 17, 2015 7:26 PM
> To: Savolainen, Petri (Nokia - FI/Espoo)
> Cc: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [API-NEXT PATCH 09/19] linux-gen
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Friday, December 25, 2015 3:49 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCH 2/3] validation: test
> odp_pktio_link_status()
>
> Signed-off-by:
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Monday, December 28, 2015 6:40 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCHv2 2/4] helper: define
> odph_pktio_wailt_linkup() helper to wait link
> -Original Message-
> From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org]
> Sent: Tuesday, December 29, 2015 12:56 PM
> To: Elo, Matias (Nokia - FI/Espoo) ; lng-
> o...@lists.linaro.org
> Subject: Re: [lng-odp] [API-NEXT PATCHv2 2/4] helper: define
> odph_pktio_
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Wednesday, December 30, 2015 12:18 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [NEXT PATCHv3 2/2] validation: test odp_pktio_link_status()
>
> Signed-off-by: Ma
For both patches.
Reviewed-and-Tested-by: Matias Elo
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT Maxim
> Uvarov
> Sent: Wednesday, December 30, 2015 3:13 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCHv4 0/2] impl
Good catch.
Reviewed-and-tested-by: Matias Elo
> On 4 Feb 2017, at 22:33, Maxim Uvarov wrote:
>
> struct rte_eth_dev_info should be initialized before
> usage with strcmp(dev_info.driver_name, "rte_ixgbe_pmd").
> Patch fixes segfault on that compare.
>
> CC: Elo Matias
> Signed-off-by: Maxim
This patch set (http://patches.opendataplane.org/patch/7828/) should be merged
to the master as it includes no API changes. These patches are needed by
odp-dpdk to enable testing HW accelerated crypto.
Regards,
Matias
Hi Oriol,
This seems rather odd indeed (especially point e). Just to be clear, are you
using OFP in any part of the test setup or is the simplified setup as follows?
standard nginx <> odp_l2fwd <> standard wget
You could try testing with different odp pktio types (preferably net
> On 17 Feb 2017, at 14:03, Oriol Arcas wrote:
>
> Hi,
>
> Thanks for your reply Marias.
>
> I tried a simpler setup and the bug persists. With a linux bridge it works
> fine.
>
> My setup is the following:
>
> | nginx <---> veth0 -|- veth1 <---> l2fwd <---> veth2 -|- veth3 <---> wget |
>
gt;
>>>>
>>>>
>>>> that is environment which we use in 'make check' testing. Even for dpdk
>>>> or netmap. You can take exact steps from .travis.yml file. But it always
>>>> run in our CI. Maybe you have some issues related to pr
> IMO, It is better for the above num value to be a #define rather than
> a local variable so that its easy to modify for multiple platforms if
> required.
>
True, will fix this.
-Matias
Ping.
> On 15 Feb 2017, at 18:01, Matias Elo wrote:
>
> Previously the highest already parsed layer was unnecessarily reparsed on
> the following packet_parse_common() calls.
>
> Signed-off-by: Matias Elo
> ---
> platform/linux-generic/odp_packet.c | 22 +++---
> 1 file changed,
> On 13 Mar 2017, at 19:58, Bill Fischofer wrote:
>
> This is a good start and I have no problem merging this as-is if we want to
> do this in stages, but I think a bit more is needed. For one, this is using a
> fixed offset for all references. I'd like to see references created with a
> coup
> But for better support thread and process modes I think
> getpid()+gettid() is needed.
>
> Maxim.
A valid point. Will be fixed in v2.
-Matias
> On 16 Mar 2017, at 17:01, Bogdan Pricope wrote:
>
> Hi Matias,
>
> Today, on "ODP Apps, Cloud, Demos, OFP" meeting I asked about the
> possibility/opportunity to add an odp_pktio_mac_addr_set() API.
>
> This API may not make sense for some pktios but may be useful for
> others: OFP may (even
Ping.
> On 22 Mar 2017, at 17:29, Matias Elo wrote:
>
> Signed-off-by: Matias Elo
> ---
> example/generator/odp_generator.c | 4 ++--
> example/ipsec/odp_ipsec_stream.c | 6 +++---
> helper/include/odp/helper/ip.h| 3 ++-
> platform/linux-generic/include/p
Ping.
> On 17 Mar 2017, at 14:16, Matias Elo wrote:
>
> Signed-off-by: Matias Elo
> ---
> platform/linux-generic/Makefile.am | 1 +
> platform/linux-generic/include/odp_thread_internal.h | 20
> platform/linux-generic/odp_thread.c | 10
Ping.
> On 27 Feb 2017, at 14:18, Matias Elo wrote:
>
> Previously packet_test_concatsplit() could fail on some pool
> implementations as the pool ran out of buffers. Increase default pools size
> and use capability to make sure the value is valid.
>
> Signed-off-by: Matias Elo
> ---
> V2:
>
> On 28 Mar 2017, at 17:21, Krishna Garapati
> wrote:
>
> This pool size is not enough with odp-dpdk. It runs out of buffers hence the
> "packet_test_ref" fails. We should increase it to even higher size.
> /Krishna
OK, if you have the reference patches merged could you verify which value wo
Sorry, wrong version number. Should be ignored.
-Matias
> On 29 Mar 2017, at 16:10, Matias Elo wrote:
>
> Previously packet_test_concatsplit() could fail on some pool
> implementations as the pool ran out of buffers. Increase default pools size
> and use capability to make sure the value is va
Hi,
The patch I just submitted "test: bench_packet: fix headroom/tailroom test"
should fix this problem.
-Matias
> On 30 Mar 2017, at 10:13, Krishna Garapati
> wrote:
>
> ping
>
> On 24 March 2017 at 14:40, Balakrishna Garapati <
> balakrishna.garap...@linaro.org> wrote:
>
>> "bench_packe
> On 31 Mar 2017, at 16:54, Maxim Uvarov wrote:
>
> On 03/31/17 10:43, Matias Elo wrote:
>> Fixes https://bugs.linaro.org/show_bug.cgi?id=2910
>>
>
> Matias please add some description here. Link to problem is good
> but people like to read only git logs.
>
> Maxim.
Sure, fixed in v2.
-Mati
Sure, I'll send rebased v2.
-Matias
> On 3 Apr 2017, at 22:38, Maxim Uvarov wrote:
>
> Matias can you please update patches and check them?
>
> Maxim.
>
> On 04/03/17 02:36, Bill Fischofer wrote:
>> For this series:
>>
>> Reviewed-and-tested-by: Bill Fischofer
>>
>> On Wed, Mar 22, 2017 a
> On 4 Apr 2017, at 18:30, Maxim Uvarov wrote:
>
> breaks build:
> https://travis-ci.org/muvarov/odp/jobs/218496566
>
>
Hi Maxim,
I'm unable to repeat this problem. Were the patches perhaps merged to the wrong
branch?
-Matias
1 - 100 of 289 matches
Mail list logo
