Re: [lng-odp] [API-NEXT PATCH 0/5] name argument definitions in *_create() functions

[Maxim Uvarov]

Merged,
Maxim.

On 11/16/16 13:43, Elo, Matias (Nokia - FI/Espoo) wrote:


Ping. This patch set has been reviewed and tested.

Reviewed-and-tested-by: Bill Fischofer >
Reviewed-by: Petri Savolainen >



On 24 Oct 2016, at 13:44, Elo, Matias (Nokia - FI/Espoo) 
> wrote:



Ping. This patch set has been reviewed and tested.

-Matias

On 20 Oct 2016, at 1.08, Bill Fischofer > 
wrote:


For this series:

Reviewed-and-tested-by: Bill Fischofer >


On Fri, Oct 14, 2016 at 3:49 AM, Matias Elo > wrote:
This patch set improves name argument definitions in *_create() 
functions to
clearly state when NULL is a valid value and when the name string 
doesn't have

to be unique.

The related function implementions are fixed to handle NULL name values
correctly. NULL values are also tested in the validation suite.

Note: NULL name values are not yet working (and tested) for 
odp_pool_create()
and odp_timer_pool_create(). Fixing these functions would require 
editing odp
shared memory code which is currently being updated in a separate 
patch set.


Matias Elo (5):
 api: improve name argument definitions in *_create() functions
 linux-gen: schedule: fix creating event group with no name
 linux-gen: queue: fix creating queue with no name
 linux-gen: classification: fix creating cos with no name
 linux-gen: timer: fix creating timer pool with no name

include/odp/api/spec/classification.h  | 10 +
include/odp/api/spec/pool.h| 17 +-
include/odp/api/spec/queue.h   |  9 +---
include/odp/api/spec/schedule.h| 12 +-
include/odp/api/spec/timer.h   |  5 -
platform/linux-generic/odp_classification.c| 11 ++---
platform/linux-generic/odp_queue.c |  8 +--
platform/linux-generic/odp_schedule.c  | 26 
+++---

platform/linux-generic/odp_schedule_sp.c   | 11 +++--
platform/linux-generic/odp_timer.c | 14 
.../api/classification/odp_classification_basic.c  |  4 +---
test/common_plat/validation/api/queue/queue.c  | 10 -
.../validation/api/scheduler/scheduler.c   |  9 +++-
13 files changed, 97 insertions(+), 49 deletions(-)

--
2.7.4

Re: [lng-odp] [API-NEXT PATCH 0/5] name argument definitions in *_create() functions

[Elo, Matias (Nokia - FI/Espoo)]

Ping. This patch set has been reviewed and tested.

Reviewed-and-tested-by: Bill Fischofer 
mailto:bill.fischo...@linaro.org>>
Reviewed-by: Petri Savolainen 
mailto:petri.savolai...@nokia.com>>


On 24 Oct 2016, at 13:44, Elo, Matias (Nokia - FI/Espoo) 
mailto:matias@nokia-bell-labs.com>> wrote:


Ping. This patch set has been reviewed and tested.

-Matias

On 20 Oct 2016, at 1.08, Bill Fischofer 
mailto:bill.fischo...@linaro.org>>
 wrote:

For this series:

Reviewed-and-tested-by: Bill Fischofer 
mailto:bill.fischo...@linaro.org>>

On Fri, Oct 14, 2016 at 3:49 AM, Matias Elo 
mailto:matias@nokia.com>>
 wrote:
This patch set improves name argument definitions in *_create() functions to
clearly state when NULL is a valid value and when the name string doesn't have
to be unique.

The related function implementions are fixed to handle NULL name values
correctly. NULL values are also tested in the validation suite.

Note: NULL name values are not yet working (and tested) for odp_pool_create()
and odp_timer_pool_create(). Fixing these functions would require editing odp
shared memory code which is currently being updated in a separate patch set.

Matias Elo (5):
 api: improve name argument definitions in *_create() functions
 linux-gen: schedule: fix creating event group with no name
 linux-gen: queue: fix creating queue with no name
 linux-gen: classification: fix creating cos with no name
 linux-gen: timer: fix creating timer pool with no name

include/odp/api/spec/classification.h  | 10 +
include/odp/api/spec/pool.h| 17 +-
include/odp/api/spec/queue.h   |  9 +---
include/odp/api/spec/schedule.h| 12 +-
include/odp/api/spec/timer.h   |  5 -
platform/linux-generic/odp_classification.c| 11 ++---
platform/linux-generic/odp_queue.c |  8 +--
platform/linux-generic/odp_schedule.c  | 26 +++---
platform/linux-generic/odp_schedule_sp.c   | 11 +++--
platform/linux-generic/odp_timer.c | 14 
.../api/classification/odp_classification_basic.c  |  4 +---
test/common_plat/validation/api/queue/queue.c  | 10 -
.../validation/api/scheduler/scheduler.c   |  9 +++-
13 files changed, 97 insertions(+), 49 deletions(-)

--
2.7.4

Re: [lng-odp] [API-NEXT PATCH 0/5] name argument definitions in *_create() functions

[Elo, Matias (Nokia - FI/Espoo)]

Ping. This patch set has been reviewed and tested.

-Matias

On 20 Oct 2016, at 1.08, Bill Fischofer 
mailto:bill.fischo...@linaro.org>> wrote:

For this series:

Reviewed-and-tested-by: Bill Fischofer 
mailto:bill.fischo...@linaro.org>>

On Fri, Oct 14, 2016 at 3:49 AM, Matias Elo 
mailto:matias@nokia.com>> wrote:
This patch set improves name argument definitions in *_create() functions to
clearly state when NULL is a valid value and when the name string doesn't have
to be unique.

The related function implementions are fixed to handle NULL name values
correctly. NULL values are also tested in the validation suite.

Note: NULL name values are not yet working (and tested) for odp_pool_create()
and odp_timer_pool_create(). Fixing these functions would require editing odp
shared memory code which is currently being updated in a separate patch set.

Matias Elo (5):
  api: improve name argument definitions in *_create() functions
  linux-gen: schedule: fix creating event group with no name
  linux-gen: queue: fix creating queue with no name
  linux-gen: classification: fix creating cos with no name
  linux-gen: timer: fix creating timer pool with no name

 include/odp/api/spec/classification.h  | 10 +
 include/odp/api/spec/pool.h| 17 +-
 include/odp/api/spec/queue.h   |  9 +---
 include/odp/api/spec/schedule.h| 12 +-
 include/odp/api/spec/timer.h   |  5 -
 platform/linux-generic/odp_classification.c| 11 ++---
 platform/linux-generic/odp_queue.c |  8 +--
 platform/linux-generic/odp_schedule.c  | 26 +++---
 platform/linux-generic/odp_schedule_sp.c   | 11 +++--
 platform/linux-generic/odp_timer.c | 14 
 .../api/classification/odp_classification_basic.c  |  4 +---
 test/common_plat/validation/api/queue/queue.c  | 10 -
 .../validation/api/scheduler/scheduler.c   |  9 +++-
 13 files changed, 97 insertions(+), 49 deletions(-)

--
2.7.4

Re: [lng-odp] [API-NEXT PATCH 0/5] name argument definitions in *_create() functions

[Bill Fischofer]

For this series:

Reviewed-and-tested-by: Bill Fischofer 

On Fri, Oct 14, 2016 at 3:49 AM, Matias Elo  wrote:

> This patch set improves name argument definitions in *_create() functions
> to
> clearly state when NULL is a valid value and when the name string doesn't
> have
> to be unique.
>
> The related function implementions are fixed to handle NULL name values
> correctly. NULL values are also tested in the validation suite.
>
> Note: NULL name values are not yet working (and tested) for
> odp_pool_create()
> and odp_timer_pool_create(). Fixing these functions would require editing
> odp
> shared memory code which is currently being updated in a separate patch
> set.
>
> Matias Elo (5):
>   api: improve name argument definitions in *_create() functions
>   linux-gen: schedule: fix creating event group with no name
>   linux-gen: queue: fix creating queue with no name
>   linux-gen: classification: fix creating cos with no name
>   linux-gen: timer: fix creating timer pool with no name
>
>  include/odp/api/spec/classification.h  | 10 +
>  include/odp/api/spec/pool.h| 17 +-
>  include/odp/api/spec/queue.h   |  9 +---
>  include/odp/api/spec/schedule.h| 12 +-
>  include/odp/api/spec/timer.h   |  5 -
>  platform/linux-generic/odp_classification.c| 11 ++---
>  platform/linux-generic/odp_queue.c |  8 +--
>  platform/linux-generic/odp_schedule.c  | 26
> +++---
>  platform/linux-generic/odp_schedule_sp.c   | 11 +++--
>  platform/linux-generic/odp_timer.c | 14 
>  .../api/classification/odp_classification_basic.c  |  4 +---
>  test/common_plat/validation/api/queue/queue.c  | 10 -
>  .../validation/api/scheduler/scheduler.c   |  9 +++-
>  13 files changed, 97 insertions(+), 49 deletions(-)
>
> --
> 2.7.4
>
>

[lng-odp] [API-NEXT PATCH 0/5] name argument definitions in *_create() functions

[Matias Elo]

This patch set improves name argument definitions in *_create() functions to
clearly state when NULL is a valid value and when the name string doesn't have
to be unique.

The related function implementions are fixed to handle NULL name values
correctly. NULL values are also tested in the validation suite.

Note: NULL name values are not yet working (and tested) for odp_pool_create()
and odp_timer_pool_create(). Fixing these functions would require editing odp
shared memory code which is currently being updated in a separate patch set.

Matias Elo (5):
  api: improve name argument definitions in *_create() functions
  linux-gen: schedule: fix creating event group with no name
  linux-gen: queue: fix creating queue with no name
  linux-gen: classification: fix creating cos with no name
  linux-gen: timer: fix creating timer pool with no name

 include/odp/api/spec/classification.h  | 10 +
 include/odp/api/spec/pool.h| 17 +-
 include/odp/api/spec/queue.h   |  9 +---
 include/odp/api/spec/schedule.h| 12 +-
 include/odp/api/spec/timer.h   |  5 -
 platform/linux-generic/odp_classification.c| 11 ++---
 platform/linux-generic/odp_queue.c |  8 +--
 platform/linux-generic/odp_schedule.c  | 26 +++---
 platform/linux-generic/odp_schedule_sp.c   | 11 +++--
 platform/linux-generic/odp_timer.c | 14 
 .../api/classification/odp_classification_basic.c  |  4 +---
 test/common_plat/validation/api/queue/queue.c  | 10 -
 .../validation/api/scheduler/scheduler.c   |  9 +++-
 13 files changed, 97 insertions(+), 49 deletions(-)

-- 
2.7.4