Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Bill Fischofer
Bien sûr. ☺ On Wed, Mar 2, 2016 at 7:33 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Ok. I'll send a v2 with atht typo fixed and your reviewed message, if that > is OK with you. > > On 2 March 2016 at 14:31, Bill Fischofer > wrote: > >> Ah, OK.

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Christophe Milard
Ok. I'll send a v2 with atht typo fixed and your reviewed message, if that is OK with you. On 2 March 2016 at 14:31, Bill Fischofer wrote: > Ah, OK. That wasn't obvious, so ignore my issue 2: > > For this series: > > Reviewed-and-tested-by: Bill Fischofer

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Bill Fischofer
Ah, OK. That wasn't obvious, so ignore my issue 2: For this series: Reviewed-and-tested-by: Bill Fischofer On Wed, Mar 2, 2016 at 7:30 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > shmem_odp should not be run alone: it is forked and execv'd by

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Christophe Milard
shmem_odp should not be run alone: it is forked and execv'd by shmem linux. If you run make check, only shmem_linux is actually called: shmem_linux forks and execv shmem_odp and makes sure it see the shared memory. The comment at the beginning of shmem_linux.c explains it all... hopefully :-)

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Bill Fischofer
Sorry, my bad. I forgot about --enable-test-vald When I add that then the tests build properly, so ignore my point 1. However, while shmem_linux runs and passes, shmem_odp still hangs. On Wed, Mar 2, 2016 at 7:19 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: > Make shmem_odp

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Christophe Milard
Make shmem_odp will hang alone: it needs its linux counterpart. Make should fix that for you. I assume as soon as we sort out why you have this make problme, it will work better. And I have noticed the typo in the second patch title ODP_SHM_PROP should be ODP_SHM_PROC. will be fix in v2 with your

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Christophe Milard
shouldn't you have --enable-test-vald as well? If I run: ./bootstrap && ./configure --with-cunit-path=/home/erachmi/linaro/ODP/check-odp/installed/x86_64/cunit-2.1-3 --enable-test-vald && make -j 8 && make check I get: ... make[3]: Entering directory

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Bill Fischofer
I failed to notice the pre-req. However after applying that patch I see the same behavior. ./bootstrap ./configure --enable-cunit-support make Result: nothing built in platforms/linux-generic/test/shmem If I go into that directory and type make then shmem_odp is built, but when I try to run it

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Christophe Milard
Hi Bill thanks for looking At it: I guess (hope) that point 2 is because the patch scoping shmem has not been merged yet (see first line of the cover letter). If you do have applied this patch, then I don't understand. (please confirm). I am very confused about point 1): I had a long fight with

Re: [lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-02 Thread Bill Fischofer
Two problems: 1. After applying this patch make doesn't make this test (Make infrastructure needs updating) 2. If I manually make the test, running it seems to hang. Haven't investigated further. On Tue, Mar 1, 2016 at 10:34 AM, Christophe Milard < christophe.mil...@linaro.org> wrote: >

[lng-odp] [PATCH 0/2] linux test for shared memory

2016-03-01 Thread Christophe Milard
(Note: requires: linux-generic: shmem: odp scope in /dev/shmem) Adding a platform side test to test sharing memory between ODP and linux. This test is more interresting for its side effects: *first complete test on the platform side building ODP and platform programs (other platform tests so far