Update checkpatch script to the latest version (2d453e3b41c80d1a2c02b02d672f5dcd73f95a12). Ignores some new unnecessary checks. PRIu8 and PRIu16 camel case warnings are also ignored. Signed-off-by: Matias Elo matias....@nokia.com
----------------github------------------------ /** Email created from pull request 508 (matiaselo:dev/update_checkpatch) ** https://github.com/Linaro/odp/pull/508 ** Patch: https://github.com/Linaro/odp/pull/508.patch ** Base sha: e1c0e4570a45d05dd9f2e8e052ce71164209d112 ** Merge commit sha: 94c406ea729fbe87a12f0278d7fdafa795ecda51 **/ ----------------/github------------------------ ----------------checkpatch.pl------------------------ WARNING: please, no spaces at the start of a line #95: FILE: scripts/checkpatch.pl:77: + --showfile emit diffed file position, not input file position$ WARNING: please, no spaces at the start of a line #96: FILE: scripts/checkpatch.pl:78: + -g, --git treat FILE as a single commit or git revision range$ ERROR: code indent should use tabs where possible #97: FILE: scripts/checkpatch.pl:79: + single git commit with:$ WARNING: please, no spaces at the start of a line #97: FILE: scripts/checkpatch.pl:79: + single git commit with:$ ERROR: code indent should use tabs where possible #98: FILE: scripts/checkpatch.pl:80: + <rev>$ WARNING: please, no spaces at the start of a line #98: FILE: scripts/checkpatch.pl:80: + <rev>$ ERROR: code indent should use tabs where possible #99: FILE: scripts/checkpatch.pl:81: + <rev>^$ WARNING: please, no spaces at the start of a line #99: FILE: scripts/checkpatch.pl:81: + <rev>^$ ERROR: code indent should use tabs where possible #100: FILE: scripts/checkpatch.pl:82: + <rev>~n$ WARNING: please, no spaces at the start of a line #100: FILE: scripts/checkpatch.pl:82: + <rev>~n$ ERROR: code indent should use tabs where possible #101: FILE: scripts/checkpatch.pl:83: + multiple git commits with:$ WARNING: please, no spaces at the start of a line #101: FILE: scripts/checkpatch.pl:83: + multiple git commits with:$ ERROR: code indent should use tabs where possible #102: FILE: scripts/checkpatch.pl:84: + <rev1>..<rev2>$ WARNING: please, no spaces at the start of a line #102: FILE: scripts/checkpatch.pl:84: + <rev1>..<rev2>$ ERROR: code indent should use tabs where possible #103: FILE: scripts/checkpatch.pl:85: + <rev1>...<rev2>$ WARNING: please, no spaces at the start of a line #103: FILE: scripts/checkpatch.pl:85: + <rev1>...<rev2>$ ERROR: code indent should use tabs where possible #104: FILE: scripts/checkpatch.pl:86: + <rev>-<count>$ WARNING: please, no spaces at the start of a line #104: FILE: scripts/checkpatch.pl:86: + <rev>-<count>$ ERROR: code indent should use tabs where possible #105: FILE: scripts/checkpatch.pl:87: + git merges are ignored$ WARNING: please, no spaces at the start of a line #105: FILE: scripts/checkpatch.pl:87: + git merges are ignored$ WARNING: please, no spaces at the start of a line #108: FILE: scripts/checkpatch.pl:90: + --list-types list the possible message types$ WARNING: please, no spaces at the start of a line #111: FILE: scripts/checkpatch.pl:93: + --show-types show the specific message type in the output$ ERROR: code indent should use tabs where possible #123: FILE: scripts/checkpatch.pl:116: + (default:/usr/share/codespell/dictionary.txt)$ WARNING: please, no spaces at the start of a line #123: FILE: scripts/checkpatch.pl:116: + (default:/usr/share/codespell/dictionary.txt)$ WARNING: please, no spaces at the start of a line #125: FILE: scripts/checkpatch.pl:118: + --typedefsfile Read additional types from this file$ WARNING: please, no spaces at the start of a line #126: FILE: scripts/checkpatch.pl:119: + --color[=WHEN] Use colors 'always', 'never', or only when output$ ERROR: code indent should use tabs where possible #127: FILE: scripts/checkpatch.pl:120: + is a terminal ('auto'). Default is 'auto'.$ WARNING: please, no spaces at the start of a line #127: FILE: scripts/checkpatch.pl:120: + is a terminal ('auto'). Default is 'auto'.$ WARNING: line over 80 characters #155: FILE: scripts/checkpatch.pl:149: + for ($text =~ /(?:(?:\bCHK|\bWARN|\bERROR|&\{\$msg_level})\s*\(|\$msg_type\s*=)\s*"([^"]+)"/g) { CHECK: Please use a blank line after function/struct/union/enum declarations #365: FILE: scripts/checkpatch.pl:573: } +$mode_perms_search = "(?:${mode_perms_search})"; WARNING: line over 80 characters #414: FILE: scripts/checkpatch.pl:624: + while ($string =~ /\b(($single_mode_perms_string_search)\b(?:\s*\|\s*)?\s*)/g) { WARNING: line over 80 characters #418: FILE: scripts/checkpatch.pl:628: + last if ($lastpos > 0 && ($curpos - length($omatch) != $lastpos)); WARNING: line over 80 characters #466: FILE: scripts/checkpatch.pl:726: + or warn "No structs that should be const will be found - file '$conststructsfile': $!\n"; WARNING: please, no spaces at the start of a line #466: FILE: scripts/checkpatch.pl:726: + or warn "No structs that should be const will be found - file '$conststructsfile': $!\n";$ WARNING: line over 80 characters #471: FILE: scripts/checkpatch.pl:731: + or warn "No additional types will be considered - file '$typedefsfile': $!\n"; CHECK: Please use a blank line after function/struct/union/enum declarations #473: FILE: scripts/checkpatch.pl:733: +} +$typeTypedefs .= '|' . $typeOtherTypedefs if ($typeOtherTypedefs ne ""); WARNING: line over 80 characters #478: FILE: scripts/checkpatch.pl:736: + my $mods = "(?x: \n" . join("|\n ", (@modifierList, @modifierListFile)) . "\n)"; WARNING: line over 80 characters #479: FILE: scripts/checkpatch.pl:737: + my $all = "(?x: \n" . join("|\n ", (@typeList, @typeListFile)) . "\n)"; WARNING: line over 80 characters #510: FILE: scripts/checkpatch.pl:796: + (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(| WARNING: line over 80 characters #524: FILE: scripts/checkpatch.pl:846: + my $status = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`; WARNING: line over 80 characters #559: FILE: scripts/checkpatch.pl:964: + my $lines = `git log --no-color --no-merges --pretty=format:'%H %s' $git_range`; WARNING: line over 80 characters #578: FILE: scripts/checkpatch.pl:982: + open($FILE, '-|', "git format-patch -M --stdout -1 $filename") || WARNING: line over 80 characters #589: FILE: scripts/checkpatch.pl:996: + $vname = "Commit " . substr($filename, 0, 12) . ' ("' . $git_commits{$filename} . '")'; WARNING: please, no spaces at the start of a line #624: FILE: scripts/checkpatch.pl:1034: + An upgrade to at least perl v5.10.0 is suggested.$ WARNING: please, no spaces at the start of a line #631: FILE: scripts/checkpatch.pl:1041: + them to the maintainer, see CHECKPATCH in MAINTAINERS.$ ERROR: code indent should use tabs where possible #733: FILE: scripts/checkpatch.pl:2223: + ^Imy $reported_maintainer_file = 1; # No MAINTAINTERS so silence warning$ WARNING: please, no space before tabs #733: FILE: scripts/checkpatch.pl:2223: + ^Imy $reported_maintainer_file = 1; # No MAINTAINTERS so silence warning$ WARNING: please, no spaces at the start of a line #733: FILE: scripts/checkpatch.pl:2223: + ^Imy $reported_maintainer_file = 1; # No MAINTAINTERS so silence warning$ WARNING: line over 80 characters #750: FILE: scripts/checkpatch.pl:2274: + if ($1 =~ m@Documentation/admin-guide/kernel-parameters.rst$@) { WARNING: line over 80 characters #815: FILE: scripts/checkpatch.pl:2450: + if ($realfile =~ m@^(?:drivers/net/|net/|drivers/staging/)@) { WARNING: line over 80 characters #830: FILE: scripts/checkpatch.pl:2473: + "Avoid using diff content in the commit message - patch(1) might not work\n" . $herecurr); WARNING: line over 80 characters #909: FILE: scripts/checkpatch.pl:2672: + ($short || $long || $space || $case || ($orig_desc ne $description) || !$hasparens)) { CHECK: Alignment should match open parenthesis #909: FILE: scripts/checkpatch.pl:2672: + if (defined($id) && + ($short || $long || $space || $case || ($orig_desc ne $description) || !$hasparens)) { WARNING: line over 80 characters #988: FILE: scripts/checkpatch.pl:2759: + "'$typo' may be misspelled - perhaps '$typo_fix'?\n" . $herecurr) && WARNING: line over 80 characters #1007: FILE: scripts/checkpatch.pl:2797: + "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet) WARNING: line over 80 characters #1025: FILE: scripts/checkpatch.pl:2847: + "MAINTAINERS entries use one tab after TYPE:\n" . $herecurr) && WARNING: line over 80 characters #1059: FILE: scripts/checkpatch.pl:2917: +# LONG_LINE_COMMENT a comment starts before but extends beyond $max_line_length WARNING: line over 80 characters #1060: FILE: scripts/checkpatch.pl:2918: +# LONG_LINE_STRING a string starts before but extends beyond $max_line_length WARNING: line over 80 characters #1073: FILE: scripts/checkpatch.pl:2931: + if ($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(?:KERN_\S+\s*|[^"]*))?($String\s*(?:|,|\)\s*;)\s*)$/ && WARNING: line over 80 characters #1074: FILE: scripts/checkpatch.pl:2932: + length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) { WARNING: line over 80 characters #1079: FILE: scripts/checkpatch.pl:2937: + } elsif ($line =~ /^\+\s*$String\s*(?:\s*|,|\)\s*;)\s*$/ || WARNING: line over 80 characters #1089: FILE: scripts/checkpatch.pl:2947: + } elsif ($rawline =~ /^\+.*\b[a-z][\w\.\+\-]*:\/\/\S+/i) { WARNING: line over 80 characters #1096: FILE: scripts/checkpatch.pl:2954: + length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) { WARNING: line over 80 characters #1100: FILE: scripts/checkpatch.pl:2958: + } elsif ($sline =~ /\s*($String(?:\s*(?:\\|,\s*|\)\s*;\s*))?)$/ && WARNING: line over 80 characters #1101: FILE: scripts/checkpatch.pl:2959: + length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) { WARNING: line over 80 characters #1108: FILE: scripts/checkpatch.pl:2966: + "line over $max_line_length characters\n" . $herecurr); WARNING: line over 80 characters #1119: FILE: scripts/checkpatch.pl:3027: + $sline =~ /^\+\t+( +)(?:$c90_Keywords\b|\{\s*$|\}\s*(?:else\b|while\b|\s*$)|$Declare\s*$Ident\s*[;=])/) { WARNING: line over 80 characters #1123: FILE: scripts/checkpatch.pl:3031: + "Statements should start on a tabstop\n" . $herecurr) && WARNING: line over 80 characters #1125: FILE: scripts/checkpatch.pl:3033: + $fixed[$fixlinenr] =~ s@(^\+\t+) +@$1 . "\t" x ($indent/8)@e; WARNING: line over 80 characters #1133: FILE: scripts/checkpatch.pl:3040: + $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|(?:\*\s*)*$Lval\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) { WARNING: line over 80 characters #1161: FILE: scripts/checkpatch.pl:3102: + "Block comments use * on subsequent lines\n" . $hereprev); WARNING: line over 80 characters #1174: FILE: scripts/checkpatch.pl:3111: + "Block comments use a trailing */ on a separate line\n" . $herecurr); WARNING: line over 80 characters #1197: FILE: scripts/checkpatch.pl:3134: + "Block comments should align the * on each line\n" . $hereprev); WARNING: line over 80 characters #1222: FILE: scripts/checkpatch.pl:3237: + $prevline =~ /^\+(?:(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*)?($Ident)\(/) { WARNING: line over 80 characters #1261: FILE: scripts/checkpatch.pl:3445: + if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|(?:do|else)\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { WARNING: line over 80 characters #1320: FILE: scripts/checkpatch.pl:3570: + "Avoid multiple line dereference - prefer '$ref'\n" . $hereprev); WARNING: line over 80 characters #1324: FILE: scripts/checkpatch.pl:3574: + while ($line =~ m{\b($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) { WARNING: line over 80 characters #1328: FILE: scripts/checkpatch.pl:3578: + if ($type =~ /^(?:(?:$Storage|$Inline|$Attribute)\s+)*((?:un)?signed)((?:\s*\*)*)\s*$/) { WARNING: line over 80 characters #1335: FILE: scripts/checkpatch.pl:3585: + "Prefer '" . trim($sign) . " int" . rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . $herecurr) && WARNING: line over 80 characters #1342: FILE: scripts/checkpatch.pl:3592: + $fixed[$fixlinenr] =~ s@\b$sign\s*\Q$pointer\E\s*$var\b@$decl$var@; WARNING: line over 80 characters #1364: FILE: scripts/checkpatch.pl:3716: + if ($line =~ /^\+$Type\s*$Ident(?:\s+$Modifier)*\s*=\s*($zero_initializer)\s*;/) { WARNING: line over 80 characters #1368: FILE: scripts/checkpatch.pl:3718: + "do not initialise globals to $1\n" . $herecurr) && WARNING: line over 80 characters #1371: FILE: scripts/checkpatch.pl:3720: + $fixed[$fixlinenr] =~ s/(^.$Type\s*$Ident(?:\s+$Modifier)*)\s*=\s*$zero_initializer\s*;/$1;/; WARNING: line over 80 characters #1383: FILE: scripts/checkpatch.pl:3729: + $fixed[$fixlinenr] =~ s/(\bstatic\s.*?)\s*=\s*$zero_initializer\s*;/$1;/; WARNING: line over 80 characters #1427: FILE: scripts/checkpatch.pl:3867: + "Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()\n" . $herecurr); WARNING: line over 80 characters #1463: FILE: scripts/checkpatch.pl:3885: + "printk() should include KERN_<LEVEL> facility level\n" . $herecurr); WARNING: line over 80 characters #1480: FILE: scripts/checkpatch.pl:3931: + "open brace '{' following function definitions go on the next line\n" . $herecurr) && WARNING: line over 80 characters #1500: FILE: scripts/checkpatch.pl:4378: + $msg_level = \&CHK if (($op eq '?:' || $op eq '?' || $op eq ':') && $ctx =~ /VxV/); WARNING: line over 80 characters #1505: FILE: scripts/checkpatch.pl:4381: + "spaces required around that '$op' $at\n" . $hereptr)) { WARNING: line over 80 characters #1520: FILE: scripts/checkpatch.pl:4446: + $fixed[$fixlinenr] =~ s/^(\+.*(?:do|\)))\{/$1 {/; WARNING: line over 80 characters #1536: FILE: scripts/checkpatch.pl:4542: + while ($test =~ /(?:^|[^\w\&\!\~])+\s*\(\s*([\&\!\~]?\s*$Lval\s*(?:$Compare\s*$FuncArg)?)\s*\)/g) { WARNING: line over 80 characters #1550: FILE: scripts/checkpatch.pl:4556: + "Unnecessary parentheses around '$match'\n" . $herectx); WARNING: line over 80 characters #1566: FILE: scripts/checkpatch.pl:4619: + $line =~ /^\+(.*)\b($Constant|[A-Z_][A-Z0-9_]*)\s*($Compare)\s*($LvalOrFunc)/) { WARNING: line over 80 characters #1575: FILE: scripts/checkpatch.pl:4628: + "Comparisons should place the constant on the right side of the test\n" . $herecurr) && WARNING: line over 80 characters #1586: FILE: scripts/checkpatch.pl:4639: + $fixed[$fixlinenr] =~ s/\(\s*\Q$const\E\s*$Compare\s*\Q$to\E\s*\)/($to $newcomp $const)/; WARNING: line over 80 characters #1617: FILE: scripts/checkpatch.pl:4908: + $has_arg_concat = 1 if ($ctx =~ /\#\#/ && $ctx !~ /\#\#\s*(?:__VA_ARGS__|args)\b/); WARNING: line over 80 characters #1625: FILE: scripts/checkpatch.pl:4916: + $define_args = substr($define_args, 1, length($define_args) - 2); WARNING: line over 80 characters #1692: FILE: scripts/checkpatch.pl:4981: + ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE", WARNING: line over 80 characters #1693: FILE: scripts/checkpatch.pl:4982: + "Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects\n" . "$herectx"); ERROR: code indent should use tabs where possible #1723: FILE: scripts/checkpatch.pl:5012: +^I^I^I next if ($arg =~ /\.\.\./);$ ERROR: code indent should use tabs where possible #1724: FILE: scripts/checkpatch.pl:5013: +^I^I^I next if ($arg =~ /^type$/i);$ WARNING: line over 80 characters #1726: FILE: scripts/checkpatch.pl:5015: + $tmp_stmt =~ s/\b(typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g; WARNING: line over 80 characters #1732: FILE: scripts/checkpatch.pl:5021: + "Macro argument reuse '$arg' - possible side-effects?\n" . "$herectx"); WARNING: line over 80 characters #1735: FILE: scripts/checkpatch.pl:5024: + if ($tmp_stmt =~ m/($Operators)?\s*\b$arg\b\s*($Operators)?/m && WARNING: line over 80 characters #1739: FILE: scripts/checkpatch.pl:5028: + "Macro argument '$arg' may be better as '($arg)' to avoid precedence issues\n" . "$herectx"); WARNING: line over 80 characters #1751: FILE: scripts/checkpatch.pl:5240: + CHK("BRACES", "Unbalanced braces around else statement\n" . $herecurr); WARNING: line over 80 characters #1762: FILE: scripts/checkpatch.pl:5263: + "Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst\n" . $herecurr); WARNING: line over 80 characters #1784: FILE: scripts/checkpatch.pl:5311: + get_quoted_string($line, $rawline) =~ /\b$context_function\b/ && WARNING: line over 80 characters #1785: FILE: scripts/checkpatch.pl:5312: + length(get_quoted_string($line, $rawline)) != (length($context_function) + 2)) { WARNING: line over 80 characters #1787: FILE: scripts/checkpatch.pl:5314: + "Prefer using '\"%s...\", __func__' to using '$context_function', this function's name, in a string\n" . $herecurr); WARNING: line over 80 characters #1798: FILE: scripts/checkpatch.pl:5328: + if ($line =~ /$String[A-Z_]/ || $line =~ /[A-Za-z0-9_]$String/) { WARNING: line over 80 characters #1825: FILE: scripts/checkpatch.pl:5348: + "\%L$1 is non-standard C, use %ll$1\n" . $herecurr); WARNING: line over 80 characters #1831: FILE: scripts/checkpatch.pl:5354: + "%Z$1 is non-standard C, use %z$1\n" . $herecurr); WARNING: line over 80 characters #1837: FILE: scripts/checkpatch.pl:5360: + "Prefixing 0x with decimal output is defective\n" . $herecurr); WARNING: line over 80 characters #1857: FILE: scripts/checkpatch.pl:5381: + if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?|(?:kmem_cache|mempool|dma_pool)_destroy)$expr/) { WARNING: line over 80 characters #1860: FILE: scripts/checkpatch.pl:5384: + "$func(NULL) is safe and this check is probably not required\n" . $hereprev) && WARNING: line over 80 characters #1865: FILE: scripts/checkpatch.pl:5389: + if ($lines[$linenr - 2] =~ /^\+(\t*)if\s*\(\s*$tested\s*\)\s*$/) { WARNING: line over 80 characters #1870: FILE: scripts/checkpatch.pl:5394: + if ($lines[$linenr - 1] =~ /^\+(\t+)$func\s*\(\s*$tested\s*\)\s*;\s*$/) { WARNING: line over 80 characters #1872: FILE: scripts/checkpatch.pl:5396: + if (length($leading_tabs) + 1 ne length($new_leading_tabs)) { WARNING: line over 80 characters #1879: FILE: scripts/checkpatch.pl:5403: + fix_delete_line($fixlinenr - 1, $prevrawline); WARNING: line over 80 characters #1880: FILE: scripts/checkpatch.pl:5404: + $fixed[$fixlinenr] =~ s/^\+$new_leading_tabs/\+$leading_tabs/; WARNING: line over 80 characters #1891: FILE: scripts/checkpatch.pl:5421: + if ($s =~ /(?:^|\n)[ \+]\s*(?:$Type\s*)?\Q$testval\E\s*=\s*(?:\([^\)]*\)\s*)?\s*(?:devm_)?(?:[kv][czm]alloc(?:_node|_array)?\b|kstrdup|kmemdup|(?:dev_)?alloc_skb)/) { WARNING: line over 80 characters #1902: FILE: scripts/checkpatch.pl:5441: + "Avoid logging continuation uses where feasible\n" . $herecurr); WARNING: line over 80 characters #1946: FILE: scripts/checkpatch.pl:5631: + $line !~ m/^.\s*\#\s*define\s+(?:$underscore_smp_barriers)\s*\(/) { WARNING: line over 80 characters #1948: FILE: scripts/checkpatch.pl:5633: + "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr); WARNING: line over 80 characters #1955: FILE: scripts/checkpatch.pl:5640: + "waitqueue_active without comment\n" . $herecurr); WARNING: line over 80 characters #1962: FILE: scripts/checkpatch.pl:5647: + "$1read_barrier_depends should only be used in READ_ONCE or DEC Alpha code\n" . $herecurr); WARNING: line over 80 characters #1974: FILE: scripts/checkpatch.pl:5659: + "storage class '$2' should be located before type '$1'\n" . $herecurr); WARNING: line over 80 characters #1984: FILE: scripts/checkpatch.pl:5667: + "storage class should be at the beginning of the declaration\n" . $herecurr); WARNING: line over 80 characters #2004: FILE: scripts/checkpatch.pl:5745: + "Prefer kernel type '$kernel_type' over '$type'\n" . $herecurr) && WARNING: line over 80 characters #2006: FILE: scripts/checkpatch.pl:5747: + $fixed[$fixlinenr] =~ s/\b$type\b/$kernel_type/; WARNING: line over 80 characters #2016: FILE: scripts/checkpatch.pl:5757: + "Unnecessary typecast of c90 int constant\n" . $herecurr) && WARNING: line over 80 characters #2027: FILE: scripts/checkpatch.pl:5768: + $fixed[$fixlinenr] =~ s/\Q$cast\E$const\b/$newconst$suffix/; ERROR: code indent should use tabs where possible #2046: FILE: scripts/checkpatch.pl:5814: +^I^I for (my $count = $linenr; $count <= $lc; $count++) {$ WARNING: line over 80 characters #2047: FILE: scripts/checkpatch.pl:5815: + my $fmt = get_quoted_string($lines[$count - 1], raw_line($count, 0)); WARNING: line over 80 characters #2049: FILE: scripts/checkpatch.pl:5817: + if ($fmt =~ /(\%[\*\d\.]*p(?![\WSsBKRraEhMmIiUDdgVCbGNOx]).)/) { WARNING: line over 80 characters #2058: FILE: scripts/checkpatch.pl:5826: + for (my $count = $linenr + 1; $count <= $lc; $count++) { WARNING: line over 80 characters #2059: FILE: scripts/checkpatch.pl:5827: + $stat_real = $stat_real . "\n" . raw_line($count, 0); WARNING: line over 80 characters #2064: FILE: scripts/checkpatch.pl:5832: + $use =~ s/pS/ps/ if ($bad_extension =~ /pf/); WARNING: line over 80 characters #2067: FILE: scripts/checkpatch.pl:5835: + "$ext_type vsprintf pointer extension '$bad_extension'$use\n" . "$here\n$stat_real\n"); WARNING: line over 80 characters #2075: FILE: scripts/checkpatch.pl:5842: + $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/) { WARNING: line over 80 characters #2086: FILE: scripts/checkpatch.pl:5860: +# $stat =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) { WARNING: line over 80 characters #2088: FILE: scripts/checkpatch.pl:5862: +# "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . "$here\n$stat\n") && WARNING: line over 80 characters #2090: FILE: scripts/checkpatch.pl:5864: +# $fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/; WARNING: line over 80 characters #2097: FILE: scripts/checkpatch.pl:5871: +# $stat =~ /^\+(?:.*?)\bmemcmp\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) { WARNING: line over 80 characters #2099: FILE: scripts/checkpatch.pl:5873: +# "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . "$here\n$stat\n") WARNING: line over 80 characters #2106: FILE: scripts/checkpatch.pl:5880: +# $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) { WARNING: line over 80 characters #2112: FILE: scripts/checkpatch.pl:5886: +# "Prefer eth_zero_addr over memset()\n" . "$here\n$stat\n") && WARNING: line over 80 characters #2114: FILE: scripts/checkpatch.pl:5888: +# $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($2)/; WARNING: line over 80 characters #2118: FILE: scripts/checkpatch.pl:5892: +# "Prefer eth_broadcast_addr() over memset()\n" . "$here\n$stat\n") && WARNING: line over 80 characters #2120: FILE: scripts/checkpatch.pl:5894: +# $fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($2)/; WARNING: line over 80 characters #2134: FILE: scripts/checkpatch.pl:6019: + $stat =~ /^.\s*(?:extern\s+)?$Type\s*(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*\(\s*([^{]+)\s*\)\s*;/s && WARNING: line over 80 characters #2137: FILE: scripts/checkpatch.pl:6022: + while ($args =~ m/\s*($Type\s*(?:$Ident|\(\s*\*\s*$Ident?\s*\)\s*$balanced_parens)?)/g) { WARNING: line over 80 characters #2139: FILE: scripts/checkpatch.pl:6024: + if ($arg =~ /^$Type$/ && $arg !~ /enum\s+$Ident$/) { WARNING: line over 80 characters #2141: FILE: scripts/checkpatch.pl:6026: + "function definition argument '$arg' should also have an identifier name\n" . $herecurr); WARNING: line over 80 characters #2149: FILE: scripts/checkpatch.pl:6034: + $stat =~ /^.\s*(?:$Storage\s+)?$Type\s*($Ident)\s*$balanced_parens\s*{/s) { WARNING: line over 80 characters #2165: FILE: scripts/checkpatch.pl:6050: + "open brace '{' following function definitions go on the next line\n" . $herectx); WARNING: line over 80 characters #2176: FILE: scripts/checkpatch.pl:6060: + "__setup appears un-documented -- check Documentation/admin-guide/kernel-parameters.rst\n" . $herecurr); WARNING: line over 80 characters #2186: FILE: scripts/checkpatch.pl:6081: + $stat =~ /^\+\s*($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)\s*,/) { WARNING: line over 80 characters #2198: FILE: scripts/checkpatch.pl:6099: + $herectx .= raw_line($linenr, $n) . "\n"; WARNING: line over 80 characters #2202: FILE: scripts/checkpatch.pl:6102: + "Prefer $newfunc over $oldfunc with multiply\n" . $herectx) && WARNING: line over 80 characters #2216: FILE: scripts/checkpatch.pl:6132: +# check for #defines like: 1 << <digit> that could be BIT(digit), it is not exported to uapi WARNING: line over 80 characters #2218: FILE: scripts/checkpatch.pl:6134: + $line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) { WARNING: line over 80 characters #2227: FILE: scripts/checkpatch.pl:6145: + if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(CONFIG_[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) { WARNING: line over 80 characters #2230: FILE: scripts/checkpatch.pl:6148: + "Prefer IS_ENABLED(<FOO>) to CONFIG_<FOO> || CONFIG_<FOO>_MODULE\n" . $herecurr) && WARNING: line over 80 characters #2232: FILE: scripts/checkpatch.pl:6150: + $fixed[$fixlinenr] = "\+#if IS_ENABLED($config)"; WARNING: line over 80 characters #2244: FILE: scripts/checkpatch.pl:6171: + $has_break = 1 if ($fline =~ /\bswitch\b|\b(?:break\s*;[\s$;]*$|exit\s*\(\b|return\b|goto\b|continue\b)/); WARNING: line over 80 characters #2249: FILE: scripts/checkpatch.pl:6175: + "Possible switch case/default not preceded by break or fallthrough comment\n" . $herecurr); WARNING: line over 80 characters #2304: FILE: scripts/checkpatch.pl:6264: + "struct $1 should normally be const\n" . $herecurr); WARNING: line over 80 characters #2315: FILE: scripts/checkpatch.pl:6307: + "recursive locking is bad, do not use this ever.\n" . $herecurr); WARNING: line over 80 characters #2330: FILE: scripts/checkpatch.pl:6332: + $stat =~ /\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?\s*(\s*(?:${multi_mode_perms_string_search}|0[0-7]{3,3})\s*)\s*\)?\s*,\s*(\w+)\s*,\s*(\w+)\s*\)/) { WARNING: line over 80 characters #2342: FILE: scripts/checkpatch.pl:6344: + $fixed[$fixlinenr] =~ s/\bDEVICE_ATTR\s*\(\s*$var\s*,\s*\Q$perms\E\s*,\s*$show\s*,\s*$store\s*\)/DEVICE_ATTR_RW(${var})/; WARNING: line over 80 characters #2350: FILE: scripts/checkpatch.pl:6352: + $fixed[$fixlinenr] =~ s/\bDEVICE_ATTR\s*\(\s*$var\s*,\s*\Q$perms\E\s*,\s*$show\s*,\s*NULL\s*\)/DEVICE_ATTR_RO(${var})/; WARNING: line over 80 characters #2358: FILE: scripts/checkpatch.pl:6360: + $fixed[$fixlinenr] =~ s/\bDEVICE_ATTR\s*\(\s*$var\s*,\s*\Q$perms\E\s*,\s*NULL\s*,\s*$store\s*\)/DEVICE_ATTR_WO(${var})/; WARNING: line over 80 characters #2364: FILE: scripts/checkpatch.pl:6366: + $newshow = "${var}_show" if ($show ne "NULL" && $show ne "${var}_show"); WARNING: line over 80 characters #2366: FILE: scripts/checkpatch.pl:6368: + $newstore = "${var}_store" if ($store ne "NULL" && $store ne "${var}_store"); WARNING: line over 80 characters #2375: FILE: scripts/checkpatch.pl:6377: + "Consider renaming function(s)$rename\n" . $herecurr); WARNING: line over 80 characters #2378: FILE: scripts/checkpatch.pl:6380: + "DEVICE_ATTR unusual permissions '$perms' used\n" . $herecurr); WARNING: line over 80 characters #2398: FILE: scripts/checkpatch.pl:6400: + for (my $count = $linenr + 1; $count <= $lc; $count++) { WARNING: line over 80 characters #2399: FILE: scripts/checkpatch.pl:6401: + $stat_real = $stat_real . "\n" . raw_line($count, 0); WARNING: line over 80 characters #2409: FILE: scripts/checkpatch.pl:6409: + my $test = "\\b$func\\s*\\(${skip_args}($FuncArg(?:\\|\\s*$FuncArg)*)\\s*[,\\)]"; WARNING: line over 80 characters #2415: FILE: scripts/checkpatch.pl:6413: + if (!($func =~ /^(?:module_param|proc_create)/ && $val eq "0") && WARNING: line over 80 characters #2418: FILE: scripts/checkpatch.pl:6415: + ($val =~ /^$Octal$/ && length($val) ne 4))) { WARNING: line over 80 characters #2422: FILE: scripts/checkpatch.pl:6417: + "Use 4 digit octal (0777) not decimal permissions\n" . "$here\n" . $stat_real); WARNING: line over 80 characters #2424: FILE: scripts/checkpatch.pl:6419: + if ($val =~ /^$Octal$/ && (oct($val) & 02)) { WARNING: line over 80 characters #2427: FILE: scripts/checkpatch.pl:6421: + "Exporting writable files is usually an error. Consider more restrictive permissions.\n" . "$here\n" . $stat_real); WARNING: line over 80 characters #2438: FILE: scripts/checkpatch.pl:6432: + "Symbolic permissions '$oval' are not preferred. Consider using octal permissions '$octal'.\n" . $herecurr) && WARNING: line over 80 characters #2446: FILE: scripts/checkpatch.pl:6440: + my $extracted_string = get_quoted_string($line, $rawline); WARNING: line over 80 characters #2458: FILE: scripts/checkpatch.pl:6452: + "unknown module license " . $extracted_string . "\n" . $herecurr); WARNING: please, no spaces at the start of a line #2494: FILE: scripts/checkpatch.pl:6498: + mechanically convert to the typical style using --fix or --fix-inplace.$ WARNING: please, no spaces at the start of a line #2507: FILE: scripts/checkpatch.pl:6508: + You may wish to use scripts/cleanpatch or scripts/cleanfile$ WARNING: line over 80 characters #2548: FILE: scripts/checkpatch.pl:6555: + print "$vname has no obvious style problems and is ready for submission.\n"; total: 15 errors, 174 warnings, 3 checks, 2420 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile to_send-p-000.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ----------------/checkpatch.pl------------------------
