>> Sent: Thursday, February 15, 2018 4:00 PM
> > >> To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com
> >;
> > >> Bill Fischofer <bill.fischo...@linaro.org>
> > >> Cc: lng-odp-forward <lng-odp@lists.linaro.org>
> > &
ill Fischofer <bill.fischo...@linaro.org>
> >> Cc: lng-odp-forward <lng-odp@lists.linaro.org>
> >> Subject: Re: [lng-odp] odp_packet_data() considered harmful
> >>
> >> On 15/02/18 16:32, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> >>
o) <petri.savolai...@nokia.com>;
>> Bill Fischofer <bill.fischo...@linaro.org>
>> Cc: lng-odp-forward <lng-odp@lists.linaro.org>
>> Subject: Re: [lng-odp] odp_packet_data() considered harmful
>>
>> On 15/02/18 16:32, Savolainen, Petri (Nokia -
>
> > Cc: lng-odp-forward <lng-odp@lists.linaro.org>
> > Subject: Re: [lng-odp] odp_packet_data() considered harmful
> >
> > On 15/02/18 16:32, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> >
> > > odp_packet_offset() is more complex than the proposed
&
; Cc: lng-odp-forward <lng-odp@lists.linaro.org>
> Subject: Re: [lng-odp] odp_packet_data() considered harmful
>
> On 15/02/18 16:32, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
> > odp_packet_offset() is more complex than the proposed
> odp_packet_data_seg_len(). A
On 15/02/18 16:32, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> odp_packet_offset() is more complex than the proposed
> odp_packet_data_seg_len(). Application mostly finds its data from the first
> segment, so it's important to keep the most common use case fast (== simple).
> We cannot and
Subject: Re: [lng-odp] odp_packet_data() considered harmful
We already have such a routine: odp_packet_offset(pkt, 0, _len, NULL);
The fourth parameter of this routine returns the odp_packet_seg_t of the
segment containing the specified offset (2nd parameter). I'm not aware of any
use of this ca
.@lists.linaro.org] On Behalf Of
> > Dmitry Eremin-Solenikov
> > Sent: Tuesday, February 13, 2018 4:46 PM
> > To: lng-odp-forward <lng-odp@lists.linaro.org>
> > Subject: [lng-odp] odp_packet_data() considered harmful
> >
> > Hello,
> >
> > Thanks to
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of
> Dmitry Eremin-Solenikov
> Sent: Tuesday, February 13, 2018 4:46 PM
> To: lng-odp-forward <lng-odp@lists.linaro.org>
> Subject: [lng-odp] odp_packet_data() consi
Hello,
Thanks to PR #470 I've stumbled upon odp_packet_data() function again. I
think we should deprecate and remove it. It makes false assumption that
the whole packet can be addressed using single pointer + offset from
that. We already have public functions dealing with segments, getting
10 matches
Mail list logo