Re: [lng-odp] [PATCH] example: generator: actually use specified default

[Maxim Uvarov]

Retested this patch again. Now I can not reproduce issue. Merged.

Maxim.

On 10/12/16 21:42, Mike Holmes wrote:



On 22 September 2016 at 10:33, Maxim Uvarov > wrote:


Reverted this patch due to have issues with performance/odp_l2fwd


The patch is correct I think, the intended default is not being honored.
If the odp_l2fwd app depends on the incorrect behavior and actually 
requires a flood, that needs a patch to specify the behavior it 
actually needs.
I did not see the failure on my platform, so I cannot confirm this, 
but I think this will do it


diff --git a/test/common_plat/performance/odp_l2fwd_run.sh 
b/test/common_plat/performance/odp_l2fwd_run.sh

index e64aa47..757cf53 100755
--- a/test/common_plat/performance/odp_l2fwd_run.sh
+++ b/test/common_plat/performance/odp_l2fwd_run.sh
@@ -32,6 +32,8 @@ TEST_SKIPPED=77
 PLATFORM_VALIDATION=${TEST_SRC_DIR}/../../$ODP_PLATFORM/validation
+FLOOD_MODE=0
+
 # Use installed pktio env or for make check take it from platform 
directory

 if [ -f "./pktio_env" ]; then
. ./pktio_env
@@ -66,7 +68,7 @@ run_l2fwd()
#@todo: limit odp_generator to cores
#https://bugs.linaro.org/show_bug.cgi?id=1398
-   (odp_generator${EXEEXT} -I $IF0 \
+   (odp_generator${EXEEXT} --interval $FLOOD_MODE -I $IF0 \
--srcip 192.168.0.1 --dstip 192.168.0.2 \
-m u 2>&1 > /dev/null) \
2>&1 > /dev/null &

 I will post the pair as a new series.



Maxim.

On 09/14/16 05:50, Bill Fischofer wrote:

On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes
>
wrote:

The help states default is 1000ms. 0 for flood mode,
however the
default was incorrectly set to zero.

Signed-off-by: Mike Holmes >

Reviewed-by: Bill Fischofer >


---
  example/generator/odp_generator.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/example/generator/odp_generator.c
b/example/generator/odp_
generator.c
index b0053b9..48d7f5f 100644
--- a/example/generator/odp_generator.c
+++ b/example/generator/odp_generator.c
@@ -946,6 +946,7 @@ static void parse_args(int argc, char
*argv[],
appl_args_t *appl_args)
 appl_args->number = -1;
 appl_args->payload = 56;
 appl_args->timeout = -1;
+   appl_args->interval = DEFAULT_PKT_INTERVAL;

 opterr = 0; /* do not issue errors on helper
options */

--
2.7.4






--
Mike Holmes
Program Manager - Linaro Networking Group
Linaro.org ***│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"

Re: [lng-odp] [PATCH] example: generator: actually use specified default

[Mike Holmes]

On 22 September 2016 at 10:33, Maxim Uvarov  wrote:

> Reverted this patch due to have issues with performance/odp_l2fwd


The patch is correct I think, the intended default is not being honored.
If the odp_l2fwd app depends on the incorrect behavior and actually
requires a flood, that needs a patch to specify the behavior it actually
needs.
I did not see the failure on my platform, so I cannot confirm this, but I
think this will do it

diff --git a/test/common_plat/performance/odp_l2fwd_run.sh
b/test/common_plat/performance/odp_l2fwd_run.sh
index e64aa47..757cf53 100755
--- a/test/common_plat/performance/odp_l2fwd_run.sh
+++ b/test/common_plat/performance/odp_l2fwd_run.sh
@@ -32,6 +32,8 @@ TEST_SKIPPED=77

 PLATFORM_VALIDATION=${TEST_SRC_DIR}/../../$ODP_PLATFORM/validation

+FLOOD_MODE=0
+
 # Use installed pktio env or for make check take it from platform directory
 if [ -f "./pktio_env" ]; then
. ./pktio_env
@@ -66,7 +68,7 @@ run_l2fwd()

#@todo: limit odp_generator to cores
#https://bugs.linaro.org/show_bug.cgi?id=1398
-   (odp_generator${EXEEXT} -I $IF0 \
+   (odp_generator${EXEEXT} --interval $FLOOD_MODE -I $IF0 \
--srcip 192.168.0.1 --dstip 192.168.0.2 \
-m u 2>&1 > /dev/null) \
2>&1 > /dev/null &

 I will post the pair as a new series.


>
>
> Maxim.
>
> On 09/14/16 05:50, Bill Fischofer wrote:
>
>> On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes 
>> wrote:
>>
>> The help states default is 1000ms. 0 for flood mode, however the
>>> default was incorrectly set to zero.
>>>
>>> Signed-off-by: Mike Holmes 
>>>
>>> Reviewed-by: Bill Fischofer 
>>
>>
>> ---
>>>   example/generator/odp_generator.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/example/generator/odp_generator.c b/example/generator/odp_
>>> generator.c
>>> index b0053b9..48d7f5f 100644
>>> --- a/example/generator/odp_generator.c
>>> +++ b/example/generator/odp_generator.c
>>> @@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[],
>>> appl_args_t *appl_args)
>>>  appl_args->number = -1;
>>>  appl_args->payload = 56;
>>>  appl_args->timeout = -1;
>>> +   appl_args->interval = DEFAULT_PKT_INTERVAL;
>>>
>>>  opterr = 0; /* do not issue errors on helper options */
>>>
>>> --
>>> 2.7.4
>>>
>>>
>>>
>


-- 
Mike Holmes
Program Manager - Linaro Networking Group
Linaro.org  *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"

Re: [lng-odp] [PATCH] example: generator: actually use specified default

[Maxim Uvarov]

Reverted this patch due to have issues with performance/odp_l2fwd

Maxim.

On 09/14/16 05:50, Bill Fischofer wrote:

On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes 
wrote:


The help states default is 1000ms. 0 for flood mode, however the
default was incorrectly set to zero.

Signed-off-by: Mike Holmes 


Reviewed-by: Bill Fischofer 



---
  example/generator/odp_generator.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/example/generator/odp_generator.c b/example/generator/odp_
generator.c
index b0053b9..48d7f5f 100644
--- a/example/generator/odp_generator.c
+++ b/example/generator/odp_generator.c
@@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[],
appl_args_t *appl_args)
 appl_args->number = -1;
 appl_args->payload = 56;
 appl_args->timeout = -1;
+   appl_args->interval = DEFAULT_PKT_INTERVAL;

 opterr = 0; /* do not issue errors on helper options */

--
2.7.4

Re: [lng-odp] [PATCH] example: generator: actually use specified default

[Maxim Uvarov]

Merged,
Maxim.

On 09/14/16 05:50, Bill Fischofer wrote:

On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes 
wrote:


The help states default is 1000ms. 0 for flood mode, however the
default was incorrectly set to zero.

Signed-off-by: Mike Holmes 


Reviewed-by: Bill Fischofer 



---
  example/generator/odp_generator.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/example/generator/odp_generator.c b/example/generator/odp_
generator.c
index b0053b9..48d7f5f 100644
--- a/example/generator/odp_generator.c
+++ b/example/generator/odp_generator.c
@@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[],
appl_args_t *appl_args)
 appl_args->number = -1;
 appl_args->payload = 56;
 appl_args->timeout = -1;
+   appl_args->interval = DEFAULT_PKT_INTERVAL;

 opterr = 0; /* do not issue errors on helper options */

--
2.7.4

Re: [lng-odp] [PATCH] example: generator: actually use specified default

[Bill Fischofer]

On Tue, Sep 13, 2016 at 12:35 PM, Mike Holmes 
wrote:

> The help states default is 1000ms. 0 for flood mode, however the
> default was incorrectly set to zero.
>
> Signed-off-by: Mike Holmes 
>

Reviewed-by: Bill Fischofer 


> ---
>  example/generator/odp_generator.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/example/generator/odp_generator.c b/example/generator/odp_
> generator.c
> index b0053b9..48d7f5f 100644
> --- a/example/generator/odp_generator.c
> +++ b/example/generator/odp_generator.c
> @@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[],
> appl_args_t *appl_args)
> appl_args->number = -1;
> appl_args->payload = 56;
> appl_args->timeout = -1;
> +   appl_args->interval = DEFAULT_PKT_INTERVAL;
>
> opterr = 0; /* do not issue errors on helper options */
>
> --
> 2.7.4
>
>