Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
muvarov replied on github web page: example/ipfragreass/Makefile.am line 3 @@ -1,5 +1,7 @@ include $(top_srcdir)/example/Makefile.inc +LDADD += $(ATOMIC_LIBS) Comment: Ok, Than. Agree. > muvarov wrote > also please add link to bugz if it's bug fix to git comment. >> muvarov wrote >>

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
muvarov replied on github web page: test/validation/api/time/time.c line 19 @@ -423,11 +423,12 @@ static void time_test_accuracy(time_cb time_cur, time_from_ns_cb time_from_ns) { int i; odp_time_t t1, t2, wait, diff; - clock_t c1, c2; + struct timeval tv1, tv2,

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
muvarov replied on github web page: example/ipfragreass/Makefile.am line 3 @@ -1,5 +1,7 @@ include $(top_srcdir)/example/Makefile.inc +LDADD += $(ATOMIC_LIBS) Comment: This kind of thing which is better to avoid. If we are going to merge odp implementations platforms to common repo then it

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
muvarov replied on github web page: test/validation/api/time/time.c line 19 @@ -423,11 +423,12 @@ static void time_test_accuracy(time_cb time_cur, time_from_ns_cb time_from_ns) { int i; odp_time_t t1, t2, wait, diff; - clock_t c1, c2; + struct timeval tv1, tv2,

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: test/validation/api/time/time.c line 19 @@ -423,11 +423,12 @@ static void time_test_accuracy(time_cb time_cur, time_from_ns_cb time_from_ns) { int i; odp_time_t t1, t2, wait, diff; - clock_t c1, c2; + struct

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-14 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: example/ipfragreass/Makefile.am line 3 @@ -1,5 +1,7 @@ include $(top_srcdir)/example/Makefile.inc +LDADD += $(ATOMIC_LIBS) Comment: This example is not generic enough. It uses atomic primitives directly. > muvarov wrote > This kind

Re: [lng-odp] [PATCH v11] Misc fixes

2018-01-03 Thread Github ODP bot
Dmitry Eremin-Solenikov(lumag) replied on github web page: test/validation/api/time/time.c @@ -436,12 +436,12 @@ static void time_test_accuracy(time_cb time_cur, time_from_ns_cb time_from_ns) wait = odp_time_sum(wait, sec); } + c2 = time(NULL); t2 =