svn commit: r1569228 - /incubator/log4cxx/trunk/src/main/include/log4cxx/level.h

2014-02-18 Thread tschoening
Author: tschoening Date: Tue Feb 18 08:22:16 2014 New Revision: 1569228 URL: http://svn.apache.org/r1569228 Log: LOGCXX-394: Hopefully fixed a GCC problem: log4cxx/src/main/include/log4cxx/level.h:279:14: error: specializing member ‘log4cxx::helpers::ObjectPtrT::operator==’ requires ‘template<>

[jira] [Commented] (LOGCXX-394) Levels are not thread safe

2014-02-18 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903882#comment-13903882 ] Thorsten Schöning commented on LOGCXX-394: -- > First, I don't understand the compa

svn commit: r1569234 - in /incubator/log4cxx/trunk/src/main/cpp: inputstreamreader.cpp socketoutputstream.cpp

2014-02-18 Thread tschoening
Author: tschoening Date: Tue Feb 18 09:10:10 2014 New Revision: 1569234 URL: http://svn.apache.org/r1569234 Log: LOGCXX-367: Use C++ headers instead of C-ones. Modified: incubator/log4cxx/trunk/src/main/cpp/inputstreamreader.cpp incubator/log4cxx/trunk/src/main/cpp/socketoutputstream.cpp

[jira] [Commented] (LOGCXX-367) Build fails on Linux with g++ 4.4

2014-02-18 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903888#comment-13903888 ] Thorsten Schöning commented on LOGCXX-367: -- You are right, I must have missed hav

Re: Freezing trunk?

2014-02-18 Thread Thorsten Schöning
Guten Tag Florian Seydoux, am Dienstag, 18. Februar 2014 um 07:27 schrieben Sie: > But it's first required to add ant-contrib + a slightly patched version > of cpptask. I'm pretty sure to not use a patched version of cpptask with VS 2013 currently. Could you provide a link? I'm simply using mvn c

Re: Freezing trunk?

2014-02-18 Thread Rhys Ulerich
>> (a) makes visual studio 6 projects, which cannot be used by Visual >> studio versions above 2008; so you have to convert them with a VS2008 >> before being able to build with 2010, 2012 or later. > > Isn't that an argument to remove the creation of projects by cpptasks? > I have the feeling this

svn commit: r1569322 - in /incubator/log4cxx/trunk/src: main/cpp/cacheddateformat.cpp test/cpp/helpers/cacheddateformattestcase.cpp

2014-02-18 Thread tschoening
Author: tschoening Date: Tue Feb 18 13:56:35 2014 New Revision: 1569322 URL: http://svn.apache.org/r1569322 Log: LOGCXX-425: I added a test for LOGCXX-420 which failed in the former codebase, additionally to the problem with the exceptions. The reason for the exceptions were negativ indices, the

Removing the generation of different IDE projects from build.xml

2014-02-18 Thread Thorsten Schöning
Hi all, in the thread "Freezing trunk?" we encountered a new topic and I would like to summarize the discussion in this new thread. This has been said so far: >>> (a) makes visual studio 6 projects, which cannot be used by Visual >>> studio versions above 2008; so you have to convert them with a

svn commit: r1569339 - /incubator/log4cxx/trunk/src/main/include/log4cxx/level.h

2014-02-18 Thread rhys
Author: rhys Date: Tue Feb 18 14:24:23 2014 New Revision: 1569339 URL: http://svn.apache.org/r1569339 Log: Place LevelPtr::operator== into namespace helper Fixes the following compilation error on GCC 4.8.1: src/main/include/log4cxx/level.h:279:67: error: specialization of ‘template bool log4cx

Re: [jira] [Commented] (LOGCXX-394) Levels are not thread safe

2014-02-18 Thread Rhys Ulerich
> It worked without "template<>" in VS, but I added such a statement now and > hopefulyl this works in GCC as well. Thank you. I ran into log4cxx/src/main/include/log4cxx/level.h:279:67: error: specialization of 'template bool log4cxx::helpers::ObjectPtrT::operator==(const log4cxx::helpers::Obj

Coding style

2014-02-18 Thread Thorsten Schöning
Hi all, it's time to flame! ;-) Just kidding, but I would like to summarize the already available suggestions: > Tab: 4 space vs 2 > Insert spaces instead of tabs I personally prefer tabs over spaces with a width of 4, line lengths with around 100 or 125 chars, because of widescreen monitors, an

Re: Removing the generation of different IDE projects from build.xml

2014-02-18 Thread Joseph Southwell
I can maintain project files for visual studio 2008. I am already doing so internally. Where should I check them in? On Feb 18, 2014, at 8:23 AM, Thorsten Schöning wrote: > Hi all, > > in the thread "Freezing trunk?" we encountered a new topic and I would > like to summarize the discussion in

Re: Coding style

2014-02-18 Thread Rhys Ulerich
> it's time to flame! ;-) Flame on! 1TBS, 4 space indent, nary a tab, and 80 column firm limit. I say this with 2 24" monitors in front of me. I often debug by printing and reading, and line wrapping is awful as is printing 125 characters per line to avoid it. We could go Fortran and say 132 c

Re: Coding style

2014-02-18 Thread Thorsten Schöning
Guten Tag Rhys Ulerich, am Dienstag, 18. Februar 2014 um 17:20 schrieben Sie: > That said, I don't much care provided there's an Artistic Style > configuration file[...] Would we like to add those files to the repo? I'm using Eclipse sometimes as IDE and it has a powerful formatter as well. We co

Re: Coding style

2014-02-18 Thread Rhys Ulerich
> Or do we only want one file for one tool as reference? That is my inclination. Artistic Style is available as a binary download for Windows, OS X, and Linux and the configuration file is quite short (e.g. [1]) and matches the manual [2] well - Rhys [1] https://github.com/RhysU/tuna/blob/maste

Need some help for LOGCXX-425

2014-02-18 Thread Thorsten Schöning
Hi all, I worked the last hours on fixing LOGCXX-425 and currently find myself to be a bit lost. https://issues.apache.org/jira/browse/LOGCXX-425 The problem is with test17 from cacheddateformattestcase and CachedDateFormat::findMillisecondStart which only accepts found milliseconds if they are

svn commit: r1569535 - in /incubator/log4cxx/trunk/src: main/cpp/cacheddateformat.cpp test/cpp/helpers/cacheddateformattestcase.cpp

2014-02-18 Thread tschoening
Author: tschoening Date: Tue Feb 18 21:46:35 2014 New Revision: 1569535 URL: http://svn.apache.org/r1569535 Log: LOGCXX-425: Changed the calculation of millis in a formatted string again and added another tests for LOGCXX-420. There's some debug output in there which need to get removed later, b

svn commit: r1569635 - in /incubator/log4cxx/trunk/src: changes/changes.xml main/cpp/cacheddateformat.cpp test/cpp/helpers/cacheddateformattestcase.cpp

2014-02-18 Thread tschoening
Author: tschoening Date: Wed Feb 19 05:39:50 2014 New Revision: 1569635 URL: http://svn.apache.org/r1569635 Log: LOGCXX-425: exceptions in CachedDateFormatTestCase after LOGCXX-420 Modified: incubator/log4cxx/trunk/src/changes/changes.xml incubator/log4cxx/trunk/src/main/cpp/cacheddatefor

Re: Need some help for LOGCXX-425

2014-02-18 Thread Thorsten Schöning
Guten Tag Thorsten Schöning, am Dienstag, 18. Februar 2014 um 22:44 schrieben Sie: > I have committed my change with all my debug stuff in there so one of > you could have a second look and give some advice. Thanks! I removed my debug statements and restored the old behavior and changed my tests

[jira] [Resolved] (LOGCXX-425) exceptions in CachedDateFormatTestCase after LOGCXX-420

2014-02-18 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thorsten Schöning resolved LOGCXX-425. -- Resolution: Fixed I fixed this by changing how the millisecond position is calculated a