[jira] [Reopened] (LOGCXX-426) nteventlogappender.cpp could fail to compile with winsock redefinition errors.

2015-10-08 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thorsten Schöning reopened LOGCXX-426: -- Assignee: Thorsten Schöning (was: Joseph Southwell) I need to reopen this issue, beca

svn commit: r1707547 - /incubator/log4cxx/trunk/src/main/cpp/nteventlogappender.cpp

2015-10-08 Thread tschoening
Author: tschoening Date: Thu Oct 8 14:18:44 2015 New Revision: 1707547 URL: http://svn.apache.org/viewvc?rev=1707547&view=rev Log: LOGCXX-426: Let APR deal with windows.h and WIN32_LEAN_AND_MEAN and that stuff. If we define WINSOCK here, aAPR will itself include windows.h anyways, but without w

[jira] [Closed] (LOGCXX-426) nteventlogappender.cpp could fail to compile with winsock redefinition errors.

2015-10-08 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thorsten Schöning closed LOGCXX-426. Resolution: Fixed apr_strings.h includes apr.h which deals with windows.h and Winsock. If th

svn commit: r1707550 - /incubator/log4cxx/trunk/src/main/cpp/telnetappender.cpp

2015-10-08 Thread tschoening
Author: tschoening Date: Thu Oct 8 14:35:33 2015 New Revision: 1707550 URL: http://svn.apache.org/viewvc?rev=1707550&view=rev Log: Removed warning about unreachable code by making it reachable. Normally I do prefer early returns as wlel, but I guess the return NULL in this case has been left by

svn commit: r1707552 - /incubator/log4cxx/trunk/src/test/cpp/abts.h

2015-10-08 Thread tschoening
Author: tschoening Date: Thu Oct 8 14:38:36 2015 New Revision: 1707552 URL: http://svn.apache.org/viewvc?rev=1707552&view=rev Log: We rely on apr anyways, so include it earlier, because APR will then detect/define WIN32 on it's own an WIn32 users don'T need to manually anymore. Modified: in

svn commit: r1707579 - /incubator/log4cxx/trunk/src/main/include/log4cxx/appenderskeleton.h

2015-10-08 Thread tschoening
Author: tschoening Date: Thu Oct 8 16:22:46 2015 New Revision: 1707579 URL: http://svn.apache.org/viewvc?rev=1707579&view=rev Log: Foxed some lines with broken code style, comments where not properly associated to their methods and such. Modified: incubator/log4cxx/trunk/src/main/include/lo

[jira] [Created] (LOGCXX-456) Some header defined getters and setters are wrongly removed by C++-Builder 10 Seattle.

2015-10-08 Thread JIRA
Thorsten Schöning created LOGCXX-456: Summary: Some header defined getters and setters are wrongly removed by C++-Builder 10 Seattle. Key: LOGCXX-456 URL: https://issues.apache.org/jira/browse/LOGCXX-456

svn commit: r1707585 - in /incubator/log4cxx/trunk/src/main: cpp/ include/log4cxx/ include/log4cxx/filter/ include/log4cxx/helpers/ include/log4cxx/nt/ include/log4cxx/xml/

2015-10-08 Thread tschoening
Author: tschoening Date: Thu Oct 8 16:59:02 2015 New Revision: 1707585 URL: http://svn.apache.org/viewvc?rev=1707585&view=rev Log: LOGCXX-456: My C++-Builder 10 Seattle seems to wrongly remove getters and setters which are not used in the static lib itself, but e.g. only in tests, if they are d

[jira] [Resolved] (LOGCXX-456) Some header defined getters and setters are wrongly removed by C++-Builder 10 Seattle.

2015-10-08 Thread JIRA
[ https://issues.apache.org/jira/browse/LOGCXX-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thorsten Schöning resolved LOGCXX-456. -- Resolution: Fixed Fix Version/s: 0.11.0 I've committed my changes, feel free to r

svn commit: r1707594 - /incubator/log4cxx/trunk/src/main/cpp/date.cpp

2015-10-08 Thread tschoening
Author: tschoening Date: Thu Oct 8 18:03:06 2015 New Revision: 1707594 URL: http://svn.apache.org/viewvc?rev=1707594&view=rev Log: APR may include stdint.h already, which itself may provide INT64_C. So I swapped both lines to remove a warnign about a wrong redefinition of INT64_C in that case.

svn commit: r1707614 - /incubator/log4cxx/trunk/src/test/cpp/rolling/timebasedrollingtest.cpp

2015-10-08 Thread tschoening
Author: tschoening Date: Thu Oct 8 20:02:54 2015 New Revision: 1707614 URL: http://svn.apache.org/viewvc?rev=1707614&view=rev Log: Applied the same change like for date.cpp about apr.h defining INT64_C, only that in this file everythign should have been OK before already because apr_strings.h w

svn commit: r1707615 - /incubator/log4cxx/trunk/src/test/cpp/rolling/timebasedrollingtest.cpp

2015-10-08 Thread tschoening
Author: tschoening Date: Thu Oct 8 20:11:37 2015 New Revision: 1707615 URL: http://svn.apache.org/viewvc?rev=1707615&view=rev Log: Added delayUntilNextSecondWithMsg because the same msg was hard coded 3 times. Modified: incubator/log4cxx/trunk/src/test/cpp/rolling/timebasedrollingtest.cpp M