cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw stylesheet.css

2003-06-26 Thread psmith
psmith 2003/06/26 23:51:48 Modified:src/java/org/apache/log4j/chainsaw stylesheet.css Log: Arial font is awful, attempts to use Tahamo, Verdana, Helvitica before resorting to Arial. Much smoother fonts. Revision ChangesPath 1.2 +3 -3 jakarta-log4j/src/j

Chainsaw & Webstart

2003-06-26 Thread Paul Smith
Well, I have to say that Java Web start rocks, but that the Keytool/jarsigner is weird, evil, black magic stuff. I mocked up an example Web start launch file, and checked it into cvs. This took about 3 minutes to make. I managed to sign the log4j, log4j-chainsaw, and oro jars, but only after muc

RE: PMD

2003-06-26 Thread Scott Deboy
Here are the notifications I'm receiving from PMD (I've not included the test and lf5 packages in this list). This list was generated after my cleanup efforts. I looked at CheckStyle and there is a lot of commonality between the two tools, with each providing some pieces of valuable informati

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw ThresholdSlider.java

2003-06-26 Thread psmith
psmith 2003/06/26 23:30:01 Modified:src/java/org/apache/log4j/chainsaw ThresholdSlider.java Log: Jalopolization. Revision ChangesPath 1.3 +18 -17 jakarta-log4j/src/java/org/apache/log4j/chainsaw/ThresholdSlider.java Index: ThresholdSlider.java ==

cvs commit: jakarta-log4j/src chainsawWebStart.jnlp

2003-06-26 Thread psmith
psmith 2003/06/26 23:29:20 Added: src chainsawWebStart.jnlp Log: Initial/Example Java Web start configuration. This will require an Ant target to token-replace a couple of things for the final URL from where it will be launced from. Revision ChangesPath 1.1

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw ReceiversTreeModel.java

2003-06-26 Thread psmith
psmith 2003/06/26 20:25:24 Modified:src/java/org/apache/log4j/chainsaw ReceiversTreeModel.java Log: Changes to allow the Root Receiver node to detect when the logger repository threshold had changed. Revision ChangesPath 1.2 +24 -7 jakarta-log4j/src/java/or

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw ReceiversPanel.java

2003-06-26 Thread psmith
psmith 2003/06/26 20:24:01 Modified:src/java/org/apache/log4j/chainsaw ReceiversPanel.java Log: subtle refactor and jalopolization. Revision ChangesPath 1.5 +100 -62 jakarta-log4j/src/java/org/apache/log4j/chainsaw/ReceiversPanel.java Index: ReceiversPanel.

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw ThresholdSlider.java

2003-06-26 Thread psmith
psmith 2003/06/26 20:21:57 Modified:src/java/org/apache/log4j/chainsaw ThresholdSlider.java Log: A much nicer implementation of the Threshold slider. Revision ChangesPath 1.2 +22 -4 jakarta-log4j/src/java/org/apache/log4j/chainsaw/ThresholdSlider.java Ind

LoggerRepository.setThreshold(Level)

2003-06-26 Thread Paul Smith
Hi All, If in code, I call LogManager.getLoggerRepository().setThreshold(Level.INFO), it sets the level correctly, but my Receivers seem to continue to post events ?!? I think I am missing something fundamental here (probably due to lack of caffeine). In the Receiver class: public void doPost

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw ReceiversPanel.java

2003-06-26 Thread psmith
psmith 2003/06/26 16:04:27 Modified:src/java/org/apache/log4j/chainsaw ReceiversPanel.java Log: Creating a Receiver using a dialog is now very near completion. Currently only supports simple Port based receivers like SocketReceiver and UDP Receiver (although UPDReceiver seems

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw Details_UDPReceiver.html

2003-06-26 Thread psmith
psmith 2003/06/26 16:03:04 Added: src/java/org/apache/log4j/chainsaw Details_UDPReceiver.html Log: Initial description html file for UDP receiver, more of a template. Revision ChangesPath 1.1 jakarta-log4j/src/java/org/apache/log4j/chainsaw/Details_UD

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw Details_SocketReceiver.html Details_SocketReceiver.properties

2003-06-26 Thread psmith
psmith 2003/06/26 16:02:40 Added: src/java/org/apache/log4j/chainsaw Details_SocketReceiver.html Removed: src/java/org/apache/log4j/chainsaw Details_SocketReceiver.properties Log: Rather than a resource bundle of plain text, it

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw LogUI.java

2003-06-26 Thread psmith
psmith 2003/06/26 16:02:10 Modified:src/java/org/apache/log4j/chainsaw LogUI.java Log: Changes because WelcomePanel is now a singleton. Fix for a JDK 1.4 specific method that was being used. Also added a convenience method to show a Help url, that ensures the Welcome Pan

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw stylesheet.css WelcomePanel.html

2003-06-26 Thread psmith
psmith 2003/06/26 16:01:00 Modified:src/java/org/apache/log4j/chainsaw WelcomePanel.html Added: src/java/org/apache/log4j/chainsaw stylesheet.css Log: Moved out the stylesheet definition to it's own file so that other HTML files within Chainsaw can share it. Revision

cvs commit: jakarta-log4j/src/java/org/apache/log4j/chainsaw WelcomePanel.java

2003-06-26 Thread psmith
psmith 2003/06/26 16:00:29 Modified:src/java/org/apache/log4j/chainsaw WelcomePanel.java Log: Made the WelcomePanel a singleton, makes no sense to dispose /create it all the time, and the added benefit is that the URL history is retained. Revision ChangesPath 1.2

cvs commit: jakarta-log4j/src/java/org/apache/log4j/plugins PluginRegistry.java

2003-06-26 Thread psmith
psmith 2003/06/26 15:59:44 Modified:src/java/org/apache/log4j/plugins PluginRegistry.java Log: added pluginNameExists method to allow Chainsaw (and other clients) to determine if a specific plugin name is already in use. Chainsaw uses this method to suffix an incrementing num

cvs commit: jakarta-log4j/src/java/org/apache/log4j/net SocketAppender.java UDPAppender.java

2003-06-26 Thread psmith
psmith 2003/06/26 15:58:11 Modified:src/java/org/apache/log4j/net SocketAppender.java UDPAppender.java Log: Exposed as public the default ports for these two appenders. Chainsaw really needs this so it has some default values for the user when they wis

RE: PMD

2003-06-26 Thread Paul Smith
Hi Scott, Is it possible to copy/paste the summary report to the Dev list? i.e. not where the issues are, just the Distinct set of the issue's it's reported. Then we can all discuss which of the more serious ones we should tackle. The more serious violations tend to mean more change within the co

RE: PMD

2003-06-26 Thread Scott Deboy
I'm not sure what Checkstyle reports, but PMD flagged quite a number of issues in the tree, from minor to serious. Much of what I've done has been minor cleanup - using interface types in method arguments where possible (Vector -> List), removing unused declared variables, imports. -Origina

RE: PMD

2003-06-26 Thread Mark Womack
While people can use any tool they want, we kind of decided on using Checkstyle on a project level. A lot of the Jakarta projects are using it and it was felt (ok, it was me) that we could leverage the knowledge and decisions these other groups made regarding the Checkstyle settings. (Really, Oliv

RE: [Gump] build Failure - caused by changes to chainsaw

2003-06-26 Thread Mark Womack
And it looks like chainsaw was not built in the last Gump run. Ceki, how do we update Gump to have it use the ORO jar in the build? Send an email to the Gump email list? -Mark > -Original Message- > From: Ceki Gülcü [mailto:[EMAIL PROTECTED] > Sent: Wednesday, June 25, 2003 10:45 PM > T

RE: PMD

2003-06-26 Thread Shapira, Yoav
Howdy, PMD is a good tool. There's a large, and increasing, overlap between it and Checkstyle. Both of them IMHO can be misleading and shouldn't be trusted blindly. For example, both (Checkstyle only in its latest version) will complain about non-final parameters to methods, method "not desi