RE: PMD

2003-06-26 Thread Scott Deboy
Each class should declare at least one constructor 89 Unused modifiers are, well, unused 317 A method should have only one exit point, and that should be the last statement in the method -Original Message- From: Paul Smith [mailto:[EMAIL PROTECTED] Sent: Thu 6/26/2003 2:28

RE: PMD

2003-06-26 Thread Paul Smith
within the code, and we'd probably best to only make these changes with some ponderings. cheers, Paul > -Original Message- > From: Scott Deboy [mailto:[EMAIL PROTECTED] > Sent: Friday, 27 June 2003 3:13 AM > To: Log4J Developers List > Subject: RE: PMD > > &g

RE: PMD

2003-06-26 Thread Scott Deboy
bles, imports. -Original Message- From: Mark Womack [mailto:[EMAIL PROTECTED] Sent: Thursday, June 26, 2003 9:48 AM To: 'Log4J Developers List' Subject: RE: PMD While people can use any tool they want, we kind of decided on using Checkstyle on a project level. A lot of the Jakarta proje

RE: PMD

2003-06-26 Thread Mark Womack
M > To: Log4J Developers List > Subject: RE: PMD > > > > Howdy, > PMD is a good tool. There's a large, and increasing, overlap > between it and Checkstyle. Both of them IMHO can be > misleading and shouldn't be trusted blindly. For example, > both (Ch

RE: PMD

2003-06-26 Thread Shapira, Yoav
, June 25, 2003 5:25 PM >To: Log4J Developers List >Subject: Re: PMD > >Ceki Gülcü wrote: > >> At 02:15 PM 6/25/2003 -0700, you wrote: >> >>> Sorry, http://pmd.sourceforge.net/ >> >> >> LOL. I thought PMD was an acronym and "Packet Mode Data"

Re: PMD

2003-06-25 Thread Berin Loritsch
Ceki Gülcü wrote: At 02:15 PM 6/25/2003 -0700, you wrote: Sorry, http://pmd.sourceforge.net/ LOL. I thought PMD was an acronym and "Packet Mode Data", "Physical Medium Dependent", "Polarization Mode Dispersion" sounded out of place. :D My favorite backronym is "Protein Mutant Database" fro

RE: PMD

2003-06-25 Thread Ceki Gülcü
[mailto:[EMAIL PROTECTED] Sent: Wednesday, June 25, 2003 2:12 PM To: Log4J Developers List Subject: Re: PMD What is PMD? At 01:49 PM 6/25/2003 -0700, you wrote: >Just a heads up, I've been working on a rather large commit that >applies many of PMD's suggested changes to the tree. &

RE: PMD

2003-06-25 Thread Scott Deboy
They already have example output from some version of the log4j tree: http://cvs.apache.org/~tcopeland/pmdweb/jakarta-log4j_jakarta-log4j.html -Original Message- From: Ceki Gülcü [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 25, 2003 2:12 PM To: Log4J Developers List Subject: Re: PMD

RE: PMD

2003-06-25 Thread Scott Deboy
Sorry, http://pmd.sourceforge.net/ -Original Message- From: Ceki Gülcü [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 25, 2003 2:12 PM To: Log4J Developers List Subject: Re: PMD What is PMD? At 01:49 PM 6/25/2003 -0700, you wrote: >Just a heads up, I've been working on

Re: PMD

2003-06-25 Thread Ceki Gülcü
What is PMD? At 01:49 PM 6/25/2003 -0700, you wrote: Just a heads up, I've been working on a rather large commit that applies many of PMD's suggested changes to the tree. There are a number of cases I didn't resolve - in the spi, log4j and net packages - the more serious of which are appenders whi