Re: Improving Log4J concurrency, avoiding deadlock

2004-09-17 Thread Elias Ross
On Fri, 2004-09-17 at 11:51, Ceki GÃlcà wrote: > Do you realize that the main reason for synchronization in doAppend method > is avoiding simultaneous writes to the same output device? Any write > operation which is not synchronized (or otherwise protected against > simultaneous access) is a big

RE: Improving Log4J concurrency, avoiding deadlock

2004-09-17 Thread Shapira, Yoav
Hi, We also want to be careful not to change this central piece of code unless absolutely needed, i.e. if people start reporting bugs in this area. Log4j is in heavy use and this code has not significantly changed in years, so I'm inclined to think it's fairly solid ;) Yoav Shapira Millennium

Re: Improving Log4J concurrency, avoiding deadlock

2004-09-17 Thread Ceki Gülcü
Do you realize that the main reason for synchronization in doAppend method is avoiding simultaneous writes to the same output device? Any write operation which is not synchronized (or otherwise protected against simultaneous access) is a big no no... At 08:35 PM 9/17/2004, Elias Ross wrote: On

Re: Improving Log4J concurrency, avoiding deadlock

2004-09-17 Thread Elias Ross
On Fri, 2004-09-17 at 11:35, Elias Ross wrote: > If this is a concern, you might want to create some sort of semaphore so > that when an event is being logged, the appender state can't be > affected. However, as many concurrent events can be logged at the same > time. > Instead of a semaphore,

Re: Improving Log4J concurrency, avoiding deadlock

2004-09-17 Thread Elias Ross
On Fri, 2004-09-17 at 10:40, Ceki GÃlcà wrote: > Elias, > > How are your changes compatible with log4j 1.3 where layouts write directly > to the output stream without intermediary String objects? It would seem the same issue would occur if an appender is locked when a layout is writing directly

[GUMP@brutus]: logging-log4j/logging-log4j success

2004-09-17 Thread noreply
To whom it may satisfy... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact folk at [EMAIL PROTECTED] Project logging-log4j *no longer* has an issue. Project State : 'Success', Reason '' Full d

Re: Improving Log4J concurrency, avoiding deadlock

2004-09-17 Thread Ceki Gülcü
Elias, How are your changes compatible with log4j 1.3 where layouts write directly to the output stream without intermediary String objects? At 07:35 PM 9/17/2004, Elias Ross wrote: I had a created a way to avoid a deadlock condition when Appender is holding on to a lock and rendering an object.

Improving Log4J concurrency, avoiding deadlock

2004-09-17 Thread Elias Ross
I had a created a way to avoid a deadlock condition when Appender is holding on to a lock and rendering an object. In some situations, attempting to log during a toString() causes this. Refer to to Bugzilla bug: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24159 To understand why this is

cvs commit: logging-log4j/src/java/org/apache/log4j/pattern PatternParser.java ThrowableInformationPatternConverter.java

2004-09-17 Thread ceki
ceki2004/09/17 10:33:31 Modified:src/java/org/apache/log4j/pattern PatternParser.java ThrowableInformationPatternConverter.java Log: ThrowableInformationPatternConverter obviously handles throwables, as that is all it does. Revision ChangesPath

Re: [EMAIL PROTECTED]: logging-log4j/logging-log4j failed

2004-09-17 Thread Ceki Gülcü
Paul, Gump caught it. We both did not see. At 02:23 AM 9/17/2004, you wrote: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact folk at [EMAIL PROTECTED] Project logging-log4j has an

RE: Compile error with latest from CVS

2004-09-17 Thread Ceki Gülcü
Added the missing methods. Renamed chainHandlesTrowable() as chainHandlesThrowable(). Sorry about the hassle. Gump is undergoing serious changes, maybe that is the reason... At 12:30 AM 9/17/2004, you wrote: Ceki, do you still need to check something in for PatternConverter? handlesExceptions =

About to remove LF5

2004-09-17 Thread Ceki Gülcü
Hello, Given that no one is maintaining LF5, I am in favor of removing it from CVS. If any developer takes up interest in LF5 again we can resuscitate it later. If you are an LF5 enthusiast, then this is the time to speak up. -- Ceki Gülcü For log4j documentation consider "The complete log

cvs commit: logging-log4j/src/java/org/apache/log4j/lf5/viewer/images channelexplorer_new.gif

2004-09-17 Thread ceki
ceki2004/09/17 03:29:28 Removed: src/java/org/apache/log4j/lf5/viewer/images channelexplorer_new.gif Log: Removed file with potential IP issues. - To unsubscribe, e-mail: [EMAIL PROTECTED

cvs commit: logging-log4j/src/java/org/apache/log4j/chainsaw LogUI.java

2004-09-17 Thread ceki
ceki2004/09/17 03:23:32 Modified:src/java/org/apache/log4j/chainsaw/dnd FileDnDTarget.java src/java/org/apache/log4j/chainsaw LogUI.java Log: Removed unused imports. Revision ChangesPath 1.2 +0 -2 logging-log4j/src/java/org/apache/log4j/chai

cvs commit: logging-log4j/src/java/org/apache/log4j/pattern ThreadPatternConverter.java ThrowableInformationPatternConverter.java

2004-09-17 Thread ceki
ceki2004/09/17 03:15:32 Modified:tests/src/java/org/apache/log4j/pattern Num343PatternConverter.java src/java/org/apache/log4j/pattern ThreadPatternConverter.java ThrowableInformationPatternConvert

cvs commit: logging-log4j/src/java/org/apache/log4j PatternLayout.java

2004-09-17 Thread ceki
ceki2004/09/17 03:08:31 Modified:src/java/org/apache/log4j/pattern PatternConverter.java src/java/org/apache/log4j PatternLayout.java Log: Fixing type in method name. Revision ChangesPath 1.8 +23 -5 logging-log4j/src/java/org/apache/log4j/pat

RE: Maintenance approach of log4j site

2004-09-17 Thread Ceki Gülcü
A working copy can contain files which are not managed by CVS. So there is no reason to move /x1/www/logging.apache.org/log4j/docs/webstart/chainsaw/ elsewhere. At 11:44 PM 9/16/2004, you wrote: +1 Only thing I can think of is that the Chainsaw distribution is currently sitting here: /x1/www/logg