carnold 2004/12/22 12:31:11
Modified:src/java/org/apache/log4j/pattern DatePatternConverter.java
PatternConverter.java PatternParser.java
tests/src/java/org/apache/log4j/pattern
PatternParserTest.java
Log:
BUG 32064:
Curt,
Excellent initiative.
When PatternParser sees multiple the curly braces, how does it now which
curly brace corresponds to which option to be handed to the
PatternConverter instance? Do PattterConverters now have multiple setOption
methods, e.g. setOption1, setOption2, ..., setOptionN. I'm
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32810.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
The dependency on jetty for the log4j GUMP project descriptor has been
removed. This should allow log4j-tests to proceed.
I still don't see how building jetty could fail to build do to a change in
log4j.
At 09:54 PM 12/22/2004, Ceki Gülcü wrote:
As I remember it, running log4j-tests by GUMP
ceki2004/12/22 13:17:45
Modified:src/java/org/apache/log4j/pattern PatternParser.java
Log:
Removed unused method extractOption
Revision ChangesPath
1.19 +0 -1
logging-log4j/src/java/org/apache/log4j/pattern/PatternParser.java
Index: PatternParser.java
Curt,
Just looked at the code. It answered my question regarding the setOption1,
..., setOptionN. Just use an aggregated data type instead of a simple one.
I propose the following clean up would make the code in PatternConverter
simpler.
- Remove the setOption method
- Change
On Dec 22, 2004, at 2:54 PM, Ceki Gülcü wrote:
Your observation about log4j-tests failing due to the addition of
detachRepository method in RepositorySelector is news to me. Where
does that come form?
Jetty appear to be failing to compile since it has a class that
implements RepositorySelector
On Dec 22, 2004, at 3:33 PM, Ceki Gülcü wrote:
Curt,
Just looked at the code. It answered my question regarding the
setOption1, ..., setOptionN. Just use an aggregated data type instead
of a simple one.
I propose the following clean up would make the code in
PatternConverter simpler.
- Remove
At 10:49 PM 12/22/2004, you wrote:
I was hesitant to do that if there were external pattern converters that
would be broken by the change. But if that isn't a concern, then by all
means.
No need to worry about external pattern converters. From the log4j FAQ:
We are very careful not to change
ceki2004/12/22 13:56:35
Modified:src/java/org/apache/log4j/pattern DatePatternConverter.java
PatternConverter.java
PropertiesPatternConverter.java
NamedPatternConverter.java
Log:
Simplifications as discussed
What defines the log4j client API? o.a.log4j.spi?
-Mark
-Original Message-
From: Ceki Gülcü [mailto:[EMAIL PROTECTED]
Sent: Wednesday, December 22, 2004 1:55 PM
To: Log4J Developers List
Subject: Re: setOption/setOptions duality in PatternConverter
At 10:49 PM 12/22/2004, you
11 matches
Mail list logo
