Bug report for Log4j [2014/05/04]

2014-05-04 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

[jira] [Updated] (LOG4J2-618) Solr Appender

2014-05-04 Thread Markus Klose (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus Klose updated LOG4J2-618: Attachment: LOG4J2-618.patch the patch for the module log4j-nosql btw ... does anybody knows

Re: Splitting off NoSQL to its own module.

2014-05-04 Thread Markus Klose
does it makes sense to refactorr the package wihtin the module log4-nosql as well actually the package is still org.apache.logging.log4j.core.appender but its not core anymore Markus Matt Sicker boa...@gmail.com hat am 29. April 2014 um 00:49 geschrieben: After some basic discussion

[jira] [Commented] (LOG4J2-520) RollingRandomAccessFile with Async Appender skip logs

2014-05-04 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988948#comment-13988948 ] Remko Popma commented on LOG4J2-520: Andre, I've started to look at this issue again.

Re: Broken build

2014-05-04 Thread Bruce Brouwer
This is what I was starting to investigate with LOG4J2-609. I don't think this is quite there yet. For one, in StatusConsoleListener.close(), System.out and System.err can change over time, so doing the != check might still close something that at one time was System.out but no longer is. Also,

[jira] [Closed] (LOG4J2-242) Make Messages more fluent

2014-05-04 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer closed LOG4J2-242. Make Messages more fluent - Key: LOG4J2-242

[jira] [Closed] (LOG4J2-439) Create a LogEventPatternConverter to escape newlines and HTML special characters

2014-05-04 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer closed LOG4J2-439. Create a LogEventPatternConverter to escape newlines and HTML special characters

[jira] [Closed] (LOG4J2-558) Create a log4j-bom

2014-05-04 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer closed LOG4J2-558. Create a log4j-bom -- Key: LOG4J2-558 URL:

[jira] [Closed] (LOG4J2-585) Markers not as powerful as slf4j

2014-05-04 Thread Bruce Brouwer (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Brouwer closed LOG4J2-585. Markers not as powerful as slf4j Key: LOG4J2-585

Re: Broken build

2014-05-04 Thread Bruce Brouwer
Edit: Because of the way these shared *listeners* are found... On Sun, May 4, 2014 at 9:38 AM, Bruce Brouwer bruce.brou...@gmail.comwrote: This is what I was starting to investigate with LOG4J2-609. I don't think this is quite there yet. For one, in StatusConsoleListener.close(), System.out

Re: Broken build

2014-05-04 Thread Ralph Goers
I see two choices here - maintain a use count or just let the OS close the files. The second would be pretty easy to do once we move the web stuff to its own module as it can add a property that the console Appender would look for. The first option is probably better if it could be made to

[jira] [Commented] (LOG4J2-520) RollingRandomAccessFile with Async Appender skip logs

2014-05-04 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989002#comment-13989002 ] Remko Popma commented on LOG4J2-520: You were right: this is related to the fix for

Re: Broken build

2014-05-04 Thread Matt Sicker
So how about adding a check at construction checking against System.out and System.err? Really, once you start messing with those streams, you can't be sure they'll ever be closed until the JVM stops or you manually close it. On 4 May 2014 09:36, Ralph Goers rgo...@apache.org wrote: I see two

Working on splitting off log4j-web.

2014-05-04 Thread Matt Sicker
This will take a bit longer than the nosql split. I need to update some poms as well in this case. -- Matt Sicker boa...@gmail.com

Re: Broken build

2014-05-04 Thread Ralph Goers
That is what I was doing yesterday before I got your haha email. Ralph On May 4, 2014, at 9:53 AM, Matt Sicker boa...@gmail.com wrote: So how about adding a check at construction checking against System.out and System.err? Really, once you start messing with those streams, you can't be

Re: Broken build

2014-05-04 Thread Ralph Goers
Also, that doesn't solve the case Remko mentioned of multiple web apps writing to a single file. Ralph On May 4, 2014, at 9:53 AM, Matt Sicker boa...@gmail.com wrote: So how about adding a check at construction checking against System.out and System.err? Really, once you start messing

Re: Broken build

2014-05-04 Thread Matt Sicker
This is starting to sound like we need a full-blown factory/context/logger implementation of StatusLogger. On 4 May 2014 12:46, Ralph Goers rgo...@apache.org wrote: Also, that doesn't solve the case Remko mentioned of multiple web apps writing to a single file. Ralph On May 4, 2014, at

Re: Broken build

2014-05-04 Thread Ralph Goers
No, it can be simpler than that. Sent from my iPad On May 4, 2014, at 10:55 AM, Matt Sicker boa...@gmail.com wrote: This is starting to sound like we need a full-blown factory/context/logger implementation of StatusLogger. On 4 May 2014 12:46, Ralph Goers rgo...@apache.org wrote:

Re: Broken build

2014-05-04 Thread Matt Sicker
Oh phew. Well, I'll leave that to you if you wanted to continue what you were working on. All I added was a check on close() to compare against the current System.out and System.err. I'll take a look into OpenJDK to see how to properly lock those (if possible) to prevent fun race conditions. On

Re: Broken build

2014-05-04 Thread Matt Sicker
Looks like there's nothing to synchronise on actually. Guess you can just cache them before the check in general. On 4 May 2014 13:25, Matt Sicker boa...@gmail.com wrote: Oh phew. Well, I'll leave that to you if you wanted to continue what you were working on. All I added was a check on

Re: Broken build

2014-05-04 Thread Bruce Brouwer
I haven't spent much time on this since my initial attempt on 609. Shall I leave it to Ralph to come up with the final solution, or would you like me to try? On May 4, 2014 2:35 PM, Matt Sicker boa...@gmail.com wrote: Looks like there's nothing to synchronise on actually. Guess you can just

Re: Working on splitting off log4j-web.

2014-05-04 Thread Bruce Brouwer
Don't forget to update the bom with all of these pom changes. On May 4, 2014 1:18 PM, Matt Sicker boa...@gmail.com wrote: This will take a bit longer than the nosql split. I need to update some poms as well in this case. -- Matt Sicker boa...@gmail.com

Re: Working on splitting off log4j-web.

2014-05-04 Thread Matt Sicker
Done so :) On 4 May 2014 14:06, Bruce Brouwer bruce.brou...@gmail.com wrote: Don't forget to update the bom with all of these pom changes. On May 4, 2014 1:18 PM, Matt Sicker boa...@gmail.com wrote: This will take a bit longer than the nosql split. I need to update some poms as well in

Re: Broken build

2014-05-04 Thread Bruce Brouwer
I was hoping to hear from Ralph as it sounds like he already started something. On May 4, 2014 3:22 PM, Matt Sicker boa...@gmail.com wrote: If you've got a good idea on how to do it, sure. On 4 May 2014 14:04, Bruce Brouwer bruce.brou...@gmail.com wrote: I haven't spent much time on this

[jira] [Resolved] (LOG4J2-570) Memory Leak

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker resolved LOG4J2-570. Resolution: Fixed Shutdown thread memory leak fixed in r1592429. Memory Leak ---

[jira] [Commented] (LOG4J2-570) Memory Leak

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989194#comment-13989194 ] Matt Sicker commented on LOG4J2-570: In r1592429, I've added a check for the presence

[jira] [Updated] (LOG4J2-428) Integration of GELF Appender

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-428: --- Fix Version/s: 2.1 Integration of GELF Appender

[jira] [Closed] (LOG4J2-577) Refactor LoggerContext initialization/destruction code

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker closed LOG4J2-577. -- Resolution: Not a Problem This was able to be resolved using a simpler method. Refactor

[jira] [Updated] (LOG4J2-428) Integration of GELF Appender

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-428: --- Affects Version/s: (was: 2.0) 2.1 Integration of GELF Appender

[jira] [Updated] (LOG4J2-534) As an Amazon Web Services user, I want a DynamoDB NoSQL appender

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-534: --- Affects Version/s: (was: 2.0) 2.1 As an Amazon Web Services user, I want

[jira] [Updated] (LOG4J2-586) Capability to merge LoggerContexts or dynamically add an additional ConfigurationSource to a context.

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-586: --- Affects Version/s: 2.1 Capability to merge LoggerContexts or dynamically add an additional

[jira] [Updated] (LOG4J2-428) Integration of GELF Appender

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-428: --- Fix Version/s: (was: 2.1) Integration of GELF Appender

[jira] [Updated] (LOG4J2-547) Update LoggerStream API

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-547: --- Fix Version/s: (was: 2.0-rc2) 2.1 Update LoggerStream API

[jira] [Closed] (LOG4J2-602) Several unit tests are too spammy in the build log

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker closed LOG4J2-602. -- Resolution: Fixed Build is a lot less verbose now, thanks guys! Several unit tests are too spammy in

[jira] [Updated] (LOG4J2-608) Add support for a java.util.logging bridge.

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-608: --- Fix Version/s: 2.1 Add support for a java.util.logging bridge.

Re: Broken build

2014-05-04 Thread Matt Sicker
Could you summarize how you'd implement this? Idea sharing could help reduce the overall effort required to elegantly fix this. On 4 May 2014 16:00, Bruce Brouwer bruce.brou...@gmail.com wrote: I was hoping to hear from Ralph as it sounds like he already started something. On May 4, 2014

[jira] [Updated] (LOG4J2-603) Use Gora as storage abstraction for Log4j 2.X

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-603: --- Affects Version/s: 2.1 Use Gora as storage abstraction for Log4j 2.X

[jira] [Closed] (LOG4J2-613) log4j-core bundle specifies javax.servlet version range [3.0,4)

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker closed LOG4J2-613. -- Resolution: Fixed Fix Version/s: 2.0-rc2 Recently fixed as a manual override in the

[jira] [Updated] (LOG4J2-618) Solr Appender

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-618: --- Affects Version/s: (was: 2.0-rc1) 2.1 Solr Appender -

[jira] [Commented] (LOG4J2-570) Memory Leak

2014-05-04 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989214#comment-13989214 ] Ralph Goers commented on LOG4J2-570: Rather than check for a class I would prefer that

[jira] [Commented] (LOG4J2-570) Memory Leak

2014-05-04 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989215#comment-13989215 ] Matt Sicker commented on LOG4J2-570: Wait so like a system property? Or we could even

[jira] [Commented] (LOG4J2-570) Memory Leak

2014-05-04 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989222#comment-13989222 ] Ralph Goers commented on LOG4J2-570: I am in front of my computer now so I can look at

Re: Broken build

2014-05-04 Thread Ralph Goers
I plan on removing the “extends Closeable” from the StatusListener interface and then creating a StatusCloseableListener that extends StatusConsoleListener. The close method will move there. Then in StatusConfiguration we will create the appropriate type based on what the destination is set to.

Re: Broken build

2014-05-04 Thread Bruce Brouwer
I was thinking of something along these lines (since Matt was asking me for my ideas): First off, make StatusConsoleListener a base class for StatusSystemOutListener and StatusSystemErrListener (maybe inner classes). These would no longer need to hold a reference to System.out or System.err, so

Re: Broken build

2014-05-04 Thread Ralph Goers
It sounds like we are on a similar approach. Even with registering the Configuration with the StatusFileListener it is possible that multiple configurations would want to write to the same file, and so should share the same Listener. In that case closing the file would only happen when the

Re: Broken build

2014-05-04 Thread Bruce Brouwer
So, who gets to implement it. Ralph, is your time better spent on other log4j issues, or should I look for new opportunities to help here? Any suggestions? On Sun, May 4, 2014 at 9:25 PM, Ralph Goers ralph.go...@dslextreme.comwrote: It sounds like we are on a similar approach. Even with

Re: Broken build

2014-05-04 Thread Ralph Goers
Go for it! Ralph On May 4, 2014, at 7:04 PM, Bruce Brouwer bruce.brou...@gmail.com wrote: So, who gets to implement it. Ralph, is your time better spent on other log4j issues, or should I look for new opportunities to help here? Any suggestions? On Sun, May 4, 2014 at 9:25 PM, Ralph