Re: JSON and XML tag format for log events

2014-05-14 Thread Gary Gregory
Here is JSON in all camelCase: http://pastebin.com/8zpHsjNL and in CamelCase for Elements and camelCase for attributes: http://pastebin.com/ed0R0grE You can edit org.apache.logging.log4j.core.jackson.JSONConstants to play with the names (and expect some test to fail). You can comment out a //

Re: JSON and XML tag format for log events

2014-05-14 Thread Ralph Goers
Sorry, I meant an example of how the JSON looks with these cases. I am less concerned with the XML. Ralph On May 13, 2014, at 10:23 PM, Gary Gregory garydgreg...@gmail.com wrote: Here is an example for the current XML: http://pastebin.com/cLbuwe4b Gary On Tue, May 13, 2014 at 10:53

Re: svn commit: r1594342 [1/3] - in /logging/log4j/log4j2/trunk: log4j-1.2-api/src/main/java/org/apache/log4j/ log4j-1.2-api/src/test/java/org/apache/log4j/ log4j-core/src/main/java/org/apache/logging

2014-05-14 Thread Ralph Goers
On May 13, 2014, at 12:33 PM, ggreg...@apache.org wrote: Author: ggregory Date: Tue May 13 19:33:08 2014 New Revision: 1594342 URL: http://svn.apache.org/r1594342 Log: Rename package org.apache.logging.log4j.core.helpers to org.apache.logging.log4j.core.util because we use the util

Re: JSON and XML tag format for log events

2014-05-14 Thread Ralph Goers
Oops. Having said that and then looking at the XML example there are obvious problems. The Marker element has a Parents container element that contains another Parents element that has a name attribute? I would guess the inner Parents should be Parent? Having said that, I would have

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Ralph Goers
Do these changes really accomplish anything? What is so magic about ? It is pretty damn obvious what is going on. Ralph On May 13, 2014, at 8:35 AM, ggreg...@apache.org wrote: Author: ggregory Date: Tue May 13 15:35:38 2014 New Revision: 1594250 URL: http://svn.apache.org/r1594250

Re: Log4J-2.0 New Logo

2014-05-14 Thread Ralph Goers
Yes the Jira outlines a process that was proposed by Christian in the Jira issue. However, that would be equivalent to someone creating an issue and saying that a new feature must be implemented a certain way. I don’t recall ever really discussing that process on the mailing list or even in the

Dependency to javax.persistence

2014-05-14 Thread Mikael Ståldal
Can't the dependency to javax.persistence be declared as provided? -- Mikael Ståldal Chief Software Architect *Appear* Phone: +46 8 545 91 572 Email: mikael.stal...@appearnetworks.com

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-14 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997357#comment-13997357 ] Mikael Ståldal commented on LOG4J2-623: --- I did not know that markers support

[jira] [Resolved] (LOG4J2-584) TCP and UDP socket servers should be able to handle JSON log events

2014-05-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-584. - Resolution: Fixed Fix Version/s: 2.0-rc2 Resolving as the functionality is in. There will

[jira] [Commented] (LOG4J2-635) Log4j 2 should also support properties file

2014-05-14 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997361#comment-13997361 ] Ralph Goers commented on LOG4J2-635: That is interesting as I didn't implement

RE: Dependency to javax.persistence

2014-05-14 Thread Gary Gregory
Why? How would that bring in the right jar in a standalone app? Are you assuming the app lives in a container like a J2EE server? Gary div Original message /divdivFrom: Mikael Ståldal mikael.stal...@appearnetworks.com /divdivDate:05/14/2014 04:01 (GMT-05:00) /divdivTo:

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-14 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997380#comment-13997380 ] Mikael Ståldal commented on LOG4J2-623: --- The latest code from SVN does not seem to

Re: Log4J-2.0 New Logo

2014-05-14 Thread Christian Grobmeier
On 14 May 2014, at 8:52, Ralph Goers wrote: Yes the Jira outlines a process that was proposed by Christian in the Jira issue. However, that would be equivalent to someone creating an issue and saying that a new feature must be implemented a certain way. I don’t recall ever really discussing

Re: Log4J-2.0 New Logo

2014-05-14 Thread Christian Grobmeier
It should be doable to transform this image to vector with inkscape. Borders will be sharper and smoother then. It might be a problem with the gradient colors though, we would have to try out (i am just a prime-time vectorist) On 13 May 2014, at 16:42, Matt Sicker wrote: Can you make it a

Re: Log4J-2.0 New Logo

2014-05-14 Thread Christian Grobmeier
I recall that usually Jim or Sam is very helpful with setting up the voting tool for such things. Maybe somebody else involved in Infra is willing to help as well. Somebody got time to ask there? On 13 May 2014, at 22:00, Ralph Goers wrote: Then we could do it manually. You can find some

Re: Dependency to javax.persistence

2014-05-14 Thread Mikael Ståldal
I guess that a standalone app will not work with javax.persistence API only, it needs an implementation of it as well. And that implementation will most likely bring in the API as well. The JMS API dependecy is already declared as provided, from log4j-core/pom.xml: !-- Used for JMS appenders

[jira] [Created] (LOG4J2-636) IOException: Stream Closed RollingRandomAccessFile

2014-05-14 Thread Adrian Wilford (JIRA)
Adrian Wilford created LOG4J2-636: - Summary: IOException: Stream Closed RollingRandomAccessFile Key: LOG4J2-636 URL: https://issues.apache.org/jira/browse/LOG4J2-636 Project: Log4j 2 Issue

[jira] [Updated] (LOG4J2-636) IOException: Stream Closed RollingRandomAccessFile

2014-05-14 Thread Adrian Wilford (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Wilford updated LOG4J2-636: -- Description: After some time, RollingRandomAccessFile can no longer write logging events

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Gary Gregory
It's not always obvious, for example, when you see someVar = and otherVar = '. Are they both right, does one have a typo? It's about communicating intent. Using a constant leaves no room for misinterpretation. Maybe readers that use a giant courier font see it differently, but the point of

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997548#comment-13997548 ] Gary Gregory commented on LOG4J2-623: - Hm, let's see {{JsonProcessingException}} is in

Re: Log4J-2.0 New Logo

2014-05-14 Thread Ralph Goers
On May 14, 2014, at 4:04 AM, Christian Grobmeier grobme...@gmail.com wrote: On 14 May 2014, at 8:52, Ralph Goers wrote: Yes the Jira outlines a process that was proposed by Christian in the Jira issue. However, that would be equivalent to someone creating an issue and saying that a

Re: Log4J-2.0 New Logo

2014-05-14 Thread Gary Gregory
On Wed, May 14, 2014 at 7:06 AM, Christian Grobmeier grobme...@gmail.comwrote: It should be doable to transform this image to vector with inkscape. Borders will be sharper and smoother then. It might be a problem with the gradient colors though, we would have to try out (i am just a

Re: JSON and XML tag format for log events

2014-05-14 Thread Gary Gregory
You're right, it's weird that all the elements are called Parents. Gary On Wed, May 14, 2014 at 3:02 AM, Ralph Goers ralph.go...@dslextreme.comwrote: Oops. Having said that and then looking at the XML example there are obvious problems. The Marker element has a Parents container element

Re: JSON and XML tag format for log events

2014-05-14 Thread Gary Gregory
OK, fixed in SVN. We now generate: Marker name=Marker1 Parents Marker name=ParentMarker1 Parents Marker name=GrandMotherMarker/ Marker name=GrandFatherMarker/ /Parents /Marker Marker name=ParentMarker2/

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Ralph Goers
Any time your reason for a change ends with “IMO” I would recommend asking first. In this case it seems like hundreds of instances were changed, which would seem to me that the various people who did that thought differently than you. Ralph On May 14, 2014, at 6:34 AM, Gary Gregory

Re: Dependency to javax.persistence

2014-05-14 Thread Matt Sicker
Yeah, the JPA API should be provided. All the providers include the JPA API in their core JARs. On 14 May 2014 06:37, Mikael Ståldal mikael.stal...@appearnetworks.comwrote: I guess that a standalone app will not work with javax.persistence API only, it needs an implementation of it as well.

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Matt Sicker
I think it'd be important to make named constants for things like ' or '' (wow those look impossible to read in sans-serif). For an empty string, the is the constant. On 14 May 2014 10:54, Ralph Goers ralph.go...@dslextreme.com wrote: Any time your reason for a change ends with “IMO” I would

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Matt Sicker
I've only ever seen that idea mentioned in the C++ Programming Language book. I just use nice monospace fonts that don't try to look like a typewriter. On 14 May 2014 11:04, Gary Gregory garydgreg...@gmail.com wrote: I can't tell any of these apart on my phone without zooming in close! Same

Log4j 2 plugin to Liquibase

2014-05-14 Thread Mikael Ståldal
I have made an Log4j 2 plugin to Liquibase (http://www.liquibase.org/). It seems like the Liquibase project don't want this kind of stuff in their own project, they seems to encourage third-party plugins. But I would like this to be available as a public Maven dependency. So I wonder if it's

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Ralph Goers
I have no problem in IntelliJ, but that is not the point. The point is to bring these changes up before you do them and see if you have consensus, not arbitrarily move stuff from one package to another or “fix” these kinds of things. I am just getting tired of reviewing minor stuff like this

Re: JSON and XML tag format for log events

2014-05-14 Thread Ralph Goers
What about ContextStack, ExtendedStackTrace and Suppressed? Ralph On May 14, 2014, at 8:32 AM, Gary Gregory garydgreg...@gmail.com wrote: OK, fixed in SVN. We now generate: Marker name=Marker1 Parents Marker name=ParentMarker1 Parents Marker

Re: Dependency to javax.persistence

2014-05-14 Thread Gary Gregory
Well, sure for JPA you need the API and a provider. What I am curious about is if we can start log4j without Jackson... Gary div Original message /divdivFrom: Mikael Ståldal mikael.stal...@appearnetworks.com /divdivDate:05/14/2014 07:37 (GMT-05:00) /divdivTo: Log4J

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-14 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997734#comment-13997734 ] Mikael Ståldal commented on LOG4J2-623: --- Then you need to clearly document when

Re: Log4j 2 plugin to Liquibase

2014-05-14 Thread Matt Sicker
Looks like you'll have to update it for the current API (which will be finalized with 2.0). On 14 May 2014 11:26, Mikael Ståldal mikael.stal...@appearnetworks.comwrote: I have made an Log4j 2 plugin to Liquibase (http://www.liquibase.org/). It seems like the Liquibase project don't want this

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Matt Sicker
Shouldn't the diffs for file renames just have a list of files that were renamed and no content diffs? On 14 May 2014 11:28, Ralph Goers ralph.go...@dslextreme.com wrote: I have no problem in IntelliJ, but that is not the point. The point is to bring these changes up before you do them and

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Matt Sicker
I think it'd be important to make named constants for things like ' or '' (wow those look impossible to read in sans-serif). For an empty string, the is the constant. On 14 May 2014 10:54, Ralph Goers ralph.go...@dslextreme.com wrote: Any time your reason for a change ends with “IMO” I would

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Gary Gregory
What's a typewriter?  div Original message /divdivFrom: Matt Sicker boa...@gmail.com /divdivDate:05/14/2014 12:07 (GMT-05:00) /divdivTo: Log4J Developers List log4j-dev@logging.apache.org /divdivSubject: Re: svn commit: r1594250 -

Re: JSON and XML tag format for log events

2014-05-14 Thread Gary Gregory
Coming up as soon as I get back from lunch! Cuban! Gary div Original message /divdivFrom: Ralph Goers ralph.go...@dslextreme.com /divdivDate:05/14/2014 12:22 (GMT-05:00) /divdivTo: Log4J Developers List log4j-dev@logging.apache.org /divdivSubject: Re: JSON and XML tag format

RE: Log4j 2 plugin to Liquibase

2014-05-14 Thread Gary Gregory
Time to create a Jira and attach a patch for a new module then. Will you be able to maintain it? Gary div Original message /divdivFrom: Mikael Ståldal mikael.stal...@appearnetworks.com /divdivDate:05/14/2014 12:26 (GMT-05:00) /divdivTo: Log4J log4j-dev@logging.apache.org

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-14 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997677#comment-13997677 ] Mikael Ståldal commented on LOG4J2-623: --- I use an XML configuration file, and

Re: svn commit: r1594250 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/LoggerContextAdmin.java

2014-05-14 Thread Gary Gregory
I can't tell any of these apart on my phone without zooming in close! Same when I'm in Eclipse. I refuse to code in courier. Java is not cobol! ;) Gary div Original message /divdivFrom: Matt Sicker boa...@gmail.com /divdivDate:05/14/2014 11:59 (GMT-05:00) /divdivTo: Log4J

Re: Log4J-2.0 New Logo

2014-05-14 Thread Gary Gregory
I'm not sure this moves the ball forward, we need to follow the procedure we initially presented... Gary On Tue, May 6, 2014 at 6:28 PM, Matt Sicker boa...@gmail.com wrote: I like: https://issues.apache.org/jira/secure/attachment/12605823/apache-log4j-2.png

[jira] [Resolved] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2014-05-14 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ralph Goers resolved LOG4J2-623. Resolution: Fixed This has been fixed in revision 1593727. I left the tag name as Properties