[jira] [Commented] (LOG4J2-1033) SimpleLogger creates unnecessary Map objects by calling ThreadContext.getContext() instead of getImmutableContext()

2015-05-29 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565446#comment-14565446 ] Gary Gregory commented on LOG4J2-1033: -- I can't recall of the top of my head. [~ralp

[jira] [Commented] (LOG4J2-927) Race condition between a LoggerContext stop() and async loggers

2015-05-29 Thread Mariano Gonzalez (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565105#comment-14565105 ] Mariano Gonzalez commented on LOG4J2-927: - I've been trying to get a unit test to

How to do a wrapper for Log4j 2's Logger interface

2015-05-29 Thread Mikael Ståldal
I am working with a Scala wrapper for Log4j 2's Logger interface. I have some problems with the lifecycle methods entry, exit, throwing and catching. I am actually wrapping the ExtendedLogger interface (which I believe is how it should be done), and do the actual logging with its methods. But ho

[jira] [Commented] (LOG4J2-1033) SimpleLogger creates unnecessary Map objects by calling ThreadContext.getContext() instead of getImmutableContext()

2015-05-29 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564986#comment-14564986 ] Mikael Ståldal commented on LOG4J2-1033: Now when this is fixed, what is the actu

[jira] [Closed] (LOG4J2-1033) SimpleLogger creates unnecessary Map objects by calling ThreadContext.getContext() instead of getImmutableContext()

2015-05-29 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1033. Verified by user. Ackd on the ML. Closing. > SimpleLogger creates unnecessary Map objects by calling

[jira] [Commented] (LOG4J2-321) Provide configuration alternative to system properties

2015-05-29 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564924#comment-14564924 ] Remko Popma commented on LOG4J2-321: This Jira ticket has not been implemented yet. Pl

[jira] [Comment Edited] (LOG4J2-321) Provide configuration alternative to system properties

2015-05-29 Thread gowri sankar (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564734#comment-14564734 ] gowri sankar edited comment on LOG4J2-321 at 5/29/15 12:55 PM: -

[jira] [Commented] (LOG4J2-321) Provide configuration alternative to system properties

2015-05-29 Thread gowri sankar (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564734#comment-14564734 ] gowri sankar commented on LOG4J2-321: - Is it safe to assume that using is enough to e

Re:

2015-05-29 Thread Mikael Ståldal
Now when this is changed, what is the actual purpose for ThreadContextMap.getCopy() and ThreadContext.getContext()? It seems like the only usage is in org.apache.logging.slf4j.Log4jMDCAdapter. On Fri, May 29, 2015 at 2:14 AM, Gary Gregory wrote: > Please verify and close: [LOG4J2-1033] SimpleL

[jira] [Commented] (LOG4J2-1033) SimpleLogger creates unnecessary Map objects by calling ThreadContext.getContext() instead of getImmutableContext()

2015-05-29 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564378#comment-14564378 ] Mikael Ståldal commented on LOG4J2-1033: Your fix looks good. I do not have permi