JUnit and Log4j

2015-09-14 Thread Gary Gregory
FYI: https://garygregory.wordpress.com/2015/09/14/the-art-of-test-driven-development-logging-junit-test-results/ Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition

Build failed in Jenkins: Log4j 2.x #1373

2015-09-14 Thread Apache Jenkins Server
See Changes: [ggregory] Checkstyle Javadoc. [ggregory] New Checkstyle: LineLength does not apply to import statements. [ggregory] Checkstyle: do not hide field. -- [...truncated 18937 lines...] Run

[jira] [Commented] (LOG4J2-1116) upgrade to log4j2 causes too frequent minor gc

2015-09-14 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744573#comment-14744573 ] Ralph Goers commented on LOG4J2-1116: - Can you please provide your JVM parameters as

[jira] [Commented] (LOG4J2-1116) upgrade to log4j2 causes too frequent minor gc

2015-09-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744473#comment-14744473 ] Gary Gregory commented on LOG4J2-1116: -- GC is highly dependent of Java version and v

[jira] [Comment Edited] (LOG4J2-1122) Memory leak with dymanic configuration.

2015-09-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743961#comment-14743961 ] Gary Gregory edited comment on LOG4J2-1122 at 9/14/15 9:27 PM:

[jira] [Commented] (LOG4J2-1122) Memory leak with dymanic configuration.

2015-09-14 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744293#comment-14744293 ] Ralph Goers commented on LOG4J2-1122: - My guess is that they must have code that gene

[jira] [Commented] (LOG4J2-1122) Memory leak with dymanic configuration.

2015-09-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743961#comment-14743961 ] Gary Gregory commented on LOG4J2-1122: -- Thank you for your report Leonid. What do y

[jira] [Comment Edited] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743828#comment-14743828 ] Remko Popma edited comment on LOG4J2-1121 at 9/14/15 5:52 PM: -

[jira] [Comment Edited] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743828#comment-14743828 ] Remko Popma edited comment on LOG4J2-1121 at 9/14/15 5:30 PM: -

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743828#comment-14743828 ] Remko Popma commented on LOG4J2-1121: - The original solution covered more than the cu

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743700#comment-14743700 ] Ralph Goers commented on LOG4J2-1121: - I am pretty sure the original solution I imple

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743694#comment-14743694 ] Ralph Goers commented on LOG4J2-1121: - No > LoggerConfig performance improvement: re

Re: Checkstyle

2015-09-14 Thread Gary Gregory
Done in Git master. Note that we had this already specified in javastyle.xml but we did not say it checkstyle.xml! Gary On Mon, Sep 14, 2015 at 2:18 AM, Remko Popma wrote: > No objections here either. > > > On Monday, September 14, 2015, Ralph Goers > wrote: > >> Seems reasonable. >> >> Ralph

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743607#comment-14743607 ] Gary Gregory commented on LOG4J2-1121: -- Would any of this change if we used Java 7's

[jira] [Updated] (LOG4J2-1122) Memory leak with dymanic configuration.

2015-09-14 Thread Leonid Kazantsev (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonid Kazantsev updated LOG4J2-1122: - Description: There are put to {code}private final ConcurrentMap loggers = new Concurren

[jira] [Updated] (LOG4J2-1122) Memory leak with dymanic configuration.

2015-09-14 Thread Leonid Kazantsev (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonid Kazantsev updated LOG4J2-1122: - Description: There are put to {code}private final ConcurrentMap loggers = new Concurren

[jira] [Updated] (LOG4J2-1122) Memory leak with dymanic configuration.

2015-09-14 Thread Leonid Kazantsev (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonid Kazantsev updated LOG4J2-1122: - Description: There are put to {code}private final ConcurrentMap loggers = new Concurren

[jira] [Created] (LOG4J2-1122) Memory leak with dymanic configuration.

2015-09-14 Thread Leonid Kazantsev (JIRA)
Leonid Kazantsev created LOG4J2-1122: Summary: Memory leak with dymanic configuration. Key: LOG4J2-1122 URL: https://issues.apache.org/jira/browse/LOG4J2-1122 Project: Log4j 2 Issue Type:

Re: Checkstyle

2015-09-14 Thread Remko Popma
No objections here either. On Monday, September 14, 2015, Ralph Goers wrote: > Seems reasonable. > > Ralph > > On Sep 14, 2015, at 12:35 AM, Gary Gregory > wrote: > > OK, I updated checkstyle with HidddenFields. > > Next, I'd like LineLength to be ignored for import statements. > > Thoughts? >

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743208#comment-14743208 ] Remko Popma commented on LOG4J2-1121: - I also noticed that Appender Manager covers th

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743196#comment-14743196 ] Remko Popma commented on LOG4J2-1121: - I was thinking to call a separate helper metho

Re: Fast date classes from Commons Lang 3

2015-09-14 Thread Ralph Goers
No. I didn't apply the latest changes but they aren't that significant. Ralph > On Sep 14, 2015, at 12:42 AM, Gary Gregory wrote: > > WRT the fast date classes from Commons Lang 3, are we using the latest and > greatest? > > Gary > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.o

Re: Checkstyle

2015-09-14 Thread Ralph Goers
Seems reasonable. Ralph > On Sep 14, 2015, at 12:35 AM, Gary Gregory wrote: > > OK, I updated checkstyle with HidddenFields. > > Next, I'd like LineLength to be ignored for import statements. > > Thoughts? > > Gary > >> On Fri, Sep 11, 2015 at 5:36 PM, Ralph Goers >> wrote: >> Actually, I

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743090#comment-14743090 ] Ralph Goers commented on LOG4J2-1121: - I see shutdown and reconfigure as two very dif

Fast date classes from Commons Lang 3

2015-09-14 Thread Gary Gregory
WRT the fast date classes from Commons Lang 3, are we using the latest and greatest? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Sp

Re: Checkstyle

2015-09-14 Thread Gary Gregory
OK, I updated checkstyle with HidddenFields. Next, I'd like LineLength to be ignored for import statements. Thoughts? Gary On Fri, Sep 11, 2015 at 5:36 PM, Ralph Goers wrote: > Actually, I am fine with setters that do that as well. Both can be > configured to be OK with the HiddenField elemen

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-14 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743044#comment-14743044 ] Gary Gregory commented on LOG4J2-1121: -- I am wondering if we can tie this in to a br