[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-16 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791605#comment-14791605 ] Ralph Goers commented on LOG4J2-1121: - Scenario: Thread 1 calls logMessage. The logge

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791378#comment-14791378 ] Remko Popma commented on LOG4J2-1121: - It may be possible to fix the race condition i

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791380#comment-14791380 ] Remko Popma commented on LOG4J2-1121: - It may be possible to fix the race condition i

TODO: No YAML Syntax section

2015-09-16 Thread Gary Gregory
Our Configuration chapter contains sections for XML and JSON, but not YAML. Just another TODO. Gary -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition

org.apache.logging.log4j.EventLogger

2015-09-16 Thread Gary Gregory
What is the point of this class? It does so little... what am I missing? Some better Javadocs are required to justify its existence IMO. Gary -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition JUnit in Action,

False positives in tests for org.apache.logging.log4j.EventLogger.logEvent(StructuredDataMessage)?

2015-09-16 Thread Gary Gregory
The method org.apache.logging.log4j.EventLogger.logEvent(StructuredDataMessage) is coded as: /** * Logs events with a level of ALL. * @param msg The event StructuredDataMessage. */ public static void logEvent(final StructuredDataMessage msg) { LOGGER.logIfEnabled(FQC

RE: Travelling

2015-09-16 Thread Gary Gregory
Thank you for the heads up!  Travel safe, Gary  Original message From: Remko Popma Date: 09/16/2015 07:33 (GMT-08:00) To: Log4J Developers List Subject: Travelling From tomorrow I'll be travelling for 3 weeks, and I may not always have internet access during that time,

Travelling

2015-09-16 Thread Remko Popma
>From tomorrow I'll be travelling for 3 weeks, and I may not always have internet access during that time, so my replies may be slow at times. -Remko

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768954#comment-14768954 ] Remko Popma commented on LOG4J2-1121: - Good point. No, the shutdown hook calls Logger

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-16 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14768828#comment-14768828 ] Gary Gregory commented on LOG4J2-1121: -- Does a shutdown preempt the waiting? > Logg

[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

2015-09-16 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14747092#comment-14747092 ] Remko Popma commented on LOG4J2-1121: - Are there any drawbacks to waiting uncondition