[jira] [Commented] (LOG4J2-1142) ThreadLocals in Layout implementations should be non-static to prevent memory leaks in web containers

2015-10-01 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940791#comment-14940791 ] Remko Popma commented on LOG4J2-1142: - Yes, I do that in a helper method. I think t

[jira] [Commented] (LOG4J2-1142) ThreadLocals in Layout implementations should be non-static to prevent memory leaks in web containers

2015-10-01 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940646#comment-14940646 ] Ralph Goers commented on LOG4J2-1142: - In the second case I am assuming that you then

[jira] [Commented] (LOG4J2-1142) ThreadLocals in Layout implementations should be non-static to prevent memory leaks in web containers

2015-10-01 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940632#comment-14940632 ] Remko Popma commented on LOG4J2-1142: - I confirmed (in Tomcat 7.0.50) that it made no

[jira] [Comment Edited] (LOG4J2-1050) Add a Log4jLookup class to help write log files relative to log4j2.xml

2015-10-01 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939675#comment-14939675 ] Remko Popma edited comment on LOG4J2-1050 at 10/1/15 11:19 PM:

[jira] [Closed] (LOG4J2-1147) Add %equalsIgnoreCase to PatternLayout to test and replace patterns with strings.

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1147. Resolution: Fixed Git master. > Add %equalsIgnoreCase to PatternLayout to test and replace pattern

[jira] [Created] (LOG4J2-1147) Add %equalsIgnoreCase to PatternLayout to test and replace patterns with strings.

2015-10-01 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1147: Summary: Add %equalsIgnoreCase to PatternLayout to test and replace patterns with strings. Key: LOG4J2-1147 URL: https://issues.apache.org/jira/browse/LOG4J2-1147 Pro

[jira] [Updated] (LOG4J2-1146) Add %notEmpty to PatternLayout to avoid output of patterns where all variables are empty.

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1146: - Attachment: LOG4J2-1146-ggregory-v1.diff > Add %notEmpty to PatternLayout to avoid output of patt

[jira] [Updated] (LOG4J2-1146) Add %notEmpty to PatternLayout to avoid output of patterns where all variables are empty.

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1146: - Attachment: (was: LOG4J2-1146-ggregory-v1.diff) > Add %notEmpty to PatternLayout to avoid out

Re: Pattern layout and Markers

2015-10-01 Thread Gary Gregory
Feedback please: https://issues.apache.org/jira/browse/LOG4J2-1146 Note the addition of the isVariable() method. Gary On Wed, Sep 30, 2015 at 7:45 PM, Ralph Goers wrote: > Topic 1 > > This is quite a common use case. I have no problem with %equals but > %notEmpty{[%marker]} would be nicer for

[jira] [Updated] (LOG4J2-1146) Add %notEmpty to PatternLayout to avoid output of patterns where all variables are empty.

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1146: - Attachment: LOG4J2-1146-ggregory-v1.diff > Add %notEmpty to PatternLayout to avoid output of patt

[jira] [Created] (LOG4J2-1146) Add %notEmpty to PatternLayout to avoid output of patterns where all variables are empty.

2015-10-01 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1146: Summary: Add %notEmpty to PatternLayout to avoid output of patterns where all variables are empty. Key: LOG4J2-1146 URL: https://issues.apache.org/jira/browse/LOG4J2-1146

Re: Pattern layout and Markers

2015-10-01 Thread Gary Gregory
So, silly example: %notEmpty{<%marker>%msg} would only print if marker AND msg are not empty? Gary On Wed, Sep 30, 2015 at 7:45 PM, Ralph Goers wrote: > Topic 1 > > This is quite a common use case. I have no problem with %equals but > %notEmpty{[%marker]} would be nicer for this use case - it

Re: Pattern layout and Markers

2015-10-01 Thread Gary Gregory
I did %equals, I'll take a look at %notEmpty... On Wed, Sep 30, 2015 at 5:15 PM, Gary Gregory wrote: > Topic 1 > > Let's say I want my logs to look like this: > > Date [thread] [loggerName] [MarkerName] Message > > But most of the time I do not have a marker so I end up with a lot of lame > look

[jira] [Closed] (LOG4J2-1145) Add %equals to PatternLayout to test and replace patterns with strings.

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1145. Resolution: Fixed In Git master. > Add %equals to PatternLayout to test and replace patterns with

[jira] [Created] (LOG4J2-1145) Add %equals to PatternLayout to test and replace patterns with strings.

2015-10-01 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1145: Summary: Add %equals to PatternLayout to test and replace patterns with strings. Key: LOG4J2-1145 URL: https://issues.apache.org/jira/browse/LOG4J2-1145 Project: Log4

Re: Bad PatternLayout site docs

2015-10-01 Thread Gary Gregory
Thanks Remko. Fixed. G On Thu, Oct 1, 2015 at 12:04 AM, Remko Popma wrote: > Good catch! The 2nd explanation has more detail, looks like the 1st row > can be deleted. > > Small detail: the "{pattern}" part of "enc{pattern} encode{pattern}" in > the 2nd row should not use bold font. > > Sent fr

Jenkins build is back to stable : Log4j 2.x #1431

2015-10-01 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

Jenkins build became unstable: Log4j 2.x #1430

2015-10-01 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

[jira] [Closed] (LOG4J2-1144) Add %markerSimpleName in pattern layout should evaluate to marker name (not toString()).

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1144. Resolution: Fixed In Git master. > Add %markerSimpleName in pattern layout should evaluate to mark

[jira] [Updated] (LOG4J2-1144) Add %markerSimpleName in pattern layout should evaluate to marker name (not toString()).

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1144: - Description: Add %markerSimpleName in pattern layout should evaluate to marker name (not toStrin

[jira] [Updated] (LOG4J2-1144) Add %markerSimpleName in pattern layout should evaluate to marker name (not toString()).

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1144: - Summary: Add %markerSimpleName in pattern layout should evaluate to marker name (not toString()).

[jira] [Updated] (LOG4J2-1144) Add %markerName in pattern layout should evaluate to marker name (not toString()).

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1144: - Summary: Add %markerName in pattern layout should evaluate to marker name (not toString()). (was

[jira] [Updated] (LOG4J2-1144) Add %markerName in pattern layout should evaluate to marker name (not toString()).

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1144: - Description: Add %markerName in pattern layout should evaluate to marker name (not toString()).

Re: Pattern layout and Markers

2015-10-01 Thread Gary Gregory
Looking back at the code and unit test, the intent is clear to print out the FQN of the marker, so I'll leave that as is but add getFullName() method. I'll add a %markerName for the a converter that just does a getName(). Gary On Thu, Oct 1, 2015 at 3:26 AM, Remko Popma wrote: > About printing

[jira] [Updated] (LOG4J2-1144) Add %markerSimpleName in pattern layout should evaluate to marker name (not toString()).

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1144: - Summary: Add %markerSimpleName in pattern layout should evaluate to marker name (not toString()).

[jira] [Commented] (LOG4J2-435) Support limiting number of log files based on date pattern

2015-10-01 Thread Carlos Silva A. (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940152#comment-14940152 ] Carlos Silva A. commented on LOG4J2-435: Sure, i just need a couple of days. ​ >

[jira] [Created] (LOG4J2-1144) %marker in pattern layout should evaluate to marker name (not toString()).

2015-10-01 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1144: Summary: %marker in pattern layout should evaluate to marker name (not toString()). Key: LOG4J2-1144 URL: https://issues.apache.org/jira/browse/LOG4J2-1144 Project: L

[jira] [Commented] (LOG4J2-627) Better structure of Thread Context Stack in XMLLayout

2015-10-01 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939947#comment-14939947 ] Mikael Ståldal commented on LOG4J2-627: --- I use neither XMLLayout nor Thread Context

[jira] [Commented] (LOG4J2-627) Better structure of Thread Context Stack in XMLLayout

2015-10-01 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939899#comment-14939899 ] Gary Gregory commented on LOG4J2-627: - The alternative is to provide a second layout t

[jira] [Commented] (LOG4J2-1142) ThreadLocals in Layout implementations should be non-static to prevent memory leaks in web containers

2015-10-01 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939739#comment-14939739 ] Remko Popma commented on LOG4J2-1142: - I will look at the ObjectPool performance and

[jira] [Commented] (LOG4J2-1050) Add a Log4jLookup class to help write log files relative to log4j2.xml

2015-10-01 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939675#comment-14939675 ] Remko Popma commented on LOG4J2-1050: - Adam, the [code is there|http://logging.apach

Re: Pattern layout and Markers

2015-10-01 Thread Remko Popma
About printing the Marker NAME instead of toString(), this sounds reasonable (but to be honest I have never used Markers so I am no expert). On Thu, Oct 1, 2015 at 8:30 AM, Gary Gregory wrote: > I was in the middle of addressing the easier of my topics by creating a > new class MarkerNamePattern

[jira] [Created] (LOG4J2-1143) Lookup Plugin not found

2015-10-01 Thread Pascal Heinrich (JIRA)
Pascal Heinrich created LOG4J2-1143: --- Summary: Lookup Plugin not found Key: LOG4J2-1143 URL: https://issues.apache.org/jira/browse/LOG4J2-1143 Project: Log4j 2 Issue Type: Improvement

[Bug 58470] xml message

2015-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58470 ahmed elattar changed: What|Removed |Added CC||[email protected]

[jira] [Commented] (LOG4J2-623) Better structure of Thread Context Map in JSONLayout

2015-10-01 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939525#comment-14939525 ] Mikael Ståldal commented on LOG4J2-623: --- Should we close this as Won't Fix since cha

[Bug 58470] New: xml message

2015-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58470 Bug ID: 58470 Summary: xml message Product: Log4j Version: unspecified Hardware: PC Status: NEW Severity: major Priority: P2 Component: Other

[jira] [Commented] (LOG4J2-627) Better structure of Thread Context Stack in XMLLayout

2015-10-01 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939523#comment-14939523 ] Mikael Ståldal commented on LOG4J2-627: --- Should we close this as Won't Fix since cha

Re: Pattern layout and Markers

2015-10-01 Thread Mikael Ståldal
I like %nonEmpty{[%marker]} On Thu, Oct 1, 2015 at 4:45 AM, Ralph Goers wrote: > Topic 1 > > This is quite a common use case. I have no problem with %equals but > %notEmpty{[%marker]} would be nicer for this use case - it would mean don’t > print anything if the variables in the pattern are emp

Jenkins build is back to stable : Log4j 2.x #1429

2015-10-01 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

Re: logging-log4j2 git commit: Add org.apache.logging.log4j.core.layout.PatternLayoutTest.testRegexEmptyMarker().

2015-10-01 Thread Remko Popma
For some reason Jenkins is still not happy with that test after the line change to 303. https://builds.apache.org/job/Log4j%202.x/lastBuild/org.apache.logging.log4j$log4j-core/testReport/org.apache.logging.log4j.core.layout/PatternLayoutTest/testPatternSelector/ Sent from my iPhone > On 2015/1

Re: Bad PatternLayout site docs

2015-10-01 Thread Remko Popma
Good catch! The 2nd explanation has more detail, looks like the 1st row can be deleted. Small detail: the "{pattern}" part of "enc{pattern} encode{pattern}" in the 2nd row should not use bold font. Sent from my iPhone > On 2015/10/01, at 1:43, Gary Gregory wrote: > > The site docs at > h