Re: Your name on the Log4j 2 site.

2015-11-11 Thread Remko Popma
Murad, Understood. Thanks for the confirmation! Remko Sent from my iPhone > On 2015/11/12, at 3:10, Murad Ersoy wrote: > > Hi Remko, > > All the info details are correct. > It was a pleasure for me to contribute. > > Regards, > Murad Ersoy > > > > Murad Ersoy > On 11 Nov 2015, at 09:49,

[jira] [Updated] (LOG4J2-1197) Improve RollingFileAppender to avoid having stale log events in the buffer

2015-11-11 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1197: Description: With bufferedIO=true the buffer contains log events that I want to see, but the buffe

[jira] [Created] (LOG4J2-1197) Improve RollingFileAppender to avoid having stale log events in the buffer

2015-11-11 Thread Benjamin Jaton (JIRA)
Benjamin Jaton created LOG4J2-1197: -- Summary: Improve RollingFileAppender to avoid having stale log events in the buffer Key: LOG4J2-1197 URL: https://issues.apache.org/jira/browse/LOG4J2-1197 Projec

Re: Perf code

2015-11-11 Thread Gary Gregory
Thank you for checking. Gary On Wed, Nov 11, 2015 at 8:45 AM, Remko Popma wrote: > Gary, looks like the code in ReflectionUtil already has a comment with a > reference to the log4j-perf benchmark. (Nice, Matt!) > The duplication in this case is just "new Throwable()", so I think we're > good. >

Re: Perf code

2015-11-11 Thread Remko Popma
Gary, looks like the code in ReflectionUtil already has a comment with a reference to the log4j-perf benchmark. (Nice, Matt!) The duplication in this case is just "new Throwable()", so I think we're good. On Thu, Nov 12, 2015 at 1:16 AM, Matt Sicker wrote: > I know I used that in ReflectionUtil

[jira] [Updated] (LOG4J2-435) Support limiting number of log files based on custom policies

2015-11-11 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-435: --- Summary: Support limiting number of log files based on custom policies (was: Support limiting number

Re: Perf code

2015-11-11 Thread Matt Sicker
I know I used that in ReflectionUtil because of the log4j-perf test that demonstrates the difference between Throwable and Thread. On 11 November 2015 at 10:11, Gary Gregory wrote: > I suggest you add a comment there too or preferably refactor the > duplication. > > Gary > On Nov 11, 2015 8:05 A

Re: Perf code

2015-11-11 Thread Gary Gregory
I suggest you add a comment there too or preferably refactor the duplication. Gary On Nov 11, 2015 8:05 AM, "Remko Popma" wrote: > I agree I should have added a ref to the JIRA to document the reason for > doing it this way. I added a comment just now. > > About moving this to a util class, I'd

Re: Perf code

2015-11-11 Thread Remko Popma
I agree I should have added a ref to the JIRA to document the reason for doing it this way. I added a comment just now. About moving this to a util class, I'd be fine with that. FYI, the other place that uses {{new Throwable().getStackTrace()}} is ReflectionUtil#getEquivalentStackTraceElement. O

Perf code

2015-11-11 Thread Gary Gregory
I think this needs a code comment to avoid the code being changed in the future to undo the improvement. IMO all perf changes like this need good docs with a ref to the Jira. Who knows how this kind of stuff will play out on top on Java 8 and 9. If we do this kind of call in different places, we

Jenkins build is back to stable : Log4j 2.x #1544

2015-11-11 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

Jenkins build is still unstable: Log4j 2.x #1543

2015-11-11 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

[jira] [Assigned] (LOG4J2-435) Support limiting number of log files based on date pattern

2015-11-11 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-435: -- Assignee: Remko Popma (was: Ralph Goers) > Support limiting number of log files based on date

[jira] [Resolved] (LOG4J2-1029) Performance improvement when gathering Location Information

2015-11-11 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1029. - Resolution: Fixed Fixed in master in commit 65adfab1. Please verify and close. > Performance im

Jenkins build became unstable: Log4j 2.x #1542

2015-11-11 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

[jira] [Resolved] (LOG4J2-1172) ThreadLocal leak [AsyncLogger$Info] on Tomcat when using AsyncLoggerContextSelector

2015-11-11 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1172. - Resolution: Fixed Fixed in master in commits 680eb6eb, a02bce46, f132f9ad, 908ae829, c9eff73f. *

[jira] [Updated] (LOG4J2-1172) ThreadLocal leak [AsyncLogger$Info] on Tomcat when using AsyncLoggerContextSelector

2015-11-11 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1172: Description: Tomcat warns at SEVERE level about a ThreadLocal leak (AsyncLogger$Info). Steps to re

Re: logging-log4j2 git commit: Update reference to Kafka client library

2015-11-11 Thread Mikael Ståldal
OK, removed the version number. On Tue, Nov 10, 2015 at 1:32 AM, Ralph Goers wrote: > Maven generates > http://logging.apache.org/log4j/2.x/log4j-core/dependencies.html from the > pom.xml. It does that for every module. You should be able to point there > for the correct version. > > Ralph > > O

Re: Redundant dependency information on site

2015-11-11 Thread Mikael Ståldal
OK, removed the redundant one. On Mon, Nov 9, 2015 at 7:42 PM, Gary Gregory wrote: > On Mon, Nov 9, 2015 at 10:15 AM, Mikael Ståldal > wrote: > >> Which one should we keep? >> > > http://logging.apache.org/log4j/2.x/runtime-dependencies.html refers to > all modules, the other is only about core