Re: Jenkins build is back to stable : Log4j 2.x #1698

Haha :-) Sent from my iPhone > On 2016/02/20, at 16:09, Matt Sicker wrote: > > Checking the diff, I think Jenkins has become self-aware. > >> On 20 February 2016 at 01:08, Apache Jenkins Server >> wrote: >> See >> >> >> -

Re: Jenkins build is back to stable : Log4j 2.x #1698

Checking the diff, I think Jenkins has become self-aware. On 20 February 2016 at 01:08, Apache Jenkins Server < [email protected]> wrote: > See > > > - > To unsubsc

Jenkins build is back to stable : Log4j 2.x #1698

See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

[jira] [Assigned] (LOG4J2-1278) Garbage-free logging API (no varargs/autoboxing)

[ https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1278: --- Assignee: Remko Popma > Garbage-free logging API (no varargs/autoboxing) > -

Jenkins build is still unstable: Log4j 2.x #1697

See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

Re: Jenkins build is still unstable: Log4j 2.x #1696

That looks like a sporadic failure. Should be working again by the next commit(s). On 19 February 2016 at 23:00, Apache Jenkins Server < [email protected]> wrote: > See > > > --

Jenkins build is still unstable: Log4j 2.x #1696

See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

[jira] [Commented] (LOG4J2-1278) Garbage-free logging API (no varargs/autoboxing)

[ https://issues.apache.org/jira/browse/LOG4J2-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155379#comment-15155379 ] Remko Popma commented on LOG4J2-1278: - If nobody objects, I'll start some work on thi

Fwd: logging-log4j2 git commit: Update tests to use LoggerContextRule.

Nice clean up Matt. Gary -- Forwarded message -- From: Date: Fri, Feb 19, 2016 at 8:14 PM Subject: logging-log4j2 git commit: Update tests to use LoggerContextRule. To: [email protected] Repository: logging-log4j2 Updated Branches: refs/heads/master 6e54d7160 -> a8c8f

Fwd: logging-log4j2 git commit: Update tests for LOG4J2-1289.

Thanks Matt! Gary -- Forwarded message -- From: Date: Fri, Feb 19, 2016 at 6:57 PM Subject: logging-log4j2 git commit: Update tests for LOG4J2-1289. To: [email protected] Repository: logging-log4j2 Updated Branches: refs/heads/master 504c2ebd5 -> 5fef2798e Update t

Re: Jenkins build is still unstable: Log4j 2.x #1695

Damn, missed a few. Updating. On 19 February 2016 at 21:58, Apache Jenkins Server < [email protected]> wrote: > See > > > - > To unsubscribe, e-mail: log4j-dev-unsubscr.

Jenkins build is still unstable: Log4j 2.x #1695

See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

Re: Jenkins build is still unstable: Log4j 2.x #1694

Thanks! Sent from my iPhone > On 2016/02/20, at 11:52, Matt Sicker wrote: > > Also fixing the log4j-core tests that I didn't notice were failing until I > built it locally. > >> On 19 February 2016 at 20:37, Matt Sicker wrote: >> Issue is due to the change from "entry" to "Enter". I'm fixing

Re: Jenkins build is still unstable: Log4j 2.x #1694

Also fixing the log4j-core tests that I didn't notice were failing until I built it locally. On 19 February 2016 at 20:37, Matt Sicker wrote: > Issue is due to the change from "entry" to "Enter". I'm fixing the > log4j-jul tests right now. No worries! > > On 19 February 2016 at 19:59, Apache Jen

Re: Jenkins build is still unstable: Log4j 2.x #1694

Issue is due to the change from "entry" to "Enter". I'm fixing the log4j-jul tests right now. No worries! On 19 February 2016 at 19:59, Apache Jenkins Server < [email protected]> wrote: > See > > > ---

Jenkins build is still unstable: Log4j 2.x #1694

See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

Jenkins build is still unstable: Log4j 2.x #1693

See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

[jira] [Closed] (LOG4J2-1289) Change flow logging text from "entry' to "Enter" and "exit" to "Exit"

[ https://issues.apache.org/jira/browse/LOG4J2-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1289. Resolution: Fixed In Git master. > Change flow logging text from "entry' to "Enter" and "exit" to

Re: logging-log4j2 git commit: Refactor words into constants.

sure. G On Fri, Feb 19, 2016 at 4:23 PM, Remko Popma wrote: > What about "default prefix" for "word"? > > Sent from my iPhone > > > On 2016/02/20, at 9:18, [email protected] wrote: > > > > Repository: logging-log4j2 > > Updated Branches: > > refs/heads/master 5e51ae127 -> e0489eb15 > > > > >

Re: logging-log4j2 git commit: LOG4J2-1281 LoggerConfig.getProperties() should not allocate on each call.

I like that idea very much. Sent from my iPhone > On 2016/02/20, at 7:37, Matt Sicker wrote: > > We could use an annotation. That would make it easier to implement an > aspect-oriented unit test to verify gc-free code paths. > >> On 19 February 2016 at 16:14, Remko Popma wrote: >> Another t

[jira] [Created] (LOG4J2-1289) Change flow logging text from "entry' to "Enter" and "exit" to "Exit"

Gary Gregory created LOG4J2-1289: Summary: Change flow logging text from "entry' to "Enter" and "exit" to "Exit" Key: LOG4J2-1289 URL: https://issues.apache.org/jira/browse/LOG4J2-1289 Project: Log4j

Re: logging-log4j2 git commit: Refactor words into constants.

What about "default prefix" for "word"? Sent from my iPhone > On 2016/02/20, at 9:18, [email protected] wrote: > > Repository: logging-log4j2 > Updated Branches: > refs/heads/master 5e51ae127 -> e0489eb15 > > > Refactor words into constants. > > Project: http://git-wip-us.apache.org/repos/

[jira] [Created] (LOG4J2-1288) Chnage flow logging text from "entry' to "Enter" and "exit

Gary Gregory created LOG4J2-1288: Summary: Chnage flow logging text from "entry' to "Enter" and "exit Key: LOG4J2-1288 URL: https://issues.apache.org/jira/browse/LOG4J2-1288 Project: Log4j 2

[jira] [Created] (LOG4J2-1287) Chnage flow logging text from "entry' to

Gary Gregory created LOG4J2-1287: Summary: Chnage flow logging text from "entry' to Key: LOG4J2-1287 URL: https://issues.apache.org/jira/browse/LOG4J2-1287 Project: Log4j 2 Issue Type: Bug

Re: Default flow logging text entry/exit

I am fine with that. Remko Sent from my iPhone > On 2016/02/20, at 9:18, Ralph Goers wrote: > > I am OK with that. > > Ralph > >> On Feb 19, 2016, at 5:15 PM, Gary Gregory wrote: >> >> Hi, >> >> At work our custom flow logging use "Enter" and "Exit" instead of "entry" >> and "exit". >>

Re: Jenkins build became unstable: Log4j 2.x #1692

It appears one of the MessageSupplier tests is now failing. Ralph > On Feb 19, 2016, at 5:11 PM, Apache Jenkins Server > wrote: > > See > > > - > To unsubscribe, e-mai

Re: Default flow logging text entry/exit

I am OK with that. Ralph > On Feb 19, 2016, at 5:15 PM, Gary Gregory wrote: > > Hi, > > At work our custom flow logging use "Enter" and "Exit" instead of "entry" and > "exit". > > First the word should be in init cap IMO since the word starts a "sentence": > > Enter methodA() > Exit method

Default flow logging text entry/exit

Hi, At work our custom flow logging use "Enter" and "Exit" instead of "entry" and "exit". First the word should be in init cap IMO since the word starts a "sentence": Enter methodA() Exit methodA() Also "entry" just sounds and looks weird to me. How about changing: - Start the words with an i

Jenkins build became unstable: Log4j 2.x #1692

See - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

[jira] [Commented] (LOG4J2-1255) Logger.entry and Logger.exit should support Messages.

[ https://issues.apache.org/jira/browse/LOG4J2-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155168#comment-15155168 ] Gary Gregory commented on LOG4J2-1255: -- My use cases need: - org.apache.logging.log

[jira] [Commented] (LOG4J2-1255) Logger.entry and Logger.exit should support Messages.

[ https://issues.apache.org/jira/browse/LOG4J2-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155152#comment-15155152 ] Gary Gregory commented on LOG4J2-1255: -- Another way to think about this is to consid

[jira] [Resolved] (LOG4J2-1286) Deprecate org.apache.logging.log4j.util.MessageSupplier

[ https://issues.apache.org/jira/browse/LOG4J2-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1286. -- Resolution: Fixed Fix Version/s: 2.6 Done, please verify and close. > Deprecate org.apa

Re: MessageSupplier and Supplier

Done, tracked through https://issues.apache.org/jira/browse/LOG4J2-1286 Gary On Fri, Feb 19, 2016 at 12:29 PM, Ralph Goers wrote: > Yes, I am OK with this. > > Ralph > > On Feb 19, 2016, at 1:28 PM, Gary Gregory wrote: > > If we all agree that MS should be deprecated then yes, let's have one t

[jira] [Created] (LOG4J2-1286) Deprecate org.apache.logging.log4j.util.MessageSupplier

Gary Gregory created LOG4J2-1286: Summary: Deprecate org.apache.logging.log4j.util.MessageSupplier Key: LOG4J2-1286 URL: https://issues.apache.org/jira/browse/LOG4J2-1286 Project: Log4j 2 Iss

Re: logging-log4j2 git commit: LOG4J2-1281 LoggerConfig.getProperties() should not allocate on each call.

We could use an annotation. That would make it easier to implement an aspect-oriented unit test to verify gc-free code paths. On 19 February 2016 at 16:14, Remko Popma wrote: > Another thing:if you look at the new code, where should I put the comment? > There is nothing tricky about the new logi

Re: FlowMessageFactory

I documented the new properties in the Configuration manual page. Did I forget to commit that? On Saturday, 20 February 2016, Remko Popma wrote: > I initially used PropertiesUtil but this failed somehow. Since this is > used while initializing s class constant, the failure resulted in a > NoClas

Re: logging-log4j2 git commit: LOG4J2-1281 LoggerConfig.getProperties() should not allocate on each call.

Another thing:if you look at the new code, where should I put the comment? There is nothing tricky about the new logic... Gary has a point that it may be good to have some sort of standardized reminder to distinguish performance sensitive methods (executed for each event) from non-sensitive logic

Re: FlowMessageFactory

I initially used PropertiesUtil but this failed somehow. Since this is used while initializing s class constant, the failure resulted in a NoClassDefError... So I reverted to System.getProperties. I can take another look, or if someone else has time, please feel free to replace this with Properties

[jira] [Commented] (LOG4J2-1255) Logger.entry and Logger.exit should support Messages.

[ https://issues.apache.org/jira/browse/LOG4J2-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154821#comment-15154821 ] Gary Gregory commented on LOG4J2-1255: -- Hm, not sure about that. I'll review later t

Re: MessageSupplier and Supplier

Yes, I am OK with this. Ralph > On Feb 19, 2016, at 1:28 PM, Gary Gregory wrote: > > If we all agree that MS should be deprecated then yes, let's have one task to > remove new 2.6 MS APIs and deprecate existing 2.5 ones. > > Ralph? Are you OK with this? > > Then we can continue refining. >

Re: FlowMessageFactory

I should have qualified this to say that the log4j2.component.properties file is managed by the PropertiesUtil class. Properties should be access through its methods. Ralph > On Feb 19, 2016, at 1:09 PM, Ralph Goers wrote: > > I see two new properties to allow users to override the default

Re: MessageSupplier and Supplier

If we all agree that MS should be deprecated then yes, let's have one task to remove new 2.6 MS APIs and deprecate existing 2.5 ones. Ralph? Are you OK with this? Then we can continue refining. Gary On Feb 18, 2016 8:23 AM, "Remko Popma" wrote: > I addressed the problem in > https://issues.apa

Re: FlowMessageFactory

I see two new properties to allow users to override the default MessageFactory and FlowMessageFactory. It seems very unlikely they will ever get used, but they should NOT be calling System.getProperty() directly. Please remember that wherever adding something to the configuration won’t work you

Re: FlowMessageFactory

On Fri, Feb 19, 2016 at 9:24 AM, Remko Popma wrote: > > FlowMessageFactory is now extracted. I'm quite happy with the result. > Please take a look at https://issues.apache.org/jira/browse/LOG4J2-1255 for further follow-up. OK, that seems fine. Thank you for doing the work. The only thing I am no

[jira] [Commented] (LOG4J2-1284) Make default MessageFactory configurable

[ https://issues.apache.org/jira/browse/LOG4J2-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154627#comment-15154627 ] Matt Sicker commented on LOG4J2-1284: - You can override props in a properties file th

Re: logging-log4j2 git commit: LOG4J2-1281 LoggerConfig.getProperties() should not allocate on each call.

That sounds like a far more robust solution :) On 19 February 2016 at 11:18, Remko Popma wrote: > Good point. > I'm looking at a way to use aspects during unit testing to automatically > detect if objects are allocated. > This will help prevent regressions once the no-GC goal has been achieved.

[jira] [Commented] (LOG4J2-1284) Make default MessageFactory configurable

[ https://issues.apache.org/jira/browse/LOG4J2-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154581#comment-15154581 ] Gary Gregory commented on LOG4J2-1284: -- Please, no more sys props, use the config fi

[jira] [Created] (LOG4J2-1285) AsyncLogger should not use deprecated Disruptor constructors

Remko Popma created LOG4J2-1285: --- Summary: AsyncLogger should not use deprecated Disruptor constructors Key: LOG4J2-1285 URL: https://issues.apache.org/jira/browse/LOG4J2-1285 Project: Log4j 2

Re: FlowMessageFactory

FlowMessageFactory is now extracted. I'm quite happy with the result. Please take a look at https://issues.apache.org/jira/browse/LOG4J2-1255 for further follow-up. On Fri, Feb 19, 2016 at 2:40 PM, Remko Popma wrote: > I see, so there actually is a use case to remove the need for the > isTraceEn

Re: logging-log4j2 git commit: LOG4J2-1281 LoggerConfig.getProperties() should not allocate on each call.

Good point. I'm looking at a way to use aspects during unit testing to automatically detect if objects are allocated. This will help prevent regressions once the no-GC goal has been achieved. On Sat, Feb 20, 2016 at 2:03 AM, Gary Gregory wrote: > I think that all these perf changes need a method

[jira] [Closed] (LOG4J2-1284) Make default MessageFactory configurable

[ https://issues.apache.org/jira/browse/LOG4J2-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-1284. --- > Make default MessageFactory configurable > > >

[jira] [Resolved] (LOG4J2-1284) Make default MessageFactory configurable

[ https://issues.apache.org/jira/browse/LOG4J2-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1284. - Resolution: Fixed The default message factory is now configurable with system property {{log4j2.

Re: logging-log4j2 git commit: LOG4J2-1281 LoggerConfig.getProperties() should not allocate on each call.

Agreed. Don't want to accidentally refactor performance-sensitive code! We have similar comments in Marker. On 19 February 2016 at 11:03, Gary Gregory wrote: > I think that all these perf changes need a method comment that says > something like "note that this code carefully does this and not th

[jira] [Created] (LOG4J2-1284) Make default MessageFactory configurable

Remko Popma created LOG4J2-1284: --- Summary: Make default MessageFactory configurable Key: LOG4J2-1284 URL: https://issues.apache.org/jira/browse/LOG4J2-1284 Project: Log4j 2 Issue Type: Improvem

Fwd: logging-log4j2 git commit: LOG4J2-1281 LoggerConfig.getProperties() should not allocate on each call.

I think that all these perf changes need a method comment that says something like "note that this code carefully does this and not that for performance". It should all be doc'd otherwise it is too easy for someone else to edit the method and undo the intent of the carefully tweaked perf changes.

[jira] [Resolved] (LOG4J2-1281) LoggerConfig.getProperties() should not allocate on each call

[ https://issues.apache.org/jira/browse/LOG4J2-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1281. - Resolution: Fixed Fix Version/s: 2.6 Fixed in master in commit 3458ea9. > LoggerConfig.ge

[jira] [Closed] (LOG4J2-1281) LoggerConfig.getProperties() should not allocate on each call

[ https://issues.apache.org/jira/browse/LOG4J2-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-1281. --- > LoggerConfig.getProperties() should not allocate on each call > ---

[jira] [Assigned] (LOG4J2-1281) LoggerConfig.getProperties() should not allocate on each call

[ https://issues.apache.org/jira/browse/LOG4J2-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1281: --- Assignee: Remko Popma > LoggerConfig.getProperties() should not allocate on each call >

[jira] [Resolved] (LOG4J2-1280) Logger methods taking Supplier parameters should check if supplied value is Message

[ https://issues.apache.org/jira/browse/LOG4J2-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1280. - Resolution: Fixed Fixed in master in commit 25a780e. > Logger methods taking Supplier parameters

[jira] [Created] (LOG4J2-1283) Provide alternative gc-free caching mechanism in DatePatternConverter

Remko Popma created LOG4J2-1283: --- Summary: Provide alternative gc-free caching mechanism in DatePatternConverter Key: LOG4J2-1283 URL: https://issues.apache.org/jira/browse/LOG4J2-1283 Project: Log4j 2

[jira] [Created] (LOG4J2-1282) Make RingBufferLogEvent::mergePropertiesIntoContextMap allocation-free if possible

Remko Popma created LOG4J2-1282: --- Summary: Make RingBufferLogEvent::mergePropertiesIntoContextMap allocation-free if possible Key: LOG4J2-1282 URL: https://issues.apache.org/jira/browse/LOG4J2-1282 Proj

[jira] [Created] (LOG4J2-1281) LoggerConfig.getProperties() should not allocate on each call

Remko Popma created LOG4J2-1281: --- Summary: LoggerConfig.getProperties() should not allocate on each call Key: LOG4J2-1281 URL: https://issues.apache.org/jira/browse/LOG4J2-1281 Project: Log4j 2

[jira] [Commented] (LOG4J2-649) Close a dynamically created appender

[ https://issues.apache.org/jira/browse/LOG4J2-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154029#comment-15154029 ] Sascha Scholz commented on LOG4J2-649: -- Unfortunately, the IdlePurgePolicy in 2.5 has

[jira] [Commented] (LOG4J2-1235) org.apache.logging.log4j.core.appender.routing.IdlePurgePolicy not working correctly

[ https://issues.apache.org/jira/browse/LOG4J2-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154019#comment-15154019 ] Sascha Scholz commented on LOG4J2-1235: --- I think I've found another race condition

[jira] [Commented] (LOG4J2-1255) Logger.entry and Logger.exit should support Messages.

[ https://issues.apache.org/jira/browse/LOG4J2-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154000#comment-15154000 ] Remko Popma commented on LOG4J2-1255: - Ralph, you mentioned that {quote} The use case

[jira] [Commented] (LOG4J2-1235) org.apache.logging.log4j.core.appender.routing.IdlePurgePolicy not working correctly

[ https://issues.apache.org/jira/browse/LOG4J2-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153918#comment-15153918 ] Sascha Scholz commented on LOG4J2-1235: --- I think the solution needs to be different