[jira] [Comment Edited] (LOG4J2-1323) Remove Final Declarations on Many Classes/Methods

[ https://issues.apache.org/jira/browse/LOG4J2-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202090#comment-15202090 ] Gary Gregory edited comment on LOG4J2-1323 at 3/23/16 1:16 AM:

[jira] [Commented] (LOG4J2-1323) Remove Final Declarations on Many Classes/Methods

[ https://issues.apache.org/jira/browse/LOG4J2-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207665#comment-15207665 ] Gary Gregory commented on LOG4J2-1323: -- I added a couple of getters to {{PatternProc

Re: Potential problem in PatternLayout

I'll an eye out for it. G On Tue, Mar 22, 2016 at 9:14 AM, Remko Popma wrote: > Ouch, scary! > Would it be possible to reproduce this? I wonder why this is happening... > > I updated TextEncoderHelper with a fallback mechanism to String.getBytes() > in case an error occurs. > That will also log

Jenkins build is back to stable : Log4j 2.x #1803

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Fast and Furious

Good news: The performance gap was not as massive as it originally appeared. One factor was that the calls to Thread.sleep() during the test skewed the results. Another issue with the test was that without the sleep(), the ringbuffer fills up and the BlockingWaitStrategy gives unpredictable results

[jira] [Commented] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207482#comment-15207482 ] Remko Popma commented on LOG4J2-1324: - I think this is a very different issue from h

[jira] [Commented] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207479#comment-15207479 ] Remko Popma commented on LOG4J2-1324: - If it is possible to work around this in log4j

[jira] [Comment Edited] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207371#comment-15207371 ] Ron Gonzalez edited comment on LOG4J2-1324 at 3/22/16 9:47 PM:

[jira] [Commented] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207371#comment-15207371 ] Ron Gonzalez commented on LOG4J2-1324: -- we dug into the heap dump and found that the

Re: Message.getFormattedMessage() return type widening

Makes sense to me. I always like using the weakest type necessary. On 22 March 2016 at 11:45, Remko Popma wrote: > Mikael's message below gave me an idea: > > why don't we change Message.getFormattedMessage() to return a CharSequence > instead of a String? > > I believe this change would be back

Tests in error

With the latest from master I get: Tests in error: RingBufferLogEventTest.testGetLevelReturnsOffIfNullLevelSet:62 » NullPointer RingBufferLogEventTest.testGetMessageReturnsNonNullMessage:82 » NullPointer RingBufferLogEventTest.testGetMillisReturnsConstructorMillisForNormalMessage:102 » NullPo

Jenkins build is still unstable: Log4j 2.x #1802

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Message.getFormattedMessage() return type widening

Mikael's message below gave me an idea: why don't we change Message.getFormattedMessage() to return a CharSequence instead of a String? I believe this change would be backwards compatible (all Message implementations that return a String will work as is), and it opens the way for Message implemen

Re: Error in RingBufferLogEvent

Yes, works now. On Tue, Mar 22, 2016 at 5:25 PM, Remko Popma wrote: > My bad. This is fixed in master now. > > On Wed, Mar 23, 2016 at 3:11 AM, Mikael Ståldal > wrote: > >> After last commit to master, I get this when running GcFreeLoggingTest: >> >> Mar 22, 2016 5:08:03 PM com.lmax.disruptor.F

Re: Error in RingBufferLogEvent

My bad. This is fixed in master now. On Wed, Mar 23, 2016 at 3:11 AM, Mikael Ståldal wrote: > After last commit to master, I get this when running GcFreeLoggingTest: > > Mar 22, 2016 5:08:03 PM com.lmax.disruptor.FatalExceptionHandler > handleEventException > SEVERE: Exception processing: 0 > or

Re: Potential problem in PatternLayout

Ouch, scary! Would it be possible to reproduce this? I wonder why this is happening... I updated TextEncoderHelper with a fallback mechanism to String.getBytes() in case an error occurs. That will also log the text that could not be encoded to the StatusLogger at ERROR level. If it happens again,

Error in RingBufferLogEvent

After last commit to master, I get this when running GcFreeLoggingTest: Mar 22, 2016 5:08:03 PM com.lmax.disruptor.FatalExceptionHandler handleEventException SEVERE: Exception processing: 0 org.apache.logging.log4j.core.async.RingBufferLogEvent@5704d25c java.lang.NullPointerException at org.apache

Jenkins build became unstable: Log4j 2.x #1801

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: RingBufferLogEvent#StringBuilderWrapperMessage is incomplete

I think it will be difficult to adapt all layouts (and appenders without layouts) to use StringBuilderFormattable.formatTo(StringBuilder) instead of String Message.getFormattedMessage(). I suggest we add another method to StringBuilderFormattable: CharSequence getFormattedMessageBuffer(); // feel

Re: Potential problem in PatternLayout

Does it work better with the current master? On Tue, Mar 22, 2016 at 4:25 PM, Gary Gregory wrote: > Coincidentally, I just got: > > 2016-03-22 07:58:19,034 main ERROR An exception occurred processing > Appender RollingFile java.lang.IllegalArgumentException > at java.nio.Buffer.position(Buffer.j

Re: RingBufferLogEvent#StringBuilderWrapperMessage is incomplete

Should we to the trimming in getFormattedMessage() as well as in toFormat()? On Tue, Mar 22, 2016 at 4:38 PM, Remko Popma wrote: > Thanks! Done. > > Sent from my iPhone > > On 2016/03/23, at 0:10, Mikael Ståldal wrote: > > I think that RingBufferLogEvent#StringBuilderWrapperMessage need to have

Re: RingBufferLogEvent#StringBuilderWrapperMessage is incomplete

Thanks! Done. Sent from my iPhone > On 2016/03/23, at 0:10, Mikael Ståldal wrote: > > I think that RingBufferLogEvent#StringBuilderWrapperMessage need to have a > proper implementation of getFormattedMessage(), otherwise layouts and > appenders which does not use formatTo() will not work. >

Re: Potential problem in PatternLayout

Coincidentally, I just got: 2016-03-22 07:58:19,034 main ERROR An exception occurred processing Appender RollingFile java.lang.IllegalArgumentException at java.nio.Buffer.position(Buffer.java:236) at sun.nio.cs.UTF_8.updatePositions(UTF_8.java:78) at sun.nio.cs.UTF_8$Encoder.encodeArrayLoop(UTF_8.

RingBufferLogEvent#StringBuilderWrapperMessage is incomplete

I think that RingBufferLogEvent#StringBuilderWrapperMessage need to have a proper implementation of getFormattedMessage(), otherwise layouts and appenders which does not use formatTo() will not work. -- [image: MagineTV] *Mikael Ståldal* Senior software developer *Magine TV* mikael.stal...@magi

[jira] [Commented] (LOG4J2-1295) Automated testing to verify no temporary objects allocated in gc-free configuration

[ https://issues.apache.org/jira/browse/LOG4J2-1295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206378#comment-15206378 ] Mikael Ståldal commented on LOG4J2-1295: There seems to be an error there, I had

[jira] [Comment Edited] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206245#comment-15206245 ] Ron Gonzalez edited comment on LOG4J2-1324 at 3/22/16 1:39 PM:

[jira] [Comment Edited] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206272#comment-15206272 ] Ron Gonzalez edited comment on LOG4J2-1324 at 3/22/16 1:35 PM:

[jira] [Comment Edited] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206272#comment-15206272 ] Ron Gonzalez edited comment on LOG4J2-1324 at 3/22/16 1:35 PM:

[jira] [Comment Edited] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206272#comment-15206272 ] Ron Gonzalez edited comment on LOG4J2-1324 at 3/22/16 1:36 PM:

[jira] [Comment Edited] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206272#comment-15206272 ] Ron Gonzalez edited comment on LOG4J2-1324 at 3/22/16 1:34 PM:

Jenkins build is back to stable : Log4j 2.x #1800

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Comment Edited] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206272#comment-15206272 ] Ron Gonzalez edited comment on LOG4J2-1324 at 3/22/16 12:33 PM: ---

[jira] [Updated] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Gonzalez updated LOG4J2-1324: - Attachment: 2016-03-22_8-32-37.jpg attaching image, shows: On Left: Shows default consumer thre

[jira] [Updated] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Gonzalez updated LOG4J2-1324: - Environment: LOG4J CORE Release Version 2.2 Disruptor Bundle-Version 3.3.2 ORACLE jdk1.8.0_45 Li

[jira] [Comment Edited] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206245#comment-15206245 ] Ron Gonzalez edited comment on LOG4J2-1324 at 3/22/16 12:14 PM: ---

[jira] [Commented] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206245#comment-15206245 ] Ron Gonzalez commented on LOG4J2-1324: -- bq. Looking at the Thread Dump, the AsyncLog

Re: Potential problem in PatternLayout

I fixed it while moving the field and method to AbstractStringLayout (to be able to use from GelfLayout as well). On Tue, Mar 22, 2016 at 12:55 PM, Mikael Ståldal wrote: > I am working on a fix. > > On Tue, Mar 22, 2016 at 11:52 AM, Remko Popma > wrote: > >> I think you're right. This should be

Re: Potential problem in PatternLayout

I am working on a fix. On Tue, Mar 22, 2016 at 11:52 AM, Remko Popma wrote: > I think you're right. This should be an instance field, not a static > field. Good catch! > > > On Tuesday, 22 March 2016, Mikael Ståldal > wrote: > >> In PatternLayout we have: >> >> private static final ThreadLocal

Re: Potential problem in PatternLayout

I think you're right. This should be an instance field, not a static field. Good catch! On Tuesday, 22 March 2016, Mikael Ståldal wrote: > In PatternLayout we have: > > private static final ThreadLocal textEncoderHelper = > new ThreadLocal<>(); > > private TextEncoderHelper getCachedTextEnc

Potential problem in PatternLayout

In PatternLayout we have: private static final ThreadLocal textEncoderHelper = new ThreadLocal<>(); private TextEncoderHelper getCachedTextEncoderHelper() { TextEncoderHelper result = textEncoderHelper.get(); if (result == null) { result = new TextEncoderHelper(getCharset());

[jira] [Comment Edited] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205641#comment-15205641 ] Remko Popma edited comment on LOG4J2-1324 at 3/22/16 8:26 AM: -

[jira] [Updated] (LOG4J2-1324) Async Logger - Consumer thread dying - new thread unable to start

[ https://issues.apache.org/jira/browse/LOG4J2-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1324: Summary: Async Logger - Consumer thread dying - new thread unable to start (was: Async Appender -