Re: @Required on layout on AbstractAppender

I understand now, thank you. All build methods do not use the same default. I'll remove the @Required tomorrow. Gary On Sep 11, 2016 9:11 PM, "Matt Sicker" wrote: > I mean if you do something like this: > > @PluginElement("Layout") > @Required > private Layout layout = PatternLayout.defaultLayo

[jira] [Commented] (LOG4J2-1313) not working

[ https://issues.apache.org/jira/browse/LOG4J2-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483067#comment-15483067 ] Ralph Goers commented on LOG4J2-1313: - I guess I have to agree with Gary. What you d

Re: @Required on layout on AbstractAppender

I mean if you do something like this: @PluginElement("Layout") @Required private Layout layout = PatternLayout.defaultLayout(); Then it should work. But if you defer the creation of a default layout until you execute the build() method, then the validator will err out before build() is called. O

Re: @Required on layout on AbstractAppender

HI Matt, Right now, all of the build() methods handle null layouts by using a default layout. That works for programmatic configs. But in order for that to work from a config file, the @Required needs to be removed. I feel like I am not understanding something in your message :-( Gary On Sun, S

[jira] [Commented] (LOG4J2-1313) not working

[ https://issues.apache.org/jira/browse/LOG4J2-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482807#comment-15482807 ] Gary Gregory commented on LOG4J2-1313: -- IMO: 1) null 2) "" 3) "" > not working >

[jira] [Commented] (LOG4J2-1313) not working

[ https://issues.apache.org/jira/browse/LOG4J2-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482751#comment-15482751 ] Remko Popma commented on LOG4J2-1313: - When I looked at PluginValueVisitor in a debug

[jira] [Comment Edited] (LOG4J2-1563) Log4j 2.6.2 can lose exceptions when a security manager is present

[ https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482732#comment-15482732 ] Jason Tedor edited comment on LOG4J2-1563 at 9/12/16 1:32 AM: -

[jira] [Commented] (LOG4J2-1563) Log4j 2.6.2 can lose exceptions when a security manager is present

[ https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482737#comment-15482737 ] Jason Tedor commented on LOG4J2-1563: - {quote}How do we run a whole build with a secu

[jira] [Commented] (LOG4J2-1563) Log4j 2.6.2 can lose exceptions when a security manager is present

[ https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482732#comment-15482732 ] Jason Tedor commented on LOG4J2-1563: - Thanks [~garydgregory], sorry that I missed yo

[jira] [Updated] (LOG4J2-1563) Log4j 2.6.2 can lose exceptions when a security manager is present

[ https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Tedor updated LOG4J2-1563: Attachment: 0001-Unify-handling-of-throwables-when-loading-class.patch Attached is a patch to unify

[jira] [Commented] (LOG4J2-1563) Log4j 2.6.2 can lose exceptions when a security manager is present

[ https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482727#comment-15482727 ] Jason Tedor commented on LOG4J2-1563: - I think we can make this simpler by just follo

[jira] [Updated] (LOG4J2-1563) Log4j 2.6.2 can lose exceptions when a security manager is present

[ https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Tedor updated LOG4J2-1563: Attachment: 0002-Remove-policy-in-throwable-proxy-security-test.patch Attached is a a patch that re

[jira] [Commented] (LOG4J2-1563) Log4j 2.6.2 can lose exceptions when a security manager is present

[ https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482723#comment-15482723 ] Jason Tedor commented on LOG4J2-1563: - That gets tricky because that means storing of

[jira] [Commented] (LOG4J2-1313) not working

[ https://issues.apache.org/jira/browse/LOG4J2-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482677#comment-15482677 ] Ralph Goers commented on LOG4J2-1313: - A property with a null value should be the sam

[jira] [Assigned] (LOG4J2-1548) [CronTriggeringPolicy] ConfigurationScheduler schedules the task infinitely after first fire

[ https://issues.apache.org/jira/browse/LOG4J2-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1548: --- Assignee: Gary Gregory > [CronTriggeringPolicy] ConfigurationScheduler schedules the task in

[jira] [Assigned] (LOG4J2-1235) org.apache.logging.log4j.core.appender.routing.IdlePurgePolicy not working correctly

[ https://issues.apache.org/jira/browse/LOG4J2-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1235: --- Assignee: Gary Gregory > org.apache.logging.log4j.core.appender.routing.IdlePurgePolicy not

[jira] [Assigned] (LOG4J2-1320) Custom plugins are not loaded, URL protocol vfs is not supported

[ https://issues.apache.org/jira/browse/LOG4J2-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1320: --- Assignee: Gary Gregory > Custom plugins are not loaded, URL protocol vfs is not supported >

[jira] [Assigned] (LOG4J2-1559) NPE in Level.isInRange

[ https://issues.apache.org/jira/browse/LOG4J2-1559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1559: --- Assignee: Gary Gregory > NPE in Level.isInRange > -- > >

[jira] [Assigned] (LOG4J2-1563) Log4j 2.6.2 can lose exceptions when a security manager is present

[ https://issues.apache.org/jira/browse/LOG4J2-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1563: --- Assignee: Gary Gregory > Log4j 2.6.2 can lose exceptions when a security manager is present

[jira] [Assigned] (LOG4J2-1490) Log4j2 is creating empty log files.

[ https://issues.apache.org/jira/browse/LOG4J2-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1490: --- Assignee: Gary Gregory > Log4j2 is creating empty log files. > -

[jira] [Commented] (LOG4J2-1313) not working

[ https://issues.apache.org/jira/browse/LOG4J2-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482596#comment-15482596 ] Remko Popma commented on LOG4J2-1313: - Also, what do we want an empty attribute to me

Re: OS-based dynamic configuration file

Yes. The Appenders tag inside the ScriptSelector are the Appenders that are to be created. But now that I think about it, we can’t use “Appenders” for this. If you look at the RoutingAppender you will notice that Appenders there are declared under a Route element. The Route plugin is defined wit

Re: @Required on layout on AbstractAppender

I thought that @Required would check the field at build time, not injection time. If the field was set to null, then you're going to have a bad time. On 11 September 2016 at 10:50, Gary Gregory wrote: > I forgot to say that: > > org.apache.logging.log4j.core.appender.ConsoleAppender.Builder.buil

Re: OS-based dynamic configuration file

Or maybe call is "StartScript"? since we have the notion of life-cycle and appenders have start() and stop() methods. I'm not sure we'd need a StopScript but it makes it look nicer IMO. The Init/StartScript would run when the ScriptSelectorAppender is started right? Gary Gary On Sun, Sep 11, 201

Re: OS-based dynamic configuration file

Are the tags really meant to be nested? Gary On Sat, Sep 10, 2016 at 11:48 AM, Ralph Goers wrote: > Oops. I forgot the closing CDATA tag in the script. > > Ralph > > On Sep 10, 2016, at 11:43 AM, Ralph Goers > wrote: > > Interesting. OS/390. I worked on MVS, OS/370, z/OS, etc many moons ago

Re: OS-based dynamic configuration file

The configuration would look just like what I have shown except it would probably be “InitScript” instead of “Script”. It could make sense to allow both as I could envision the InitScript setting things up for the script that runs every time, but we would need a way to pass data between them. Th

Jenkins build is back to stable : Log4j 2.x #2293

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: Test failure in PropertyTest.testEmptyAttribute:

I think this is better: @Ignore("TODO fix LOG4J2-1313") Than: @Ignore() // TODO fix LOG4J2-1313 So I've change it. Presumably some tooling could pick this up. Gary On Sun, Sep 11, 2016 at 10:06 AM, Remko Popma wrote: > This test is for LOG4J2-1313 >

[jira] [Resolved] (LOG4J2-1575) (GC) Store Configuration Properties in List instead of Map to prevent creating temporary iterators

[ https://issues.apache.org/jira/browse/LOG4J2-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1575. - Resolution: Fixed Pushed to master. Updating some pre-existing tests for this feature exposed a

[jira] [Closed] (LOG4J2-1575) (GC) Store Configuration Properties in List instead of Map to prevent creating temporary iterators

[ https://issues.apache.org/jira/browse/LOG4J2-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-1575. --- > (GC) Store Configuration Properties in List instead of Map to prevent > creating temporary iterators >

Re: Test failure in PropertyTest.testEmptyAttribute:

This test is for LOG4J2-1313 . I've @ignored it for now. On Mon, Sep 12, 2016 at 1:41 AM, Gary Gregory wrote: > With git master, I get: > > Failed tests: > PropertyTest.testEmptyAttribute:60 expected:<1=elementValue,2=[, > 3=attributeValue,4=a

[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15482046#comment-15482046 ] Remko Popma commented on LOG4J2-1447: - You are probably right. Changes in the underly

Re: OS-based dynamic configuration file

On Sat, Sep 10, 2016 at 11:43 AM, Ralph Goers wrote: > Interesting. OS/390. I worked on MVS, OS/370, z/OS, etc many moons ago > but haven’t worked on a mainframe since 2001. > > This sort of sounds like you want an Appender Selector, which would be an > Appender that uses a Selector to figure ou

Test failure in PropertyTest.testEmptyAttribute:

With git master, I get: Failed tests: PropertyTest.testEmptyAttribute:60 expected:<1=elementValue,2=[,3=attributeValue,4=attributeValue2,5=attribute]Value3,m=msg> but was:<1=elementValue,2=[${sys:emptyElementKey},3=attributeValue,4=attributeValue2,5=element]Value3,m=msg> Tests run: 1334, Failur

Re: @Required on layout on AbstractAppender

I forgot to say that: org.apache.logging.log4j.core.appender.ConsoleAppender.Builder.build() org.apache.logging.log4j.core.appender.FileAppender.Builder.build() org.apache.logging.log4j.core.appender.RollingFileAppender.Builder.build() org.apache.logging.log4j.core.appender.SocketAppender.Builder.

@Required on layout on AbstractAppender

I'm pretty sure we no longer need @Required on layout on org.apache.logging.log4j.core.appender.AbstractAppender.Builder.layout. Would it be OK to say that an appender should provide a default layout? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate,

[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481920#comment-15481920 ] Gary Gregory commented on LOG4J2-1447: -- In my mind, it is possible that as "as" meth

Re: OS-based dynamic configuration file

I see. For what it's worth, I like the embedded script idea. It seems like it could be very powerful. On Mon, Sep 12, 2016 at 12:11 AM, Gary Gregory wrote: > On Sep 10, 2016 11:33 PM, "Ralph Goers" > wrote: > > > > But Gary said he didn’t want the OS390 appender created unless he is > running

Re: OS-based dynamic configuration file

On Sep 10, 2016 11:33 PM, "Ralph Goers" wrote: > > But Gary said he didn’t want the OS390 appender created unless he is running on OS390. Right, IRL, I am going to use an Appender that does some JNI calls that will only work on OS/390. Gary > > But your example makes me think we also need an Ap

[jira] [Updated] (LOG4J2-1575) (GC) Store Configuration Properties in List instead of Map to prevent creating temporary iterators

[ https://issues.apache.org/jira/browse/LOG4J2-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1575: Description: Currently the Configuration stores Property values in a Map, where the key is the Pro

[jira] [Created] (LOG4J2-1575) (GC) Store Configuration Properties in List instead of Map to prevent creating temporary iterators

Remko Popma created LOG4J2-1575: --- Summary: (GC) Store Configuration Properties in List instead of Map to prevent creating temporary iterators Key: LOG4J2-1575 URL: https://issues.apache.org/jira/browse/LOG4J2-1575

Jenkins build is still unstable: Log4j 2.x #2292

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Jenkins build is still unstable: Log4j 2.x #2291

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org