Re: logging-log4j2 git commit: Add logo for 2.7 release

2016-09-19 Thread Gary Gregory
Boo :-( I am done for today here FWIW. Gary On Mon, Sep 19, 2016 at 10:37 PM, Ralph Goers wrote: > Thanks. First release build failed due to check-ins while it was running > :-( > > Ralph > > On Sep 19, 2016, at 10:18 PM, Gary Gregory wrote:

Re: logging-log4j2 git commit: Add logo for 2.7 release

2016-09-19 Thread Ralph Goers
Thanks. First release build failed due to check-ins while it was running :-( Ralph > On Sep 19, 2016, at 10:18 PM, Gary Gregory wrote: > > Nice choice :-) > > Gary > -- Forwarded message -- > From: > > Date:

Fwd: logging-log4j2 git commit: Add logo for 2.7 release

2016-09-19 Thread Gary Gregory
Nice choice :-) Gary -- Forwarded message -- From: Date: Mon, Sep 19, 2016 at 10:01 PM Subject: logging-log4j2 git commit: Add logo for 2.7 release To: comm...@logging.apache.org Repository: logging-log4j2 Updated Branches: refs/heads/master 62c5e9e9f ->

[jira] [Commented] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

2016-09-19 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505539#comment-15505539 ] Gary Gregory commented on LOG4J2-1597: -- I tweaked the example. > Add a ScriptAppenderSelector to

[jira] [Commented] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

2016-09-19 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505464#comment-15505464 ] Remko Popma commented on LOG4J2-1597: - About the Appenders manual page documentation for this

[jira] [Created] (LOG4J2-1599) NPE in org.apache.logging.log4j.message.ParameterFormatter.formatMessage3(StringBuilder, char[], int, Object[], int, int[])

2016-09-19 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1599: Summary: NPE in org.apache.logging.log4j.message.ParameterFormatter.formatMessage3(StringBuilder, char[], int, Object[], int, int[]) Key: LOG4J2-1599 URL:

Re: logging-log4j2 git commit: Add missing license headers

2016-09-19 Thread Ralph Goers
Too bad I did it to the wrong branch. Just added them again to master. Ralph > On Sep 19, 2016, at 7:39 PM, Remko Popma wrote: > > Thank you! Sorry I missed that. > > Sent from my iPhone > >> On 2016/09/20, at 9:31, rgo...@apache.org wrote: >> >> Repository:

Re: logging-log4j2 git commit: Add missing license headers

2016-09-19 Thread Remko Popma
Thank you! Sorry I missed that. Sent from my iPhone > On 2016/09/20, at 9:31, rgo...@apache.org wrote: > > Repository: logging-log4j2 > Updated Branches: > refs/heads/LOG4J2-1597 21ac645e0 -> 4a5f2b70d > > > Add missing license headers > > > Project:

[jira] [Closed] (LOG4J2-1598) Update Jackson from 2.8.2 to 2.8.3

2016-09-19 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1598. Resolution: Fixed Fix Version/s: 2.7 In Git master. > Update Jackson from 2.8.2 to 2.8.3 >

Jenkins build is back to stable : Log4j 2.x #2332

2016-09-19 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Created] (LOG4J2-1598) Update Jackson from 2.8.2 to 2.8.3

2016-09-19 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1598: Summary: Update Jackson from 2.8.2 to 2.8.3 Key: LOG4J2-1598 URL: https://issues.apache.org/jira/browse/LOG4J2-1598 Project: Log4j 2 Issue Type: Improvement

[jira] [Closed] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

2016-09-19 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed LOG4J2-1597. Closing: In Git master. > Add a ScriptAppenderSelector to create an Appender specified by a Script >

Re: OS-based dynamic configuration file

2016-09-19 Thread Gary Gregory
Branch LOG4J2-1597 merged in Git master; tracked with https://issues.apache.org/jira/browse/LOG4J2-1597. I'll delete the LOG4J2-1597 branch soon. Gary On Mon, Sep 19, 2016 at 4:55 PM, Gary Gregory wrote: > I am OK with ScriptAppenderSelector so I'll change it to that. >

[jira] [Resolved] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

2016-09-19 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1597. -- Resolution: Fixed Fix Version/s: 2.7 In Git master. > Add a ScriptAppenderSelector to

[jira] [Updated] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

2016-09-19 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1597: - Description: The use case is to create an OS-based dynamic configuration file. The script

[jira] [Updated] (LOG4J2-1597) Add a ScriptAppenderSelector to create an Appender specified by a Script

2016-09-19 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1597: - Summary: Add a ScriptAppenderSelector to create an Appender specified by a Script (was: Add a

Re: OS-based dynamic configuration file

2016-09-19 Thread Gary Gregory
I am OK with ScriptAppenderSelector so I'll change it to that. Gary On Mon, Sep 19, 2016 at 3:23 PM, Ralph Goers wrote: > The 3 obvious choices: ScriptSelectorAppender, ScriptAppenderSelector, or > AppenderScriptSelector. I actually prefer the second as it is an >

Re: OS-based dynamic configuration file

2016-09-19 Thread Ralph Goers
The 3 obvious choices: ScriptSelectorAppender, ScriptAppenderSelector, or AppenderScriptSelector. I actually prefer the second as it is an AppenderSelector that uses a Script (or rather, a Selector of an Appender that uses a Script). The first isn’t too bad as it is an Appender that is a

Re: OS-based dynamic configuration file

2016-09-19 Thread Gary Gregory
ScriptSelectorAppender? On Sep 19, 2016 2:29 PM, "Ralph Goers" wrote: > Actually, I do have one minor issue. It will cause confusion calling it > ScriptSelector. I am imagining the next step will be to create a > LayoutSelector that uses Scripts. I can also imagine

Re: OS-based dynamic configuration file

2016-09-19 Thread Ralph Goers
Actually, I do have one minor issue. It will cause confusion calling it ScriptSelector. I am imagining the next step will be to create a LayoutSelector that uses Scripts. I can also imagine a Selector for AppenderRefs that uses Scripts. So calling it ScriptSelector is a bit ambiguous, unless

Re: OS-based dynamic configuration file

2016-09-19 Thread Gary Gregory
Ok, thank you. I'll merge in a couple of hours. Gary On Sep 19, 2016 2:22 PM, "Ralph Goers" wrote: > I took a look and it looks OK to me. > > On Sep 19, 2016, at 12:02 AM, Gary Gregory wrote: > > Great, thanks Ralph. > > Gary > > On Sun, Sep

Re: OS-based dynamic configuration file

2016-09-19 Thread Ralph Goers
I took a look and it looks OK to me. > On Sep 19, 2016, at 12:02 AM, Gary Gregory wrote: > > Great, thanks Ralph. > > Gary > > On Sun, Sep 18, 2016 at 11:14 PM, Ralph Goers > wrote: > Yup to both. I’ll

Re: Fwd: logging-log4j2 git commit: [LOG4J2-1597]

2016-09-19 Thread Gary Gregory
On Sep 19, 2016 7:09 AM, "Matt Sicker" wrote: > > When could the Configuration possibly be null? Through programmatic configuration, if you force it or forget to set it. It seems simpler to centralize validation in one place. Gary If you want to support required params via

Fwd: logging-log4j2 git commit: [LOG4J2-1597]

2016-09-19 Thread Matt Sicker
When could the Configuration possibly be null? If you want to support required params via builders, I'd suggest adding the null check in the setter rather than in the build() method. During config file parsing (the usual method), the @Required annotation invokes a validator that also checks for

[jira] [Commented] (LOG4J2-1576) Better automated backwards compatibility checking

2016-09-19 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503530#comment-15503530 ] Remko Popma commented on LOG4J2-1576: - I started a thread on the revapi mailing list:

[jira] [Commented] (LOG4J2-1593) Concrete Filter implementations should override equals and hashCode

2016-09-19 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502737#comment-15502737 ] Mikael Ståldal commented on LOG4J2-1593: OK, given the current implementation of the filter

[jira] [Commented] (LOG4J2-1593) Concrete Filter implementations should override equals and hashCode

2016-09-19 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502717#comment-15502717 ] Remko Popma commented on LOG4J2-1593: - The alternative is to override equals on AbstractFilter, but I

[jira] [Commented] (LOG4J2-1593) Concrete Filter implementations should override equals and hashCode

2016-09-19 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502701#comment-15502701 ] Mikael Ståldal commented on LOG4J2-1593: Then we need to document that third-party Filters need

Jenkins build became unstable: Log4j 2.x #2331

2016-09-19 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: OS-based dynamic configuration file

2016-09-19 Thread Gary Gregory
Great, thanks Ralph. Gary On Sun, Sep 18, 2016 at 11:14 PM, Ralph Goers wrote: > Yup to both. I’ll look at it tomorrow. > > Ralph > > On Sep 18, 2016, at 10:31 PM, Gary Gregory wrote: > > Nevermind, I can just overwrite the name in the

Re: OS-based dynamic configuration file

2016-09-19 Thread Ralph Goers
Yup to both. I’ll look at it tomorrow. Ralph > On Sep 18, 2016, at 10:31 PM, Gary Gregory wrote: > > Nevermind, I can just overwrite the name in the Node's attribute map... that > works. I'd like a code review before or after merging to master. > > Gary > > On Sun,