Re: [deprecation] getContextMap() in LogEvent has been deprecated

To be honest I don't know much about (and currently not planning to spend time learning) JPA. I have very little time for Log4j recently and want to spend it on other issues. Anyone who wants to improve this is welcome to do the work of course. Sent from my iPhone > On 19 Nov 2016, at 16:21,

Re: [1/2] logging-log4j2 git commit: Add org.apache.logging.log4j.core.AbstractLifeCycle.getLogger()

This class is the root of all of classes. I'm not saying we should add this method to all root classes. I just see it as useful here because I have a few custom Appenders. Gary On Fri, Nov 18, 2016 at 11:12 PM, Remko Popma wrote: > If we end up providing this protected

Re: [deprecation] getContextMap() in LogEvent has been deprecated

I get you now. It seems odd (to me) that we would deprecate one method and then a second another method that delegates to the first deprecated one but with the exact same signature. It feels confusing. Maybe it's just me of course ;-) To complete the deprecation story of getContextMap(), we could

Re: [1/2] logging-log4j2 git commit: Add org.apache.logging.log4j.core.AbstractLifeCycle.getLogger()

If we end up providing this protected method in all abstract classes instead of simply doing a static import of StatusLogger.getLogger(), that would be silly... Sent from my iPhone > On 19 Nov 2016, at 15:30, Gary Gregory wrote: > >> On Fri, Nov 18, 2016 at 8:58 PM,

Re: [deprecation] getContextMap() in LogEvent has been deprecated

Sorry I was unclear. Usually we deprecate one method when we offer a better alternative. Does BasicLogEventEntity have a getContextData() method that would be the newly preferred method for client code to use instead of BasicLogEventEntity.getContextMap()? If so then deprecating

Re: [1/2] logging-log4j2 git commit: Add org.apache.logging.log4j.core.AbstractLifeCycle.getLogger()

On Fri, Nov 18, 2016 at 8:58 PM, Remko Popma wrote: > getStatusLogger() is a much better name. > Somehow it feels like the wrong direction though. Do we really need to > build anything new here? > Wouldn't it be cleaner for components to static import the >

Re: [1/2] logging-log4j2 git commit: Add org.apache.logging.log4j.core.AbstractLifeCycle.getLogger()

getStatusLogger() is a much better name. Somehow it feels like the wrong direction though. Do we really need to build anything new here? Wouldn't it be cleaner for components to static import the StatusLogger.getLogger() method, for example? On Saturday, November 19, 2016, Gary Gregory

Re: [1/2] logging-log4j2 git commit: Add org.apache.logging.log4j.core.AbstractLifeCycle.getLogger()

But... from a provider's POV, like when I implement a custom Appender, it seems cleaner and more OO to call getLogger() than to access the static var directly. Now that I think about it, calling it getStatusLogger() would be even better. WDYT? Gary On Fri, Nov 18, 2016 at 8:10 PM, Remko Popma

Re: [1/2] logging-log4j2 git commit: Add org.apache.logging.log4j.core.AbstractLifeCycle.getLogger()

Why? I prefer to keep the constant: that makes it clearer that this is a status logger for internal use. Sent from my iPhone > On 19 Nov 2016, at 3:54, ggreg...@apache.org wrote: > > Repository: logging-log4j2 > Updated Branches: > refs/heads/master 551cf8399 -> ee6f50d4c > > > Add

Re: [deprecation] getContextMap() in LogEvent has been deprecated

Not sure if we actually provide a converter for the new getContextData() method (as an alternative to the deprecated method). If we do then that's a good idea. Sent from my iPhone > On 19 Nov 2016, at 10:33, Gary Gregory wrote: > > Question: For methods like >

Re: [deprecation] getContextMap() in LogEvent has been deprecated

Actually, not for methods "like" that one. That method is the only case I found ;-) Gary On Fri, Nov 18, 2016 at 5:33 PM, Gary Gregory wrote: > Question: For methods like org.apache.logging.log4j.core.appender.db.jpa. > BasicLogEventEntity.getContextMap(): > >

Re: [deprecation] getContextMap() in LogEvent has been deprecated

Question: For methods like org.apache.logging.log4j.core.appender.db.jpa.BasicLogEventEntity.getContextMap(): @SuppressWarnings("deprecation") @Override @Convert(converter = ContextMapAttributeConverter.class) public Map getContextMap() { return

Re: [deprecation] getContextMap() in LogEvent has been deprecated

Done. On Fri, Nov 18, 2016 at 9:59 AM, Gary Gregory wrote: > Whatever it takes ;-) > > Gary [AFK] > > On Nov 17, 2016 4:56 PM, "Matt Sicker" wrote: > >> So do these just need to be refactored to use the new ContextDataInjector >> class, or is it

[jira] [Commented] (LOG4J2-1713) Allow for more general serialization of Log4j2 configurations

[ https://issues.apache.org/jira/browse/LOG4J2-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677718#comment-15677718 ] Gary Gregory commented on LOG4J2-1713: -- So we can close this issue. All is well? > Allow for more

Jenkins build is back to stable : Log4j 2.x #2494

See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Commented] (LOG4J2-1691) Setup build process for new Git repo logging-log4j-scala, including site

[ https://issues.apache.org/jira/browse/LOG4J2-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677196#comment-15677196 ] Ralph Goers commented on LOG4J2-1691: - I can look at it this evening or over the weekend. > Setup

[jira] [Commented] (LOG4J2-1691) Setup build process for new Git repo logging-log4j-scala, including site

[ https://issues.apache.org/jira/browse/LOG4J2-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677075#comment-15677075 ] Mikael Ståldal commented on LOG4J2-1691: I need some help to get the site build to work.