[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433027#comment-15433027 ] Remko Popma commented on LOG4J2-1447: - No, one implementation is enough. After the most recent set

[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433012#comment-15433012 ] Remko Popma commented on LOG4J2-1447: - Yes we need to support null keys because the ThreadContext API

[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433000#comment-15433000 ] Remko Popma commented on LOG4J2-1447: - Yes, this is to guide future work to make

[jira] [Comment Edited] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432877#comment-15432877 ] Remko Popma edited comment on LOG4J2-1349 at 8/23/16 3:10 PM: -- h1. Corrected

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432981#comment-15432981 ] Remko Popma commented on LOG4J2-1349: - The ones we decide not to use can be moved to src/test

[jira] [Comment Edited] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432877#comment-15432877 ] Remko Popma edited comment on LOG4J2-1349 at 8/23/16 3:07 PM: -- h1. Corrected

[jira] [Updated] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1349: Attachment: v2_ThreadContextPut.png v2_DataStructOpsPerfMediumDataSet.png

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432599#comment-15432599 ] Remko Popma commented on LOG4J2-1349: - I agree. The multiple implementations were more

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432589#comment-15432589 ] Remko Popma commented on LOG4J2-1349: - It is not really intertwined but is based on the head

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432518#comment-15432518 ] Remko Popma commented on LOG4J2-1349: - Looking at the ArrayContextDataVsHashMapBenchmark

Re: logging-log4j2 git commit: Remove internal method that is @deprecated Use {@link #createLogger(boolean, Level, String, String, AppenderRef[], Property[], Configuration, Filter)}

Can we add entries in the change log for deprecated methods or constants that were removed? Otherwise the only way to tell for users is when they get a compilation error... Sent from my iPhone > On 2016/08/23, at 14:54, ggreg...@apache.org wrote: > > Repository: logging-log4j2 > Updated

[jira] [Commented] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431758#comment-15431758 ] Remko Popma commented on LOG4J2-1349: - Okay, I will add benchmarks for the "legacy inject"

[jira] [Comment Edited] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431155#comment-15431155 ] Remko Popma edited comment on LOG4J2-1349 at 8/22/16 4:59 PM: -- This is now

[jira] [Updated] (LOG4J2-1349) Garbage-free ThreadContext map

[ https://issues.apache.org/jira/browse/LOG4J2-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1349: Attachment: DataStructOpsPerfMediumDataSet.png DataStructOpsPerfSmallDataSet.png

[jira] [Commented] (LOG4J2-1010) Injectable context properties

[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430998#comment-15430998 ] Remko Popma commented on LOG4J2-1010: - I've modified DynamicThresholdFilter and ContextMapLookup

[jira] [Commented] (LOG4J2-1528) Serialize configuration into a log4j2.xml file

[ https://issues.apache.org/jira/browse/LOG4J2-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429924#comment-15429924 ] Remko Popma commented on LOG4J2-1528: - Looking at the code snippet, yes: LoggerConfig looks

[jira] [Updated] (LOG4J2-1521) StringIndexOutOfBoundsException thrown when rolling logs

[ https://issues.apache.org/jira/browse/LOG4J2-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1521: Fix Version/s: 2.7 > StringIndexOutOfBoundsException thrown when rolling l

Re: Close Input Stream in Configuration factory?

Sounds like an oversight. I can't think of any reason why closing the InputStream would be correct for some ConfigFactories but incorrect for PropertiesConfigurationFactory. Closing it should be fine. Sent from my iPhone > On 2016/08/21, at 19:40, Mikael Ståldal

[jira] [Commented] (LOG4J2-1528) Serialize configuration into a log4j2.xml file

[ https://issues.apache.org/jira/browse/LOG4J2-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429739#comment-15429739 ] Remko Popma commented on LOG4J2-1528: - Away from PC now but from memory the default

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

could add an EditorConfig file to enforce it > automatically in IDEs even. > > On 20 August 2016 at 19:33, Remko Popma <remko.po...@gmail.com> wrote: > >> Gary, can you please check your IDE settings for line endings? >> It is really difficult to see what changed if the

Re: build fail

to apply a patch. > > On 19 August 2016 at 20:25, Matt Sicker <boa...@gmail.com> wrote: > >> Isn't that the error we get periodically on jenkins? >> >> On 19 August 2016 at 20:17, Remko Popma <remko.po...@gmail.com> wrote: >> >>> I'm see

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

Gary, can you please check your IDE settings for line endings? It is really difficult to see what changed if the whole file is marked as modified in the commit mail. I suspect this is because your IDE converts the unix line endings to windows CRLF or something. On Sun, Aug 21, 2016 at 9:30 AM,

[jira] [Commented] (LOG4J2-1518) Deadlock when using pure async and toString logs another message

[ https://issues.apache.org/jira/browse/LOG4J2-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429543#comment-15429543 ] Remko Popma commented on LOG4J2-1518: - Leon, I finally took a closer look at this and I see now

[jira] [Updated] (LOG4J2-1518) Deadlock when using pure async and toString logs another message

[ https://issues.apache.org/jira/browse/LOG4J2-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1518: Fix Version/s: 2.7 > Deadlock when using pure async and toString logs another mess

[jira] [Commented] (LOG4J2-1537) Experience of a newbie to logging

[ https://issues.apache.org/jira/browse/LOG4J2-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429540#comment-15429540 ] Remko Popma commented on LOG4J2-1537: - I'm fine with answering questions on Jira as well

Re: ThreadContextMap2

d for Map then. Since we have TCM2, now is the time > to add anything else. Check? > > Gary > > On Aug 20, 2016 3:05 PM, "Remko Popma" <remko.po...@gmail.com> wrote: > >> I agree with Ralph. >> >> I am working on custom implementations of Thread

Re: ThreadContextMap2

I agree with Ralph. I am working on custom implementations of ThreadContextMap (LOG4J2-1010, LOG4J2-1447, LOG4J2-1349) and I'm very glad the interface is small. My rule of thumb for API design is YAGNI: don't add until you really need it, otherwise it'll get in the way. Remko Sent from my

build fail

I'm seeing this error when I do mvn clean package Failed tests: RollingAppenderCronTest.testAppender:85 No compressed files found Anyone seeing this too?

[jira] [Resolved] (LOG4J2-1527) NPE thrown when log4j2 used within a webapp and RingBufferLogEvent's getFormattedMessage() is called.

[ https://issues.apache.org/jira/browse/LOG4J2-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1527. - Resolution: Fixed Fixed in master in commit 147f78c. Please verify and close. > NPE thr

[jira] [Commented] (LOG4J2-1518) Deadlock when using pure async and toString logs another message

[ https://issues.apache.org/jira/browse/LOG4J2-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429105#comment-15429105 ] Remko Popma commented on LOG4J2-1518: - Yes, that is the ticket I meant. Can you try if the problems

[jira] [Resolved] (LOG4J2-1516) Add ThreadContextMap.putAll(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1516. - Resolution: Fixed Assignee: Remko Popma (was: Gary Gregory) Fixed in master in commit

[jira] [Commented] (LOG4J2-1517) Add ThreadContext.setContext(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429071#comment-15429071 ] Remko Popma commented on LOG4J2-1517: - We should not add API to allow code reduction from two lines

Re: logging-log4j2 git commit: [LOG4J2-1501] FileAppender should be able to create files lazily.

Maybe even explain what on demand means in this context: the file is not created until a log event passes all filters and is routed to this appender. Sent from my iPhone > On 2016/08/20, at 0:57, ggreg...@apache.org wrote: > > Repository: logging-log4j2 > Updated Branches: >

[jira] [Commented] (LOG4J2-1504) RollingFileAppender should be able to create files lazily

[ https://issues.apache.org/jira/browse/LOG4J2-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428370#comment-15428370 ] Remko Popma commented on LOG4J2-1504: - I also think "create on demand" is more d

[jira] [Commented] (LOG4J2-1516) Add ThreadContextMap.putAll(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427737#comment-15427737 ] Remko Popma commented on LOG4J2-1516: - Any objection if I revert the change to ThreadContextMap? I'll

Re: logging-log4j2 git commit: Remove unused import.

Gary, Can you please fix your import static settings? +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; ... -import static org.junit.Assert.*; On Fri, Aug 19,

[jira] [Commented] (LOG4J2-1517) Add ThreadContext.setContext(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427498#comment-15427498 ] Remko Popma commented on LOG4J2-1517: - But why? Users can do ThreadContext.clearMap

[jira] [Commented] (LOG4J2-1518) Deadlock when using pure async and toString logs another message

[ https://issues.apache.org/jira/browse/LOG4J2-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427494#comment-15427494 ] Remko Popma commented on LOG4J2-1518: - By default the AsyncQueueFullPolicy will only log

[jira] [Assigned] (LOG4J2-1518) Deadlock when using pure async and toString logs another message

[ https://issues.apache.org/jira/browse/LOG4J2-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1518: --- Assignee: Remko Popma > Deadlock when using pure async and toString logs another mess

[jira] [Updated] (LOG4J2-1527) NPE thrown when log4j2 used within a webapp and RingBufferLogEvent's getFormattedMessage() is called.

[ https://issues.apache.org/jira/browse/LOG4J2-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1527: Fix Version/s: 2.7 > NPE thrown when log4j2 used within a webapp and RingBufferLogEven

[jira] [Assigned] (LOG4J2-1527) NPE thrown when log4j2 used within a webapp and RingBufferLogEvent's getFormattedMessage() is called.

[ https://issues.apache.org/jira/browse/LOG4J2-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reassigned LOG4J2-1527: --- Assignee: Remko Popma > NPE thrown when log4j2 used within a web

[jira] [Commented] (LOG4J2-905) Ability to disable (date) lookup completely, compatibility issues with other libraries like camel

[ https://issues.apache.org/jira/browse/LOG4J2-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427486#comment-15427486 ] Remko Popma commented on LOG4J2-905: I like this idea of having an option that disables lookups

[jira] [Comment Edited] (LOG4J2-1531) Change attribute and component values from String to Object

[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427458#comment-15427458 ] Remko Popma edited comment on LOG4J2-1531 at 8/19/16 1:52 AM: -- Roger, would

[jira] [Commented] (LOG4J2-1517) Add ThreadContext.setContext(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427480#comment-15427480 ] Remko Popma commented on LOG4J2-1517: - Do we still need {{ThreadContext.setContext(Map)}} if we have

[jira] [Closed] (LOG4J2-1519) Add ThreadContext.putAll(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-1519. --- Resolution: Fixed Closing again after taking a better look. I reopened LOG4J2-1516 instead. >

[jira] [Reopened] (LOG4J2-1516) Add ThreadContextMap.putAll(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reopened LOG4J2-1516: - Sorry for the delay in taking a look at this. The main problem I have

[jira] [Commented] (LOG4J2-1529) composite configurations do not merge attributes on logger nodes

[ https://issues.apache.org/jira/browse/LOG4J2-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427466#comment-15427466 ] Remko Popma commented on LOG4J2-1529: - [~narras], would you be able to provide a patch

[jira] [Updated] (LOG4J2-1534) Create alias 'statusDestination' for 'dest' attribute in Configuration

[ https://issues.apache.org/jira/browse/LOG4J2-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1534: Priority: Minor (was: Major) > Create alias 'statusDestination' for 'dest' attrib

[jira] [Commented] (LOG4J2-1531) Change attribute and component values from String to Object

[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427458#comment-15427458 ] Remko Popma commented on LOG4J2-1531: - Roger, would you mind providing a patch for this (ideally

[jira] [Commented] (LOG4J2-1510) why MutableLogEvent don't keep original log object or even the ReusableObjectMessage

[ https://issues.apache.org/jira/browse/LOG4J2-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427452#comment-15427452 ] Remko Popma commented on LOG4J2-1510: - [~maple.feng.w...@hotmail.com], You marked this question

[jira] [Created] (LOG4J2-1534) Create alias 'statusDestination' for 'dest' attribute in Configuration

Remko Popma created LOG4J2-1534: --- Summary: Create alias 'statusDestination' for 'dest' attribute in Configuration Key: LOG4J2-1534 URL: https://issues.apache.org/jira/browse/LOG4J2-1534 Project: Log4j

[jira] [Closed] (LOG4J2-1284) Make default MessageFactory configurable

[ https://issues.apache.org/jira/browse/LOG4J2-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-1284. --- Resolution: Fixed Updated Extending Log4j page: added section for MessageFactory. Committed

[jira] [Resolved] (LOG4J2-1526) Possibility to set StatusLogger destination in ConfigurationBuilder

[ https://issues.apache.org/jira/browse/LOG4J2-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1526. - Resolution: Fixed Agreed that a separate ticket for aliasing the {{dest}} attribute is a better

[jira] [Commented] (LOG4J2-1528) Serialize configuration into a log4j2.xml file

[ https://issues.apache.org/jira/browse/LOG4J2-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426515#comment-15426515 ] Remko Popma commented on LOG4J2-1528: - A method returning the current object as a string in some

[jira] [Reopened] (LOG4J2-1526) Possibility to set StatusLogger destination in ConfigurationBuilder

[ https://issues.apache.org/jira/browse/LOG4J2-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reopened LOG4J2-1526: - > Possibility to set StatusLogger destination in ConfigurationBuil

[jira] [Commented] (LOG4J2-1526) Possibility to set StatusLogger destination in ConfigurationBuilder

[ https://issues.apache.org/jira/browse/LOG4J2-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426264#comment-15426264 ] Remko Popma commented on LOG4J2-1526: - If this is an existing attribute, can we alias

Re: logging-log4j2 git commit: LOG4J2-1526 Possibility to set StatusLogger destination in ConfigurationBuilder

Can we change the naming to make configuration more intuitive? At first glance there's no way to see that these two lines are related: status = ERROR +dest = err How about something like this? status = ERROR statusDestination = err Sent from my iPhone > On 2016/08/18, at 4:54,

[jira] [Commented] (LOG4J2-1521) StringIndexOutOfBoundsException thrown when rolling logs

[ https://issues.apache.org/jira/browse/LOG4J2-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422620#comment-15422620 ] Remko Popma commented on LOG4J2-1521: - Away from PC, can't open attachments. Could you also specify

[jira] [Comment Edited] (LOG4J2-1521) StringIndexOutOfBoundsException thrown when rolling logs

[ https://issues.apache.org/jira/browse/LOG4J2-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422620#comment-15422620 ] Remko Popma edited comment on LOG4J2-1521 at 8/16/16 11:39 AM: --- Away from

Re: logging-log4j2 git commit: [LOG4J2-1516] Add ThreadContextMap.putAll(Map<String, String>).

r org.junit.Assert.* and org.hamcrest.Matchers.*, and > non-wildcard static imports for everything else. > >> On 15 August 2016 at 20:22, Remko Popma <remko.po...@gmail.com> wrote: >> Maybe I had it the wrong way around, because at the moment looks like your >> formatter conver

Re: logging-log4j2 git commit: [LOG4J2-1516] Add ThreadContextMap.putAll(Map<String, String>).

's for anything less > that 99. > > Gary > >> On Mon, Aug 15, 2016 at 6:16 PM, Gary Gregory <garydgreg...@gmail.com> wrote: >> Odd, mine is set to 99 for static imports, I'll set it to 1 for statics. >> >> Gary >> >>> On Mon, Aug 15, 2016

Re: logging-log4j2 git commit: [LOG4J2-1516] Add ThreadContextMap.putAll(Map<String, String>).

ts before going to *, or are we just using > a really high number like 100 to prevent it altogether? > >> On 15 August 2016 at 17:45, Remko Popma <remko.po...@gmail.com> wrote: >> Gary, you may have upgraded your IDE and forgotten to change the static >> import threshold t

Re: logging-log4j2 git commit: [LOG4J2-1516] Add ThreadContextMap.putAll(Map<String, String>).

Gary, you may have upgraded your IDE and forgotten to change the static import threshold to 1 in the formatter. > +import static org.junit.Assert.assertEquals; > +import static org.junit.Assert.assertFalse; > +import static org.junit.Assert.assertNull; > +import static

[jira] [Reopened] (LOG4J2-1519) Add ThreadContext.putAll(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reopened LOG4J2-1519: - Reopening. No time to write much comment. Please refer to my comments on the ticket Gary referred

[jira] [Commented] (LOG4J2-1516) Add ThreadContextMap.putAll(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421815#comment-15421815 ] Remko Popma commented on LOG4J2-1516: - I guess I can add this method to the new data structures

[jira] [Commented] (LOG4J2-1259) Log4j threads are leaking on tomcat shutdown

[ https://issues.apache.org/jira/browse/LOG4J2-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421808#comment-15421808 ] Remko Popma commented on LOG4J2-1259: - In my previous comment I asked for additional information

[jira] [Commented] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421801#comment-15421801 ] Remko Popma commented on LOG4J2-1447: - Well spotted. In the branch they are matched now (get/putValue

[jira] [Commented] (LOG4J2-1518) Deadlock when using pure async and toString logs another message

[ https://issues.apache.org/jira/browse/LOG4J2-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421791#comment-15421791 ] Remko Popma commented on LOG4J2-1518: - I'll take a look at this when I get back from traveling

[jira] [Comment Edited] (LOG4J2-1517) Add ThreadContext.setContext(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420600#comment-15420600 ] Remko Popma edited comment on LOG4J2-1517 at 8/15/16 4:24 AM: -- Not sure I

[jira] [Commented] (LOG4J2-1516) Add ThreadContextMap.putAll(Map<String, String>)

[ https://issues.apache.org/jira/browse/LOG4J2-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420596#comment-15420596 ] Remko Popma commented on LOG4J2-1516: - Gary, would you mind adding some reason for this change

Re: [2/3] logging-log4j2 git commit: Clear ThreadContext after test

The @After public void tearDown() currently clears the *stack* while we put data in the *map*. Away from PC, but if I remember correctly there is a method ThreadContext.clear () that clears both. That should be fine. Sent from my iPhone > On 2016/08/14, at 2:13, mi...@apache.org wrote: > >

Re: Migrating from Log4j 1

so you have to use one of > these hacks. > > Ralph > > > > >> On Aug 12, 2016, at 5:35 PM, Matt Sicker <boa...@gmail.com> wrote: >> >> I found this, looks promising: https://stackoverflow.com/a/4717025 >> >>> On 12 August 2016 at 19:

Re: Migrating from Log4j 1

nal contextual data which I find pointless honestly. >> >>> On 12 August 2016 at 18:05, Remko Popma <remko.po...@gmail.com> wrote: >>> Just read this thread: >>> https://issues.apache.org/jira/browse/SPARK-6305 >>> >>> Concerns: >>&g

Re: Migrating from Log4j 1

Just read this thread: https://issues.apache.org/jira/browse/SPARK-6305 Concerns: * User-supplied logging configurations would break * Spark code to suppress some overly verbose logging in dependencies (which ignore config?) -not sure about impact * POM changes to exclude log4j 1.2 - Spark

[jira] [Commented] (LOG4J2-1510) why MutableLogEvent don't keep original log object or even the ReusableObjectMessage

[ https://issues.apache.org/jira/browse/LOG4J2-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418388#comment-15418388 ] Remko Popma commented on LOG4J2-1510: - Yes, this is on purpose. With asynchronous logging, we need

[jira] [Updated] (LOG4J2-1510) why MutableLogEvent don't keep original log object or even the ReusableObjectMessage

[ https://issues.apache.org/jira/browse/LOG4J2-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1510: Description: After upgrading Log4j from 2.5 to 2.6.2, I found that log event catched by my

[jira] [Updated] (LOG4J2-1284) Make default MessageFactory configurable

[ https://issues.apache.org/jira/browse/LOG4J2-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1284: Fix Version/s: 2.7 > Make default MessageFactory configura

[jira] [Reopened] (LOG4J2-1284) Make default MessageFactory configurable

[ https://issues.apache.org/jira/browse/LOG4J2-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma reopened LOG4J2-1284: - > Make default MessageFactory configura

[jira] [Commented] (LOG4J2-1284) Make default MessageFactory configurable

[ https://issues.apache.org/jira/browse/LOG4J2-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417207#comment-15417207 ] Remko Popma commented on LOG4J2-1284: - They are documented in the Configuration page in the System

Re: logging-log4j2 git commit: [LOG4J2-1505] Create a Builder for FileAppender. Use @Required per Matt's suggestion. Thank you Matt!

it's the same basic behaviour (error message is logged, factory >> returns null). I can verify in code in like 9 hours from now, though. >> >>> On 9 August 2016 at 17:26, Remko Popma <remko.po...@gmail.com> wrote: >>> Does using the @Required annotation result i

Re: logging-log4j2 git commit: [LOG4J2-1505] Create a Builder for FileAppender. Use @Required per Matt's suggestion. Thank you Matt!

Does using the @Required annotation result in the same behavior? The old code logged an ERROR level message and returned null, so the configuration for that appender was ignored. How does it behave now if a null name or filename is configured? Remko Sent from my iPhone > On 2016/08/09, at

Re: [1/2] logging-log4j2 git commit: [LOG4J2-1501] FileAppender should be able to create files lazily. Use final.

Gary, Can you change your IDE settings so that it won't convert line endings? It is impossible to see what changed from the commit mail... Remko Sent from my iPhone > On 2016/08/09, at 2:42, ggreg...@apache.org wrote: > > Repository: logging-log4j2 > Updated Branches: > refs/heads/master

[jira] [Commented] (LOG4J2-1501) FileAppender should be able to create files lazily

[ https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414324#comment-15414324 ] Remko Popma commented on LOG4J2-1501: - Strictly speaking this isn't the API module so I see

[jira] [Comment Edited] (LOG4J2-667) Add customization for JSON Layout keys and values

[ https://issues.apache.org/jira/browse/LOG4J2-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412659#comment-15412659 ] Remko Popma edited comment on LOG4J2-667 at 8/8/16 11:56 PM: - Ok, beginning

[jira] [Commented] (LOG4J2-667) Add customization for JSON Layout keys and values

[ https://issues.apache.org/jira/browse/LOG4J2-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412659#comment-15412659 ] Remko Popma commented on LOG4J2-667: Ok, beginning to get it now. Still like to see an example. Can

[jira] [Comment Edited] (LOG4J2-667) Add customization for JSON Layout keys and values

[ https://issues.apache.org/jira/browse/LOG4J2-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412069#comment-15412069 ] Remko Popma edited comment on LOG4J2-667 at 8/8/16 4:54 PM: I have trouble

[jira] [Commented] (LOG4J2-667) Add customization for JSON Layout keys and values

[ https://issues.apache.org/jira/browse/LOG4J2-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412069#comment-15412069 ] Remko Popma commented on LOG4J2-667: I have trouble seeing how the %escape idea would work. Can you

Re: logging-log4j2 git commit: [LOG4J2-1482] Improper header in CsvParameterLayout.

view? > > Thank you, > Gary > > On Thu, Aug 4, 2016 at 5:02 PM, Gary Gregory <garydgreg...@gmail.com> > wrote: > >> Remko, >> >> Thank you for the feedback. I will perform the code fiddling, this will >> simplify the current solution. >

[jira] [Resolved] (LOG4J2-1448) Allow comma separated agents, host list to be passed to FlumeAppender

[ https://issues.apache.org/jira/browse/LOG4J2-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma resolved LOG4J2-1448. - Resolution: Fixed Assignee: Remko Popma Fix Version/s: 2.7 Merged pull request

Re: logging-log4j2 git commit: [LOG4J2-1482] Improper header in CsvParameterLayout.

t is not feasible, >> >> Yeah, maybe it's a matter of passing null for the log event and making sure >> we have null checks in the right places. >> >> Gary >> >>> On Wed, Aug 3, 2016 at 4:09 PM, Remko Popma <remko.po...@gmail.com> wrote: >>

[jira] [Commented] (LOG4J2-1482) Improper header in CsvParameterLayout

[ https://issues.apache.org/jira/browse/LOG4J2-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407580#comment-15407580 ] Remko Popma commented on LOG4J2-1482: - 2.7 is likely to be a fairly big release with two new Scala

[jira] [Created] (LOG4J2-1498) [Java 9] fix dependency on old JDK versioning scheme

Remko Popma created LOG4J2-1498: --- Summary: [Java 9] fix dependency on old JDK versioning scheme Key: LOG4J2-1498 URL: https://issues.apache.org/jira/browse/LOG4J2-1498 Project: Log4j 2 Issue

Re: logging-log4j2 git commit: Use the standard US English spelling for "behavior".

We never agreed that there is any need to standardize on a particular flavour of the English language. Let's celebrate our diversity and the fact that we are a global community. I respectfully ask that this change is reverted. -Remko On Thursday, 4 August 2016, wrote: >

Re: logging-log4j2 git commit: [LOG4J2-1482] Improper header in CsvParameterLayout.

would like it much better if StrSubstitutor could be fixed so that a LogEvent becomes optional, or, if that is not feasible, localize creating the LogEvent to the Serializer. On Thursday, 4 August 2016, Remko Popma <remko.po...@gmail.com> wrote: > Why is this fixed in AbstactStr

Re: logging-log4j2 git commit: [LOG4J2-1482] Improper header in CsvParameterLayout.

Why is this fixed in AbstactStringLayout, with ripple effect to JSON and YAML layouts? The problem seems to be in Serializer. It is still unclear to me why Serializer needs a LogEvent, (away from PC now) but I assume it is because of StrSubstitutor. I would like it much better if

[jira] [Commented] (LOG4J2-1482) Improper header in CsvParameterLayout

[ https://issues.apache.org/jira/browse/LOG4J2-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406697#comment-15406697 ] Remko Popma commented on LOG4J2-1482: - Gary, rollover is not garbagefree (and I have no plans

[jira] [Commented] (LOG4J2-1491) Exception when mixing varargs and non-varargs overloads

[ https://issues.apache.org/jira/browse/LOG4J2-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403781#comment-15403781 ] Remko Popma commented on LOG4J2-1491: - Can you show a stacktrace? This reminds me of https

[jira] [Commented] (LOG4J2-1490) Log4j2 is creating empty log files.

[ https://issues.apache.org/jira/browse/LOG4J2-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403667#comment-15403667 ] Remko Popma commented on LOG4J2-1490: - Is this related to http://stackoverflow.com/q/38678140/1446916

[jira] [Issue Comment Deleted] (LOG4J2-1447) Garbage-free data structure for LogEvent's context map data

[ https://issues.apache.org/jira/browse/LOG4J2-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1447: Comment: was deleted (was: Initial perf test attempt. (Cannot commit from work) @BenchmarkMode

[jira] [Closed] (LOG4J2-1438) Add method getParameter() to ObjectMessage (and ReusableObjectMessage)

[ https://issues.apache.org/jira/browse/LOG4J2-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma closed LOG4J2-1438. --- Resolution: Fixed Added @since 2.7 javadoc. > Add method getParameter() to ObjectMess

<    5   6   7   8   9   10   11   12   13   14   >