[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257360#comment-15257360 ] Remko Popma commented on LOG4J2-1297: - I suspect the big drop in throughput has to do with locking:

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256540#comment-15256540 ] Ralph Goers commented on LOG4J2-1297: - If I was to guess I would think that has something to do with

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256530#comment-15256530 ] Ceki Gülcü commented on LOG4J2-1297: [~rem...@yahoo.com] The logback-perf.xml file looks good. I am

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255509#comment-15255509 ] Remko Popma commented on LOG4J2-1297: - Thoughts on which graphs to show in the performance section:

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255232#comment-15255232 ] Remko Popma commented on LOG4J2-1297: - Our version of Logback was old (1.1.3), so I need to rerun

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

Yes, in that case the threadpool doesn't outlive the application so there's no chance of memory leaks. Not sure if Tomcat also can be configured to have separate threadpools per web app and to refresh the thread pool on web app undeploy/redeploy. Sent from my iPhone > On 2016/04/19, at

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

But would you say it's safe to use ThreadLocal when you don't undeploy or redeploy web apps? Like if you always restart Tomcat when you redeploy, would it be safe to use ThreadLocal in such a scenario? On 18 April 2016 at 09:49, Remko Popma wrote: > The problem is that

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

The problem is that values stored in ThreadLocals may live longer than the web application since the threads that hold these values are in a pool and the threads live on after the web application is undeployed. If the value is a JDK class this is not a problem. If the value is a class that is

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

So is this only bad to use when you have multiple wars on a single Tomcat, or is it bad for when you try to undeploy, or is there another issue here? On 18 April 2016 at 09:01, Remko Popma wrote: > Yes but if this is wrong because there is no threadpool or so, then you >

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

Yes but if this is wrong because there is no threadpool or so, then you can use System property "log4j2.is.webapp" to tell Log4j that it should consider your app a non-webapp. On Mon, Apr 18, 2016 at 10:59 PM, Matt Sicker wrote: > Would an embedded Tomcat/Jetty a la Spring

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

Would an embedded Tomcat/Jetty a la Spring Boot really be considered a web application? On 18 April 2016 at 08:56, Remko Popma wrote: > When I finish performance testing I will add graphs to the Performance > section of the gc-free manual page so that users can make an

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

When I finish performance testing I will add graphs to the Performance section of the gc-free manual page so that users can make an informed decision. (The below one is an example.) So far, it seems that even with the garbage-free logging enabled, synchronous logging throughput (the green line)

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

Is it wise to enable by default given that "multi-threaded applications that use synchronous logging may see worse performance"? On Mon, Apr 18, 2016 at 2:22 PM, Remko Popma wrote: > Enabled, except for web apps; for those log4j will be low garbage. > > See the first

Re: [jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

Enabled, except for web apps; for those log4j will be low garbage. See the first paragraph of the Configuration section in the manual page. Please let me know if this is not clear. (The fact that you asked means this probably needs improvement...) Sent from my iPhone > On 2016/04/18, at

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245018#comment-15245018 ] Remko Popma commented on LOG4J2-1297: - TODO allocate many temporary objects -> allocate temporary

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223606#comment-15223606 ] Remko Popma commented on LOG4J2-1297: - Yes, users probably know the converters by key ("%c" etc)

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223506#comment-15223506 ] Matt Sicker commented on LOG4J2-1297: - When referencing the PatternConverters, it might be helpful to

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223145#comment-15223145 ] Remko Popma commented on LOG4J2-1297: - Draft of the work in progress, feedback welcome: h1.

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208601#comment-15208601 ] Mikael Ståldal commented on LOG4J2-1297: It seems like the stacktrace formatting in PatternLayout

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160045#comment-15160045 ] Remko Popma commented on LOG4J2-1297: - Sure, I will look at doing the performance testing using the

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159611#comment-15159611 ] Gary Gregory commented on LOG4J2-1297: -- Instead of big-banging on the vararg rollout, can we pick

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159598#comment-15159598 ] Remko Popma commented on LOG4J2-1297: - Sure, but first we need to get consensus on the number of

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159593#comment-15159593 ] Remko Popma commented on LOG4J2-1297: - I don't see an easy way to handle LOG4J2-1282 at the moment.

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159472#comment-15159472 ] Matt Sicker commented on LOG4J2-1297: - Don't forget to annotate the code! :) > Document "gc-free"

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159193#comment-15159193 ] Gary Gregory commented on LOG4J2-1297: -- Is the properties section read-only? If so, could we avoid

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159142#comment-15159142 ] Remko Popma commented on LOG4J2-1297: - Making all Loggers asynchronous means all LogEvents are

[jira] [Commented] (LOG4J2-1297) Document "gc-free" configuration and performance

[ https://issues.apache.org/jira/browse/LOG4J2-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159126#comment-15159126 ] Ralph Goers commented on LOG4J2-1297: - Why do loggers all need to be asynchronous? It isn't obvious